[jira] [Commented] (CALCITE-2454) HepPlanner should not pick cached RelNode when type mismatch while digest matches

[ https://issues.apache.org/jira/browse/CALCITE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574210#comment-16574210 ] Yuzhao Chen commented on CALCITE-2454: -- Hi, [~julianhyde] I have changed the head the attach the

[jira] [Updated] (CALCITE-2454) HepPlanner should not pick cached RelNode when type mismatch while digest matches

[ https://issues.apache.org/jira/browse/CALCITE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2454: - Description: After CALCITE-2116, a RelNode will be reused based on digest, but now many

[jira] [Updated] (CALCITE-2454) HepPlanner should not pick cached RelNode when type mismatch while digest matches

[ https://issues.apache.org/jira/browse/CALCITE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2454: - Description: After CALCITE-2116, a RelNode will be reused based on digest, but now many

[jira] [Updated] (CALCITE-2454) HepPlanner should not pick cached RelNode when type mismatch while digest matches

[ https://issues.apache.org/jira/browse/CALCITE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2454: - Summary: HepPlanner should not pick cached RelNode when type mismatch while digest matches

[jira] [Updated] (CALCITE-2455) simplifyCoalesce of constant should match nullability

[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2455: - Description: After CALCITE-2227, we will not replace Coalesce to Case When for natural join,

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574203#comment-16574203 ] Yuzhao Chen commented on CALCITE-2455: -- Hi, [~julianhyde] I have attach the details and change the

[jira] [Updated] (CALCITE-2455) simplifyCoalesce of constant should match nullability

[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2455: - Description: After CALCITE-2227, we will not replace Coalesce to Case When for natural join,

[jira] [Updated] (CALCITE-2455) simplifyCoalesce of constant should match nullability

[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2455: - Summary: simplifyCoalesce of constant should match nullability (was: Fix simplifyCoalesce of

[jira] [Updated] (CALCITE-2455) Fix simplifyCoalesce of constant when nullability missing

[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuzhao Chen updated CALCITE-2455: - Description: After CALCITE-2227, we will not replace Coalesce to Case When for natural join,

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573961#comment-16573961 ] Vladimir Sitnikov commented on CALCITE-2439: AFAIK, IDEA (which is Apache 2.0 licensed)

[jira] [Resolved] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2438. -- Resolution: Won't Fix Ok, I'm done. Won't fix. > RexCall#isAlwaysTrue return incorrect

[jira] [Commented] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573902#comment-16573902 ] Vladimir Sitnikov commented on CALCITE-2450: {quote}Re first example: It is valid. I was

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573900#comment-16573900 ] Julian Hyde commented on CALCITE-2439: -- I take your point that {{getMatchRelevance}} can take a

[jira] [Commented] (CALCITE-2455) Fix simplifyCoalesce of constant when nullability missing

[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573891#comment-16573891 ] Julian Hyde commented on CALCITE-2455: -- A JIRA case should describe the problem, not the solution.

[jira] [Comment Edited] (CALCITE-2458) Evaluate use of Kotlin for unit tests

[ https://issues.apache.org/jira/browse/CALCITE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573876#comment-16573876 ] Vladimir Sitnikov edited comment on CALCITE-2458 at 8/8/18 9:04 PM:

[jira] [Commented] (CALCITE-2458) Evaluate use of Kotlin for unit tests

[ https://issues.apache.org/jira/browse/CALCITE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573876#comment-16573876 ] Vladimir Sitnikov commented on CALCITE-2458: {quote}If we were to use Kotlin for tests,

[jira] [Commented] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573863#comment-16573863 ] Julian Hyde commented on CALCITE-2450: -- Re first example: It is valid. I was thinking about

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573862#comment-16573862 ] Vladimir Sitnikov commented on CALCITE-2457: {quote}If we were to upgrade to Junit 5, would

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573852#comment-16573852 ] Vladimir Sitnikov commented on CALCITE-2438: It is. As I said, the error messages that

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573851#comment-16573851 ] Julian Hyde commented on CALCITE-2453: -- Reviewing [PR

[jira] [Comment Edited] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573830#comment-16573830 ] Vladimir Sitnikov edited comment on CALCITE-2439 at 8/8/18 8:46 PM:

[jira] [Commented] (CALCITE-2458) Evaluate use of Kotlin for unit tests

[ https://issues.apache.org/jira/browse/CALCITE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573832#comment-16573832 ] Julian Hyde commented on CALCITE-2458: -- I use Kotlin at $dayjob and I like it. If we were to use

[jira] [Commented] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573827#comment-16573827 ] Julian Hyde commented on CALCITE-2456: -- I can well believe that there is a bug in Volcano for

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573830#comment-16573830 ] Vladimir Sitnikov commented on CALCITE-2439: {quote}getMatchRelevance as you have described

[jira] [Updated] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2456: - Affects Version/s: 1.17.0 > VolcanoRuleCall#match works incorrectly for unordered child

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573809#comment-16573809 ] Andrei Sereda commented on CALCITE-2457: For failure you don't like error message ? Or is it

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573799#comment-16573799 ] Julian Hyde commented on CALCITE-2457: -- If we were to upgrade to Junit 5, would we need to modify

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573797#comment-16573797 ] Julian Hyde commented on CALCITE-2438: -- [~vlsi], As you're probably aware, as a committer you can

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573731#comment-16573731 ] Andrei Sereda commented on CALCITE-2457: To add context information you can use

[jira] [Commented] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573544#comment-16573544 ] Haisheng Yuan commented on CALCITE-2456: [~julianhyde] Can you take a look at this issue? >

[jira] [Updated] (CALCITE-2458) Evaluate use of Kotlin for unit tests

[ https://issues.apache.org/jira/browse/CALCITE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-2458: --- Description: It looks like Kotlin might simplify writing tests: 1) Calcite tests

[jira] [Updated] (CALCITE-2458) Evaluate use of Kotlin for unit tests

[ https://issues.apache.org/jira/browse/CALCITE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-2458: --- Description: It looks like Kotlin might simplify writing tests: 1) Calcite tests

[jira] [Created] (CALCITE-2458) Evaluate use of Kotlin for unit tests

Vladimir Sitnikov created CALCITE-2458: -- Summary: Evaluate use of Kotlin for unit tests Key: CALCITE-2458 URL: https://issues.apache.org/jira/browse/CALCITE-2458 Project: Calcite Issue

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573410#comment-16573410 ] Vladimir Sitnikov commented on CALCITE-2457: [~asereda], that is an interesting point. I've

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573369#comment-16573369 ] Andrei Sereda commented on CALCITE-2457: While we're at testing infrastructure discussion what

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573277#comment-16573277 ] Andrei Sereda commented on CALCITE-2457: I think surefire parallel execution of tests

[jira] [Commented] (CALCITE-2402) COVAR_POP/COVAR_SAMP/REGR_SXX/REGR_SYY do not work

[ https://issues.apache.org/jira/browse/CALCITE-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573193#comment-16573193 ] Sergey Nuyanzin commented on CALCITE-2402: -- Thank you for your response. About {{SUM}} yes you

[jira] [Comment Edited] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573016#comment-16573016 ] Enrico Olivelli edited comment on CALCITE-2457 at 8/8/18 10:56 AM: ---

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573016#comment-16573016 ] Enrico Olivelli commented on CALCITE-2457: -- You will have to upgrade to latest maven surefire

[jira] [Created] (CALCITE-2457) Upgrade to JUnit 5

Vladimir Sitnikov created CALCITE-2457: -- Summary: Upgrade to JUnit 5 Key: CALCITE-2457 URL: https://issues.apache.org/jira/browse/CALCITE-2457 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572960#comment-16572960 ] charbel yazbeck commented on CALCITE-2453: -- Hi Julian, sorry about the patch and the tests, I

[jira] [Updated] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zuozhi Wang updated CALCITE-2456: - Description: h2. Bug Description: This bug occurs when there'a rule matching a Union operator

[jira] [Updated] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zuozhi Wang updated CALCITE-2456: - Description: h3. Description: This bug occurs when there'a rule matching a Union operator

[jira] [Updated] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zuozhi Wang updated CALCITE-2456: - Description: Description: This bug occurs when there'a rule matching a Union operator with an

[jira] [Updated] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zuozhi Wang updated CALCITE-2456: - Description: Description: This bug occurs when there'a rule matching a Union operator with an

[jira] [Updated] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zuozhi Wang updated CALCITE-2456: - Description: Description: This bug occurs when there'a rule matching a Union operator with an

[jira] [Created] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

Zuozhi Wang created CALCITE-2456: Summary: VolcanoRuleCall#match works incorrectly for unordered child operand Key: CALCITE-2456 URL: https://issues.apache.org/jira/browse/CALCITE-2456 Project:

[jira] [Comment Edited] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572892#comment-16572892 ] Vladimir Sitnikov edited comment on CALCITE-2450 at 8/8/18 9:38 AM:

[jira] [Comment Edited] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572892#comment-16572892 ] Vladimir Sitnikov edited comment on CALCITE-2450 at 8/8/18 8:48 AM:

[jira] [Comment Edited] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572892#comment-16572892 ] Vladimir Sitnikov edited comment on CALCITE-2450 at 8/8/18 8:48 AM:

[jira] [Commented] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572892#comment-16572892 ] Vladimir Sitnikov commented on CALCITE-2450: {quote} if we're going to generate code from

[jira] [Comment Edited] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572822#comment-16572822 ] Vladimir Sitnikov edited comment on CALCITE-2438 at 8/8/18 7:56 AM:

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572822#comment-16572822 ] Vladimir Sitnikov commented on CALCITE-2438: {quote}If I know the file, the line number and

[jira] [Comment Edited] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572744#comment-16572744 ] Vladimir Sitnikov edited comment on CALCITE-2450 at 8/8/18 6:31 AM:

[jira] [Comment Edited] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572744#comment-16572744 ] Vladimir Sitnikov edited comment on CALCITE-2450 at 8/8/18 6:29 AM:

[jira] [Commented] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572744#comment-16572744 ] Vladimir Sitnikov commented on CALCITE-2450: A slightly more sophisticated example would be

[jira] [Commented] (CALCITE-2450) RexSimplify: reorder predicates to a canonical form as a part of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572734#comment-16572734 ] Vladimir Sitnikov commented on CALCITE-2450: What is the expected output of {{AND(42/0 > 0,