[jira] [Comment Edited] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810180#comment-17810180 ] Julian Hyde edited comment on CALCITE-6219 at 1/24/24 3:04 AM: --- That

[jira] [Commented] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810180#comment-17810180 ] Julian Hyde commented on CALCITE-6219: -- That sounds good. Views are also a consideration;

[jira] [Comment Edited] (CALCITE-6188) Multi-query optimization

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810169#comment-17810169 ] Julian Hyde edited comment on CALCITE-6188 at 1/24/24 2:41 AM: --- Thank

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810169#comment-17810169 ] Julian Hyde commented on CALCITE-6188: -- Thank you, [~zabetak]! I knew Hive had such a syntax, but

[jira] [Commented] (CALCITE-6216) The JDBC adapter is unable to push down queries when a query involves multiple data sources

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810164#comment-17810164 ] Julian Hyde commented on CALCITE-6216: -- As you note, JDBC rules are unique in that they have

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809646#comment-17809646 ] Julian Hyde commented on CALCITE-6214: -- I'm not sure what you mean by 'merge aggregates'. If you

[jira] [Commented] (CALCITE-6216) The JDBC adapter is unable to push down queries when there is a join involved in the query.

2024-01-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809638#comment-17809638 ] Julian Hyde commented on CALCITE-6216: -- If a join involves two tables in different databases, and

[jira] [Created] (CALCITE-6217) PER clause for aggregate functions

2024-01-22 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-6217: Summary: PER clause for aggregate functions Key: CALCITE-6217 URL: https://issues.apache.org/jira/browse/CALCITE-6217 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809165#comment-17809165 ] Julian Hyde commented on CALCITE-6214: -- Can you remove backticks from the jira subject? Backticks

[jira] [Commented] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809164#comment-17809164 ] Julian Hyde commented on CALCITE-6214: -- I have no problem with doing this via a rule. But it could

[jira] [Commented] (CALCITE-6209) Long queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809157#comment-17809157 ] Julian Hyde commented on CALCITE-6209: -- [~stoty], More parameters more things to screw up. So we

[jira] [Commented] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809147#comment-17809147 ] Julian Hyde commented on CALCITE-6214: -- You should do other aggregate functions also - e.g. SUM

[jira] [Commented] (CALCITE-6209) All queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-01-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808351#comment-17808351 ] Julian Hyde commented on CALCITE-6209: -- I would presume that the

[jira] [Commented] (CALCITE-6209) All queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-01-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807800#comment-17807800 ] Julian Hyde commented on CALCITE-6209: -- It seems that the server has stopped responding, for some

[jira] [Commented] (CALCITE-6207) Improve connection resource in JDBCUtils

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807479#comment-17807479 ] Julian Hyde commented on CALCITE-6207: -- Yes, I think that would be best in this case. I think this

[jira] [Commented] (CALCITE-6207) Improve connection resource in JDBCUtils

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807475#comment-17807475 ] Julian Hyde commented on CALCITE-6207: -- [~mbudiu], Can you check the jira conversation before you

[jira] [Commented] (CALCITE-6098) Remove mentions of Jekyll from LICENSE and NOTICE files

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807460#comment-17807460 ] Julian Hyde commented on CALCITE-6098: -- +1 > Remove mentions of Jekyll from LICENSE and NOTICE

[jira] [Commented] (CALCITE-6098) Remove mentions of Jekyll from LICENSE and NOTICE files

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807449#comment-17807449 ] Julian Hyde commented on CALCITE-6098: -- It is very likely the case that I copied from ORC. I

[jira] [Commented] (CALCITE-6206) Add library operator mapping for unparsing

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807438#comment-17807438 ] Julian Hyde commented on CALCITE-6206: -- I support this initiative. Calcite needs to "translate SQL

[jira] [Commented] (CALCITE-6207) Improve connection resource in JDBCUtils

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807436#comment-17807436 ] Julian Hyde commented on CALCITE-6207: -- If {{connection.getMetaData()}} or

[jira] [Commented] (CALCITE-6202) `sqlsh` does not print error message when query fails

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807128#comment-17807128 ] Julian Hyde commented on CALCITE-6202: -- Thank you for fixing this! > `sqlsh` does not print error

[jira] [Commented] (CALCITE-6207) Improve connection resource in JDBCUtils

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807124#comment-17807124 ] Julian Hyde commented on CALCITE-6207: -- Is there a problem with the current method? If it ain't

[jira] [Updated] (CALCITE-6044) RelMetadataQuery should regard single-row relational expressions as unique

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6044: - Summary: RelMetadataQuery should regard single-row relational expressions as unique (was:

[jira] [Resolved] (CALCITE-6044) Column uniqueness for single-row relations

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6044. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-6044) Column uniqueness for single-row relations

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806239#comment-17806239 ] Julian Hyde commented on CALCITE-6044: -- Looks good. Final testing and will merge to main shortly.

[jira] [Commented] (CALCITE-6192) DEFAULT expression with NULL value throws unexpected exception

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806227#comment-17806227 ] Julian Hyde commented on CALCITE-6192: -- Please remember to create Jira links to bugs, so that they

[jira] [Commented] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806226#comment-17806226 ] Julian Hyde commented on CALCITE-6193: -- [~4wei], Is this a good summary of the case: {quote} If a

[jira] [Commented] (CALCITE-6180) Append possibility to escape backslash in LIKE expression

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806220#comment-17806220 ] Julian Hyde commented on CALCITE-6180: -- I agree with you on the first part. An example of the

[jira] [Commented] (CALCITE-6195) SqlValidator validateParameterizedExpression is not supporting qualified paths

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806176#comment-17806176 ] Julian Hyde commented on CALCITE-6195: -- The {{validateParameterizedExpression}} is called in one

[jira] [Commented] (CALCITE-6196) Accept BigQuery PERCENTILE functions without OVER clause

2024-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806175#comment-17806175 ] Julian Hyde commented on CALCITE-6196: -- Would this feature be turned on in BigQuery mode or in all

[jira] [Commented] (CALCITE-6195) SqlValidator validateParameterizedExpression is not supporting qualified paths

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804929#comment-17804929 ] Julian Hyde commented on CALCITE-6195: -- It looks wrong to be putting qualified names into a map

[jira] [Updated] (CALCITE-6180) Append possibility to escape backslash in LIKE expression

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6180: - Fix Version/s: (was: 1.37.0) > Append possibility to escape backslash in LIKE expression >

[jira] [Comment Edited] (CALCITE-6180) Append possibility to escape backslash in LIKE expression

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804878#comment-17804878 ] Julian Hyde edited comment on CALCITE-6180 at 1/9/24 8:42 PM: -- The PR was

[jira] [Commented] (CALCITE-6180) Append possibility to escape backslash in LIKE expression

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804878#comment-17804878 ] Julian Hyde commented on CALCITE-6180: -- The PR was originally merged to main as commit

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804855#comment-17804855 ] Julian Hyde commented on CALCITE-6188: -- I forgot an important case. Two or more queries that can

[jira] [Comment Edited] (CALCITE-6188) Multi-query optimization

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803732#comment-17803732 ] Julian Hyde edited comment on CALCITE-6188 at 1/9/24 7:17 PM: -- I had an

[jira] [Updated] (CALCITE-6188) Multi-query optimization

2024-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6188: - Description: Devise extensions to SQL for multi-query optimization (MQO). Queries with

[jira] [Updated] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6193: - Fix Version/s: 1.37.0 > SubstitutionVisitor stop trying incorrect subtree because of wrong

[jira] [Commented] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804528#comment-17804528 ] Julian Hyde commented on CALCITE-6193: -- This bug looks legitimate. However, it would be useful if

[jira] [Commented] (CALCITE-6194) Contributor rules do not give instructions about how to quote commits

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804519#comment-17804519 ] Julian Hyde commented on CALCITE-6194: -- Practice has changed recently. Can you change "and also

[jira] [Commented] (CALCITE-6178) WITH RECURSIVE query when cloned using SqlShuttle loses RECURSIVE property

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804496#comment-17804496 ] Julian Hyde commented on CALCITE-6178: -- (In my view, PRs are just scaffolding. Jira and the git

[jira] [Commented] (CALCITE-6178) WITH RECURSIVE query when cloned using SqlShuttle loses RECURSIVE property

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804494#comment-17804494 ] Julian Hyde commented on CALCITE-6178: -- Still not good. 6d95a10 isn't on main. You must use a URL

[jira] [Commented] (CALCITE-6178) WITH RECURSIVE query when cloned using SqlShuttle loses RECURSIVE property

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804490#comment-17804490 ] Julian Hyde commented on CALCITE-6178: -- [~mbudiu], Can you note the actual commit SHA (in main

[jira] [Updated] (CALCITE-6178) WITH RECURSIVE query when cloned using SqlShuttle loses RECURSIVE property

2024-01-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6178: - Summary: WITH RECURSIVE query when cloned using SqlShuttle loses RECURSIVE property (was:

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804010#comment-17804010 ] Julian Hyde commented on CALCITE-6188: -- The DML options are probably syntactic sugar. Note that

[jira] [Commented] (CALCITE-6185) Support century function format

2024-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803981#comment-17803981 ] Julian Hyde commented on CALCITE-6185: -- Which function or functions should support this format

[jira] [Commented] (CALCITE-6191) Remove join if input is one row literal

2024-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803980#comment-17803980 ] Julian Hyde commented on CALCITE-6191: -- I think you’re actually converting the Join into a

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803732#comment-17803732 ] Julian Hyde commented on CALCITE-6188: -- I had an idea for DML. The idea is that each DML operation

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803650#comment-17803650 ] Julian Hyde commented on CALCITE-6188: -- I got some feedback on twitter that we need to be able to

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803373#comment-17803373 ] Julian Hyde commented on CALCITE-6188: -- Thank you, [~jaynarale]! The sequence node is not

[jira] [Updated] (CALCITE-6188) Multi-query optimization

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6188: - Description: Devise extensions to SQL so that queries with multiple input tables, multiple

[jira] [Created] (CALCITE-6188) Multi-query optimization

2024-01-04 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-6188: Summary: Multi-query optimization Key: CALCITE-6188 URL: https://issues.apache.org/jira/browse/CALCITE-6188 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-6186) Enable DATEDIFF for Snowflake, map to BigQuery equivalents

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803348#comment-17803348 ] Julian Hyde commented on CALCITE-6186: -- Yes, it's worth experimenting with stuff like that.

[jira] [Comment Edited] (CALCITE-6182) Add LENGTH/LEN function (enabled in Snowflake library)

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803321#comment-17803321 ] Julian Hyde edited comment on CALCITE-6182 at 1/4/24 8:53 PM: -- (I edited

[jira] [Commented] (CALCITE-6182) Add LENGTH/LEN function (enabled in Snowflake library)

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803321#comment-17803321 ] Julian Hyde commented on CALCITE-6182: -- (I edited the above message because I force-pushed to fix

[jira] [Comment Edited] (CALCITE-6182) Add LENGTH/LEN function (enabled in Snowflake library)

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802323#comment-17802323 ] Julian Hyde edited comment on CALCITE-6182 at 1/4/24 8:51 PM: -- Merged via

[jira] [Resolved] (CALCITE-6187) Linter should disallow tags such as '[MINOR]' in commit messages

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6187. -- Fix Version/s: 1.37.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-6186) Enable DATEDIFF for Snowflake, map to BigQuery equivalents

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803314#comment-17803314 ] Julian Hyde commented on CALCITE-6186: -- Does this change cover incoming SQL (i.e.

[jira] [Created] (CALCITE-6187) Linter should disallow tags such as '[MINOR]' in commit messages

2024-01-04 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-6187: Summary: Linter should disallow tags such as '[MINOR]' in commit messages Key: CALCITE-6187 URL: https://issues.apache.org/jira/browse/CALCITE-6187 Project: Calcite

[jira] [Comment Edited] (CALCITE-6185) Support more date format

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803261#comment-17803261 ] Julian Hyde edited comment on CALCITE-6185 at 1/4/24 7:01 PM: -- The jira

[jira] [Comment Edited] (CALCITE-6185) Support more date format

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803261#comment-17803261 ] Julian Hyde edited comment on CALCITE-6185 at 1/4/24 6:58 PM: -- The jira

[jira] [Commented] (CALCITE-6185) Support more date format

2024-01-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803261#comment-17803261 ] Julian Hyde commented on CALCITE-6185: -- The jira subject must describe the feature, i.e. what the

[jira] [Commented] (CALCITE-6176) 'exists' in 'join on' has a wrong result with CoreRules.JOIN_SUB_QUERY_TO_CORRELATE

2024-01-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802329#comment-17802329 ] Julian Hyde commented on CALCITE-6176: -- This seems to be a bug. I looked at your first query, and

[jira] [Commented] (CALCITE-5791) DDL commands ceased to work in 1.23-1.24 transition

2024-01-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802322#comment-17802322 ] Julian Hyde commented on CALCITE-5791: -- I was able to reproduce from SQLLine, as follows:

[jira] [Comment Edited] (CALCITE-6180) Append possibility to escape backslash in LIKE expression

2024-01-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802320#comment-17802320 ] Julian Hyde edited comment on CALCITE-6180 at 1/3/24 8:48 PM: -- [~zstan]

[jira] [Commented] (CALCITE-6180) Append possibility to escape backslash in LIKE expression

2024-01-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802320#comment-17802320 ] Julian Hyde commented on CALCITE-6180: -- [~zstan], I think the previous behavior was correct. This

[jira] [Resolved] (CALCITE-6128) RelBuilder.limit should apply offset and fetch to previous Sort operator, if possible

2024-01-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6128. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-6178) WITH RECURSIVE query when cloned using sqlshuttle looses RECURSIVE property

2023-12-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801397#comment-17801397 ] Julian Hyde commented on CALCITE-6178: -- Might be useful for SqlUnparserTest to unparse everything

[jira] [Resolved] (CALCITE-6181) Upgrade janino to 3.1.11

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6181. -- Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-6181) Upgrade janino to 3.1.11

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6181: - Fix Version/s: 1.37.0 > Upgrade janino to 3.1.11 > > >

[jira] [Commented] (CALCITE-6181) Upgrade janino to 3.1.11

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801282#comment-17801282 ] Julian Hyde commented on CALCITE-6181: -- It's not helpful to talk about CVEs in open bugs. If you

[jira] [Reopened] (CALCITE-6180) Append possibility to escape backslash in LIKE with ESCAPE operator

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reopened CALCITE-6180: -- > Append possibility to escape backslash in LIKE with ESCAPE operator >

[jira] [Commented] (CALCITE-6180) Append possibility to escape backslash in LIKE with ESCAPE operator

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801281#comment-17801281 ] Julian Hyde commented on CALCITE-6180: -- I don't think {{ESCAPE}} has anything to do with it.

[jira] [Commented] (CALCITE-6182) Add LENGTH/LEN function (enabled in Snowflake library)

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801277#comment-17801277 ] Julian Hyde commented on CALCITE-6182: -- I reviewed. Looks good, could just use more explanatory

[jira] [Commented] (CALCITE-6172) Allow aliased operators to re-use existing tests

2023-12-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801276#comment-17801276 ] Julian Hyde commented on CALCITE-6172: -- I don't feel strongly about either approach. I do think

[jira] [Commented] (CALCITE-6172) Allow aliased operators to re-use existing tests

2023-12-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799615#comment-17799615 ] Julian Hyde commented on CALCITE-6172: -- [~tanclary], You can easily answer the question 'What

[jira] [Comment Edited] (CALCITE-6156) Add ENDSWITH, STARTSWITH functions (enabled in Postgres, Snowflake libraries)

2023-12-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799594#comment-17799594 ] Julian Hyde edited comment on CALCITE-6156 at 12/21/23 10:35 PM: -

[jira] [Commented] (CALCITE-6172) Allow aliased operators to re-use existing tests

2023-12-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799597#comment-17799597 ] Julian Hyde commented on CALCITE-6172: -- One particular test is {{SqlOperatorTest.java}}. In

[jira] [Commented] (CALCITE-6145) Function 'TRIM' without parameters throw NullPointerException

2023-12-20 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799123#comment-17799123 ] Julian Hyde commented on CALCITE-6145: -- I agree with [~asolimando]. The dev list is a good place

[jira] [Updated] (CALCITE-3329) Implement osquery for OS adapter

2023-12-20 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3329: - Component/s: os-adapter > Implement osquery for OS adapter >

[jira] [Resolved] (CALCITE-3329) Implement osquery for OS adapter

2023-12-20 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-3329. -- Fix Version/s: 1.37.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-6170) DruidException: Illegal use of dynamic parameter with 'LOWER(?)'

2023-12-19 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798695#comment-17798695 ] Julian Hyde commented on CALCITE-6170: -- The bug is probably in Calcite, not Avatica-Go. Or rather,

[jira] [Commented] (CALCITE-3329) Implement osquery for OS adapter

2023-12-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798465#comment-17798465 ] Julian Hyde commented on CALCITE-3329: -- [~x1q1j1] In my

[jira] [Commented] (CALCITE-3522) sql validator limits decimal literals to 64 bits

2023-12-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798445#comment-17798445 ] Julian Hyde commented on CALCITE-3522: -- I don't think you can just remove the checks. If you do

[jira] [Commented] (CALCITE-6168) RexExecutor can throw during compilation

2023-12-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798440#comment-17798440 ] Julian Hyde commented on CALCITE-6168: -- This case is very similar to CALCITE-1439. Is it possible

[jira] [Commented] (CALCITE-6162) Add rule(s) to remove joins with constant single tuple relations

2023-12-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798437#comment-17798437 ] Julian Hyde commented on CALCITE-6162: -- That sounds right. > Add rule(s) to remove joins with

[jira] [Commented] (CALCITE-6165) Add date_sub and date_add functions

2023-12-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798021#comment-17798021 ] Julian Hyde commented on CALCITE-6165: -- Don't close the ticket. It is still valid - the goal is to

[jira] [Commented] (CALCITE-6167) JoinConditionPushRule shouldn't push 'exists' with other table conditions down

2023-12-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798020#comment-17798020 ] Julian Hyde commented on CALCITE-6167: -- I wonder whether the problem is the correlated variable

[jira] [Commented] (CALCITE-3329) Implement osquery for OS adapter

2023-12-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798010#comment-17798010 ] Julian Hyde commented on CALCITE-3329: -- Thank you for doing this. I will review in a day or two.

[jira] [Commented] (CALCITE-6165) Add date_sub and date_add functions

2023-12-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798008#comment-17798008 ] Julian Hyde commented on CALCITE-6165: -- Correct. Functions with ordinary syntax do not require

[jira] [Comment Edited] (CALCITE-6166) Optimization rule AggregateReduceFunctionsRule rewrites queries to semantically non-equivalent ones

2023-12-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797308#comment-17797308 ] Julian Hyde edited comment on CALCITE-6166 at 12/15/23 8:17 PM: I agree

[jira] [Commented] (CALCITE-6166) Optimization rule AggregateReduceFunctionsRule rewrites queries to semantically non-equivalent ones

2023-12-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797308#comment-17797308 ] Julian Hyde commented on CALCITE-6166: -- I agree that the rule should preserve the type. Depending

[jira] [Comment Edited] (CALCITE-6165) Add datefunctiontest on SqlParserTest

2023-12-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796884#comment-17796884 ] Julian Hyde edited comment on CALCITE-6165 at 12/14/23 7:27 PM: This

[jira] [Commented] (CALCITE-6165) Add datefunctiontest on SqlParserTest

2023-12-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796884#comment-17796884 ] Julian Hyde commented on CALCITE-6165: -- This commit is not large enough in scope to add to the

[jira] [Commented] (CALCITE-6164) add testPushDownProjectAggregateWithAvg on CsvTest

2023-12-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796497#comment-17796497 ] Julian Hyde commented on CALCITE-6164: -- Not a goal of this test. In fact we should have pushed

[jira] [Commented] (CALCITE-6162) Add rule(s) to remove joins with constant single tuple relations

2023-12-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796494#comment-17796494 ] Julian Hyde commented on CALCITE-6162: -- I see you have {{cross join}} and {{{}inner join{}}}. Is

[jira] [Commented] (CALCITE-6164) add testPushDownProjectAggregateWithAvg on CsvTest

2023-12-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796416#comment-17796416 ] Julian Hyde commented on CALCITE-6164: -- This does not belong in the {{example}} module. The

[jira] [Commented] (CALCITE-6161) The equalsDeep of sqlCall should compare sqlOperator's sqlKind

2023-12-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795542#comment-17795542 ] Julian Hyde commented on CALCITE-6161: -- If you add those cases and they pass I will merge your PR.

[jira] [Commented] (CALCITE-6161) The equalsDeep of sqlCall should compare sqlOperator's sqlKind

2023-12-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795541#comment-17795541 ] Julian Hyde commented on CALCITE-6161: -- Can you add a few test cases for {{equalsDeep}}: * -(x,

[jira] [Commented] (CALCITE-6157) SqlValidatorImpl breaks join condition

2023-12-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795536#comment-17795536 ] Julian Hyde commented on CALCITE-6157: -- I'm puzzled, too. Your test case looks like a faithful

<    1   2   3   4   5   6   7   8   9   10   >