[
https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810180#comment-17810180
]
Julian Hyde edited comment on CALCITE-6219 at 1/24/24 3:04 AM:
---
That
[
https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810180#comment-17810180
]
Julian Hyde commented on CALCITE-6219:
--
That sounds good.
Views are also a consideration;
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810169#comment-17810169
]
Julian Hyde edited comment on CALCITE-6188 at 1/24/24 2:41 AM:
---
Thank
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810169#comment-17810169
]
Julian Hyde commented on CALCITE-6188:
--
Thank you, [~zabetak]! I knew Hive had such a syntax, but
[
https://issues.apache.org/jira/browse/CALCITE-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810164#comment-17810164
]
Julian Hyde commented on CALCITE-6216:
--
As you note, JDBC rules are unique in that they have
[
https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809646#comment-17809646
]
Julian Hyde commented on CALCITE-6214:
--
I'm not sure what you mean by 'merge aggregates'. If you
[
https://issues.apache.org/jira/browse/CALCITE-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809638#comment-17809638
]
Julian Hyde commented on CALCITE-6216:
--
If a join involves two tables in different databases, and
Julian Hyde created CALCITE-6217:
Summary: PER clause for aggregate functions
Key: CALCITE-6217
URL: https://issues.apache.org/jira/browse/CALCITE-6217
Project: Calcite
Issue Type:
[
https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809165#comment-17809165
]
Julian Hyde commented on CALCITE-6214:
--
Can you remove backticks from the jira subject? Backticks
[
https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809164#comment-17809164
]
Julian Hyde commented on CALCITE-6214:
--
I have no problem with doing this via a rule. But it could
[
https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809157#comment-17809157
]
Julian Hyde commented on CALCITE-6209:
--
[~stoty], More parameters more things to screw up. So we
[
https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809147#comment-17809147
]
Julian Hyde commented on CALCITE-6214:
--
You should do other aggregate functions also - e.g. SUM
[
https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808351#comment-17808351
]
Julian Hyde commented on CALCITE-6209:
--
I would presume that the
[
https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807800#comment-17807800
]
Julian Hyde commented on CALCITE-6209:
--
It seems that the server has stopped responding, for some
[
https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807479#comment-17807479
]
Julian Hyde commented on CALCITE-6207:
--
Yes, I think that would be best in this case. I think this
[
https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807475#comment-17807475
]
Julian Hyde commented on CALCITE-6207:
--
[~mbudiu], Can you check the jira conversation before you
[
https://issues.apache.org/jira/browse/CALCITE-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807460#comment-17807460
]
Julian Hyde commented on CALCITE-6098:
--
+1
> Remove mentions of Jekyll from LICENSE and NOTICE
[
https://issues.apache.org/jira/browse/CALCITE-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807449#comment-17807449
]
Julian Hyde commented on CALCITE-6098:
--
It is very likely the case that I copied from ORC. I
[
https://issues.apache.org/jira/browse/CALCITE-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807438#comment-17807438
]
Julian Hyde commented on CALCITE-6206:
--
I support this initiative. Calcite needs to "translate SQL
[
https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807436#comment-17807436
]
Julian Hyde commented on CALCITE-6207:
--
If {{connection.getMetaData()}} or
[
https://issues.apache.org/jira/browse/CALCITE-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807128#comment-17807128
]
Julian Hyde commented on CALCITE-6202:
--
Thank you for fixing this!
> `sqlsh` does not print error
[
https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807124#comment-17807124
]
Julian Hyde commented on CALCITE-6207:
--
Is there a problem with the current method? If it ain't
[
https://issues.apache.org/jira/browse/CALCITE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6044:
-
Summary: RelMetadataQuery should regard single-row relational expressions
as unique (was:
[
https://issues.apache.org/jira/browse/CALCITE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-6044.
--
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806239#comment-17806239
]
Julian Hyde commented on CALCITE-6044:
--
Looks good. Final testing and will merge to main shortly.
[
https://issues.apache.org/jira/browse/CALCITE-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806227#comment-17806227
]
Julian Hyde commented on CALCITE-6192:
--
Please remember to create Jira links to bugs, so that they
[
https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806226#comment-17806226
]
Julian Hyde commented on CALCITE-6193:
--
[~4wei], Is this a good summary of the case:
{quote}
If a
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806220#comment-17806220
]
Julian Hyde commented on CALCITE-6180:
--
I agree with you on the first part.
An example of the
[
https://issues.apache.org/jira/browse/CALCITE-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806176#comment-17806176
]
Julian Hyde commented on CALCITE-6195:
--
The {{validateParameterizedExpression}} is called in one
[
https://issues.apache.org/jira/browse/CALCITE-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806175#comment-17806175
]
Julian Hyde commented on CALCITE-6196:
--
Would this feature be turned on in BigQuery mode or in all
[
https://issues.apache.org/jira/browse/CALCITE-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804929#comment-17804929
]
Julian Hyde commented on CALCITE-6195:
--
It looks wrong to be putting qualified names into a map
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6180:
-
Fix Version/s: (was: 1.37.0)
> Append possibility to escape backslash in LIKE expression
>
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804878#comment-17804878
]
Julian Hyde edited comment on CALCITE-6180 at 1/9/24 8:42 PM:
--
The PR was
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804878#comment-17804878
]
Julian Hyde commented on CALCITE-6180:
--
The PR was originally merged to main as commit
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804855#comment-17804855
]
Julian Hyde commented on CALCITE-6188:
--
I forgot an important case. Two or more queries that can
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803732#comment-17803732
]
Julian Hyde edited comment on CALCITE-6188 at 1/9/24 7:17 PM:
--
I had an
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6188:
-
Description:
Devise extensions to SQL for multi-query optimization (MQO). Queries with
[
https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6193:
-
Fix Version/s: 1.37.0
> SubstitutionVisitor stop trying incorrect subtree because of wrong
[
https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804528#comment-17804528
]
Julian Hyde commented on CALCITE-6193:
--
This bug looks legitimate. However, it would be useful if
[
https://issues.apache.org/jira/browse/CALCITE-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804519#comment-17804519
]
Julian Hyde commented on CALCITE-6194:
--
Practice has changed recently. Can you change "and also
[
https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804496#comment-17804496
]
Julian Hyde commented on CALCITE-6178:
--
(In my view, PRs are just scaffolding. Jira and the git
[
https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804494#comment-17804494
]
Julian Hyde commented on CALCITE-6178:
--
Still not good. 6d95a10 isn't on main. You must use a URL
[
https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804490#comment-17804490
]
Julian Hyde commented on CALCITE-6178:
--
[~mbudiu], Can you note the actual commit SHA (in main
[
https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6178:
-
Summary: WITH RECURSIVE query when cloned using SqlShuttle loses RECURSIVE
property (was:
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804010#comment-17804010
]
Julian Hyde commented on CALCITE-6188:
--
The DML options are probably syntactic sugar. Note that
[
https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803981#comment-17803981
]
Julian Hyde commented on CALCITE-6185:
--
Which function or functions should support this format
[
https://issues.apache.org/jira/browse/CALCITE-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803980#comment-17803980
]
Julian Hyde commented on CALCITE-6191:
--
I think you’re actually converting the Join into a
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803732#comment-17803732
]
Julian Hyde commented on CALCITE-6188:
--
I had an idea for DML. The idea is that each DML operation
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803650#comment-17803650
]
Julian Hyde commented on CALCITE-6188:
--
I got some feedback on twitter that we need to be able to
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803373#comment-17803373
]
Julian Hyde commented on CALCITE-6188:
--
Thank you, [~jaynarale]! The sequence node is not
[
https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6188:
-
Description:
Devise extensions to SQL so that queries with multiple input tables, multiple
Julian Hyde created CALCITE-6188:
Summary: Multi-query optimization
Key: CALCITE-6188
URL: https://issues.apache.org/jira/browse/CALCITE-6188
Project: Calcite
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/CALCITE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803348#comment-17803348
]
Julian Hyde commented on CALCITE-6186:
--
Yes, it's worth experimenting with stuff like that.
[
https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803321#comment-17803321
]
Julian Hyde edited comment on CALCITE-6182 at 1/4/24 8:53 PM:
--
(I edited
[
https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803321#comment-17803321
]
Julian Hyde commented on CALCITE-6182:
--
(I edited the above message because I force-pushed to fix
[
https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802323#comment-17802323
]
Julian Hyde edited comment on CALCITE-6182 at 1/4/24 8:51 PM:
--
Merged via
[
https://issues.apache.org/jira/browse/CALCITE-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-6187.
--
Fix Version/s: 1.37.0
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803314#comment-17803314
]
Julian Hyde commented on CALCITE-6186:
--
Does this change cover incoming SQL (i.e.
Julian Hyde created CALCITE-6187:
Summary: Linter should disallow tags such as '[MINOR]' in commit
messages
Key: CALCITE-6187
URL: https://issues.apache.org/jira/browse/CALCITE-6187
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803261#comment-17803261
]
Julian Hyde edited comment on CALCITE-6185 at 1/4/24 7:01 PM:
--
The jira
[
https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803261#comment-17803261
]
Julian Hyde edited comment on CALCITE-6185 at 1/4/24 6:58 PM:
--
The jira
[
https://issues.apache.org/jira/browse/CALCITE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803261#comment-17803261
]
Julian Hyde commented on CALCITE-6185:
--
The jira subject must describe the feature, i.e. what the
[
https://issues.apache.org/jira/browse/CALCITE-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802329#comment-17802329
]
Julian Hyde commented on CALCITE-6176:
--
This seems to be a bug. I looked at your first query, and
[
https://issues.apache.org/jira/browse/CALCITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802322#comment-17802322
]
Julian Hyde commented on CALCITE-5791:
--
I was able to reproduce from SQLLine, as follows:
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802320#comment-17802320
]
Julian Hyde edited comment on CALCITE-6180 at 1/3/24 8:48 PM:
--
[~zstan]
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802320#comment-17802320
]
Julian Hyde commented on CALCITE-6180:
--
[~zstan], I think the previous behavior was correct. This
[
https://issues.apache.org/jira/browse/CALCITE-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-6128.
--
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801397#comment-17801397
]
Julian Hyde commented on CALCITE-6178:
--
Might be useful for SqlUnparserTest to unparse everything
[
https://issues.apache.org/jira/browse/CALCITE-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-6181.
--
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6181:
-
Fix Version/s: 1.37.0
> Upgrade janino to 3.1.11
>
>
>
[
https://issues.apache.org/jira/browse/CALCITE-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801282#comment-17801282
]
Julian Hyde commented on CALCITE-6181:
--
It's not helpful to talk about CVEs in open bugs. If you
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde reopened CALCITE-6180:
--
> Append possibility to escape backslash in LIKE with ESCAPE operator
>
[
https://issues.apache.org/jira/browse/CALCITE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801281#comment-17801281
]
Julian Hyde commented on CALCITE-6180:
--
I don't think {{ESCAPE}} has anything to do with it.
[
https://issues.apache.org/jira/browse/CALCITE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801277#comment-17801277
]
Julian Hyde commented on CALCITE-6182:
--
I reviewed. Looks good, could just use more explanatory
[
https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801276#comment-17801276
]
Julian Hyde commented on CALCITE-6172:
--
I don't feel strongly about either approach.
I do think
[
https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799615#comment-17799615
]
Julian Hyde commented on CALCITE-6172:
--
[~tanclary], You can easily answer the question 'What
[
https://issues.apache.org/jira/browse/CALCITE-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799594#comment-17799594
]
Julian Hyde edited comment on CALCITE-6156 at 12/21/23 10:35 PM:
-
[
https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799597#comment-17799597
]
Julian Hyde commented on CALCITE-6172:
--
One particular test is {{SqlOperatorTest.java}}. In
[
https://issues.apache.org/jira/browse/CALCITE-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799123#comment-17799123
]
Julian Hyde commented on CALCITE-6145:
--
I agree with [~asolimando]. The dev list is a good place
[
https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-3329:
-
Component/s: os-adapter
> Implement osquery for OS adapter
>
[
https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-3329.
--
Fix Version/s: 1.37.0
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798695#comment-17798695
]
Julian Hyde commented on CALCITE-6170:
--
The bug is probably in Calcite, not Avatica-Go. Or rather,
[
https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798465#comment-17798465
]
Julian Hyde commented on CALCITE-3329:
--
[~x1q1j1] In my
[
https://issues.apache.org/jira/browse/CALCITE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798445#comment-17798445
]
Julian Hyde commented on CALCITE-3522:
--
I don't think you can just remove the checks. If you do
[
https://issues.apache.org/jira/browse/CALCITE-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798440#comment-17798440
]
Julian Hyde commented on CALCITE-6168:
--
This case is very similar to CALCITE-1439. Is it possible
[
https://issues.apache.org/jira/browse/CALCITE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798437#comment-17798437
]
Julian Hyde commented on CALCITE-6162:
--
That sounds right.
> Add rule(s) to remove joins with
[
https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798021#comment-17798021
]
Julian Hyde commented on CALCITE-6165:
--
Don't close the ticket. It is still valid - the goal is to
[
https://issues.apache.org/jira/browse/CALCITE-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798020#comment-17798020
]
Julian Hyde commented on CALCITE-6167:
--
I wonder whether the problem is the correlated variable
[
https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798010#comment-17798010
]
Julian Hyde commented on CALCITE-3329:
--
Thank you for doing this. I will review in a day or two.
[
https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798008#comment-17798008
]
Julian Hyde commented on CALCITE-6165:
--
Correct. Functions with ordinary syntax do not require
[
https://issues.apache.org/jira/browse/CALCITE-6166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797308#comment-17797308
]
Julian Hyde edited comment on CALCITE-6166 at 12/15/23 8:17 PM:
I agree
[
https://issues.apache.org/jira/browse/CALCITE-6166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797308#comment-17797308
]
Julian Hyde commented on CALCITE-6166:
--
I agree that the rule should preserve the type. Depending
[
https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796884#comment-17796884
]
Julian Hyde edited comment on CALCITE-6165 at 12/14/23 7:27 PM:
This
[
https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796884#comment-17796884
]
Julian Hyde commented on CALCITE-6165:
--
This commit is not large enough in scope to add to the
[
https://issues.apache.org/jira/browse/CALCITE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796497#comment-17796497
]
Julian Hyde commented on CALCITE-6164:
--
Not a goal of this test. In fact we should have pushed
[
https://issues.apache.org/jira/browse/CALCITE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796494#comment-17796494
]
Julian Hyde commented on CALCITE-6162:
--
I see you have {{cross join}} and {{{}inner join{}}}. Is
[
https://issues.apache.org/jira/browse/CALCITE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796416#comment-17796416
]
Julian Hyde commented on CALCITE-6164:
--
This does not belong in the {{example}} module. The
[
https://issues.apache.org/jira/browse/CALCITE-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795542#comment-17795542
]
Julian Hyde commented on CALCITE-6161:
--
If you add those cases and they pass I will merge your PR.
[
https://issues.apache.org/jira/browse/CALCITE-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795541#comment-17795541
]
Julian Hyde commented on CALCITE-6161:
--
Can you add a few test cases for {{equalsDeep}}:
* -(x,
[
https://issues.apache.org/jira/browse/CALCITE-6157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795536#comment-17795536
]
Julian Hyde commented on CALCITE-6157:
--
I'm puzzled, too. Your test case looks like a faithful
201 - 300 of 11138 matches
Mail list logo