[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048836#comment-17048836
]
Danny Chen commented on CALCITE-3769:
-
Thanks, i agree the ScannableTable could have a
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048490#comment-17048490
]
Stamatis Zampetakis commented on CALCITE-3769:
--
Thanks for your patience [~danny0405]!
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048454#comment-17048454
]
Danny Chen commented on CALCITE-3769:
-
The EnumerableTableScan can not handle projects/filter
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048345#comment-17048345
]
Stamatis Zampetakis commented on CALCITE-3769:
--
I am sorry but I am still missing some
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047352#comment-17047352
]
Danny Chen commented on CALCITE-3769:
-
> Why EnumerableTableScanRule has to introduce a
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047306#comment-17047306
]
Stamatis Zampetakis commented on CALCITE-3769:
--
Guys nobody is accusing anybody. I know
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047185#comment-17047185
]
Danny Chen commented on CALCITE-3769:
-
[~zabetak]
bq. I also find it a bit weird that
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046997#comment-17046997
]
Julian Hyde commented on CALCITE-3769:
--
I agree with [~zabetak]. Let's be pragmatic and back this
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046729#comment-17046729
]
Stamatis Zampetakis commented on CALCITE-3769:
--
Given that we would like to get the 1.22.0
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045294#comment-17045294
]
Enrico Olivelli commented on CALCITE-3769:
--
In my case the fix was easy, just to return "null"
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045210#comment-17045210
]
Vladimir Sitnikov commented on CALCITE-3769:
[~eolivelli] mentioned that this change
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045197#comment-17045197
]
Stamatis Zampetakis commented on CALCITE-3769:
--
[~anha] mentioned a regression in the
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035760#comment-17035760
]
Julian Hyde commented on CALCITE-3769:
--
I don't think they're the same:
* Danny's change would not
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035715#comment-17035715
]
Vladimir Sitnikov commented on CALCITE-3769:
{quote}Do you have any other
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035252#comment-17035252
]
Danny Chen commented on CALCITE-3769:
-
Sure, let's make this into 1.22, the Apache Flink code
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035220#comment-17035220
]
Stamatis Zampetakis commented on CALCITE-3769:
--
[~danny0405] There are for sure cases
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034967#comment-17034967
]
Danny Chen commented on CALCITE-3769:
-
[~vladimirsitnikov] Do you have any other
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034069#comment-17034069
]
Danny Chen commented on CALCITE-3769:
-
[~julianhyde]
{quote}It makes me want to break up the
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034062#comment-17034062
]
Danny Chen commented on CALCITE-3769:
-
[~vladimirsitnikov], as for the plan change in the tests, i
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033898#comment-17033898
]
Julian Hyde commented on CALCITE-3769:
--
bq. Looking forward to such a change that does *not* edit
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033883#comment-17033883
]
Vladimir Sitnikov commented on CALCITE-3769:
{quote} This fix does not expect to break the
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033874#comment-17033874
]
Julian Hyde commented on CALCITE-3769:
--
[~zabetak], Yes, that's it. Thanks for finding the link.
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033365#comment-17033365
]
Danny Chen commented on CALCITE-3769:
-
[~vladimirsitnikov] This fix does not expect to break the
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032840#comment-17032840
]
Stamatis Zampetakis commented on CALCITE-3769:
--
[~julianhyde] I suppose you are referring
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032559#comment-17032559
]
Julian Hyde commented on CALCITE-3769:
--
There was a discussion a few months ago about the
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032477#comment-17032477
]
Vladimir Sitnikov commented on CALCITE-3769:
I wonder if anyone raises a question on
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032252#comment-17032252
]
Danny Chen commented on CALCITE-3769:
-
Finally i gave a solution:
* Deprecate TableScanRule and
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030892#comment-17030892
]
Stamatis Zampetakis commented on CALCITE-3769:
--
I would prefer if we didn't introduce a
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030333#comment-17030333
]
Danny Chen commented on CALCITE-3769:
-
Instead of deprecate RelOptTable#toRel, i prefer to keep it,
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030312#comment-17030312
]
Danny Chen commented on CALCITE-3769:
-
{quote}ToRelContext is difficult to understand, and poorly
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030306#comment-17030306
]
Julian Hyde commented on CALCITE-3769:
--
Is your goal to put enough capabilities into RelBuilder so
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030304#comment-17030304
]
Julian Hyde commented on CALCITE-3769:
--
An alternative is to deprecate {{toRel}}.
(I really don’t
[
https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030289#comment-17030289
]
Danny Chen commented on CALCITE-3769:
-
I did fire a mail in dev mailing list, but the mail never
33 matches
Mail list logo