[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469157#comment-16469157 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde] I've missed that - I was clearly

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469267#comment-16469267 ] Zoltan Haindrich commented on CALCITE-2247: --- sorry...I see now that actually AND(null, ...)

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469371#comment-16469371 ] Zoltan Haindrich commented on CALCITE-2247: --- the current changeset incorrectly simplifies

[jira] [Commented] (CALCITE-2257) Combination of predicates can be proved to be always true

[ https://issues.apache.org/jira/browse/CALCITE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453890#comment-16453890 ] Zoltan Haindrich commented on CALCITE-2257: --- [~vitalii]: I've tried to peek into this

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470036#comment-16470036 ] Zoltan Haindrich commented on CALCITE-2247: --- I've fixed that issue; but it looks like (x &&

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471630#comment-16471630 ] Zoltan Haindrich commented on CALCITE-2247: --- I've checked it separetly; it was there before my

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466077#comment-16466077 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde]: yes, cases like that are covered.

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480289#comment-16480289 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde]: I've discovered that (x&&!x) might

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482038#comment-16482038 ] Zoltan Haindrich commented on CALCITE-2247: --- I've also thinked about this; and I've ended up

[jira] [Commented] (CALCITE-2328) Operand of Logical And/OR should support type like INT, DOUTLE not only Boolean

[ https://issues.apache.org/jira/browse/CALCITE-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490662#comment-16490662 ] Zoltan Haindrich commented on CALCITE-2328: --- I'm not sure if this is a problem...I think even

[jira] [Commented] (CALCITE-2314) Verify RexNode transformations by evaluating before and after expressions against sample values

[ https://issues.apache.org/jira/browse/CALCITE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488907#comment-16488907 ] Zoltan Haindrich commented on CALCITE-2314: --- [~julianhyde] I've fixed the remaining tests, and

[jira] [Commented] (CALCITE-2247) Add rule to push conditions into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489824#comment-16489824 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde] I think that

[jira] [Created] (CALCITE-2326) Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify

Zoltan Haindrich created CALCITE-2326: - Summary: Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify Key: CALCITE-2326 URL: https://issues.apache.org/jira/browse/CALCITE-2326 Project:

[jira] [Moved] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich moved HIVE-19712 to CALCITE-2327: -- Workflow: jira (was: no-reopen-closed, patch-avail)

[jira] [Commented] (CALCITE-2247) Add rule to push conditions into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490346#comment-16490346 ] Zoltan Haindrich commented on CALCITE-2247: --- I've opened CALCITE-2326 for the generalization;

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476041#comment-16476041 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde] Could you please take a look at the

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481147#comment-16481147 ] Zoltan Haindrich commented on CALCITE-2247: --- I think that probably unknownAsFalse should be

[jira] [Updated] (CALCITE-2338) Reduce the externally visible api of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2338: -- Summary: Reduce the externally visible api of RexSimplify (was: Reconsider the

[jira] [Comment Edited] (CALCITE-2338) Reduce the externally visible api of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504860#comment-16504860 ] Zoltan Haindrich edited comment on CALCITE-2338 at 6/7/18 4:04 PM: ---

[jira] [Commented] (CALCITE-2338) Reduce the externally visible api of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504860#comment-16504860 ] Zoltan Haindrich commented on CALCITE-2338: --- [~julianhyde] I understand your point of view;

[jira] [Commented] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494765#comment-16494765 ] Zoltan Haindrich commented on CALCITE-2327: --- [~jcamachorodriguez] Could you take a look? I

[jira] [Commented] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501437#comment-16501437 ] Zoltan Haindrich commented on CALCITE-2327: --- [~jcamachorodriguez] could you please take a

[jira] [Created] (CALCITE-2338) Reconsider the externally visible api of RexSimplify

Zoltan Haindrich created CALCITE-2338: - Summary: Reconsider the externally visible api of RexSimplify Key: CALCITE-2338 URL: https://issues.apache.org/jira/browse/CALCITE-2338 Project: Calcite

[jira] [Commented] (CALCITE-2393) RexSimplify optimization error for expression 'x is not null and x <> 5'

[ https://issues.apache.org/jira/browse/CALCITE-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529853#comment-16529853 ] Zoltan Haindrich commented on CALCITE-2393: --- I think that "null<> 5 should return true" is

[jira] [Commented] (CALCITE-2393) RexSimplify optimization error for expression 'x is not null and x <> 5'

[ https://issues.apache.org/jira/browse/CALCITE-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529839#comment-16529839 ] Zoltan Haindrich commented on CALCITE-2393: --- I would like to try to convince you that its

[jira] [Commented] (CALCITE-2393) RexSimplify optimization error for expression 'x is not null and x <> 5'

[ https://issues.apache.org/jira/browse/CALCITE-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529848#comment-16529848 ] Zoltan Haindrich commented on CALCITE-2393: --- there is another way, by looking at the truth

[jira] [Commented] (CALCITE-2384) Performance issue in getPulledUpPredicates

[ https://issues.apache.org/jira/browse/CALCITE-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530021#comment-16530021 ] Zoltan Haindrich commented on CALCITE-2384: --- It's a kinda sophisticated thing; but to

[jira] [Commented] (CALCITE-2384) Performance issue in getPulledUpPredicates

[ https://issues.apache.org/jira/browse/CALCITE-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531243#comment-16531243 ] Zoltan Haindrich commented on CALCITE-2384: --- I've added an internal feature toggle to

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454531#comment-16454531 ] Zoltan Haindrich commented on CALCITE-2247: --- I've made some bad trials which have done that!

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462670#comment-16462670 ] Zoltan Haindrich commented on CALCITE-2247: --- [~julianhyde], [~jcamachorodriguez]: Could you

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453810#comment-16453810 ] Zoltan Haindrich commented on CALCITE-2247: --- After a few loose ends, I think I've finally

[jira] [Commented] (CALCITE-2257) Combination of predicates can be proved to be always true

[ https://issues.apache.org/jira/browse/CALCITE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457978#comment-16457978 ] Zoltan Haindrich commented on CALCITE-2257: --- [~zhong.j.yu] ; oh really, thanks for pointing

[jira] [Created] (CALCITE-2444) Rel2Sql: support c IN (1,2)

Zoltan Haindrich created CALCITE-2444: - Summary: Rel2Sql: support c IN (1,2) Key: CALCITE-2444 URL: https://issues.apache.org/jira/browse/CALCITE-2444 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-2445) RexSimplify x=x

Zoltan Haindrich created CALCITE-2445: - Summary: RexSimplify x=x Key: CALCITE-2445 URL: https://issues.apache.org/jira/browse/CALCITE-2445 Project: Calcite Issue Type: Improvement

[jira] [Resolved] (CALCITE-2445) RexSimplify x=x

[ https://issues.apache.org/jira/browse/CALCITE-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2445. --- Resolution: Invalid Unfortunately hitting return in the summary field: submits the

[jira] [Commented] (CALCITE-2451) RexSimplify: fuse unknownAsFalse and IS TRUE handling

[ https://issues.apache.org/jira/browse/CALCITE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571407#comment-16571407 ] Zoltan Haindrich commented on CALCITE-2451: --- I've tried this earlier...with a slightly

[jira] [Commented] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594915#comment-16594915 ] Zoltan Haindrich commented on CALCITE-2327: --- I disagree with "off the track" - but even if I

[jira] [Commented] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594828#comment-16594828 ] Zoltan Haindrich commented on CALCITE-2327: --- [~vladimirsitnikov]: You have submitted a

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594670#comment-16594670 ] Zoltan Haindrich commented on CALCITE-2444: --- I've went into a little bit of overcomplicating

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594674#comment-16594674 ] Zoltan Haindrich commented on CALCITE-2444: --- opened pullrequest:

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596189#comment-16596189 ] Zoltan Haindrich commented on CALCITE-2444: --- [~vladimirsitnikov] I've added a test for that

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596202#comment-16596202 ] Zoltan Haindrich commented on CALCITE-2444: --- I have added one more - but I feel that these

[jira] [Commented] (CALCITE-2421) RexSimplify#simplifyAnds foregoes some simplications if unknownAsFalse set to true

[ https://issues.apache.org/jira/browse/CALCITE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549955#comment-16549955 ] Zoltan Haindrich commented on CALCITE-2421: --- I think I understand - and I agree; I've one

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609138#comment-16609138 ] Zoltan Haindrich commented on CALCITE-2444: --- [~julianhyde] Could you please take a look? I

[jira] [Created] (CALCITE-2401) Improve RelMdPredicates performance

Zoltan Haindrich created CALCITE-2401: - Summary: Improve RelMdPredicates performance Key: CALCITE-2401 URL: https://issues.apache.org/jira/browse/CALCITE-2401 Project: Calcite Issue

[jira] [Commented] (CALCITE-2338) Reduce the externally visible api of RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534944#comment-16534944 ] Zoltan Haindrich commented on CALCITE-2338: --- The calls into these intermediate methods are

[jira] [Moved] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich moved HIVE-19150 to CALCITE-2247: -- Workflow: jira (was: no-reopen-closed, patch-avail)

[jira] [Comment Edited] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432147#comment-16432147 ] Zoltan Haindrich edited comment on CALCITE-2247 at 4/10/18 12:06 PM: -

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432147#comment-16432147 ] Zoltan Haindrich commented on CALCITE-2247: --- I've opened

[jira] [Created] (CALCITE-2240) Predicate push into CASE statment doesn't happen in some cases

Zoltan Haindrich created CALCITE-2240: - Summary: Predicate push into CASE statment doesn't happen in some cases Key: CALCITE-2240 URL: https://issues.apache.org/jira/browse/CALCITE-2240 Project:

[jira] [Commented] (CALCITE-2240) Predicate push into CASE statment doesn't happen in some cases

[ https://issues.apache.org/jira/browse/CALCITE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427140#comment-16427140 ] Zoltan Haindrich commented on CALCITE-2240: --- opened pullrequest: 

[jira] [Commented] (CALCITE-2247) Add rule to push in condition condition into a related disjunctive expression

[ https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434548#comment-16434548 ] Zoltan Haindrich commented on CALCITE-2247: --- When I've looked into RexImplicationChecker it

[jira] [Commented] (CALCITE-2257) Combination of predicates can be proved to be always true

[ https://issues.apache.org/jira/browse/CALCITE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454318#comment-16454318 ] Zoltan Haindrich commented on CALCITE-2257: --- Thank you [~vitalii]! I was using the wrong

[jira] [Commented] (CALCITE-2384) Performance issue in getPulledUpPredicates

[ https://issues.apache.org/jira/browse/CALCITE-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527797#comment-16527797 ] Zoltan Haindrich commented on CALCITE-2384: --- thank you [~michaelmior] for bisecting this; I

[jira] [Commented] (CALCITE-2451) RexSimplify: fuse unknownAsFalse and IS TRUE handling

[ https://issues.apache.org/jira/browse/CALCITE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641579#comment-16641579 ] Zoltan Haindrich commented on CALCITE-2451: --- sorry: in my last comment I was not talking

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641976#comment-16641976 ] Zoltan Haindrich commented on CALCITE-2611: --- reason behind this issue is that the

[jira] [Assigned] (CALCITE-1413) New CASE statement simplification

[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-1413: - Assignee: Zoltan Haindrich (was: Jesus Camacho Rodriguez) > New CASE

[jira] [Commented] (CALCITE-1413) New CASE statement simplification

[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646586#comment-16646586 ] Zoltan Haindrich commented on CALCITE-1413: --- opened

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646626#comment-16646626 ] Zoltan Haindrich commented on CALCITE-2615: --- in 3 valued logic the following stands: {code} a

[jira] [Commented] (CALCITE-1289) RexUtil.simplifyCase() should account for nullability

[ https://issues.apache.org/jira/browse/CALCITE-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650267#comment-16650267 ] Zoltan Haindrich commented on CALCITE-1289: --- I was looking into these casts around case

[jira] [Commented] (CALCITE-2630) Convert SqlInOperator to In-Expression

[ https://issues.apache.org/jira/browse/CALCITE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655368#comment-16655368 ] Zoltan Haindrich commented on CALCITE-2630: --- Thank you [~pzw2018] for starting this

[jira] [Created] (CALCITE-2631) Address small issues in case simplification

Zoltan Haindrich created CALCITE-2631: - Summary: Address small issues in case simplification Key: CALCITE-2631 URL: https://issues.apache.org/jira/browse/CALCITE-2631 Project: Calcite

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655112#comment-16655112 ] Zoltan Haindrich commented on CALCITE-2615: --- Thank you [~jcamachorodriguez] for commiting

[jira] [Created] (CALCITE-2632) Add hashCode and equals implementations to RexNode

Zoltan Haindrich created CALCITE-2632: - Summary: Add hashCode and equals implementations to RexNode Key: CALCITE-2632 URL: https://issues.apache.org/jira/browse/CALCITE-2632 Project: Calcite

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655171#comment-16655171 ] Zoltan Haindrich commented on CALCITE-2632: --- I right now see to better options to the

[jira] [Comment Edited] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655171#comment-16655171 ] Zoltan Haindrich edited comment on CALCITE-2632 at 10/18/18 12:41 PM:

[jira] [Updated] (CALCITE-2652) SqlNode to SQL conversion fails if the join condition contains a boolean column reference

[ https://issues.apache.org/jira/browse/CALCITE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2652: -- Summary: SqlNode to SQL conversion fails if the join condition contains a boolean

[jira] [Commented] (CALCITE-2652) SqlNode to SQL conversion fails if the join condition contains a boolean column reference

[ https://issues.apache.org/jira/browse/CALCITE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672303#comment-16672303 ] Zoltan Haindrich commented on CALCITE-2652: --- [~julianhyde] I've updated the summary - please

[jira] [Created] (CALCITE-2652) Fix Rel2Sql conversion in case the join condition contains a boolean column reference

Zoltan Haindrich created CALCITE-2652: - Summary: Fix Rel2Sql conversion in case the join condition contains a boolean column reference Key: CALCITE-2652 URL: https://issues.apache.org/jira/browse/CALCITE-2652

[jira] [Created] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

Zoltan Haindrich created CALCITE-2675: - Summary: ReduceExpressionRule may leave behind altered types w.r.t nullability Key: CALCITE-2675 URL: https://issues.apache.org/jira/browse/CALCITE-2675

[jira] [Commented] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

[ https://issues.apache.org/jira/browse/CALCITE-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688318#comment-16688318 ] Zoltan Haindrich commented on CALCITE-2675: --- My proposed solution is to remove the invocation

[jira] [Commented] (CALCITE-2652) SqlNode to SQL conversion fails if the join condition uses a column of type BOOLEAN

[ https://issues.apache.org/jira/browse/CALCITE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681504#comment-16681504 ] Zoltan Haindrich commented on CALCITE-2652: --- Thank you [~julianhyde] and [~zhenw]! Is there

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638411#comment-16638411 ] Zoltan Haindrich commented on CALCITE-2611: --- I'm not sure how to get started with this issue

[jira] [Created] (CALCITE-2611) Code generation fails if one side of an or contains unknown

Zoltan Haindrich created CALCITE-2611: - Summary: Code generation fails if one side of an or contains unknown Key: CALCITE-2611 URL: https://issues.apache.org/jira/browse/CALCITE-2611 Project:

[jira] [Created] (CALCITE-2606) Return type inference for and/or may identify result type incorrectly

Zoltan Haindrich created CALCITE-2606: - Summary: Return type inference for and/or may identify result type incorrectly Key: CALCITE-2606 URL: https://issues.apache.org/jira/browse/CALCITE-2606

[jira] [Commented] (CALCITE-2606) Return type inference for and/or may identify result type incorrectly

[ https://issues.apache.org/jira/browse/CALCITE-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637260#comment-16637260 ] Zoltan Haindrich commented on CALCITE-2606: --- That sounds good; then that will also ensure

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642472#comment-16642472 ] Zoltan Haindrich commented on CALCITE-2615: --- I've found a smaller sample: {code} @Test

[jira] [Comment Edited] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642472#comment-16642472 ] Zoltan Haindrich edited comment on CALCITE-2615 at 10/8/18 9:26 PM:

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642567#comment-16642567 ] Zoltan Haindrich commented on CALCITE-2615: --- opened PR: 

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642900#comment-16642900 ] Zoltan Haindrich commented on CALCITE-2615: --- I went back to paper and proved to myself; how

[jira] [Comment Edited] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642900#comment-16642900 ] Zoltan Haindrich edited comment on CALCITE-2615 at 10/9/18 7:25 AM:

[jira] [Commented] (CALCITE-2326) Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633979#comment-16633979 ] Zoltan Haindrich commented on CALCITE-2326: --- Passing unkownAs in the methods makes them a bit

[jira] [Moved] (CALCITE-2608) Simplifying using predicates should consider not equals in case its a predicate

[ https://issues.apache.org/jira/browse/CALCITE-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich moved HIVE-20689 to CALCITE-2608: -- Workflow: jira (was: no-reopen-closed, patch-avail)

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638094#comment-16638094 ] Zoltan Haindrich commented on CALCITE-2438: --- I think this issue is very important; because

[jira] [Reopened] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reopened CALCITE-2438: --- Assignee: Zoltan Haindrich (was: Julian Hyde) > RexCall#isAlwaysTrue return

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642004#comment-16642004 ] Zoltan Haindrich commented on CALCITE-2611: --- The uncommon in this {{Boolean.FALSE} is that

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642019#comment-16642019 ] Zoltan Haindrich commented on CALCITE-2611: --- BlockBuilderTest level testcase: {code} @Test

[jira] [Assigned] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-2611: - Assignee: Zoltan Haindrich (was: Julian Hyde) > Code generation fails if one

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642386#comment-16642386 ] Zoltan Haindrich commented on CALCITE-2615: --- I'll take a look > When simplifying NOT-AND-OR,

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644046#comment-16644046 ] Zoltan Haindrich commented on CALCITE-2615: --- The concept on which it builds is somewhat the

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597368#comment-16597368 ] Zoltan Haindrich commented on CALCITE-2444: --- [~julianhyde] I've updated the pullrequest; I

[jira] [Commented] (CALCITE-2451) RexSimplify: fuse unknownAsFalse and IS TRUE handling

[ https://issues.apache.org/jira/browse/CALCITE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623807#comment-16623807 ] Zoltan Haindrich commented on CALCITE-2451: --- interesting...I think I've kinda tried it a

[jira] [Commented] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

[ https://issues.apache.org/jira/browse/CALCITE-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689758#comment-16689758 ] Zoltan Haindrich commented on CALCITE-2675: --- [~jcamachorodriguez] Could you please take a

[jira] [Commented] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744031#comment-16744031 ] Zoltan Haindrich commented on CALCITE-2783: --- I was able to fix this; and because it has a

[jira] [Commented] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743188#comment-16743188 ] Zoltan Haindrich commented on CALCITE-2783: --- it seems like the problem arises from the

[jira] [Commented] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747824#comment-16747824 ] Zoltan Haindrich commented on CALCITE-2783: --- opened pr:

[jira] [Updated] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2783: -- Summary: Fix null related issues during RexToLix translation (was: Null checks

[jira] [Commented] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750352#comment-16750352 ] Zoltan Haindrich commented on CALCITE-2783: --- It's a [git

[jira] [Resolved] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2783. --- Resolution: Fixed Fix Version/s: 1.19.0 > Fix null related issues during

[jira] [Commented] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749946#comment-16749946 ] Zoltan Haindrich commented on CALCITE-2783: --- Fixed in

  1   2   3   >