Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2362#discussion_r193963265
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2362#discussion_r193962103
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -74,6 +74,8 @@ public boolean hasNext() throws IOExceptio
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2363
@ravipesala : please merge this fix to 1.4.0 branch also
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravindra Pesala resolved CARBONDATA-2591.
-
Resolution: Fixed
Fix Version/s: 1.4.1
> SDK CarbonReader support fil
[
https://issues.apache.org/jira/browse/CARBONDATA-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravindra Pesala resolved CARBONDATA-2569.
-
Resolution: Fixed
Fix Version/s: 1.4.1
> Search mode throw exception
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2363
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5139/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6302/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509109#comment-16509109
]
xuchuanyin edited comment on CARBONDATA-2340 at 6/12/18 3:09 AM:
-
[
https://issues.apache.org/jira/browse/CARBONDATA-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509109#comment-16509109
]
xuchuanyin commented on CARBONDATA-2340:
[~niaoshu] Hi, about 32000 characte
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2252#discussion_r194603907
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@ -56,7
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2363
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5138/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6301/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5261/
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2252#discussion_r194597446
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java
---
@@ -30,21 +30,19 @@
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194595227
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -218,6 +222,40 @@ public static void updateTableI
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2252#discussion_r194479546
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@ -56
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2362
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5260/
---
Github user eychih commented on the issue:
https://github.com/apache/carbondata/pull/2335
@ravipesala @jackylk It looks like the discussion become uninteresting and
unproductive now. I just try to make some constructive comments. The comments
I made in the previous discussions remai
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2362
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5259/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2362
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5137/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2362
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6300/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2362
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5258/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2362
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5257/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-2573.
--
Resolution: Fixed
Fix Version/s: 1.4.1
> Merge carbonstore branch to master
> -
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2335
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2335
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2362
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5256/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2265
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5134/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2265
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6296/
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2357
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2362
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5135/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2357
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2367
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5133/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2362
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6298/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2335
@eychih The code added to rewrite with MV table is done outside so there
would not be any harm to the purpose of MV. And moreover checking the
sameresult multiple times gives performance prob
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2367
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6295/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194382421
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -218,6 +222,40 @@ public static void updateTab
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2362
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5255/
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2363
LGTM.
This fix need to merge to both master and 1.4 branch
---
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/2265
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2367
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2362
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5132/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2362
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6294/
---
Rahul Kumar created CARBONDATA-2603:
---
Summary: if creation of one CarbonReader for non-transactional
table fails then we are not able to create new object of CarbonReader
Key: CARBONDATA-2603
URL: https://issue
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5131/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2363
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6293/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2363
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5254/
---
kumar vishal created CARBONDATA-2602:
Summary: Support Filter Query on Local dictionary generated columns
Key: CARBONDATA-2602
URL: https://issues.apache.org/jira/browse/CARBONDATA-2602
Project: Ca
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2252#discussion_r194350793
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java
---
@@ -30,21 +30,19 @@
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2367
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5130/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2367
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6292/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2367
SDV Build Success , Please check CI
http://144.76.159.231:8080/job/ApacheSDVTests/5253/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194334876
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -179,7 +179,11 @@ public CarbonReaderBuilder setEndPoi
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194324248
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -105,6 +115,243 @@ public void testWriteAndReadFiles() thr
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194323660
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -105,6 +115,243 @@ public void testWriteAndReadFiles(
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2363#discussion_r194323041
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -179,7 +179,11 @@ public CarbonReaderBuilder setE
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2366
@sandeep-katta Please handle the comments if its applicable to your
commit. Thanks.
---
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2366
@ravipesala @gvramana @chenliang613 .
Please review and merge as the builds are already passed.
---
Github user sujith71955 commented on the issue:
https://github.com/apache/carbondata/pull/2364
@ravipesala @gvramana @chenliang613 Please review and merge as the builds
are already passed.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2367
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5129/
---
63 matches
Mail list logo