[GitHub] carbondata pull request #2362: [CARBONDATA-2578] fixed memory leak inside Ca...

2018-06-11 Thread rahulforallp
Github user rahulforallp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2362#discussion_r193963265 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala ---

[GitHub] carbondata pull request #2362: [CARBONDATA-2578] fixed memory leak inside Ca...

2018-06-11 Thread rahulforallp
Github user rahulforallp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2362#discussion_r193962103 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -74,6 +74,8 @@ public boolean hasNext() throws IOExceptio

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2363 @ravipesala : please merge this fix to 1.4.0 branch also ---

[jira] [Resolved] (CARBONDATA-2591) SDK CarbonReader support filter

2018-06-11 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-2591. - Resolution: Fixed Fix Version/s: 1.4.1 > SDK CarbonReader support fil

[jira] [Resolved] (CARBONDATA-2569) Search mode throw exception but test case pass

2018-06-11 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-2569. - Resolution: Fixed Fix Version/s: 1.4.1 > Search mode throw exception

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2363 ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2363 LGTM ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2363 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5139/ ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2363 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6302/ ---

[jira] [Comment Edited] (CARBONDATA-2340) load数据超过32000byte

2018-06-11 Thread xuchuanyin (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509109#comment-16509109 ] xuchuanyin edited comment on CARBONDATA-2340 at 6/12/18 3:09 AM: -

[jira] [Commented] (CARBONDATA-2340) load数据超过32000byte

2018-06-11 Thread xuchuanyin (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509109#comment-16509109 ] xuchuanyin commented on CARBONDATA-2340: [~niaoshu] Hi, about 32000 characte

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194603907 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@ -56,7

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2363 retest this please ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2363 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5138/ ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2363 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6301/ ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2363 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5261/ ---

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194597446 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java --- @@ -30,21 +30,19 @@

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2363#discussion_r194595227 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -218,6 +222,40 @@ public static void updateTableI

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194479546 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@ -56

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2362 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5260/ ---

[GitHub] carbondata issue #2335: [CARBONDATA-2573] integrate carbonstore mv branch

2018-06-11 Thread eychih
Github user eychih commented on the issue: https://github.com/apache/carbondata/pull/2335 @ravipesala @jackylk It looks like the discussion become uninteresting and unproductive now. I just try to make some constructive comments. The comments I made in the previous discussions remai

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2362 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5259/ ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2362 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5137/ ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2362 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6300/ ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2362 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5258/ ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2362 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5257/ ---

[jira] [Resolved] (CARBONDATA-2573) Merge carbonstore branch to master

2018-06-11 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2573. -- Resolution: Fixed Fix Version/s: 1.4.1 > Merge carbonstore branch to master > -

[GitHub] carbondata pull request #2335: [CARBONDATA-2573] integrate carbonstore mv br...

2018-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2335 ---

[GitHub] carbondata issue #2335: [CARBONDATA-2573] integrate carbonstore mv branch

2018-06-11 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2335 LGTM ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2362 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5256/ ---

[GitHub] carbondata issue #2265: Added Performance Optimization for Presto by using M...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2265 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5134/ ---

[GitHub] carbondata issue #2265: Added Performance Optimization for Presto by using M...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2265 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6296/ ---

[GitHub] carbondata pull request #2357: [CARBONDATA-2569] Change the strategy of Sear...

2018-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2357 ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2362 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5135/ ---

[GitHub] carbondata issue #2357: [CARBONDATA-2569] Change the strategy of Search mode...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2357 LGTM ---

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2367 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5133/ ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2362 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6298/ ---

[GitHub] carbondata issue #2335: [CARBONDATA-2573] integrate carbonstore mv branch

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2335 @eychih The code added to rewrite with MV table is done outside so there would not be any harm to the purpose of MV. And moreover checking the sameresult multiple times gives performance prob

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2367 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6295/ ---

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2363#discussion_r194382421 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -218,6 +222,40 @@ public static void updateTab

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2362 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5255/ ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2363 LGTM. This fix need to merge to both master and 1.4 branch ---

[GitHub] carbondata issue #2265: Added Performance Optimization for Presto by using M...

2018-06-11 Thread bhavya411
Github user bhavya411 commented on the issue: https://github.com/apache/carbondata/pull/2265 retest this please ---

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2367 retest this please ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2362 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5132/ ---

[GitHub] carbondata issue #2362: [CARBONDATA-2578] fixed memory leak inside CarbonRea...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2362 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6294/ ---

[jira] [Created] (CARBONDATA-2603) if creation of one CarbonReader for non-transactional table fails then we are not able to create new object of CarbonReader

2018-06-11 Thread Rahul Kumar (JIRA)
Rahul Kumar created CARBONDATA-2603: --- Summary: if creation of one CarbonReader for non-transactional table fails then we are not able to create new object of CarbonReader Key: CARBONDATA-2603 URL: https://issue

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2363 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5131/ ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2363 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6293/ ---

[GitHub] carbondata issue #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReader filte...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2363 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5254/ ---

[jira] [Created] (CARBONDATA-2602) Support Filter Query on Local dictionary generated columns

2018-06-11 Thread kumar vishal (JIRA)
kumar vishal created CARBONDATA-2602: Summary: Support Filter Query on Local dictionary generated columns Key: CARBONDATA-2602 URL: https://issues.apache.org/jira/browse/CARBONDATA-2602 Project: Ca

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194350793 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java --- @@ -30,21 +30,19 @@

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2367 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5130/ ---

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2367 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6292/ ---

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2367 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5253/ ---

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2363#discussion_r194334876 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -179,7 +179,11 @@ public CarbonReaderBuilder setEndPoi

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2363#discussion_r194324248 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -105,6 +115,243 @@ public void testWriteAndReadFiles() thr

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2363#discussion_r194323660 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -105,6 +115,243 @@ public void testWriteAndReadFiles(

[GitHub] carbondata pull request #2363: [HOTFIX][CARBONDATA-2591] Fix SDK CarbonReade...

2018-06-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2363#discussion_r194323041 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -179,7 +179,11 @@ public CarbonReaderBuilder setE

[GitHub] carbondata issue #2366: [CARBONDATA-2532][Integration] Carbon to support spa...

2018-06-11 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/carbondata/pull/2366 @sandeep-katta Please handle the comments if its applicable to your commit. Thanks. ---

[GitHub] carbondata issue #2366: [CARBONDATA-2532][Integration] Carbon to support spa...

2018-06-11 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/carbondata/pull/2366 @ravipesala @gvramana @chenliang613 . Please review and merge as the builds are already passed. ---

[GitHub] carbondata issue #2364: [CARBONDATA-2592][Integration] Getting NoSuchMethod ...

2018-06-11 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/carbondata/pull/2364 @ravipesala @gvramana @chenliang613 Please review and merge as the builds are already passed. ---

[GitHub] carbondata issue #2367: [CARBONDATA-2601] Support column with varchar type i...

2018-06-11 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2367 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5129/ ---