[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194603907 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@ -56,7

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194597446 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java --- @@ -30,21 +30,19 @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194479546 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-06-11 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r194350793 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java --- @@ -30,21 +30,19 @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-23 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190222169 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java --- @@ -369,6 +379,9 @@ public void fillDataChunks()

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-23 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190220126 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -849,7 +852,41 @@ public int

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-23 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190161224 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java --- @@ -32,13 +32,14 @@ * by

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-23 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190160809 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -849,7 +852,41 @@ public int

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-23 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190150092 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java ---

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190104281 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java --- @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190104257 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java --- @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190103945 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java --- @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190103851 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java --- @@

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r190103691 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java --- @@ -92,8 +93,10 @@ public

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r189912968 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java ---

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r189913075 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java ---

[GitHub] carbondata pull request #2252: [CARBONDATA-2420] Support string longer than ...

2018-05-22 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2252#discussion_r189911364 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java --- @@ -92,8 +93,10 @@ public