[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/621/ ---

[GitHub] carbondata issue #2733: [CARBONDATA-2818] Upgrade presto integration version...

2018-09-28 Thread sraghunandan
Github user sraghunandan commented on the issue: https://github.com/apache/carbondata/pull/2733 LGTM ---

[GitHub] carbondata pull request #2738: [CARBONDATA-2952] Provide c++ interface for S...

2018-09-28 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2738#discussion_r221149564 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -90,6 +91,33 @@ public T readNextRow() throws

[GitHub] carbondata pull request #2733: [CARBONDATA-2818] Upgrade presto integration ...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2733 ---

[jira] [Created] (CARBONDATA-2983) Change bloom query model to proceed multiple filter values

2018-09-28 Thread jiangmanhua (JIRA)
jiangmanhua created CARBONDATA-2983: --- Summary: Change bloom query model to proceed multiple filter values Key: CARBONDATA-2983 URL: https://issues.apache.org/jira/browse/CARBONDATA-2983 Project:

[GitHub] carbondata pull request #2738: [CARBONDATA-2952] Provide c++ interface for S...

2018-09-28 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2738#discussion_r221153398 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -90,6 +91,33 @@ public T readNextRow() throws IOException,

[GitHub] carbondata pull request #2781: [CARBONDATA-2983][BloomDataMap] Change bloom ...

2018-09-28 Thread kevinjmh
GitHub user kevinjmh opened a pull request: https://github.com/apache/carbondata/pull/2781 [CARBONDATA-2983][BloomDataMap] Change bloom query model to proceed multiple filter values currently, bloom generates multiple query model for each value of InExpression. This PR changes

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2789 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/840/ ---

[GitHub] carbondata issue #2779: [CARBONDATA-2989] Upgrade spark integration version ...

2018-09-28 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/2779 @sujith71955 @chenliang613 @ravipesala @jackylk this pr is ready, please review, thanks. ---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2783 @ravipesala @kumarvishal09 We have encountered JVM crash problem. The dump file complains

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/813/ ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2781 This PR is supposed to optimize the pruning for InExpression. For a expression like colA in (1, 2, 3). Previously it will create 3 bloom query model and for each query model it will

[GitHub] carbondata issue #2774: [CARBONDATA-2979] select count fails when carbondata...

2018-09-28 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2774 LGTM ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2782 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/625/ ---

[GitHub] carbondata issue #2773: [CARBONDATA-2978] Fixed JVM crash issue when insert ...

2018-09-28 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2773 retest this please ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2782 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8886/ ---

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2780 retest this please ---

[GitHub] carbondata pull request #2781: [CARBONDATA-2983][BloomDataMap] Change bloom ...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2781#discussion_r221177988 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -194,16 +186,25 @@ private String

[GitHub] carbondata pull request #2782: [CARBONDATA-2984][Streaming] Fix NPE when the...

2018-09-28 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/carbondata/pull/2782 [CARBONDATA-2984][Streaming] Fix NPE when there is no data in the task of a batch Fix NPE when there is no data in the task of a batch - [x] Any interfaces changed? no -

[GitHub] carbondata issue #2665: [CARBONDATA-2897][DataMap] Assign to datamap only fo...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2665 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/816/ ---

[GitHub] carbondata issue #2665: [CARBONDATA-2897][DataMap] Assign to datamap only fo...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2665 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8885/ ---

[GitHub] carbondata issue #2665: [CARBONDATA-2897][DataMap] Assign to datamap only fo...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2665 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/624/ ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2782 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/817/ ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8882/ ---

[GitHub] carbondata issue #2767: [CARBONDATA-2974] Fixed multiple expressions issue o...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2767 After discussed with @kevinjmh offline, we agreed that this PR fixed the problem as far as we considered. So I will merge this PR. ---

[GitHub] carbondata issue #2767: [CARBONDATA-2974] Fixed multiple expressions issue o...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2767 LGTM ---

[GitHub] carbondata pull request #2781: [CARBONDATA-2983][BloomDataMap] Change bloom ...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2781#discussion_r221178600 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -194,16 +186,25 @@ private String

[GitHub] carbondata pull request #2670: [CARBONDATA-2917] Support binary datatype

2018-09-28 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/carbondata/pull/2670 ---

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2780 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/623/ ---

[jira] [Created] (CARBONDATA-2984) streaming throw NPE when there is no data in the task of a batch

2018-09-28 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-2984: Summary: streaming throw NPE when there is no data in the task of a batch Key: CARBONDATA-2984 URL: https://issues.apache.org/jira/browse/CARBONDATA-2984 Project:

[GitHub] carbondata issue #2665: [CARBONDATA-2897][DataMap] Assign to datamap only fo...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2665 @kevinjmh I accepted another PR #2767 which also intends to fix this problem. You can close this PR now. Thanks for your working all the same! ---

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2780 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8884/ ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/818/ ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/622/ ---

[jira] [Resolved] (CARBONDATA-2974) Bloomfilter not working when created bloom on multiple columns and queried

2018-09-28 Thread xuchuanyin (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuchuanyin resolved CARBONDATA-2974. Resolution: Fixed Fix Version/s: 1.5.0 > Bloomfilter not working when created

[GitHub] carbondata pull request #2767: [CARBONDATA-2974] Fixed multiple expressions ...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2767 ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/626/ ---

[jira] [Assigned] (CARBONDATA-2985) Fix issues in Table level compaction and TableProperties

2018-09-28 Thread Indhumathi Muthumurugesh (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Indhumathi Muthumurugesh reassigned CARBONDATA-2985: Assignee: (was: Indhumathi Muthumurugesh) > Fix

[jira] [Created] (CARBONDATA-2987) Data mismatch after compaction with measure sort columns

2018-09-28 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-2987: Summary: Data mismatch after compaction with measure sort columns Key: CARBONDATA-2987 URL: https://issues.apache.org/jira/browse/CARBONDATA-2987 Project:

[GitHub] carbondata issue #2784: [CARBONDATA-2987] Data mismatch after compaction wit...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2784 @jackylk : No this issue introduce only in this version (1.5) after adaptive encoding of primitive type changes. Previously column page wrapper was only for complex columns, this

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/631/ ---

[GitHub] carbondata issue #2770: [CARBONDATA-2975] DefaultValue choosing and removeNu...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2770 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/632/ ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/823/ ---

[GitHub] carbondata issue #2770: [CARBONDATA-2975] DefaultValue choosing and removeNu...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2770 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8893/ ---

[GitHub] carbondata issue #2770: [CARBONDATA-2975] DefaultValue choosing and removeNu...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2770 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/627/ ---

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2780 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/815/ ---

[GitHub] carbondata issue #2781: [CARBONDATA-2983][BloomDataMap] Change bloom query m...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2781 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8887/ ---

[GitHub] carbondata pull request #2775: [HOTFIX][Streaming] Avoid throwing NPE during...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2775 ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2782 the testcases in `TestStreamingTableOperation.scala` are tight independent with each other, I suggest you to refactor before adding more tests. ---

[GitHub] carbondata pull request #2787: [HOTFIX]fixed filter mismatch issue

2018-09-28 Thread kumarvishal09
GitHub user kumarvishal09 opened a pull request: https://github.com/apache/carbondata/pull/2787 [HOTFIX]fixed filter mismatch issue **Problem:** Between query is giving wrong result. **Root cause:** For timestamp time when filter is given in -mm-dd format instead of

[GitHub] carbondata issue #2786: [CARBONDATA-2967] Fixed NPE for preaggregate queries

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2786 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/633/ ---

[GitHub] carbondata issue #2770: [CARBONDATA-2975] DefaultValue choosing and removeNu...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2770 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/826/ ---

[GitHub] carbondata issue #2788: [Documentation] Readme updated with latest topics an...

2018-09-28 Thread sgururajshetty
Github user sgururajshetty commented on the issue: https://github.com/apache/carbondata/pull/2788 @sraghunandan review ---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2783 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/635/ ---

[GitHub] carbondata issue #2786: [CARBONDATA-2967] Fixed NPE for preaggregate queries

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2786 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8894/ ---

[GitHub] carbondata pull request #2784: [CARBONDATA-2987] Data mismatch after compact...

2018-09-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2784#discussion_r221258211 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -302,8 +311,19 @@ public boolean

[GitHub] carbondata pull request #2786: [CARBONDATA-2967] Fixed NPE for preaggregate ...

2018-09-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2786#discussion_r221259855 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala --- @@ -80,6 +82,20 @@ case class

[GitHub] carbondata pull request #2786: [CARBONDATA-2967] Fixed NPE for preaggregate ...

2018-09-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2786#discussion_r221260295 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala --- @@ -80,6 +82,20 @@ case class

[GitHub] carbondata pull request #2784: [CARBONDATA-2987] Data mismatch after compact...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2784#discussion_r221261712 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -302,8 +311,19 @@ public boolean

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2783 @xuchuanyin I don't what is the purpose of doing this? Please elaborate problem in PR description. This variable is added to avoid JVM crash when freed multiple times. I am not getting

[GitHub] carbondata pull request #2783: [CARBONDATA-2988] use unsafe for query model ...

2018-09-28 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2783#discussion_r221266728 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java --- @@ -120,7 +121,7 @@ private boolean isFG;

[GitHub] carbondata issue #2785: [CARBONDATA-2986] Table Properties are lost when mul...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2785 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/829/ ---

[GitHub] carbondata issue #2773: [CARBONDATA-2978] Fixed JVM crash issue when insert ...

2018-09-28 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2773 LGTM ---

[jira] [Resolved] (CARBONDATA-2978) JVM crashes when data inserted from one table to other table with unsafe true

2018-09-28 Thread kumar vishal (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal resolved CARBONDATA-2978. -- Resolution: Fixed > JVM crashes when data inserted from one table to other table

[jira] [Assigned] (CARBONDATA-2978) JVM crashes when data inserted from one table to other table with unsafe true

2018-09-28 Thread kumar vishal (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal reassigned CARBONDATA-2978: Assignee: Ravindra Pesala (was: kumar vishal) > JVM crashes when data

[GitHub] carbondata issue #2785: [CARBONDATA-2986] Table Properties are lost when mul...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2785 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/634/ ---

[GitHub] carbondata pull request #2788: [Documentation] Readme updated with latest to...

2018-09-28 Thread sgururajshetty
GitHub user sgururajshetty opened a pull request: https://github.com/apache/carbondata/pull/2788 [Documentation] Readme updated with latest topics and new TOC > Readme updated with the new structure > Formatting issue fixed > Review comments fixed You can merge this pull

[GitHub] carbondata pull request #2789: [HOTFIX] Fixed S3 metrics issue.

2018-09-28 Thread ravipesala
GitHub user ravipesala opened a pull request: https://github.com/apache/carbondata/pull/2789 [HOTFIX] Fixed S3 metrics issue. Problem: When data read from s3 it shows the data read as more than the size of carbon data total size. Reason: It happens because carbondata uses

[GitHub] carbondata pull request #2787: [HOTFIX] Fixed Between Query Data Mismatch is...

2018-09-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2787#discussion_r221258708 --- Diff:

[GitHub] carbondata issue #2770: [CARBONDATA-2975] DefaultValue choosing and removeNu...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2770 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/636/ ---

[GitHub] carbondata issue #2785: [CARBONDATA-2986] Table Properties are lost when mul...

2018-09-28 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2785 LGTM ---

[GitHub] carbondata issue #2779: [WIP] Upgrade spark integration version to 2.3.2

2018-09-28 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2779 @zzcclp Please check and fix the tests ---

[GitHub] carbondata issue #2779: [WIP] Upgrade spark integration version to 2.3.2

2018-09-28 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/2779 @ravipesala can you help me to check why these three test cases fail? It's about the decimal precision. ---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2783 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/830/ ---

[GitHub] carbondata pull request #2773: [CARBONDATA-2978] Fixed JVM crash issue when ...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2773 ---

[jira] [Assigned] (CARBONDATA-2978) JVM crashes when data inserted from one table to other table with unsafe true

2018-09-28 Thread kumar vishal (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal reassigned CARBONDATA-2978: Assignee: kumar vishal > JVM crashes when data inserted from one table to

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

2018-09-28 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2789 LGTM ---

[GitHub] carbondata issue #2790: [HOTFIX] carbon reader support open another reader w...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2790 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/839/ ---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2789 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/645/ ---

[GitHub] carbondata issue #2789: [HOTFIX] Fixed S3 metrics issue.

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2789 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8908/ ---

[GitHub] carbondata issue #2790: [HOTFIX] carbon reader support open another reader w...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2790 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8907/ ---

[GitHub] carbondata pull request #2768: [CARBONDATA-2594] Do not add InvertedIndex in...

2018-09-28 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2768#discussion_r221411345 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java --- @@ -224,7 +224,7 @@ private ColumnSchema

[GitHub] carbondata pull request #2790: [HOTFIX] carbon reader support open another r...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2790#discussion_r221411334 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -115,11 +115,13 @@ public CarbonReaderBuilder

[GitHub] carbondata pull request #2780: [CARBONDATA-2982] CarbonSchemaReader support ...

2018-09-28 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2780#discussion_r221411423 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1435,5 +1435,99 @@ public void

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2780 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/647/ ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2782 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/646/ ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2782 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8909/ ---

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2780 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/842/ ---

[GitHub] carbondata issue #2780: [CARBONDATA-2982] CarbonSchemaReader support array

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2780 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8910/ ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2782 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/841/ ---

[GitHub] carbondata issue #2790: [HOTFIX] carbon reader support open another reader w...

2018-09-28 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2790 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/648/ ---

[GitHub] carbondata issue #2782: [CARBONDATA-2984][Streaming] Fix NPE when there is n...

2018-09-28 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/2782 @xuchuanyin different test cases use different tables, they are independent. ---

[GitHub] carbondata issue #2778: [CARBONDATA-2980][BloomDataMap] Fix bug in clearing ...

2018-09-28 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2778 @manishgupta88 Oh, if it is so, then I think the interfaces of cache are confusing. Currently we use only one cache instance for all purpose like mainDataMap, bloomDataMap, dictionary, but

[GitHub] carbondata pull request #2779: [CARBONDATA-2989] Upgrade spark integration v...

2018-09-28 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2779#discussion_r221414692 --- Diff: integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala --- @@ -0,0 +1,55 @@ +/*

[GitHub] carbondata issue #2779: [CARBONDATA-2989] Upgrade spark integration version ...

2018-09-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2779 My comment : only for 4 parameters , copy the whole file(CarbonDataSourceScan.scala) for spark 2.3 integration, may not require. see if can add the judgement for different spark version

[GitHub] carbondata pull request #2790: [HOTFIX] carbon reader support open another r...

2018-09-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2790#discussion_r221415694 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -115,11 +115,13 @@ public CarbonReaderBuilder

[GitHub] carbondata issue #2778: [CARBONDATA-2980][BloomDataMap] Fix bug in clearing ...

2018-09-28 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2778 @xuchuanyin .`CarbonLRUCache` instance is one per JVM but cache implementation is different for different purpose like we have separate cache provider implementation for blockDataMap

[jira] [Assigned] (CARBONDATA-2989) Upgrade spark integration version to 2.3.2

2018-09-28 Thread Zhichao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhichao Zhang reassigned CARBONDATA-2989: -- Assignee: Zhichao Zhang > Upgrade spark integration version to 2.3.2 >

[jira] [Created] (CARBONDATA-2989) Upgrade spark integration version to 2.3.2

2018-09-28 Thread Zhichao Zhang (JIRA)
Zhichao Zhang created CARBONDATA-2989: -- Summary: Upgrade spark integration version to 2.3.2 Key: CARBONDATA-2989 URL: https://issues.apache.org/jira/browse/CARBONDATA-2989 Project: CarbonData

[GitHub] carbondata pull request #2790: [HOTFIX] carbon reader support open another r...

2018-09-28 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2790 [HOTFIX] carbon reader support open another reader without closing previous reader [HOTFIX] carbon reader support open another reader without closing previous reader

  1   2   >