[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r244678587 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1445,16 +1445,10 @@ private

[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r244678677 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -626,22 +626,29

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r244681720 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -156,4 +161,206 @@

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r244681963 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/DataSkewRangePartitioner.scala --- @@ -0,0 +1,319 @@ +/* + * Licensed to

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r244681813 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestGlobalSortDataLoad.scala --- @@ -106,6

[GitHub] carbondata pull request #3041: [CARBONDATA-3218] Fix schema refresh and wron...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3041#discussion_r244692501 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -134,23 +127,17 @@ */

[GitHub] carbondata issue #3044: [CARBONDATA-3149]Documentation for alter table colum...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3044 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2109/ ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2971 @QiangCai @jackylk Adding a `RANGE_COLUMN` at each load level does not create an issue? If user selects different range column for each load how you are going to compact when you support it

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-02 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/3045 [CARBONDATA-3222]Fix dataload failure after creation of preaggregate datamap on main table with long_string_columns This PR is to Fix dataload failure after creation of preaggregate

[GitHub] carbondata issue #3044: [CARBONDATA-3149]Documentation for alter table colum...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3044 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2314/ ---

[GitHub] carbondata issue #3044: [CARBONDATA-3149]Documentation for alter table colum...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3044 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10363/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10364/ ---

[GitHub] carbondata pull request #3044: [CARBONDATA-3202]Documentation for alter tabl...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244677596 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r244679013 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -626,22 +626,29

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r244680876 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -156,4 +161,206 @@

[jira] [Created] (CARBONDATA-3222) Fix dataload failure after creation of preaggregate datamap on main table with long_string_columns

2019-01-02 Thread Shardul Singh (JIRA)
Shardul Singh created CARBONDATA-3222: - Summary: Fix dataload failure after creation of preaggregate datamap on main table with long_string_columns Key: CARBONDATA-3222 URL:

[GitHub] carbondata pull request #3041: [CARBONDATA-3218] Fix schema refresh and wron...

2019-01-02 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3041#discussion_r244686891 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -134,23 +127,17 @@ */

[GitHub] carbondata issue #3044: [CARBONDATA-3202]Documentation for alter table colum...

2019-01-02 Thread SteNicholas
Github user SteNicholas commented on the issue: https://github.com/apache/carbondata/pull/3044 @akashrn5 Yeah,for example ALTER TABLE [db_name.]table_name CHANGE old_col_name new_col_name column_data_type comment ' ' Spark 2.1 couldn't support column coment

[GitHub] carbondata issue #3044: [CARBONDATA-3202]Documentation for alter table colum...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3044 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10362/ ---

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r244681164 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -156,4 +161,206 @@

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

2019-01-02 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r244681062 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala --- @@ -95,6 +96,67 @@ object

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2110/ ---

[GitHub] carbondata pull request #3044: [CARBONDATA-3202]Documentation for alter tabl...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244676690 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2111/ ---

[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

2019-01-02 Thread chandrasaripaka
Github user chandrasaripaka commented on the issue: https://github.com/apache/carbondata/pull/3021 Thank you..let's use your pull request and close this...so that we can have a single.place to comment. ---

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10385/ ---

[GitHub] carbondata issue #3014: [CARBONDATA-3201] Added load level SORT_SCOPE

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3014 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2336/ ---

[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

2019-01-02 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/3021 I will check on it On Wed, 2 Jan 2019 at 10:37 PM, Chandrasekhar Saripaka < notificati...@github.com> wrote: > b0733ec >

[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

2019-01-02 Thread chandrasaripaka
Github user chandrasaripaka commented on the issue: https://github.com/apache/carbondata/pull/3021 We get error from a commit related to altertableschema.. which is not there in cloudera spark ---

[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

2019-01-02 Thread chandrasaripaka
Github user chandrasaripaka commented on the issue: https://github.com/apache/carbondata/pull/3021 https://github.com/apache/carbondata/commit/b0733ecbf380d7956dee57a9048dd7537620744e ---

[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

2019-01-02 Thread chandrasaripaka
Github user chandrasaripaka commented on the issue: https://github.com/apache/carbondata/pull/3021 This commit breaks the cloudera 2.2.0cloudera2 ---

[GitHub] carbondata issue #3014: [CARBONDATA-3201] Added load level SORT_SCOPE

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3014 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10384/ ---

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2337/ ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2132/ ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10386/ ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2338/ ---

[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-02 Thread kevinjmh
Github user kevinjmh commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2996#discussion_r244906592 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -165,15 +167,22

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2133/ ---

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244907282 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int localDictionaryThreshold) {

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

2019-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3031 ---

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3047 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2341/ ---

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3047 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10389/ ---

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244907183 --- Diff: store/CSDK/test/main.cpp --- @@ -853,7 +854,7 @@ int main(int argc, char *argv[]) { } else { int batch = 32000;

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244911752 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,21 @@ object CarbonStore {

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2339/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK validate the improper ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10388/ ---

[jira] [Resolved] (CARBONDATA-3212) Select * is failing with java.lang.NegativeArraySizeException in SDK flow

2019-01-02 Thread kumar vishal (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal resolved CARBONDATA-3212. -- Resolution: Fixed > Select * is failing with java.lang.NegativeArraySizeException

[GitHub] carbondata pull request #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-02 Thread kevinjmh
Github user kevinjmh commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2996#discussion_r244906489 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -165,15 +167,22

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10387/ ---

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244895354 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,21 @@ object CarbonStore {

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244907927 --- Diff: store/CSDK/test/main.cpp --- @@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc, char *argv[]) {

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3047 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2135/ ---

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/3031 @shivamasn Please update the PR details In Local Dictionary, page size was not getting updated for complex children columns. So during fallback, new page was being created with

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3031#discussion_r244914880 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java --- @@ -140,6 +140,7 @@ public boolean

[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3010 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2136/ ---

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/3031 LGTM ---

[jira] [Created] (CARBONDATA-3224) SDK should validate the improper value

2019-01-02 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3224: --- Summary: SDK should validate the improper value Key: CARBONDATA-3224 URL: https://issues.apache.org/jira/browse/CARBONDATA-3224 Project: CarbonData Issue

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK validate the im...

2019-01-02 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3048 [CARBONDATA-3224] Support SDK validate the improper value when using withLoadOptions 1. validate BAD_RECORDS_ACTION 2. validate BAD_RECORDS_LOGGER_ENABLE Be sure to do all of

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244908015 --- Diff: store/CSDK/test/main.cpp --- @@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int argc, char **argv) {

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK validate the improper ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2134/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK validate the improper ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2340/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK validate the improper ...

2019-01-02 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/3048 @xubo245 : why we are adding only for SDK ? It should be in a common place ? a) what is happening now, if I give invalid actions in bad record ? b) carbon session also this

[GitHub] carbondata issue #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3035 @KanakaKumar @ajantha-bhat @jackylk @ravipesala Please review it. ---

[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue

2019-01-02 Thread Shubh18s
Github user Shubh18s commented on the issue: https://github.com/apache/carbondata/pull/3010 retest this please ---

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244915526 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int localDictionaryThreshold) {

[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3010 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10390/ ---

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2137/ ---

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10391/ ---

[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...

2019-01-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244919178 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2343/ ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244921991 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -180,10 +180,10 @@ class

[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3010 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2342/ ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244923003 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataFileFooterConverterV3.java --- @@ -73,6 +73,11 @@ public DataFileFooter

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2138/ ---

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244920921 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -46,9 +47,9 @@ object CarbonStore {

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244922117 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,23 @@ object CarbonStore {

[GitHub] carbondata issue #3026: [CARBONDATA-3193] Added support to compile carbon CD...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3026 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2139/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2140/ ---

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-02 Thread kunal642
GitHub user kunal642 opened a pull request: https://github.com/apache/carbondata/pull/3046 [WIP] Added check to start fallback based on size Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r244708339 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java --- @@ -205,8 +205,10 @@ public

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r244708432 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -1491,6 +1491,16 @@ private void

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r244708172 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -2076,4 +2076,15 @@ private

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2320/ ---

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3031 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2322/ ---

[GitHub] carbondata issue #3031: [CARBONDATA-3212] Fixed NegativeArraySizeException w...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3031 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10371/ ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244721944 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java --- @@ -105,10 +105,15 @@ public

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2121/ ---

[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10374/ ---

[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2326/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2112/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2114/ ---

[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2116/ ---

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r244708667 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java --- @@ -128,16

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10365/ ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244712666 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/InMemorySortTempChunkHolder.java --- @@ -0,0 +1,109 @@

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244713354 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static

[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2119/ ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244714375 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java --- @@ -400,24 +417,53 @@ private static

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3029 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2120/ ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-02 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2971 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2327/ ---

  1   2   >