Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2830
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9270/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228042421
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -66,6 +66,14 @@ public abstract
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228042373
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -66,6 +66,14 @@ public abstract
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228041857
--- Diff: store/CSDK/main.cpp ---
@@ -21,6 +21,7 @@
#include
--- End diff --
Can we move this to test ? because this is not a
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228041948
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -176,7 +179,7 @@ private static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228041838
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -176,7 +179,7 @@ private static
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2830
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1004/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2829
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1002/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2852
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1001/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2816
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1003/
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228040809
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,208 @@ public boolean accept(File dir,
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228040609
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/RowUtil.java ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2830
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1217/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228040371
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoderMeta.java
---
@@ -49,6 +49,8 @@
// Make it
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228040196
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeDecimalColumnPage.java
---
@@ -193,6 +193,30 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228040088
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java
---
@@ -0,0 +1,278
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228039991
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java
---
@@ -0,0 +1,278
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228039614
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1845,6 +1845,18 @@
public static final
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228039418
--- Diff: docs/csdk-guide.md ---
@@ -68,20 +68,42 @@ JNIEnv *initJVM() {
bool readFromLocalWithoutProjection(JNIEnv *env) {
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228039285
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java
---
@@ -54,10 +75,15 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r228038986
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/MeasureRawColumnChunk.java
---
@@ -105,6 +106,22 @@ public ColumnPage
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1213/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9266/
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228034556
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1845,6 +1845,21 @@
public static final
GitHub user Indhumathi27 opened a pull request:
https://github.com/apache/carbondata/pull/2852
[WIP]Column Schema objects are present in Driver even after dropping table
**Problem:**
Column Schema objects are present in Driver even after dropping table.
**Solution:**
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2851
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9265/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2851
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1212/
---
Indhumathi Muthumurugesh created CARBONDATA-3042:
Summary: Column Schema objects are present in Driver even after
dropping table
Key: CARBONDATA-3042
URL:
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228028896
--- Diff: README.md ---
@@ -61,6 +61,7 @@ CarbonData is built using Apache Maven, to [build
CarbonData](https://github.com
* [CarbonData
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228028346
--- Diff: store/CSDK/main.cpp ---
@@ -21,6 +21,8 @@
#include
#include
#include "CarbonReader.h"
+#include "CarbonRow.h"
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2851
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/999/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1000/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228026273
--- Diff: store/CSDK/CMakeLists.txt ---
@@ -1,17 +1,17 @@
-cmake_minimum_required (VERSION 2.8)
-project (CJDK)
[
https://issues.apache.org/jira/browse/CARBONDATA-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiangmanhua updated CARBONDATA-3040:
Summary: Fix bug for merging bloom index (was: Add checking before merging
bloom
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228025690
--- Diff: store/CSDK/main.cpp ---
@@ -21,6 +21,8 @@
#include
#include
#include "CarbonReader.h"
+#include "CarbonRow.h"
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228025597
--- Diff: store/CSDK/CarbonReader.cpp ---
@@ -17,6 +17,7 @@
#include "CarbonReader.h"
#include
+#include
--- End diff --
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228025429
--- Diff: store/CSDK/CMakeLists.txt ---
@@ -1,17 +1,17 @@
-cmake_minimum_required (VERSION 2.8)
-project (CJDK)
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r228024318
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/iterator/ChunkRowIterator.java
---
@@ -74,4 +76,13 @@ public
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2792
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9264/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1211/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2850
emm, but in your implementation, most of the work has to be done by the
user (multi-thread handling). CarbonData itself only split the input data and
return multiple readers. If this is the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2851#discussion_r228010573
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/events/DataMapEvents.scala
---
@@ -60,7 +60,8 @@ case class
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2851#discussion_r228010750
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomIndexFileStore.java
---
@@ -70,27 +73,37 @@ public boolean
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2851#discussion_r228009613
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -48,8 +48,14 @@ class
wangsen created CARBONDATA-3041:
---
Summary: Provide a global parameter to specify the minimum amount
of data loaded by a node
Key: CARBONDATA-3041
URL: https://issues.apache.org/jira/browse/CARBONDATA-3041
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/998/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228010100
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,204 @@ public boolean accept(File dir,
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228009608
--- Diff: docs/csdk-guide.md ---
@@ -68,20 +68,42 @@ JNIEnv *initJVM() {
bool readFromLocalWithoutProjection(JNIEnv *env) {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228009633
--- Diff: docs/csdk-guide.md ---
@@ -106,20 +128,41 @@ bool readFromS3(JNIEnv *env, char *argv[]) {
// "your endPoint"
args[2] =
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228009906
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,204 @@ public boolean accept(File dir,
Github user kevinjmh commented on the issue:
https://github.com/apache/carbondata/pull/2851
description updated
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2814
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9263/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2814
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1210/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2814
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/997/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2846
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1208/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9262/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1209/
---
Github user kumarvishal09 closed the pull request at:
https://github.com/apache/carbondata/pull/2815
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2815
Closing this PR as handled as part of #2819 and One more PR will be raised
based on #2819 Interface
---
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2792
LGTM apart from those nits in guide & ut.
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227839509
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,204 @@ public boolean accept(File dir,
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227839131
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1522,4 +1522,204 @@ public boolean accept(File dir,
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227836644
--- Diff: docs/csdk-guide.md ---
@@ -106,20 +128,41 @@ bool readFromS3(JNIEnv *env, char *argv[]) {
// "your endPoint"
args[2] =
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227836440
--- Diff: docs/csdk-guide.md ---
@@ -68,20 +68,42 @@ JNIEnv *initJVM() {
bool readFromLocalWithoutProjection(JNIEnv *env) {
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2847
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9260/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2847
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1207/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2792
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/996/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-3034.
--
Resolution: Fixed
> Combing CarbonCommonConstants
> -
>
>
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2843
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2843
LGTM
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227807282
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -93,32 +92,10 @@ public T readNextRow() throws IOException,
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227798659
--- Diff: store/CSDK/CarbonRow.cpp ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2846
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/995/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2847
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/994/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2851
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9258/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2851
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1205/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2846
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9261/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2846
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/993/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2851
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/992/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2846
Build Failed with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9259/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2851
Another related question: What will happen if we create multiple datamaps
concurrently for the same table?
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2851
please add description about why adding datamap name will solve the problem
in the analyze part of your PR description
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2848
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2848
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9257/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiangmanhua updated CARBONDATA-3040:
Summary: Add checking before merging bloom index (was: Add folder check
before
GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2851
[CARBONDATA-3040][BloomDataMap] Add checking before merging bloom index
*Scene*
There is a bug which causes query failure when we create two bloom datamaps
on same table with data.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2848
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1204/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2814
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9255/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2818
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1201/
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r227741794
--- Diff: store/CSDK/CarbonRow.cpp ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2848
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/991/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2818
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9254/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2814
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1202/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2843
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1200/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2843
Build Success with Spark 2.3.1, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/9253/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2814
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/989/
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2848#discussion_r227731562
--- Diff:
Github user manishnalla1994 commented on the issue:
https://github.com/apache/carbondata/pull/2848
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2818
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/988/
---
1 - 100 of 150 matches
Mail list logo
