Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2819#discussion_r228038986
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/MeasureRawColumnChunk.java
 ---
    @@ -105,6 +106,22 @@ public ColumnPage convertToColumnPageWithOutCache(int 
index) {
         }
       }
     
    +  /**
    +   * Convert raw data with specified page number processed to 
DimensionColumnDataChunk and fill the
    +   * vector
    +   *
    +   * @param pageNumber page number to decode and fill the vector
    +   * @param vectorInfo vector to be filled with column page
    +   */
    +  public void convertToColumnPageAndFillVector(int pageNumber, 
ColumnVectorInfo vectorInfo) {
    +    assert pageNumber < pagesCount;
    +    try {
    +      chunkReader.decodeColumnPageAndFillVector(this, pageNumber, 
vectorInfo);
    +    } catch (IOException | MemoryException e) {
    +      throw new RuntimeException(e);
    --- End diff --
    
    Because those are checked exceptions, need to handle and throw the same 
exceptions till callers


---

Reply via email to