Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2819#discussion_r228039614
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
    @@ -1845,6 +1845,18 @@
       public static final int CARBON_MINMAX_ALLOWED_BYTE_COUNT_MIN = 10;
       public static final int CARBON_MINMAX_ALLOWED_BYTE_COUNT_MAX = 1000;
     
    +  /**
    +   * When enabled complete row filters will be handled by carbon in case 
of vector.
    +   * If it is disabled then only page level pruning will be done by carbon 
and row level filtering
    +   * will be done by spark for vector.
    +   * There is no change in flow for non-vector based queries.
    --- End diff --
    
    will make it as false by default in other pending PR. Since this PR is 
focused only on full scan many tests fail that's why it defaults it to true. 


---

Reply via email to