Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2583
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2565
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2574
@xuchuanyin ...It is better that we should go with PR #2565 as it contains
the proper code which handles the bugs.
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2574#discussion_r205948912
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
---
@@ -542,48 +551,48 @@ protected void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2574#discussion_r205948964
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -223,17 +222,15 @@ protected short
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2517#discussion_r205748318
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -724,6 +724,7 @@ public void
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2560
@ravipesala ...handled review comments...kindly review and merge
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2560#discussion_r205677203
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -81,6 +82,8 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2565#discussion_r205676555
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -165,9 +180,11 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2560#discussion_r205436561
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -81,6 +82,8 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2546#discussion_r205409053
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2441#discussion_r205388461
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -647,6 +648,11 @@ private int
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2548
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2560
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2560
[HOTFIX] Removed file existence check to improve dataMap loading performance
**Problem**
DataMap loading performance degraded after adding file existence check.
**Analysis
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2558
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2558#discussion_r205102509
--- Diff: docs/data-management-on-carbondata.md ---
@@ -141,7 +141,103 @@ This tutorial is going to introduce all commands and
data operations
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2550
LGTM...can be merged once build passes
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2550
@kumarvishal09 ...Please rebase
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2548
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2530
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2550#discussion_r204981714
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -239,36 +249,34 @@ private void
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2548
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2540
@ravipesala ...handled review comments..please review and merge
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2540#discussion_r204682071
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
---
@@ -221,7 +223,30 @@ public void
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2534
LGTM
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2540
[WIP] Handled executor min/max pruning when filter column in not cached in
driver for CACHE_LEVEL=BLOCKLET
Things handled as part of this PR:
1. Modified code to use min/max
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2534#discussion_r204287054
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -597,7 +597,14 @@ public SegmentFile getSegmentFile
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2534#discussion_r204287026
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -597,7 +597,14 @@ public SegmentFile getSegmentFile
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2503
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r204272253
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3235,4 +3235,17 @@ public boolean accept(CarbonFile file
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r204202741
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3235,4 +3235,17 @@ public boolean accept(CarbonFile file
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2518
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2531#discussion_r204000404
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
---
@@ -237,6 +241,32 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2525#discussion_r203991119
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
---
@@ -375,7 +381,15 @@ public
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2503
@ravipesala ...I got your point that we should always take the path
relative to tablePath.
But problem with using CarbonTablePath.getShortBlockIdForPartitionTable is
even in case
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2531
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2531
[HOTFIX] Improved BlockDataMap caching performance during first time query
Things done as part of this PR
1. Created taskSumamry and FileFooterEntry schema once and stored in member
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2503
@ravipesala ...Please correct me if my understanding is not correct.
SegmentFileName != null check was introduced at the time when partition
feature was developed to distinguish
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2515
[CARBONDATA-2714][Merge Index] Fixed block dataMap cache refresh issue
after creation of merge index file
Things handled as part of this PR
1. Fixed block dataMap cache refresh issue
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2488#discussion_r202607656
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3231,4 +3231,42 @@ private static int
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2510
[WIP] [CARBONDATA-2649] Fixed arrayIndexOutOfBoundException while loading
Blocklet DataMap after alter add column operation
Things done as part of this PR
1. Fixed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2507#discussion_r202576343
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
---
@@ -709,6 +709,22
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2462
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2307
LGTM...can be merged once build passes
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2499#discussion_r202278145
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/TableBlockIndexUniqueIdentifierWrapper.java
---
@@ -35,18 +35,34
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2307#discussion_r202251585
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -1085,11 +1085,11 @@ public static Long
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2462#discussion_r202229400
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2462#discussion_r202229386
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2462#discussion_r202229089
--- Diff:
core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java
---
@@ -155,7 +155,7 @@ private String
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2462#discussion_r202229032
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -304,10 +304,15 @@ public static boolean
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2307
@dhatchayani ...I have few doubts
1. Why UUID is optional here? I can see from some methods it is passed as
null and then System.currentTime is used as UUID
2. Please update
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2499
[CARBONDATA-2648] Fixed NPE issue with legacy store when CACHE_LEVEL is
Blocklet
Things done as part of this PR:
1. Fixed Null pointer exception when store is of <= 1.1 vers
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2467
@kumarvishal09 ...handled review comments...kindly review and merge
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2454
@kumarvishal09 ..As discussed with you I have handled these comments as
part of PR https://github.com/apache/carbondata/pull/2467
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2467
[WIP] [CARBONDATA-2649] Add code for caching min/max only for specified
columns
Things done as part of this PR
1. Supported configuring column for caching min/max in driver
2
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2449
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2437
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2454
[WIP] [CARBONDATA-2701] Refactor code to store minimal required info in
Block and Blocklet Cache
Things done as part of this PR
1. Refactored code to keep only minimal information
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2437
@ravipesala ..handled review comments. Kindly review and merge
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2426
[WIP] Fix cache level display in describe formatted command
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2418#discussion_r198542124
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -1165,4 +1165,30 @@ private static void
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2418
[WIP] [CARBONDATA-2647] [CARBONDATA-2648] Add support for COLUMN_META_CACHE
and CACHE_LEVEL in create table and alter table properties
Things done as part of this PR
1. Support
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2389
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2387
LGTM...can be merged once build passes
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2389#discussion_r197027345
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -128,7
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2389#discussion_r197019345
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/events/DataMapEvents.scala
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2389#discussion_r197019227
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
---
@@ -272,6 +284,13 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2387#discussion_r197015265
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapSuite.scala
---
@@ -37,6 +39,11 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2387#discussion_r197010690
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1530,6 +1531,22 @@ public String
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2385
LGTM...can be merged once build passes
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2369
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2358
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2333
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2344
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2344#discussion_r191122822
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -892,7 +894,22 @@ public boolean
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2332
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2332#discussion_r190128821
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2382,6 +2382,7 @@ static DataType
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2326#discussion_r189787853
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -488,6 +491,8 @@ private void buildTableSchema
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2326#discussion_r189787603
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -406,8 +406,9 @@ private CarbonTable
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2326#discussion_r189787714
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -431,18 +432,20 @@ private void
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2033
@kunal642 ...If IDG is not updated then raise a jira for IDG updation and
tracking
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2033
LGTM
---
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/2060
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2060
Need some more work for proper optimization. Therefore closing as of now
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2322#discussion_r189495300
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java ---
@@ -67,7 +76,22 @@
List indexInfo
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2294#discussion_r187343421
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -114,12 +115,12 @@ public void
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2294
[CARBONDATA-2443][SDK] Multi level complex type support for AVRO based SDK
**Problem:**
Problem inferring the complex type schema with boolean array type from the
store created using
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2286#discussion_r187274823
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -98,14 +99,31
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2286#discussion_r187247243
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -51,10 +57,16
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2286#discussion_r187242849
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/iterator/CarbonOutputIteratorWrapper.java
---
@@ -51,10 +57,16
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2286
[CARBONDATA-2417] [SDK Writer] SDK writer goes to infinite wait when
consumer thread goes dead
Problem:
SDK Writer going into infinte loop in case of multi-threaded scenario
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2277
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2277#discussion_r186371022
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -756,13 +756,19
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2277#discussion_r186369217
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala
---
@@ -166,7 +166,8 @@ case class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2263
LGTM
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2267
[CARBONDATA-2433] [Lucene GC Issue] Executor OOM because of GC when
blocklet pruning is done using Lucene datamap
**Problem**
Executor OOM because of GC when blocklet pruning is done
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2243
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2225
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2244#discussion_r185484269
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java ---
@@ -0,0 +1,198 @@
+/*
+ * Licensed
301 - 400 of 771 matches
Mail list logo
