Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1437#discussion_r147354409
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -287,7 +288,8 @@ abstract class
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1650#discussion_r158826285
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/ExpressionWithNullTestCase.scala
---
@@ -75,6
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1650#discussion_r158827952
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
---
@@ -78,13 +78,25 @@ object CarbonFilters
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1650#discussion_r158826908
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/ExpressionWithNullTestCase.scala
---
@@ -75,6
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1650#discussion_r158826141
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
---
@@ -78,13 +78,25 @@ object CarbonFilters
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/1763
[CARBONDATA-1984] Double Compression Codec Rectification.
Double datatype compression done through AdaptiveFloatingDelta
AdaptiveFloating codec is not returning expected output. These two
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1751
retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1751
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161963305
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -25,6 +25,8 @@
Object
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1751
Retest this please.
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r162289956
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanFiterExecuterImpl.java
---
@@ -153,13 +158,17
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r162289924
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java
---
@@ -520,7 +522,19 @@ public static String readCurrentTime
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r162290027
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtrThanEquaToFilterExecuterImpl.java
---
@@ -149,13 +154,17
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r162289986
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanEqualFilterExecuterImpl.java
---
@@ -150,14 +155,17
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r162290297
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -196,6 +201,10 @@ private DataMapRowImpl
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1751
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431619
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -45,6 +45,7 @@ struct BlockletBTreeIndex{
struct BlockletMinMaxIndex{
1
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161430749
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -25,6 +25,8 @@
Object
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431568
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
---
@@ -62,9 +62,9 @@ object CarbonSessionExample
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431581
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ExampleUtils.scala
---
@@ -39,8 +39,8 @@ object ExampleUtils {
val
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431169
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -728,9 +746,9 @@ private DataMapRow
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431217
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNodeWrapper.java
---
@@ -99,6 +99,10 @@ public
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431317
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ImplicitColumnFilterExecutor.java
---
@@ -34,7 +34,7 @@
* @return
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431299
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ImplicitColumnFilterExecutor.java
---
@@ -43,5 +43,6 @@ BitSet
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431288
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/FilterExecuter.java
---
@@ -46,7 +46,7 @@ boolean applyFilter(RowIntf
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r161431335
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/TablePageStatistics.java
---
@@ -71,6 +82,10 @@ private void
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/1977
[CARBONDATA-2181] Thread Leak during compaction processing on restructured
table
Thread Leak during compaction processing on restructured table. The
executor service which is being
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/1995
[WIP] File Format Reader
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/1751
[WIP]Measure null
Recognise Null values in blocklets so that it can help in filter prunning.
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1751
Retest this please.
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1751
Retest this please.
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1650
LGTM
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1692#discussion_r158455641
--- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala ---
@@ -20,6 +20,7 @@ package org.apache.spark.sql.hive
import
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1692#discussion_r158457326
--- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala ---
@@ -121,6 +123,19 @@ class CarbonSessionCatalog
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1692#discussion_r158457994
--- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala ---
@@ -121,6 +123,19 @@ class CarbonSessionCatalog
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1686#discussion_r158312372
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/util/DictionaryLRUCacheTestCase.scala
---
@@ -0,0 +1,424
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1686#discussion_r158312303
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ExampleUtils.scala
---
@@ -43,6 +43,8 @@ object ExampleUtils
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/1686
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1686#discussion_r158312327
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/util/DictionaryLRUCacheTestCase.scala
---
@@ -0,0 +1,424
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1686#discussion_r158312477
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/util/DictionaryLRUCacheTestCase.scala
---
@@ -0,0 +1,424
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1763#discussion_r159649771
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
---
@@ -1154,4
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2516
Retest this please.
---
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/2516
[WIP][Complex DataType Enhancements] Complex compaction
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user sounakr closed the pull request at:
https://github.com/apache/carbondata/pull/2417
---
GitHub user sounakr reopened a pull request:
https://github.com/apache/carbondata/pull/2417
[WIP][Complex Column Enhancements]Primitive DataType Adaptive Encoding
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2417
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2417
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2417
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201221334
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector(int
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201241294
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector(int
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201243892
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector(int
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201242475
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -359,38 +412,36 @@ public void freeMemory
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201244026
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201277468
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201225430
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201225285
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ComplexColumnPage.java
---
@@ -63,25 +66,42 @@ public ComplexColumnPage(List
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201226314
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201226564
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201226831
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java
---
@@ -93,9 +93,9 @@ public PrimitiveQueryType
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201229878
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java
---
@@ -870,4 +873,23 @@ private static void
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201233403
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201197596
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector(int
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201197871
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector(int
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201199734
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201199788
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -141,7 +141,7 @@ private static ColumnPage
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201198855
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector(int
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2417
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2417
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r201073104
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -17,32 +17,39 @@
package
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/2054
[CARBONDATA-2224][File Level Reader Support] External File level reader
support
File level reader reads any carbondata file placed in any external file
path. The reading can be done through 3
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2055
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2055
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2055
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2131
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2131
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2131#discussion_r179098290
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonCountStar.scala ---
@@ -76,6 +76,11 @@ case class CarbonCountStar
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2131#discussion_r179148873
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java
---
@@ -47,6 +47,13 @@
private
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/2177
[WIP][Unmanaged Table] Insert into Unmanaged Table
Insert into Unmanaged Table.
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2179
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183204286
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
---
@@ -381,8 +381,10 @@ class
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183204294
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -144,12 +144,12 @@
private boolean
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183204296
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -144,12 +144,12 @@
private boolean
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183204292
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
---
@@ -425,9 +427,11 @@ class
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2177
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2177
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2177
Retest this please
---
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2179
Retest this please
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069890
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -36,9 +39,23 @@
private String segmentFileName
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069772
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069834
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069718
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -36,9 +39,23 @@
private String segmentFileName
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2179
Retest this please.
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183074326
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -169,8 +169,28 @@ public static boolean
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2221#discussion_r184027161
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderExample.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2226#discussion_r184033067
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/sdk/SDkWriteS3Example.scala
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/2209
[WIP][Non Transactional Table]Avro Record Complex Type Implementation
Avro Complex DataType Support.
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/2214
[CARBONDATA-2387]Primitive AVRO Datatype Checking
Test case added to check all the primitive datatype support of AVRO and its
corresponding mapping with carbon datatypes.
Supported
GitHub user sounakr opened a pull request:
https://github.com/apache/carbondata/pull/2179
[WIP] Refactoring ReadCommittedStatus
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2131#discussion_r178594069
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -79,26 +80,27 @@
*
* @param segments
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2131#discussion_r178732017
--- Diff:
core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommitted.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed
301 - 400 of 415 matches
Mail list logo
