[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2605 ---

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r208186221 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala --- @@ -641,6 +641,78 @@ object

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-07 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r208157571 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,11 @@ */ public static

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r208123110 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,11 @@ */ public static

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-07 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r208117498 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,11 @@ */ public static

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r208111973 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,11 @@ */ public static

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207284617 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,17 @@ */ public static

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207282883 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala --- @@ -378,19 +376,65 @@

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207280921 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -306,9 +306,12 @@ abstract class

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207280558 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -2987,8 +2987,12 @@ public static void

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207278800 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,17 @@ */ public

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207277549 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala --- @@ -378,19 +376,65 @@

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread akashrn5
GitHub user akashrn5 opened a pull request: https://github.com/apache/carbondata/pull/2605 [CARBONDATA-2585] Fix local dictionary for both table level and system level property based on priority ### What are the changes Added a System level Property for local dictionary