Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3048
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245534079
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +181,8 @@ public CarbonWriterBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245532720
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +181,8 @@ public CarbonWriterBuilder
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245336706
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +182,8 @@ public CarbonWriterBuilder
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245328731
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +182,8 @@ public CarbonWriterBuilder
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245252822
--- Diff: store/CSDK/test/main.cpp ---
@@ -526,6 +526,71 @@ void testCarbonProperties(JNIEnv *env) {
}
}
+bool
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245246228
--- Diff: store/CSDK/test/main.cpp ---
@@ -526,6 +526,71 @@ void testCarbonProperties(JNIEnv *env) {
}
}
+bool
