Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/810#discussion_r112100462
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1185,6 +1185,8 @@
public
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/813
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/807#discussion_r111956659
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1087,6 +1087,10 @@
public
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/793
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/769
I will merge it later as we are preparing version 1.1 release, code is
freezed for master branch. Or you can create another PR to merge into 12-dev
branch. Thanks.
---
If your
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/720
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/775
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/737
please retest this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/709
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/659#discussion_r110810313
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/SegmentTaskIndexStore.java
---
@@ -338,14 +339,28 @@ private synchronized
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/737
please retest this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/769#discussion_r110798836
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonDataFrameWriter.scala
---
@@ -175,13 +175,17 @@ class
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/709
@ravipesala please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/767
please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/769
@sanoj-mg Can you refer to #737, I am doing similar thing for dataframe
writer in spark2 module
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/764
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/765#discussion_r110531875
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
---
@@ -504,3 +500,66 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/765#discussion_r110531816
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
---
@@ -504,3 +500,66 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/765#discussion_r110531763
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
---
@@ -504,3 +500,66 @@ class
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/767
Please describe the bug in JIRA or PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/767#discussion_r110531208
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/RowLevelRangeFilterResolverImpl.java
---
@@ -147,12 +148,16
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/767#discussion_r110531179
--- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java
---
@@ -540,7 +543,7 @@ public static int toInt(byte[] bytes, int
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/762
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/741
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/741
Are you merging the sort step and write step in this PR?
I think it is better to merge the row transform part from sort step into
write step only, and still have an independent sort
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/709#discussion_r109959692
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
---
@@ -171,11 +171,20 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/709#discussion_r109959185
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CompareTest.scala
---
@@ -306,6 +307,8 @@ object CompareTest
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/737
[WIP] Add no sort support in dataframe writer
User can specify Not to sort during loading, by adding an option in
dataframe.write
For example:
```
input.write
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/722
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815736
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/NoSortProcessorStepImpl.java
---
@@ -0,0 +1,123
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815428
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -490,8 +490,20 @@ abstract
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815295
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala
---
@@ -154,6
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815081
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
---
@@ -54,6 +54,8
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/722#discussion_r109814360
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/btree/BTreeDataRefNodeFinder.java
---
@@ -51,16 +51,15
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/715
This PR is actually merged into 12-dev which is branch for CarbonData 1.2
development. Master branch now is preparing for 1.1 release, so no new feature
will be merged into master
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/715
Can you add the on-going JIRA for this feature, in the CARBONDATA-782 JIRA
others LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/708
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/682
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/699
LGTM.
I will merge this now. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/695
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/702
[CARBONDATA-823] Refactory data write step
1. Remove redundant object creation
2. Simplify processDataRowsWithOutKettle method
You can merge this pull request into a Git
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/700
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/691
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/698
[CARBONDATA-820] Remove redundant creation
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/689
[CARBONDATA-812] make vectorized reader as default reader
change property for vectorized reader to true
You can merge this pull request into a Git repository by running:
$ git
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/620
I checked again, and it seems there is no new test case added for this
feature. Please add test case for it.
---
If your project is set up for it, you can reply to this email and have
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/658
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/666#discussion_r106629326
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -371,6 +307,79 @@ case class
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/666
LGTM except for adding comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/666#discussion_r106629310
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -371,6 +307,79 @@ case class
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/659
I checked recently merged PR641 for restructuring, it seems that this is
still used for maintaining metadata for each Segment, so it canât be changed
to TableProperties.
One
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/624#discussion_r106448892
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CompareTest.scala
---
@@ -0,0 +1,372 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/624#discussion_r106448866
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CompareTest.scala
---
@@ -0,0 +1,372 @@
+/*
+ * Licensed
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/664
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/663
Fix compilation for codegen
fix dictionary decode code gen compile error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/655
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/661#discussion_r106403716
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -599,11 +599,6 @@ case
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/620
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/624#discussion_r106400558
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CompareTest.scala
---
@@ -0,0 +1,343 @@
+/*
+ * Licensed
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/659
Earlier, this was used for handling restructure information. Now it is
handled in another way, so yes we should change it to reduce the number of
objects
---
If your project is set
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/624
I am afraid that 10Million record (around 200 MB) is too less, it will fit
in OS cache if I run all queries for one after another. Any suggestion on this?
Make more data?
---
If your
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
And I think it is easier to review and can be merged sooner if you could
break this PR down into smaller one. Just provide the very basic functionality
in the first round
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
Thanks for working on this. Can you describe what feature is added in term
of:
1. What SQL syntax is supported? DDL ?
2. I think it uses CarbonInputFormat to read, so are you
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/654#discussion_r105971368
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -507,12 +507,25 @@ public static String parseValue
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/654#discussion_r105970182
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -507,12 +507,25 @@ public static String parseValue
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105966957
--- Diff:
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataframe/Decimal_DataFrameTest.scala
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105968595
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
---
@@ -34,12 +34,37 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105968216
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/dataframe/Decimal_DataFrameTest.scala
---
@@ -0,0 +1,59
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105967718
--- Diff:
integration/spark/src/test/scala/org/apache/spark/sql/common/util/DataFrameUtils.scala
---
@@ -0,0 +1,43 @@
+package
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105967586
--- Diff:
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataframe/Decimal_DataFrameTest.scala
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105967226
--- Diff:
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataframe/Decimal_DataFrameTest.scala
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/653#discussion_r105920583
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -200,6 +201,123 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/653#discussion_r105921624
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -225,6 +343,25 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/653#discussion_r105921333
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -200,6 +201,123 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/653#discussion_r105921062
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -200,6 +201,123 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105909540
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java
---
@@ -52,10 +53,15
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105909192
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -352,9 +352,9 @@ public String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105906694
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105907908
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/SortProcessorStepImpl.java
---
@@ -74,7 +81,6 @@ public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105905090
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105895379
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105899292
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105898878
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105898572
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105898310
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105895986
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105896498
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105896311
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -0,0 +1,206
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105851374
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java
---
@@ -52,10 +53,15
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105842635
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -352,9 +352,9 @@ public String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105839493
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/CarbonUnsafe.java ---
@@ -34,6 +35,9 @@
public static final int
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105838661
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1149,6 +1149,19 @@
public
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/642
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/639
Please add a testcase to verify it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/632
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105579596
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CaseClassDataFrameAPIExample.scala
---
@@ -42,8 +45,25 @@ object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105578013
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105577915
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105576295
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23
1 - 100 of 528 matches
Mail list logo
