Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/606#discussion_r102372504
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/FileUtils.scala
---
@@ -91,4 +94,24 @@ object FileUtils
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102366409
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java
---
@@ -36,17 +36,76
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102363987
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -83,9 +81,12 @@ public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102363743
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -42,38 +38,40 @@
private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102363432
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKeyType.java
---
@@ -0,0 +1,38
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102363218
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java
---
@@ -16,12 +16,12
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102361729
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102360297
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102359538
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -16,57 +16,59
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102358957
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -86,7 +78,11 @@ public DictionaryKey
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102358591
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -44,7 +40,7 @@
private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/606#discussion_r102356794
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/FileUtils.scala
---
@@ -91,4 +94,24 @@ object FileUtils
Github user jackylk closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/600
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/447
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/580
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/585
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/601#discussion_r102114856
--- Diff: docs/ddl-operation-on-carbondata.md ---
@@ -220,13 +221,11 @@ of columns is used.
saleQuantity
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/604
Is there a testcase to reproduce this bug and verify this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/604#discussion_r102114630
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -255,77 +256,75 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/600#discussion_r102114090
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -141,6 +142,17 @@ class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/600#discussion_r102113919
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -141,6 +142,17 @@ class
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/573
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/582#discussion_r98597175
--- Diff: docs/dml-operation-on-carbondata.md ---
@@ -133,6 +133,25 @@ You can use the following options to load data:
NOTE: Date
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/582#discussion_r98597136
--- Diff: docs/dml-operation-on-carbondata.md ---
@@ -133,6 +133,25 @@ You can use the following options to load data:
NOTE: Date
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/581
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/578
@Vimal-Das Actually I am about to change the implementation for dictionary
client server to use netty4. I think it is better to wait for some time after
the new implementation PR is
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/577
[CARBONDATA-683] Reduce test time
Reduce test time by:
1. remove all unnecessary print
2. make sample csv file size smaller
3. change logger.audit to initialize strings in
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/575
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/576#discussion_r98163965
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/mdkey/NumberCompressor.java
---
@@ -137,12 +161,31 @@ public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98162981
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/CarbonLateDecodeStrategy.scala
---
@@ -484,12 +485,14 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98162769
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/CarbonLateDecodeStrategy.scala
---
@@ -484,12 +485,14 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98161894
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java
---
@@ -36,14 +39,37
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98158805
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java
---
@@ -36,14 +39,37
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/573
@QiangCai please check the added data.csv in this PR, I remember there is a
common data.csv for all test cases.
---
If your project is set up for it, you can reply to this email and
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/573
ok, goods fine to me. please rebase the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/573
@JihongMA Thanks for working on this, can you explain more about this PR,
why CSVReader is moved to processing module?
---
If your project is set up for it, you can reply to this
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/569#discussion_r97994548
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -129,19 +203,20
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/539
LGTM
I verified locally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/539
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/568
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/554
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97574086
--- Diff: docs/quick-start-guide.md ---
@@ -70,24 +70,22 @@ val carbon =
SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/568#discussion_r97574067
--- Diff: docs/quick-start-guide.md ---
@@ -70,24 +70,22 @@ val carbon =
SparkSession.builder().config(sc.getConf).getOrCreateCarbonSession
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/554#discussion_r97571355
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/569#discussion_r97570640
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
@@ -37,64 +37,138
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/567
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/438
@ashokblend can you work on this, this PR can help user get more
information in SparkUI
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/554#discussion_r97029982
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/554#discussion_r96984537
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/553
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/552#discussion_r96781582
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/552#discussion_r96781568
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/552#discussion_r96781406
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/552
Can you squash your commit into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/546#discussion_r96641464
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -390,11 +390,19 @@ case class
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/540#discussion_r96593534
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala
---
@@ -0,0 +1,81
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/540#discussion_r96591995
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala
---
@@ -0,0 +1,81
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/540#discussion_r96591999
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala
---
@@ -0,0 +1,81
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/540#discussion_r96592006
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala
---
@@ -0,0 +1,81
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/537
LGTM
@ravipesala please check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/544#discussion_r96406092
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionTestCase.scala
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/544#discussion_r96406113
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/ValueCompressionDataTypeTestCase.scala
Github user jackylk closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/432
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/432
This PR has too many conflict, I will close it and raise it again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/523
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/532
@chenliang613
ok, I changed org.apache.carbondata.core.update to
org.apache.carbondata.core.mutate.
iud is not appropriate as this package include support for update and
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/528
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/536
remove table status thrift file
table_status.thrift file is redundant, currently table_status file is in
json format
You can merge this pull request into a Git repository by running
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/511
LGTM
Thanks for working on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108584
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -104,14 +106,17 @@ class CarbonSource extends
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108575
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/533
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108506
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +782,47 @@ case class CarbonRelation
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108503
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +782,47 @@ case class CarbonRelation
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108486
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInput.java
---
@@ -194,28 +196,25 @@ public boolean
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/532
@kumarvishal09
I feel this lock package can be reused in other scenario also, how about
move it to org.apache.carbondata.core.lock?
---
If your project is set up for it, you can
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/512
LGTM
@ravipesala please check also
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96022199
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96022013
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
I will merge this PR now and will wait for @ravikiran23 to fix comment for
#523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/507
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96006298
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96006080
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96005973
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/511#discussion_r96005860
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -108,6 +110,10 @@ class CarbonSource extends
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/533#discussion_r96003724
--- Diff:
core/src/main/java/org/apache/carbondata/scan/executor/impl/DetailQueryExecutor.java
---
@@ -39,11 +39,12 @@
public
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/533#discussion_r96003271
--- Diff:
core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -470,6 +477,7 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/534#discussion_r96002854
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -559,11 +560,7 @@ object
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/531
Oh, I thought it is supported. Why bucket table is not supported in
spark1.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/527
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
@ravipesala Is this PR only fix some of the test case? I used mvn verify
-Pno-kettle, but IUD test case is failing. Fix in another PR?
---
If your project is set up for it, you can
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956920
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956880
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956802
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class CarbonRelation
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95956671
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala
---
@@ -237,9 +237,15 @@ class
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/517
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/532
Move package in carbon-core module
As a step to refactor code to make it more modular, this PR move following
package in carbon-core module
1. move
201 - 300 of 679 matches
Mail list logo
