[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508784#comment-15508784
 ] 

ASF GitHub Bot commented on CB-11818:
-

Github user lucatorella commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17
  
I haven't checked. I can easily check next week when I've access to a Mac 
again 


> cordova-plugin-wkwebview-engine leaks memory
> 
>
> Key: CB-11818
> URL: https://issues.apache.org/jira/browse/CB-11818
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: Luca Torella
>Assignee: Shazron Abdullah
>
> WKUserContentController retains its message handler, this cause the 
> CDVWKWebViewEngine to have a retain cycle and potentially leak memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11876) Cannot build iOS project by `-destination platform=iOS Simulator` option

2016-09-20 Thread Kousuke Ebihara (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kousuke Ebihara closed CB-11876.

Resolution: Invalid

> Cannot build iOS project by `-destination platform=iOS Simulator` option
> 
>
> Key: CB-11876
> URL: https://issues.apache.org/jira/browse/CB-11876
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: Kousuke Ebihara
>
> I got the following errors when I execute `cordova build ios` command.
> {code}
> xcodebuild: error: Unable to find a destination matching the provided 
> destination specifier:
>   { platform:iOS Simulator }
>   Missing required device specifier option.
>   The device type “iOS Simulator” requires that either “name” or “id” be 
> specified.
>   Please supply either “name” or “id”.
>   Available destinations for the "**" scheme:
>   { platform:iOS Simulator, 
> id:BA7F3550-D421-4B37-AC28-BB4135037EE6, OS:8.1, name:iPad 2 }
>   { platform:iOS Simulator, 
> id:03AB49D4-95FD-4B8F-A910-D4846956BBF9, OS:9.3, name:iPad 2 }
> ***SNIP***
>   { platform:iOS Simulator, 
> id:9DC0E0BD-524B-431E-93F2-30D479D08AA8, OS:9.3, name:iPhone 6s Plus }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11876) Cannot build iOS project by `-destination platform=iOS Simulator` option

2016-09-20 Thread Kousuke Ebihara (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508331#comment-15508331
 ] 

Kousuke Ebihara commented on CB-11876:
--

I'm sorry about my mistake. I've submit this unfinished issue and I've noticed 
this problem has already been resolved by 
https://github.com/apache/cordova-ios/commit/8aabb2c3d943048fd89ef313257b3cd90a90c053
 commit...

I'm going to close this issue.

> Cannot build iOS project by `-destination platform=iOS Simulator` option
> 
>
> Key: CB-11876
> URL: https://issues.apache.org/jira/browse/CB-11876
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: Kousuke Ebihara
>
> I got the following errors when I execute `cordova build ios` command.
> {code}
> xcodebuild: error: Unable to find a destination matching the provided 
> destination specifier:
>   { platform:iOS Simulator }
>   Missing required device specifier option.
>   The device type “iOS Simulator” requires that either “name” or “id” be 
> specified.
>   Please supply either “name” or “id”.
>   Available destinations for the "**" scheme:
>   { platform:iOS Simulator, 
> id:BA7F3550-D421-4B37-AC28-BB4135037EE6, OS:8.1, name:iPad 2 }
>   { platform:iOS Simulator, 
> id:03AB49D4-95FD-4B8F-A910-D4846956BBF9, OS:9.3, name:iPad 2 }
> ***SNIP***
>   { platform:iOS Simulator, 
> id:9DC0E0BD-524B-431E-93F2-30D479D08AA8, OS:9.3, name:iPhone 6s Plus }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11876) Cannot build iOS project by `-destination platform=iOS Simulator` option

2016-09-20 Thread Kousuke Ebihara (JIRA) 
Kousuke Ebihara created CB-11876:


 Summary: Cannot build iOS project by `-destination platform=iOS 
Simulator` option
 Key: CB-11876
 URL: https://issues.apache.org/jira/browse/CB-11876
 Project: Apache Cordova
  Issue Type: Bug
  Components: iOS
Reporter: Kousuke Ebihara


I got the following errors when I execute `cordova build ios` command.

{code}
xcodebuild: error: Unable to find a destination matching the provided 
destination specifier:
{ platform:iOS Simulator }

Missing required device specifier option.
The device type “iOS Simulator” requires that either “name” or “id” be 
specified.
Please supply either “name” or “id”.

Available destinations for the "**" scheme:
{ platform:iOS Simulator, 
id:BA7F3550-D421-4B37-AC28-BB4135037EE6, OS:8.1, name:iPad 2 }
{ platform:iOS Simulator, 
id:03AB49D4-95FD-4B8F-A910-D4846956BBF9, OS:9.3, name:iPad 2 }
***SNIP***
{ platform:iOS Simulator, 
id:9DC0E0BD-524B-431E-93F2-30D479D08AA8, OS:9.3, name:iPhone 6s Plus }
{code}





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508181#comment-15508181
 ] 

ASF GitHub Bot commented on CB-11136:
-

Github user manucorporat commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
@ephemer sure! I can rename it! it was just a funny name (bad clean code 
practice haha)
> does the window clean itself up if its rootViewController dismisses 
itself, or is there something missing?

yes, I am not sure about the mechanism used by apple, I read that UIWindows 
are garbage collected when it is hidden. Like you I was not sure and I debugged 
that, there is not leak of UIWindows. Feel free to test it yourself.



> InAppBrowser fails to close with WKWebView OAuth 
> -
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
>Reporter: Geordie Jay
>Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for 
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another 
> view controller is presented. This can be confirmed by inspecting the 
> WKWebView session in Safari, running `window.open('http://something.com')` 
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the 
> InAppBrowser's view manually, rather than 'presenting' the ViewController in 
> the traditional iOS style. In that instance the WKWebView thread continues as 
> normal and receives the confirmation to close the other InAppBrowser when the 
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big 
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the 
> InAppBrowser acceptable? Would be happy to make a pull request along these 
> lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11826) Ajax calls fails in WKWebView on self-signed servers

2016-09-20 Thread jcesarmobile (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507945#comment-15507945
 ] 

jcesarmobile commented on CB-11826:
---

I agree about that we can't do anything, but I don't think it's a bug. 
To make self signed certificates work on UIWebView you have to use a private 
API (allowsAnyHTTPSCertificateForHost).
I think it was intentional to not make it work on WKWebView. 

> Ajax calls fails in WKWebView on self-signed servers 
> -
>
> Key: CB-11826
> URL: https://issues.apache.org/jira/browse/CB-11826
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Affects Versions: 3.5.0
> Environment: iOS 8, 9, 10
>Reporter: Jörn Heid
>Assignee: Shazron Abdullah
> Attachments: WKWebView.zip
>
>
> When using jQuery's Ajax, I get
> "Failed to load resource: The certificate for this server is invalid. You 
> might be connecting to a server that is pretending to be “xxx” which could 
> put your confidential information at risk."
> when checking the webview in Safari through USB.
> I tried to implement the didReceiveAuthenticationChallenge method in 
> CDVWKWebViewEngine but it doesn't seem to be called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11826) Ajax calls fails in WKWebView on self-signed servers

2016-09-20 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507933#comment-15507933
 ] 

Shazron Abdullah commented on CB-11826:
---

Not sure if there's anything we can do here, seems to me it might be an Apple 
bug? Try filing an issue at bugreporter.apple.com to see Apple's response or 
use one of the two DTS incidents that came with your annually charged Apple 
Developer account.

> Ajax calls fails in WKWebView on self-signed servers 
> -
>
> Key: CB-11826
> URL: https://issues.apache.org/jira/browse/CB-11826
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Affects Versions: 3.5.0
> Environment: iOS 8, 9, 10
>Reporter: Jörn Heid
>Assignee: Shazron Abdullah
> Attachments: WKWebView.zip
>
>
> When using jQuery's Ajax, I get
> "Failed to load resource: The certificate for this server is invalid. You 
> might be connecting to a server that is pretending to be “xxx” which could 
> put your confidential information at risk."
> when checking the webview in Safari through USB.
> I tried to implement the didReceiveAuthenticationChallenge method in 
> CDVWKWebViewEngine but it doesn't seem to be called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11875) Cordova-Plugin-Geolocation requires feature android.hardware.location.gps (android 21+)

2016-09-20 Thread Warren Parad (JIRA) 
Warren Parad created CB-11875:
-

 Summary: Cordova-Plugin-Geolocation requires feature 
android.hardware.location.gps (android 21+)
 Key: CB-11875
 URL: https://issues.apache.org/jira/browse/CB-11875
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android, Plugin Geolocation
Reporter: Warren Parad
Priority: Critical


Hello Google Play Developer,

We're writing to let you know that the apps listed at the end of this email may 
be affected by an upcoming platform change.

Action required: If your app requires GPS hardware to operate properly, you 
will need to explicitly add the "android.hardware.location.gps" uses-feature to 
your manifest.

What’s changing

We’re making a change on October 15th, 2016 that will affect apps targeting API 
version 21 (Android 5.0, Lollipop) or higher that use ACCESS_FINE_LOCATION but 
don't explicitly have the "android.hardware.location.gps" uses-feature. Going 
forward, these apps will be available to install on devices that don't have GPS 
hardware. In most cases this won't be an issue since Wi-Fi and Cell-ID based 
location provides high enough fidelity for the typical operation of these apps. 
However, any apps that require GPS hardware, such as GPS navigators, should 
explicitly add the *"android.hardware.location.gps" uses-feature* to their 
manifest.

If your app requires GPS to function properly and you do not include 
android.hardware.location.gps in your manifest declaration, your users may have 
a poor app experience.

Also, if you’re using the fused location provider and wish to receive the most 
accurate location samples from GPS (i.e. with PRIORITY_HIGH_ACCURACY), you must 
include the "android.hardware.location.gps" feature in your app’s manifest to 
ensure that Google Play only distributes your app to devices with GPS sensors.

You can read more about this change in the Android Developers Help Center.

Regards,

The Google Play Team



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507375#comment-15507375
 ] 

ASF GitHub Bot commented on CB-11136:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
I like the implementation in #187 for the `show` method, what do you think?


> InAppBrowser fails to close with WKWebView OAuth 
> -
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
>Reporter: Geordie Jay
>Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for 
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another 
> view controller is presented. This can be confirmed by inspecting the 
> WKWebView session in Safari, running `window.open('http://something.com')` 
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the 
> InAppBrowser's view manually, rather than 'presenting' the ViewController in 
> the traditional iOS style. In that instance the WKWebView thread continues as 
> normal and receives the confirmation to close the other InAppBrowser when the 
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big 
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the 
> InAppBrowser acceptable? Would be happy to make a pull request along these 
> lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507341#comment-15507341
 ] 

ASF GitHub Bot commented on CB-11136:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
LGTM  


> InAppBrowser fails to close with WKWebView OAuth 
> -
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
>Reporter: Geordie Jay
>Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for 
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another 
> view controller is presented. This can be confirmed by inspecting the 
> WKWebView session in Safari, running `window.open('http://something.com')` 
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the 
> InAppBrowser's view manually, rather than 'presenting' the ViewController in 
> the traditional iOS style. In that instance the WKWebView thread continues as 
> normal and receives the confirmation to close the other InAppBrowser when the 
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big 
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the 
> InAppBrowser acceptable? Would be happy to make a pull request along these 
> lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread Shazron Abdullah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah resolved CB-11792.
---
Resolution: Fixed

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507246#comment-15507246
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/259


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507244#comment-15507244
 ] 

ASF subversion and git services commented on CB-11792:
--

Commit ff3df9b7e7ab37e935e1e1d38a0b1cbeff46d029 in cordova-ios's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=ff3df9b ]

CB-11792 - Fixed configuration file could not be parsed due to preprocessing 
errors

 This closes #259


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507242#comment-15507242
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/259
  
@dpogue Thanks for testing! Merging.


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507198#comment-15507198
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user dpogue commented on the issue:

https://github.com/apache/cordova-ios/pull/259
  
Tested this and I'm not getting any errors from the xcconfig :+1:
Thanks Shaz!


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507160#comment-15507160
 ] 

ASF GitHub Bot commented on CB-3232:


GitHub user manucorporat opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20

Fix handling of tel and mailto schemes in local file

### Platforms affected
iOS

### What does this PR do?
- WKWebview appears to do nothing when 
`decisionHandler(WKNavigationActionPolicyAllow);` (accepting) a request with 
`tel` or `mailto` if the loaded file is local.

### What testing has been done on this change?
- `http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/driftyco/cordova-plugin-wkwebview-engine 
fix-handle-tel-mailto

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 40a229846d7da75876677bef717dd5dbc031993d
Author: Manu Mtz.-Almeida 
Date:   2016-09-13T14:22:24Z

Fix handling of tel and mailto schemes in local file




> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: BlackBerry, CLI
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-11873) No plugins installed when running a prepare before a build in a gulp task.

2016-09-20 Thread Alex Buijs (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Buijs updated CB-11873:

Comment: was deleted

(was: It could be there is one drawback of building without separately 
preparing first: it seems like the 'before_plugin_install' hook is not 
triggered... :-/)

> No plugins installed when running a prepare before a build in a gulp task.
> --
>
> Key: CB-11873
> URL: https://issues.apache.org/jira/browse/CB-11873
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Alex Buijs
>
> I use a gulp task for building, so I work directly with {code}var cordova = 
> require('cordova-lib').cordova;
> cordova.build({platforms: ['ios', 'android'], options: {}}, cb);{code}
> Because of [a 
> check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
>  in cordova-lib/src/cordova/util.js, platforms need to be added before the 
> project can be build, otherwise the error "No platforms added to this 
> project..." is thrown.
> Since I always remove the contents of the platforms and plugins directories 
> before building (I target multiple apps from the same codebase), I need to 
> prepare the project before I can build, because of this check. This leads to 
> a bug similar to CB-11519 and CB-11589, where plugins are never correctly 
> installed.
> Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
> missing the plugins when running a prepare immediately followed by a build. 
> When the tasks are performed manually one after the other, everything works 
> fine. I am waiting for the callback of prepare to be called, before the build 
> task is started, but perhaps the prepare callback is called too early?
> Since the build function in cordova-lib/src/cordova/build.js already prepares 
> the project (after calling preProcessOptions in util.js), it seems redundant 
> to be forced to prepare the project before building.
> When the check I mentioned is not performed, a build with empty platforms and 
> plugins directories works just fine: it saves one superfluous prepare task 
> and, more importantly, plugins are correctly installed.
> My proposal: perhaps this check could be omitted when preProcessOptions is 
> called from the build task?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507065#comment-15507065
 ] 

ASF GitHub Bot commented on CB-11136:
-

Github user dotNetkow commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
Developer here that originally requested this change. To lend more credence 
to @manucorporat's changes: I tested them on an iPhone 6 running iOS 10 - works 
now as expected.  Thanks!


> InAppBrowser fails to close with WKWebView OAuth 
> -
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
>Reporter: Geordie Jay
>Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for 
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another 
> view controller is presented. This can be confirmed by inspecting the 
> WKWebView session in Safari, running `window.open('http://something.com')` 
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the 
> InAppBrowser's view manually, rather than 'presenting' the ViewController in 
> the traditional iOS style. In that instance the WKWebView thread continues as 
> normal and receives the confirmation to close the other InAppBrowser when the 
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big 
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the 
> InAppBrowser acceptable? Would be happy to make a pull request along these 
> lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11873) No plugins installed when running a prepare before a build in a gulp task.

2016-09-20 Thread Alex Buijs (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506955#comment-15506955
 ] 

Alex Buijs commented on CB-11873:
-

It could be there is one drawback of building without separately preparing 
first: it seems like the 'before_plugin_install' hook is not triggered... :-/

> No plugins installed when running a prepare before a build in a gulp task.
> --
>
> Key: CB-11873
> URL: https://issues.apache.org/jira/browse/CB-11873
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Alex Buijs
>
> I use a gulp task for building, so I work directly with {code}var cordova = 
> require('cordova-lib').cordova;
> cordova.build({platforms: ['ios', 'android'], options: {}}, cb);{code}
> Because of [a 
> check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
>  in cordova-lib/src/cordova/util.js, platforms need to be added before the 
> project can be build, otherwise the error "No platforms added to this 
> project..." is thrown.
> Since I always remove the contents of the platforms and plugins directories 
> before building (I target multiple apps from the same codebase), I need to 
> prepare the project before I can build, because of this check. This leads to 
> a bug similar to CB-11519 and CB-11589, where plugins are never correctly 
> installed.
> Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
> missing the plugins when running a prepare immediately followed by a build. 
> When the tasks are performed manually one after the other, everything works 
> fine. I am waiting for the callback of prepare to be called, before the build 
> task is started, but perhaps the prepare callback is called too early?
> Since the build function in cordova-lib/src/cordova/build.js already prepares 
> the project (after calling preProcessOptions in util.js), it seems redundant 
> to be forced to prepare the project before building.
> When the check I mentioned is not performed, a build with empty platforms and 
> plugins directories works just fine: it saves one superfluous prepare task 
> and, more importantly, plugins are correctly installed.
> My proposal: perhaps this check could be omitted when preProcessOptions is 
> called from the build task?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11874) useChunkedMode forced when uploading to https

2016-09-20 Thread Mickael Magniez (JIRA) 
Mickael Magniez created CB-11874:


 Summary: useChunkedMode forced when uploading to https
 Key: CB-11874
 URL: https://issues.apache.org/jira/browse/CB-11874
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File Transfer
 Environment: android
Reporter: Mickael Magniez


Hi,

Since commit 9347606dd33fe07ea36799b4dd28804019c68835 resolving issue CB-10974, 
useChunkedMode is forced when uploading to https.

This prevents uploading to amazon s3 using https.

Before :
{code}
boolean useChunkedMode = chunkedMode && (Build.VERSION.SDK_INT < 
Build.VERSION_CODES.FROYO || useHttps);
{code}

After:
{code}
 boolean useChunkedMode = chunkedMode || (Build.VERSION.SDK_INT < 
Build.VERSION_CODES.FROYO || useHttps);
{code}


Best regards



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506695#comment-15506695
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/195
  
@tsschaffert, please let me know if you plan to address the comments.


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11873) No plugins installed when running a prepare before a build in a gulp task.

2016-09-20 Thread Alex Buijs (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Buijs updated CB-11873:

Description: 
I use a gulp task for building, so I work directly with {code}var cordova = 
require('cordova-lib').cordova;
cordova.build({platforms: ['ios', 'android'], options: {}}, cb);{code}
Because of [a 
check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
 in cordova-lib/src/cordova/util.js, platforms need to be added before the 
project can be build, otherwise the error "No platforms added to this 
project..." is thrown.

Since I always remove the contents of the platforms and plugins directories 
before building (I target multiple apps from the same codebase), I need to 
prepare the project before I can build, because of this check. This leads to a 
bug similar to CB-11519 and CB-11589, where plugins are never correctly 
installed.

Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
missing the plugins when running a prepare immediately followed by a build. 
When the tasks are performed manually one after the other, everything works 
fine. I am waiting for the callback of prepare to be called, before the build 
task is started, but perhaps the prepare callback is called too early?

Since the build function in cordova-lib/src/cordova/build.js already prepares 
the project (after calling preProcessOptions in util.js), it seems redundant to 
be forced to prepare the project before building.

When the check I mentioned is not performed, a build with empty platforms and 
plugins directories works just fine: it saves one superfluous prepare task and, 
more importantly, plugins are correctly installed.

My proposal: perhaps this check could be omitted when preProcessOptions is 
called from the build task?

  was:
I use a gulp task for building, so I work directly with {code}var cordova = 
require('cordova-lib').cordova; cordova.build({platforms: ['ios', 'android'], 
options: {}}, cb);{code}
Because of [a 
check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
 in cordova-lib/src/cordova/util.js, platforms need to be added before the 
project can be build, otherwise the error "No platforms added to this 
project..." is thrown.

Since I always remove the contents of the platforms and plugins directories 
before building (I target multiple apps from the same codebase), I need to 
prepare the project before I can build, because of this check. This leads to a 
bug similar to CB-11519 and CB-11589, where plugins are never correctly 
installed.

Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
missing the plugins when running a prepare immediately followed by a build. 
When the tasks are performed manually one after the other, everything works 
fine. I am waiting for the callback of prepare to be called, before the build 
task is started, but perhaps the prepare callback is called too early?

Since the build function in cordova-lib/src/cordova/build.js already prepares 
the project (after calling preProcessOptions in util.js), it seems redundant to 
be forced to prepare the project before building.

When the check I mentioned is not performed, a build with empty platforms and 
plugins directories works just fine: it saves one superfluous prepare task and, 
more importantly, plugins are correctly installed.

My proposal: perhaps this check could be omitted when preProcessOptions is 
called from the build task?


> No plugins installed when running a prepare before a build in a gulp task.
> --
>
> Key: CB-11873
> URL: https://issues.apache.org/jira/browse/CB-11873
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Alex Buijs
>
> I use a gulp task for building, so I work directly with {code}var cordova = 
> require('cordova-lib').cordova;
> cordova.build({platforms: ['ios', 'android'], options: {}}, cb);{code}
> Because of [a 
> check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
>  in cordova-lib/src/cordova/util.js, platforms need to be added before the 
> project can be build, otherwise the error "No platforms added to this 
> project..." is thrown.
> Since I always remove the contents of the platforms and plugins directories 
> before building (I target multiple apps from the same codebase), I need to 
> prepare the project before I can build, because of this check. This leads to 
> a bug similar to CB-11519 and CB-11589, where plugins are never correctly 
> installed.
> Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
> missing the plugins when running a prepare immediately followed by a build. 
> When the tasks are

[jira] [Updated] (CB-11873) No plugins installed when running a prepare before a build in a gulp task.

2016-09-20 Thread Alex Buijs (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Buijs updated CB-11873:

Description: 
I use a gulp task for building, so I work directly with {code}var cordova = 
require('cordova-lib').cordova; cordova.build({platforms: ['ios', 'android'], 
options: {}}, cb);{code}
Because of [a 
check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
 in cordova-lib/src/cordova/util.js, platforms need to be added before the 
project can be build, otherwise the error "No platforms added to this 
project..." is thrown.

Since I always remove the contents of the platforms and plugins directories 
before building (I target multiple apps from the same codebase), I need to 
prepare the project before I can build, because of this check. This leads to a 
bug similar to CB-11519 and CB-11589, where plugins are never correctly 
installed.

Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
missing the plugins when running a prepare immediately followed by a build. 
When the tasks are performed manually one after the other, everything works 
fine. I am waiting for the callback of prepare to be called, before the build 
task is started, but perhaps the prepare callback is called too early?

Since the build function in cordova-lib/src/cordova/build.js already prepares 
the project (after calling preProcessOptions in util.js), it seems redundant to 
be forced to prepare the project before building.

When the check I mentioned is not performed, a build with empty platforms and 
plugins directories works just fine: it saves one superfluous prepare task and, 
more importantly, plugins are correctly installed.

My proposal: perhaps this check could be omitted when preProcessOptions is 
called from the build task?

  was:
I use a gulp task for building, so I work directly with {code}var cordova = 
require('cordova-lib').cordova.build({}, cb);{code}
Because of [a 
check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
 in cordova-lib/src/cordova/util.js, platforms need to be added before the 
project can be build, otherwise the error "No platforms added to this 
project..." is thrown.

Since I always remove the contents of the platforms and plugins directories 
before building (I target multiple apps from the same codebase), I need to 
prepare the project before I can build, because of this check. This leads to a 
bug similar to CB-11519 and CB-11589, where plugins are never correctly 
installed.

Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
missing the plugins when running a prepare immediately followed by a build. 
When the tasks are performed manually one after the other, everything works 
fine. I am waiting for the callback of prepare to be called, before the build 
task is started, but perhaps the prepare callback is called too early?

Since the build function in cordova-lib/src/cordova/build.js already prepares 
the project (after calling preProcessOptions in util.js), it seems redundant to 
be forced to prepare the project before building.

When the check I mentioned is not performed, a build with empty platforms and 
plugins directories works just fine: it saves one superfluous prepare task and, 
more importantly, plugins are correctly installed.

My proposal: perhaps this check could be omitted when preProcessOptions is 
called from the build task?


> No plugins installed when running a prepare before a build in a gulp task.
> --
>
> Key: CB-11873
> URL: https://issues.apache.org/jira/browse/CB-11873
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Alex Buijs
>
> I use a gulp task for building, so I work directly with {code}var cordova = 
> require('cordova-lib').cordova; cordova.build({platforms: ['ios', 'android'], 
> options: {}}, cb);{code}
> Because of [a 
> check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
>  in cordova-lib/src/cordova/util.js, platforms need to be added before the 
> project can be build, otherwise the error "No platforms added to this 
> project..." is thrown.
> Since I always remove the contents of the platforms and plugins directories 
> before building (I target multiple apps from the same codebase), I need to 
> prepare the project before I can build, because of this check. This leads to 
> a bug similar to CB-11519 and CB-11589, where plugins are never correctly 
> installed.
> Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
> missing the plugins when running a prepare immediately followed by a build. 
> When the tasks are performed manually one after the other, everything

[jira] [Created] (CB-11873) No plugins installed when running a prepare before a build in a gulp task.

2016-09-20 Thread Alex Buijs (JIRA) 
Alex Buijs created CB-11873:
---

 Summary: No plugins installed when running a prepare before a 
build in a gulp task.
 Key: CB-11873
 URL: https://issues.apache.org/jira/browse/CB-11873
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Affects Versions: 6.3.1
Reporter: Alex Buijs


I use a gulp task for building, so I work directly with {code}var cordova = 
require('cordova-lib').cordova.build({}, cb);{code}
Because of [a 
check|https://github.com/apache/cordova-lib/blob/6.3.x/cordova-lib/src/cordova/util.js#L279]
 in cordova-lib/src/cordova/util.js, platforms need to be added before the 
project can be build, otherwise the error "No platforms added to this 
project..." is thrown.

Since I always remove the contents of the platforms and plugins directories 
before building (I target multiple apps from the same codebase), I need to 
prepare the project before I can build, because of this check. This leads to a 
bug similar to CB-11519 and CB-11589, where plugins are never correctly 
installed.

Unfortunately, I couldn't find the exact reason why platforms/ios/ios.json is 
missing the plugins when running a prepare immediately followed by a build. 
When the tasks are performed manually one after the other, everything works 
fine. I am waiting for the callback of prepare to be called, before the build 
task is started, but perhaps the prepare callback is called too early?

Since the build function in cordova-lib/src/cordova/build.js already prepares 
the project (after calling preProcessOptions in util.js), it seems redundant to 
be forced to prepare the project before building.

When the check I mentioned is not performed, a build with empty platforms and 
plugins directories works just fine: it saves one superfluous prepare task and, 
more importantly, plugins are correctly installed.

My proposal: perhaps this check could be omitted when preProcessOptions is 
called from the build task?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11872) cordova.require is not a function in geolocation.js

2016-09-20 Thread La Min Ko (JIRA) 
La Min Ko created CB-11872:
--

 Summary: cordova.require is not a function in geolocation.js
 Key: CB-11872
 URL: https://issues.apache.org/jira/browse/CB-11872
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Geolocation
Affects Versions: 6.3.1
 Environment: - Linux lmk-inspiron-3521 4.4.0-36-generic #55-Ubuntu SMP 
Thu Aug 11 18:01:55 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
- cordova 6.3.1
- node 5.10.0
- cordova-plugin-geolocation 2.3.0
Reporter: La Min Ko
Priority: Critical


When `navigator.geolocation.getCurrentPosition` was called, an exception raised 
`cordova.require` on geolocation.js. NOTE: `cordova` global object is 
accessible from console (developer tools).

geolocation.js:34 Uncaught (in promise) TypeError: cordova.require is not a 
function(…)
win @   geolocation.js:34
cordova.callbackFromNative  @   cordova.js:293
processMessage  @   cordova.js:1081
processMessages @   cordova.js:1104

getCurrentPosition: function(success, error, args) {
var win = function() {
  var geo = 
cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
'navigator.geolocation'); < EXCEPTION RAISED
  geo.getCurrentPosition(success, error, args);
};
var fail = function() {
if (error) {
error(new PositionError (PositionError.PERMISSION_DENIED, 
'Illegal Access'));
}
};
exec(win, fail, "Geolocation", "getPermission", []);
},



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506472#comment-15506472
 ] 

ASF GitHub Bot commented on CB-11836:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-docs/pull/638

CB-11836 Documented Windows ForegroundText preference

https://issues.apache.org/jira/browse/CB-11836

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-docs CB-11836

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #638


commit 55f9dbe3657b8d2488b23f482d5f3cc942673cf1
Author: daserge 
Date:   2016-09-20T13:07:56Z

CB-11836 Documented Windows ForegroundText preference




> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-20 Thread Maarten Manders (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maarten Manders closed CB-11848.

Resolution: Duplicate

Fixed in https://github.com/apache/cordova-plugin-file/pull/112

> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-20 Thread Maarten Manders (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505917#comment-15505917
 ] 

Maarten Manders commented on CB-11848:
--

Resolved in https://github.com/apache/cordova-plugin-file/pull/112

> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11826) Ajax calls fails in WKWebView on self-signed servers

2016-09-20 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/CB-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörn Heid updated CB-11826:
---
Environment: iOS 8, 9, 10  (was: iOS 9.3.2)

> Ajax calls fails in WKWebView on self-signed servers 
> -
>
> Key: CB-11826
> URL: https://issues.apache.org/jira/browse/CB-11826
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Affects Versions: 3.5.0
> Environment: iOS 8, 9, 10
>Reporter: Jörn Heid
>Assignee: Shazron Abdullah
> Attachments: WKWebView.zip
>
>
> When using jQuery's Ajax, I get
> "Failed to load resource: The certificate for this server is invalid. You 
> might be connecting to a server that is pretending to be “xxx” which could 
> put your confidential information at risk."
> when checking the webview in Safari through USB.
> I tried to implement the didReceiveAuthenticationChallenge method in 
> CDVWKWebViewEngine but it doesn't seem to be called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-11826) Ajax calls fails in WKWebView on self-signed servers

2016-09-20 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/CB-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörn Heid updated CB-11826:
---
Comment: was deleted

(was: XCode project demonstrating the issue.)

> Ajax calls fails in WKWebView on self-signed servers 
> -
>
> Key: CB-11826
> URL: https://issues.apache.org/jira/browse/CB-11826
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Affects Versions: 3.5.0
> Environment: iOS 9.3.2
>Reporter: Jörn Heid
>Assignee: Shazron Abdullah
> Attachments: WKWebView.zip
>
>
> When using jQuery's Ajax, I get
> "Failed to load resource: The certificate for this server is invalid. You 
> might be connecting to a server that is pretending to be “xxx” which could 
> put your confidential information at risk."
> when checking the webview in Safari through USB.
> I tried to implement the didReceiveAuthenticationChallenge method in 
> CDVWKWebViewEngine but it doesn't seem to be called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505887#comment-15505887
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/259
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/259?src=pr) is 56.89% 
(diff: 75.00%)
> Merging [#259](https://codecov.io/gh/apache/cordova-ios/pull/259?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will increase coverage by **0.19%**

```diff
@@ master   #259   diff @@
==
  Files12 12  
  Lines  1090   1102+12   
  Methods 169171 +2   
  Messages  0  0  
  Branches176176  
==
+ Hits618627 +9   
- Misses  472475 +3   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[b5fb016...5e77c10](https://codecov.io/gh/apache/cordova-ios/compare/b5fb016b9f81426f9173ae36b7084fa7913dbd8f...5e77c1086d016eca67168c807a824cd3d71d6ce5?src=pr)


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11826) Ajax calls fails in WKWebView on self-signed servers

2016-09-20 Thread JIRA 

 [ 
https://issues.apache.org/jira/browse/CB-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörn Heid updated CB-11826:
---
Attachment: WKWebView.zip

XCode project demonstrating the issue.

> Ajax calls fails in WKWebView on self-signed servers 
> -
>
> Key: CB-11826
> URL: https://issues.apache.org/jira/browse/CB-11826
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Affects Versions: 3.5.0
> Environment: iOS 9.3.2
>Reporter: Jörn Heid
>Assignee: Shazron Abdullah
> Attachments: WKWebView.zip
>
>
> When using jQuery's Ajax, I get
> "Failed to load resource: The certificate for this server is invalid. You 
> might be connecting to a server that is pretending to be “xxx” which could 
> put your confidential information at risk."
> when checking the webview in Safari through USB.
> I tried to implement the didReceiveAuthenticationChallenge method in 
> CDVWKWebViewEngine but it doesn't seem to be called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11826) Ajax calls fails in WKWebView on self-signed servers

2016-09-20 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CB-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505879#comment-15505879
 ] 

Jörn Heid commented on CB-11826:


Added a project demonstrating the issue. In ViewController.m there is the 
WKWebView implementation testing

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505842#comment-15505842
 ] 

ASF GitHub Bot commented on CB-11792:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/259

CB-11792 - Fixed configuration file could not be parsed due to 
preprocessing errors



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-11792.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #259


commit 5e77c1086d016eca67168c807a824cd3d71d6ce5
Author: Shazron Abdullah 
Date:   2016-09-20T07:12:37Z

CB-11792 - Fixed configuration file could not be parsed due to 
preprocessing errors




> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505830#comment-15505830
 ] 

Shazron Abdullah commented on CB-11792:
---

Because of the redirection, I had to add this ignore directive in the 
build.xcconfig files:
{code}
// @COCOAPODS_SILENCE_WARNINGS@ //
{code}

This is to suppress this warning:
{code}
[!] CocoaPods did not set the base configuration of your project because your 
project already has a custom config set. In order for CocoaPods integration to 
work at all, please either set the base configurations of the target 
`TestClient` to `Pods/Target Support 
Files/Pods-TestClient/Pods-TestClient.debug.xcconfig` or include the 
`Pods/Target Support Files/Pods-TestClient/Pods-TestClient.debug.xcconfig` in 
your build configuration.
{code}
See: 
https://github.com/CocoaPods/CocoaPods/commit/2ab324a719713aa26109d29bb2b5e06e2120abd7

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505807#comment-15505807
 ] 

Shazron Abdullah commented on CB-11792:
---

This issue wasn't found in testing because I was monitoring stdout which is too 
verbose (usually the errors happen at the end, and I didn't see this). It 
exists if you look at stderr.

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org