[jira] [Commented] (CB-12838) Order of plugins in config.xml modified during build
[
https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124202#comment-16124202
]
ASF GitHub Bot commented on CB-12838:
-
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132795105
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null,
2), 'utf8');
}
}
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in
content)
comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
if (pluginIdConfig.indexOf(plugID) < 0) {
pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec:
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) &&
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
+((mergedPluginSpecs[plugID] !== configXMLPlugin.spec) ||
--- End diff --
Yes, exactly! Also rebased and updated based on feedback. Let me know if
there's anything else!
> Order of plugins in config.xml modified during build
>
>
> Key: CB-12838
> URL: https://issues.apache.org/jira/browse/CB-12838
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
> Environment: Mac OS 10.12.4, Cordova 7.0.1
>Reporter: Anton Weber
>Assignee: Audrey So
>Priority: Minor
> Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which
> plugins are listed in the config.xml (arranging them alphabetically).
> This causes problems when manually resolving dependencies, e.g. when
> installing a specific version of a dependency first by having it higher up in
> the list.
> Example:
> Original config.xml content:
> ...
>
>
>
>
>
> ...
> After cordova build:
> ...
>
>
>
>
>
> ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12730) Compat - INTEGRATE
[ https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124075#comment-16124075 ] Simon MacDonald commented on CB-12730: -- PR reviewed by Steve, Joe and Fil then merged into master. The plugin is ready for 1.2.0 release. > Compat - INTEGRATE > -- > > Key: CB-12730 > URL: https://issues.apache.org/jira/browse/CB-12730 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-compat >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12730) Compat - INTEGRATE
[ https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124073#comment-16124073 ] ASF subversion and git services commented on CB-12730: -- Commit 7c6449ead1b00d6f1b1fc455e0755de781806b48 in cordova-plugin-compat's branch refs/heads/master from [~macdonst] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-compat.git;h=7c6449e ] CB-12730: Compat - INTEGRATE This closes #3 > Compat - INTEGRATE > -- > > Key: CB-12730 > URL: https://issues.apache.org/jira/browse/CB-12730 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-compat >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13175) 8.1-win crashes on startup
[
https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Kapaln updated CB-13175:
Description:
This ticket is a follow up to CB-12784
The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
functions colorizeTitleBar() and {code}revertTitleBarColor(){code} exist in
template/www/cordova.js as well and my PR takes the fix the user applied in
CB-12784 and adds into cordova.js as well.
alsorokin original fix (already merged into master):
https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
was:
This ticket is a follow up to CB-12784
The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
functions {code}colorizeTitleBar(){code} and {code}revertTitleBarColor(){code}
exist in {code}template/www/cordova.js{code} as well and my PR takes the fix
the user applied in CB-12784 and adds into {code}cordova.js{code} as well.
alsorokin original fix (already merged into master):
https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
> 8.1-win crashes on startup
> --
>
> Key: CB-13175
> URL: https://issues.apache.org/jira/browse/CB-13175
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Affects Versions: Master
>Reporter: Max Kapaln
>Assignee: Jesse MacFadyen
>
> This ticket is a follow up to CB-12784
> The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
> functions colorizeTitleBar() and {code}revertTitleBarColor(){code} exist in
> template/www/cordova.js as well and my PR takes the fix the user applied in
> CB-12784 and adds into cordova.js as well.
> alsorokin original fix (already merged into master):
> https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13175) 8.1-win crashes on startup
[
https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Kapaln updated CB-13175:
Description:
This ticket is a follow up to CB-12784
The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
functions colorizeTitleBar() and =revertTitleBarColor() exist in
template/www/cordova.js as well and my PR takes the fix the user applied in
CB-12784 and adds into cordova.js as well.
alsorokin original fix (already merged into master):
https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
was:
This ticket is a follow up to CB-12784
The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
functions colorizeTitleBar() and {code}revertTitleBarColor(){code} exist in
template/www/cordova.js as well and my PR takes the fix the user applied in
CB-12784 and adds into cordova.js as well.
alsorokin original fix (already merged into master):
https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
> 8.1-win crashes on startup
> --
>
> Key: CB-13175
> URL: https://issues.apache.org/jira/browse/CB-13175
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Affects Versions: Master
>Reporter: Max Kapaln
>Assignee: Jesse MacFadyen
>
> This ticket is a follow up to CB-12784
> The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
> functions colorizeTitleBar() and =revertTitleBarColor() exist in
> template/www/cordova.js as well and my PR takes the fix the user applied in
> CB-12784 and adds into cordova.js as well.
> alsorokin original fix (already merged into master):
> https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13175) 8.1-win crashes on startup
[
https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Kapaln updated CB-13175:
Description:
This ticket is a follow up to CB-12784
The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
functions {code}colorizeTitleBar(){code} and {code}revertTitleBarColor(){code}
exist in {code}template/www/cordova.js{code} as well and my PR takes the fix
the user applied in CB-12784 and adds into {code}cordova.js{code} as well.
alsorokin original fix (already merged into master):
https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
was:
This ticket is a follow up to CB-12784
The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
functions `colorizeTitleBar()` and `revertTitleBarColor()` exist in
`template/www/cordova.js` as well and my PR takes the fix the user applied in
CB-12784 and adds into `cordova.js` as well.
alsorokin original fix (already merged into master):
https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
> 8.1-win crashes on startup
> --
>
> Key: CB-13175
> URL: https://issues.apache.org/jira/browse/CB-13175
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Affects Versions: Master
>Reporter: Max Kapaln
>Assignee: Jesse MacFadyen
>
> This ticket is a follow up to CB-12784
> The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
> functions {code}colorizeTitleBar(){code} and
> {code}revertTitleBarColor(){code} exist in
> {code}template/www/cordova.js{code} as well and my PR takes the fix the user
> applied in CB-12784 and adds into {code}cordova.js{code} as well.
> alsorokin original fix (already merged into master):
> https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13175) 8.1-win crashes on startup
[ https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Kapaln updated CB-13175: Description: This ticket is a follow up to CB-12784 The PR submitted with CB-12784 only half fixed the win8 crashing issue. The functions colorizeTitleBar() and revertTitleBarColor() exist in template/www/cordova.js as well and my PR takes the fix the user applied in CB-12784 and adds into cordova.js as well. alsorokin original fix (already merged into master): https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a was: This ticket is a follow up to CB-12784 The PR submitted with CB-12784 only half fixed the win8 crashing issue. The functions colorizeTitleBar() and =revertTitleBarColor() exist in template/www/cordova.js as well and my PR takes the fix the user applied in CB-12784 and adds into cordova.js as well. alsorokin original fix (already merged into master): https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a > 8.1-win crashes on startup > -- > > Key: CB-13175 > URL: https://issues.apache.org/jira/browse/CB-13175 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Affects Versions: Master >Reporter: Max Kapaln >Assignee: Jesse MacFadyen > > This ticket is a follow up to CB-12784 > The PR submitted with CB-12784 only half fixed the win8 crashing issue. The > functions colorizeTitleBar() and revertTitleBarColor() exist in > template/www/cordova.js as well and my PR takes the fix the user applied in > CB-12784 and adds into cordova.js as well. > alsorokin original fix (already merged into master): > https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124053#comment-16124053 ] ASF GitHub Bot commented on CB-12361: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/581 > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13175) 8.1-win crashes on
Max Kapaln created CB-13175: --- Summary: 8.1-win crashes on Key: CB-13175 URL: https://issues.apache.org/jira/browse/CB-13175 Project: Apache Cordova Issue Type: Bug Components: cordova-windows Affects Versions: Master Reporter: Max Kapaln Assignee: Jesse MacFadyen This ticket is a follow up to CB-12784 (https://issues.apache.org/jira/browse/CB-12784) The PR submitted with CB-12784 only half fixed the win8 crashing issue. The functions `colorizeTitleBar()` and `revertTitleBarColor()` exist in `template/www/cordova.js` as well and my PR takes the fix the user applied in CB-12784 and adds into `cordova.js` as well. alsorokin original fix (already merged into master): https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13175) 8.1-win crashes on startup
[ https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Kapaln updated CB-13175: Description: This ticket is a follow up to CB-12784 The PR submitted with CB-12784 only half fixed the win8 crashing issue. The functions `colorizeTitleBar()` and `revertTitleBarColor()` exist in `template/www/cordova.js` as well and my PR takes the fix the user applied in CB-12784 and adds into `cordova.js` as well. alsorokin original fix (already merged into master): https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a was: This ticket is a follow up to CB-12784 (https://issues.apache.org/jira/browse/CB-12784) The PR submitted with CB-12784 only half fixed the win8 crashing issue. The functions `colorizeTitleBar()` and `revertTitleBarColor()` exist in `template/www/cordova.js` as well and my PR takes the fix the user applied in CB-12784 and adds into `cordova.js` as well. alsorokin original fix (already merged into master): https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a > 8.1-win crashes on startup > -- > > Key: CB-13175 > URL: https://issues.apache.org/jira/browse/CB-13175 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Affects Versions: Master >Reporter: Max Kapaln >Assignee: Jesse MacFadyen > > This ticket is a follow up to CB-12784 > The PR submitted with CB-12784 only half fixed the win8 crashing issue. The > functions `colorizeTitleBar()` and `revertTitleBarColor()` exist in > `template/www/cordova.js` as well and my PR takes the fix the user applied in > CB-12784 and adds into `cordova.js` as well. > alsorokin original fix (already merged into master): > https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124051#comment-16124051 ] ASF subversion and git services commented on CB-12361: -- Commit fbad9b8ee830fd5718ebb220119bdf34a4390b7b in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fbad9b8 ] CB-12361 : added plugin remove tests > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13175) 8.1-win crashes on startup
[ https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Kapaln updated CB-13175: Summary: 8.1-win crashes on startup (was: 8.1-win crashes on ) > 8.1-win crashes on startup > -- > > Key: CB-13175 > URL: https://issues.apache.org/jira/browse/CB-13175 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Affects Versions: Master >Reporter: Max Kapaln >Assignee: Jesse MacFadyen > > This ticket is a follow up to CB-12784 > (https://issues.apache.org/jira/browse/CB-12784) > The PR submitted with CB-12784 only half fixed the win8 crashing issue. The > functions `colorizeTitleBar()` and `revertTitleBarColor()` exist in > `template/www/cordova.js` as well and my PR takes the fix the user applied in > CB-12784 and adds into `cordova.js` as well. > alsorokin original fix (already merged into master): > https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12838) Order of plugins in config.xml modified during build
[
https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124035#comment-16124035
]
ASF GitHub Bot commented on CB-12838:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132781446
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null,
2), 'utf8');
}
}
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in
content)
comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
if (pluginIdConfig.indexOf(plugID) < 0) {
pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec:
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) &&
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
+((mergedPluginSpecs[plugID] !== configXMLPlugin.spec) ||
--- End diff --
so to confirm, either `((pluginIdConfig.indexOf(plugID) > 0) &&
(mergedPluginSpecs[plugID]) &&(configXMLPlugin.variables !==
comboObject[plugID]))` or `((mergedPluginSpecs[plugID] !==
configXMLPlugin.spec) || (configXMLPlugin.variables !== comboObject[plugID]))`
need to be true
> Order of plugins in config.xml modified during build
>
>
> Key: CB-12838
> URL: https://issues.apache.org/jira/browse/CB-12838
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
> Environment: Mac OS 10.12.4, Cordova 7.0.1
>Reporter: Anton Weber
>Assignee: Audrey So
>Priority: Minor
> Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which
> plugins are listed in the config.xml (arranging them alphabetically).
> This causes problems when manually resolving dependencies, e.g. when
> installing a specific version of a dependency first by having it higher up in
> the list.
> Example:
> Original config.xml content:
> ...
>
>
>
>
>
> ...
> After cordova build:
> ...
>
>
>
>
>
> ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12838) Order of plugins in config.xml modified during build
[
https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124036#comment-16124036
]
ASF GitHub Bot commented on CB-12838:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132780476
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null,
2), 'utf8');
}
}
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in
content)
comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
if (pluginIdConfig.indexOf(plugID) < 0) {
pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec:
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) &&
(mergedPluginSpecs[plugID]) &&
--- End diff --
so this if statement, `(pluginIdConfig.indexOf(plugID) > 0)`, what if
`plugID` is in the 0th index? I think you want `>=`
> Order of plugins in config.xml modified during build
>
>
> Key: CB-12838
> URL: https://issues.apache.org/jira/browse/CB-12838
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
> Environment: Mac OS 10.12.4, Cordova 7.0.1
>Reporter: Anton Weber
>Assignee: Audrey So
>Priority: Minor
> Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which
> plugins are listed in the config.xml (arranging them alphabetically).
> This causes problems when manually resolving dependencies, e.g. when
> installing a specific version of a dependency first by having it higher up in
> the list.
> Example:
> Original config.xml content:
> ...
>
>
>
>
>
> ...
> After cordova build:
> ...
>
>
>
>
>
> ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12838) Order of plugins in config.xml modified during build
[
https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124034#comment-16124034
]
ASF GitHub Bot commented on CB-12838:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132780726
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null,
2), 'utf8');
}
}
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in
content)
comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
if (pluginIdConfig.indexOf(plugID) < 0) {
pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec:
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) &&
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
--- End diff --
I think you have an extra bracket around this one
> Order of plugins in config.xml modified during build
>
>
> Key: CB-12838
> URL: https://issues.apache.org/jira/browse/CB-12838
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
> Environment: Mac OS 10.12.4, Cordova 7.0.1
>Reporter: Anton Weber
>Assignee: Audrey So
>Priority: Minor
> Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which
> plugins are listed in the config.xml (arranging them alphabetically).
> This causes problems when manually resolving dependencies, e.g. when
> installing a specific version of a dependency first by having it higher up in
> the list.
> Example:
> Original config.xml content:
> ...
>
>
>
>
>
> ...
> After cordova build:
> ...
>
>
>
>
>
> ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13140) Support for `bundleVersion` cli option
[
https://issues.apache.org/jira/browse/CB-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123987#comment-16123987
]
Sergii Stotskyi commented on CB-13140:
--
I know but Android version also allows to pass this as cli option which is very
useful for automation builds because I don't need to read and parse xml to
change this option.
> Support for `bundleVersion` cli option
> --
>
> Key: CB-13140
> URL: https://issues.apache.org/jira/browse/CB-13140
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: 4.4.0
>Reporter: Sergii Stotskyi
>Assignee: Shazron Abdullah
>
> *Issue*:
> Add support for `bundleVersion` cli option in cordova-ios package similar to
> `--vesionCode=1` in cordova-android package
> *Actual result*:
> No way to pass `bundleVersion` as cli option for `cordova build ios`
> *Expected result*:
> when `--bundleVersion=1` is passed it should be used as `CFBundleVersion` in
> info.plist
> {code}
> cordova build ios --bundleVersion=1
> {code}
> Currently in cordova-android it's possible to do this:
> {code}
> cordova build android -- --versionCode=1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13140) Support for `bundleVersion` cli option
[
https://issues.apache.org/jira/browse/CB-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123987#comment-16123987
]
Sergii Stotskyi edited comment on CB-13140 at 8/11/17 8:29 PM:
---
I know but Android version also allows to pass this as cli option which is very
useful for automation builds because I don't need to read and parse xml to
change this attribute.
was (Author: sergii.stotskyi):
I know but Android version also allows to pass this as cli option which is very
useful for automation builds because I don't need to read and parse xml to
change this option.
> Support for `bundleVersion` cli option
> --
>
> Key: CB-13140
> URL: https://issues.apache.org/jira/browse/CB-13140
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: 4.4.0
>Reporter: Sergii Stotskyi
>Assignee: Shazron Abdullah
>
> *Issue*:
> Add support for `bundleVersion` cli option in cordova-ios package similar to
> `--vesionCode=1` in cordova-android package
> *Actual result*:
> No way to pass `bundleVersion` as cli option for `cordova build ios`
> *Expected result*:
> when `--bundleVersion=1` is passed it should be used as `CFBundleVersion` in
> info.plist
> {code}
> cordova build ios --bundleVersion=1
> {code}
> Currently in cordova-android it's possible to do this:
> {code}
> cordova build android -- --versionCode=1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12730) Compat - INTEGRATE
[ https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123973#comment-16123973 ] Simon MacDonald commented on CB-12730: -- I've created a PR for cordova-plugin-compat to prevent it from installing on projects with cordova-android 6.3.0 or greater. https://github.com/apache/cordova-plugin-compat/pull/3 > Compat - INTEGRATE > -- > > Key: CB-12730 > URL: https://issues.apache.org/jira/browse/CB-12730 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-compat >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123972#comment-16123972 ] ASF GitHub Bot commented on CB-12361: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/583 > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123971#comment-16123971 ] ASF subversion and git services commented on CB-12361: -- Commit acbd9e7547ddb0f2d632031535510e8705c08033 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=acbd9e7 ] CB-12361 : added tests for plugin/index.js > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13174) URL dependency not followed in plugin.xml
[ https://issues.apache.org/jira/browse/CB-13174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-13174: Labels: backlog tools-next (was: ) > URL dependency not followed in plugin.xml > - > > Key: CB-13174 > URL: https://issues.apache.org/jira/browse/CB-13174 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli >Affects Versions: cordova@7.0.0 >Reporter: Simon MacDonald >Priority: Minor > Labels: backlog, tools-next > > I'm using CLI 7.0.1 and I've cloned a version of cordova-plugin-camera > locally to do the test. > In my local copy of cordova-plugin-camera I modify the plugin.xml to change > the dependency tag to: > ``` > src="https://github.com/macdonst/cordova-plugin-compat-1; /> > ``` > Then I add the local copy of cordova-plugin-camera to my project via `cordova > plugin add ../cordova-plugin-camera`. When I list the plugins for the project > I get: > ``` > cordova-plugin-camera 2.4.2-dev "Camera" > cordova-plugin-compat 1.1.0 "Compat" > cordova-plugin-whitelist 1.3.2 "Whitelist" > ``` > but I'm expecting Compat to be 1.2.0-dev which is what is in the repo I'm > linking to from dependencies. > It seems like when the camera plugin is installed it reads the id of the > dependent plugin and installs it from npm instead of following the url. > Switching to: > ``` > src="https://github.com/macdonst/cordova-plugin-compat-1; /> > ``` > causes cordova-plugin-camera to fail to install. Removing the id from the > dependency tag results in this error: > Error: tag is missing id attribute in > /Users/smacdona/code/cordova/compattest/plugins/cordova-plugin-camera/plugin.xml > Using --nofetch when trying to add the plugin has no effect. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123950#comment-16123950
]
ASF subversion and git services commented on CB-12937:
--
Commit 077b1dc3c1d72ade9552773ed5a3a4c817800d37 in cordova-ios's branch
refs/heads/master from [~georgiosgalatoulas]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=077b1dc ]
CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…
(#321)
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
CB-12937 - change the NSMutableDictionary to NSDictionary with literal
declaration, added the annotation example in the CDVPlugin
* CB-12937 - revert the literal to ensure nils are not passed in the NSMutable
object
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123951#comment-16123951
]
ASF subversion and git services commented on CB-12937:
--
Commit 077b1dc3c1d72ade9552773ed5a3a4c817800d37 in cordova-ios's branch
refs/heads/master from [~georgiosgalatoulas]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=077b1dc ]
CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…
(#321)
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
CB-12937 - change the NSMutableDictionary to NSDictionary with literal
declaration, added the annotation example in the CDVPlugin
* CB-12937 - revert the literal to ensure nils are not passed in the NSMutable
object
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123949#comment-16123949
]
ASF subversion and git services commented on CB-12937:
--
Commit 077b1dc3c1d72ade9552773ed5a3a4c817800d37 in cordova-ios's branch
refs/heads/master from [~georgiosgalatoulas]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=077b1dc ]
CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…
(#321)
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
CB-12937 - change the NSMutableDictionary to NSDictionary with literal
declaration, added the annotation example in the CDVPlugin
* CB-12937 - revert the literal to ensure nils are not passed in the NSMutable
object
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah updated CB-12937:
--
Fix Version/s: (was: cordova-ios@4.5.0)
cordova-ios@4.4.1
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123948#comment-16123948
]
ASF subversion and git services commented on CB-12937:
--
Commit 077b1dc3c1d72ade9552773ed5a3a4c817800d37 in cordova-ios's branch
refs/heads/master from [~georgiosgalatoulas]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=077b1dc ]
CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…
(#321)
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
CB-12937 - change the NSMutableDictionary to NSDictionary with literal
declaration, added the annotation example in the CDVPlugin
* CB-12937 - revert the literal to ensure nils are not passed in the NSMutable
object
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah resolved CB-12937.
---
Resolution: Fixed
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12937) [iOS] Add new CDVPlugin method to handle incoming urls including sourceApplication and annotation
[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123947#comment-16123947
]
ASF subversion and git services commented on CB-12937:
--
Commit 077b1dc3c1d72ade9552773ed5a3a4c817800d37 in cordova-ios's branch
refs/heads/master from [~georgiosgalatoulas]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=077b1dc ]
CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…
(#321)
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
* CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
CB-12937 - change the NSMutableDictionary to NSDictionary with literal
declaration, added the annotation example in the CDVPlugin
* CB-12937 - revert the literal to ensure nils are not passed in the NSMutable
object
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: cordova-ios@4.4.0
>Reporter: Georgios Galatoulas
>Assignee: Shazron Abdullah
> Labels: backlog, easy-fix
> Fix For: cordova-ios@4.4.1
>
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13164) Integrate cordova-plugin-console into cordova-ios
[ https://issues.apache.org/jira/browse/CB-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123944#comment-16123944 ] ASF subversion and git services commented on CB-13164: -- Commit 990d6d883d3891f57e9fd0ec5b8d7297070f590e in cordova-ios's branch refs/heads/master from Fil Maj [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=990d6d8 ] CB-13164: Integrated cordova-plugin-console to build in support for window.console. (#330) - added native source files for CDVLogger - updated pbxproj file for CordovaLib to take the new files into account > Integrate cordova-plugin-console into cordova-ios > - > > Key: CB-13164 > URL: https://issues.apache.org/jira/browse/CB-13164 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-ios >Reporter: Filip Maj >Assignee: Filip Maj > Labels: ios-next > Fix For: cordova-ios@4.4.1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13164) Integrate cordova-plugin-console into cordova-ios
[ https://issues.apache.org/jira/browse/CB-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-13164: -- Fix Version/s: cordova-ios@4.4.1 > Integrate cordova-plugin-console into cordova-ios > - > > Key: CB-13164 > URL: https://issues.apache.org/jira/browse/CB-13164 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-ios >Reporter: Filip Maj >Assignee: Filip Maj > Labels: ios-next > Fix For: cordova-ios@4.4.1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13164) Integrate cordova-plugin-console into cordova-ios
[ https://issues.apache.org/jira/browse/CB-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-13164. --- Resolution: Fixed > Integrate cordova-plugin-console into cordova-ios > - > > Key: CB-13164 > URL: https://issues.apache.org/jira/browse/CB-13164 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-ios >Reporter: Filip Maj >Assignee: Filip Maj > Labels: ios-next > Fix For: cordova-ios@4.4.1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13174) URL dependency not followed in plugin.xml
Simon MacDonald created CB-13174: Summary: URL dependency not followed in plugin.xml Key: CB-13174 URL: https://issues.apache.org/jira/browse/CB-13174 Project: Apache Cordova Issue Type: Bug Components: cordova-cli Affects Versions: cordova@7.0.0 Reporter: Simon MacDonald Priority: Minor I'm using CLI 7.0.1 and I've cloned a version of cordova-plugin-camera locally to do the test. In my local copy of cordova-plugin-camera I modify the plugin.xml to change the dependency tag to: ``` https://github.com/macdonst/cordova-plugin-compat-1; /> ``` Then I add the local copy of cordova-plugin-camera to my project via `cordova plugin add ../cordova-plugin-camera`. When I list the plugins for the project I get: ``` cordova-plugin-camera 2.4.2-dev "Camera" cordova-plugin-compat 1.1.0 "Compat" cordova-plugin-whitelist 1.3.2 "Whitelist" ``` but I'm expecting Compat to be 1.2.0-dev which is what is in the repo I'm linking to from dependencies. It seems like when the camera plugin is installed it reads the id of the dependent plugin and installs it from npm instead of following the url. Switching to: ``` https://github.com/macdonst/cordova-plugin-compat-1; /> ``` causes cordova-plugin-camera to fail to install. Removing the id from the dependency tag results in this error: Error: tag is missing id attribute in /Users/smacdona/code/cordova/compattest/plugins/cordova-plugin-camera/plugin.xml Using --nofetch when trying to add the plugin has no effect. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123853#comment-16123853
]
ASF GitHub Bot commented on CB-12361:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/581#discussion_r132758854
--- Diff: spec/cordova/plugin/remove.spec.js ---
@@ -32,18 +66,123 @@ describe('cordova/plugin/remove', function () {
expect(e.message).toContain('No plugin specified');
}).done(done);
});
-it('should require that a provided plugin be installed in the
current project');
+
+it('should require that a provided plugin be installed in the
current project', function (done) {
+var opts = { plugins: [ undefined ] };
+remove(projectRoot, 'plugin', hook_mock, opts).then(function
() {
+fail('success handler unexpectedly invoked');
+}).fail(function (e) {
+expect(e.message).toContain('is not present in the
project');
+}).done(done);
+});
});
describe('happy path', function () {
-it('should fire the before_plugin_rm hook');
-it('should call plugman.uninstall.uninstallPlatform for each
platform installed in the project and for each provided plugin');
-it('should trigger a prepare if
plugman.uninstall.uninstallPlatform returned something falsy');
-it('should call plugman.uninstall.uninstallPlugin once plugin has
been uninstalled for each platform');
+it('should fire the before_plugin_rm hook', function (done) {
+var opts = { important: 'options', plugins: [] };
+remove(projectRoot, 'cordova-plugin-splashscreen', hook_mock,
opts).then(function () {
+
expect(hook_mock.fire).toHaveBeenCalledWith('before_plugin_rm', opts);
+}).fail(function (e) {
+fail('fail handler unexpectedly invoked');
+console.error(e);
+}).done(done);
+});
+
+it('should call plugman.uninstall.uninstallPlatform for each
platform installed in the project and for each provided plugin', function
(done) {
+
remove.validatePluginId.and.returnValue('cordova-plugin-splashscreen');
+var opts = {important: 'options', plugins:
['cordova-plugin-splashscreen']};
+remove(projectRoot, 'cordova-plugin-splashscreen', hook_mock,
opts).then(function () {
+
expect(plugman.uninstall.uninstallPlatform).toHaveBeenCalled();
+expect(events.emit).toHaveBeenCalledWith('verbose',
jasmine.stringMatching('plugman.uninstall on plugin
"cordova-plugin-splashscreen" for platform "ios"'));
+expect(events.emit).toHaveBeenCalledWith('verbose',
jasmine.stringMatching('plugman.uninstall on plugin
"cordova-plugin-splashscreen" for platform "android"'));
+}).fail(function (e) {
+fail('fail handler unexpectedly invoked');
+console.error(e);
+}).done(done);
+});
+
+it('should trigger a prepare if
plugman.uninstall.uninstallPlatform returned something falsy', function (done) {
+
remove.validatePluginId.and.returnValue('cordova-plugin-splashscreen');
+plugman.uninstall.uninstallPlatform.and.returnValue(Q(false));
+var opts = {important: 'options', plugins:
['cordova-plugin-splashscreen']};
+remove(projectRoot, 'cordova-plugin-splashscreen', hook_mock,
opts).then(function () {
+
expect(plugman.uninstall.uninstallPlatform).toHaveBeenCalled();
+expect(events.emit).toHaveBeenCalledWith('verbose',
'Calling prepare.');
--- End diff --
i'd suggest removing this expect event due to my other comment
> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123852#comment-16123852
]
ASF GitHub Bot commented on CB-12361:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/581#discussion_r132758763
--- Diff: src/cordova/plugin/remove.js ---
@@ -68,6 +68,7 @@ function remove (projectRoot, targets, hooksRunner, opts)
{
// If platform does not returned anything
we'll need
// to trigger a prepare after all plugins
installed
// TODO: if didPrepare is falsy, what does
that imply? WHY are we doing this?
+events.emit('verbose', 'Calling prepare.');
--- End diff --
I think you might want to remove this event. Since Prepare will only be
called if `didPrepare` is falsy. So you could get the output `calling prepare`
when you actually don't call prepare
> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123791#comment-16123791 ] ASF GitHub Bot commented on CB-12361: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/577 > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123790#comment-16123790 ] ASF subversion and git services commented on CB-12361: -- Commit 9cdc0f2b1af7663a3db2659ef279d97164f8991a in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=9cdc0f2 ] CB-12361 : added tests for list platform > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12904) Add docs to config.xml
[ https://issues.apache.org/jira/browse/CB-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123789#comment-16123789 ] Shazron Abdullah commented on CB-12904: --- I don't think it has, I tested doc gen locally to make sure it worked but I think it was waiting on the next doc release. > Add docs to config.xml > > > Key: CB-12904 > URL: https://issues.apache.org/jira/browse/CB-12904 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Related: CB-11908 > Just have an internal link pointing to plugin.xml docs for edit-config -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13140) Support for `bundleVersion` cli option
[
https://issues.apache.org/jira/browse/CB-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123760#comment-16123760
]
Shazron Abdullah commented on CB-13140:
---
We have support for this through the {{ios-CFBundleVersion}} attribute for the
{{widget}} tag in config.xml currently:
https://cordova.apache.org/docs/en/latest/config_ref/#widget
> Support for `bundleVersion` cli option
> --
>
> Key: CB-13140
> URL: https://issues.apache.org/jira/browse/CB-13140
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Affects Versions: 4.4.0
>Reporter: Sergii Stotskyi
>Assignee: Shazron Abdullah
>
> *Issue*:
> Add support for `bundleVersion` cli option in cordova-ios package similar to
> `--vesionCode=1` in cordova-android package
> *Actual result*:
> No way to pass `bundleVersion` as cli option for `cordova build ios`
> *Expected result*:
> when `--bundleVersion=1` is passed it should be used as `CFBundleVersion` in
> info.plist
> {code}
> cordova build ios --bundleVersion=1
> {code}
> Currently in cordova-android it's possible to do this:
> {code}
> cordova build android -- --versionCode=1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12397) fix .gitignore for plugins & platforms in app template
[ https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12397: Labels: backlog (was: ) > fix .gitignore for plugins & platforms in app template > -- > > Key: CB-12397 > URL: https://issues.apache.org/jira/browse/CB-12397 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world, cordova-cli, cordova-create, > cordova-lib >Reporter: Chris Brody > Labels: backlog, easy-fix > > Followup to CB-12008 (autosave by default in cordova@7): if a user creates an > app using "cordova create" there should be a .gitignore file to exclude the > plugins and platforms artifacts from git. > I raise this since I have seen way too many apps with outdated plugins / > platforms artifacts included in git. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12397) fix .gitignore for plugins & platforms in app template
[ https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12397: Labels: backlog easy-fix (was: backlog) > fix .gitignore for plugins & platforms in app template > -- > > Key: CB-12397 > URL: https://issues.apache.org/jira/browse/CB-12397 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world, cordova-cli, cordova-create, > cordova-lib >Reporter: Chris Brody > Labels: backlog, easy-fix > > Followup to CB-12008 (autosave by default in cordova@7): if a user creates an > app using "cordova create" there should be a .gitignore file to exclude the > plugins and platforms artifacts from git. > I raise this since I have seen way too many apps with outdated plugins / > platforms artifacts included in git. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123715#comment-16123715 ] ASF GitHub Bot commented on CB-12361: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/582 > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123713#comment-16123713 ] ASF subversion and git services commented on CB-12361: -- Commit f399c739bc6ed2a6dcc96eff8bd93a058e5122a8 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f399c73 ] CB-12361 : added tests for plugin/search.js and rebased > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123709#comment-16123709
]
ASF GitHub Bot commented on CB-12361:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/577#discussion_r132738598
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,75 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('cordova-common').events;
+var Q = require('q');
+var rewire = require('rewire');
+var platform_list = rewire('../../../src/cordova/platform/list');
--- End diff --
i don't think you use rewire anywhere in this file
> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123708#comment-16123708
]
ASF GitHub Bot commented on CB-12361:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/577#discussion_r132742737
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,75 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('cordova-common').events;
+var Q = require('q');
+var rewire = require('rewire');
+var platform_list = rewire('../../../src/cordova/platform/list');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var fail;
+
+describe('cordova/platform/list', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+spyOn(cordova_util,
'getInstalledPlatformsWithVersions').and.callThrough();
+spyOn(events, 'emit');
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+
+it('should fire the before_platform_ls hook', function () {
+platform_list(hooks_mock, projectRoot, {save: true});
+expect(hooks_mock.fire).toHaveBeenCalledWith('before_platform_ls',
Object({ save: true }));
+});
+
+it('should file the after_platform_ls hook', function (done) {
--- End diff --
type. Should be fire
> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123640#comment-16123640
]
ASF GitHub Bot commented on CB-12361:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/582#discussion_r132736159
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
console.error(e);
}).done(done);
});
-it('should open a link to cordova.apache.org/plugins if no plugins are
provided as parameter');
-it('should open a link to cordova.apache.org/plugins, providing the
plugins passed in as a query-string parameter');
-it('should fire the after_plugin_search hook');
+
+it('should open a link to cordova.apache.org/plugins if no plugins are
provided as parameter', function (done) {
+var opts = {important: 'options', plugins: []};
+search(hook_mock, opts).then(function () {
+expect(opener_mock).toHaveBeenCalled();
+}).fail(function (e) {
+console.log(e);
+fail('fail handler unexpectedly invoked');
+console.error(e);
+}).done(done);
+});
+
+it('should open a link to cordova.apache.org/plugins, providing the
plugins passed in as a query-string parameter', function (done) {
+var opts = {important: 'options', plugins:
['cordova-plugin-camera', 'cordova-plugin-splashscreen']};
+search(hook_mock, opts).then(function () {
+expect(opener_mock).toHaveBeenCalled();
+}).fail(function (e) {
+console.log(e);
--- End diff --
same
> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123639#comment-16123639
]
ASF GitHub Bot commented on CB-12361:
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/582#discussion_r132736117
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
console.error(e);
}).done(done);
});
-it('should open a link to cordova.apache.org/plugins if no plugins are
provided as parameter');
-it('should open a link to cordova.apache.org/plugins, providing the
plugins passed in as a query-string parameter');
-it('should fire the after_plugin_search hook');
+
+it('should open a link to cordova.apache.org/plugins if no plugins are
provided as parameter', function (done) {
+var opts = {important: 'options', plugins: []};
+search(hook_mock, opts).then(function () {
+expect(opener_mock).toHaveBeenCalled();
+}).fail(function (e) {
+console.log(e);
--- End diff --
Don't think you need console.log(e) since you console.error two lines below
> Speed up cordova-lib tests
> --
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13171) Camera doesn't launch in android 7
[ https://issues.apache.org/jira/browse/CB-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123609#comment-16123609 ] Matias Guido Doto commented on CB-13171: Thank you again for your help! > Camera doesn't launch in android 7 > -- > > Key: CB-13171 > URL: https://issues.apache.org/jira/browse/CB-13171 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 > Environment: android 7.0.0 / 7.0.1 (Nugat) - devices Motorola and > Samsung with same OS >Reporter: Matias Guido Doto >Assignee: Joe Bowser > Labels: beginner, performance > Fix For: 7.0.1 > > > When i press the button that contain the event that launch the camera, > nothing happens. But, when i try the same app in an older version of the OS, > it works! > plugins --> > > > > > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13171) Camera doesn't launch in android 7
[ https://issues.apache.org/jira/browse/CB-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123555#comment-16123555 ] Jan Piotrowski commented on CB-13171: - This is most probably not a Cordova problem. You should probably post at https://forum.ionicframework.com/ and comment the link to the topic you created here. The community there will help you debug this Ionic specific problem. > Camera doesn't launch in android 7 > -- > > Key: CB-13171 > URL: https://issues.apache.org/jira/browse/CB-13171 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 > Environment: android 7.0.0 / 7.0.1 (Nugat) - devices Motorola and > Samsung with same OS >Reporter: Matias Guido Doto >Assignee: Joe Bowser > Labels: beginner, performance > Fix For: 7.0.1 > > > When i press the button that contain the event that launch the camera, > nothing happens. But, when i try the same app in an older version of the OS, > it works! > plugins --> > > > > > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13171) Camera doesn't launch in android 7
[ https://issues.apache.org/jira/browse/CB-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123474#comment-16123474 ] Matias Guido Doto edited comment on CB-13171 at 8/11/17 3:28 PM: - Hello! Sorry about my bad english. This error happens when i run the app through "ionic View". When i run on browser platform or through ionic view in older versions of Android, it works fine. How can i get this logcat files? Sorry about my lack of knowledge. Thank you for your help! was (Author: matiid): Hello! Sorry about my bad english. This error happens when i run the app through "ionic View". When i run on browser platform or through ionic view in older versions of Android, it works fine. How can i get this logcat files? Sorry about my lack of knowledge. > Camera doesn't launch in android 7 > -- > > Key: CB-13171 > URL: https://issues.apache.org/jira/browse/CB-13171 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 > Environment: android 7.0.0 / 7.0.1 (Nugat) - devices Motorola and > Samsung with same OS >Reporter: Matias Guido Doto >Assignee: Joe Bowser > Labels: beginner, performance > Fix For: 7.0.1 > > > When i press the button that contain the event that launch the camera, > nothing happens. But, when i try the same app in an older version of the OS, > it works! > plugins --> > > > > > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13171) Camera doesn't launch in android 7
[ https://issues.apache.org/jira/browse/CB-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123474#comment-16123474 ] Matias Guido Doto commented on CB-13171: Hello! Sorry about my bad english. This error happens when i run the app through "ionic View". When i run on browser platform or through ionic view in older versions of Android, it works fine. How can i get this logcat files? Sorry about my lack of knowledge. > Camera doesn't launch in android 7 > -- > > Key: CB-13171 > URL: https://issues.apache.org/jira/browse/CB-13171 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 > Environment: android 7.0.0 / 7.0.1 (Nugat) - devices Motorola and > Samsung with same OS >Reporter: Matias Guido Doto >Assignee: Joe Bowser > Labels: beginner, performance > Fix For: 7.0.1 > > > When i press the button that contain the event that launch the camera, > nothing happens. But, when i try the same app in an older version of the OS, > it works! > plugins --> > > > > > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12730) Compat - INTEGRATE
[ https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123428#comment-16123428 ] ASF subversion and git services commented on CB-12730: -- Commit d364f46baa48aee013412b18b94403868baf5f5f in cordova-android's branch refs/heads/master from [~macdonst] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=d364f46 ] CB-12730: Compat - INTEGRATE > Compat - INTEGRATE > -- > > Key: CB-12730 > URL: https://issues.apache.org/jira/browse/CB-12730 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-compat >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12730) Compat - INTEGRATE
[ https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123430#comment-16123430 ] ASF subversion and git services commented on CB-12730: -- Commit 14816c7c816764fe3a422cd594c68050382e2072 in cordova-android's branch refs/heads/master from [~macdonst] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=14816c7 ] Merge pull request #399 from macdonst/CB-12730 CB-12730: Compat - INTEGRATE > Compat - INTEGRATE > -- > > Key: CB-12730 > URL: https://issues.apache.org/jira/browse/CB-12730 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-compat >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12730) Compat - INTEGRATE
[ https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123429#comment-16123429 ] ASF subversion and git services commented on CB-12730: -- Commit 14816c7c816764fe3a422cd594c68050382e2072 in cordova-android's branch refs/heads/master from [~macdonst] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=14816c7 ] Merge pull request #399 from macdonst/CB-12730 CB-12730: Compat - INTEGRATE > Compat - INTEGRATE > -- > > Key: CB-12730 > URL: https://issues.apache.org/jira/browse/CB-12730 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-compat >Reporter: Shazron Abdullah >Assignee: Simon MacDonald > > See parent issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13173) Project's plugin definitions/files when nofetch issue and plugins all around the place. Consistency.
Juan Carlos ANdreu created CB-13173: --- Summary: Project's plugin definitions/files when nofetch issue and plugins all around the place. Consistency. Key: CB-13173 URL: https://issues.apache.org/jira/browse/CB-13173 Project: Apache Cordova Issue Type: Bug Components: cordova-cli, cordova-plugins Affects Versions: 7.0.1 Environment: Windows 10, C 7.0.1 Reporter: Juan Carlos ANdreu Priority: Blocker Hello, Main issue here is that if I add a plugin with nofetch so it gets it from git for example (vla clone), it works as expected initially. The plugin is not added in the project.json dependencies, but just in cordova.plugins:[]. Good. But then if any platform is removed and readded, the nofetch plugins are added to project.json's dependencies and causes an issue when doing npm install, or removing any platform. I can see how after adding android platform, it adds the line for "cordova-android": "^6.2.3" and then starts to install the plugins specified in config.xml. But it goes for all plugins, even those added as nofetch. So I have to manually remove those plugins by hand. While doing this I notice that there are too many places where plugins are defined. config.xml, project.json dependencies and cordova.plugins:[] Then they go to ./plugins/fetch and ./plugins/ Code is downloaded in ./node_modules/ , ./plugins/ and ./platforms// I think cordova needs a bit of consistency , specially in the plugins area. Why include all plugins everywhere and not in something like cordova.plugins.json file? Why not have eveything in that schema, like cordova.platforms.json, cordova.config.json etc That way we can get stuff a bit more organized. Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13171) Camera doesn't lunch in android 7
[ https://issues.apache.org/jira/browse/CB-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123058#comment-16123058 ] Joe Bowser commented on CB-13171: - Can you provide some more information, like the output of your logcat when you attempt to do this? That would help us figure out what's happening with your device. > Camera doesn't lunch in android 7 > - > > Key: CB-13171 > URL: https://issues.apache.org/jira/browse/CB-13171 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 > Environment: android 7.0.0 / 7.0.1 (Nugat) - devices Motorola and > Samsung with same OS >Reporter: Matias Guido Doto >Assignee: Joe Bowser > Labels: beginner, performance > Fix For: 7.0.1 > > > When i press the button that contain the event that launch the camera, > nothing happens. But, when i try the same app in an older version of the OS, > it works! > plugins --> > > > > > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13171) Camera doesn't launch in android 7
[ https://issues.apache.org/jira/browse/CB-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-13171: Summary: Camera doesn't launch in android 7 (was: Camera doesn't lunch in android 7) > Camera doesn't launch in android 7 > -- > > Key: CB-13171 > URL: https://issues.apache.org/jira/browse/CB-13171 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 > Environment: android 7.0.0 / 7.0.1 (Nugat) - devices Motorola and > Samsung with same OS >Reporter: Matias Guido Doto >Assignee: Joe Bowser > Labels: beginner, performance > Fix For: 7.0.1 > > > When i press the button that contain the event that launch the camera, > nothing happens. But, when i try the same app in an older version of the OS, > it works! > plugins --> > > > > > > > > > > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13172) Ionic + iOS + Cordova not getting updated timezone if device timezone changes automatically
Shashwat Tripathi created CB-13172: -- Summary: Ionic + iOS + Cordova not getting updated timezone if device timezone changes automatically Key: CB-13172 URL: https://issues.apache.org/jira/browse/CB-13172 Project: Apache Cordova Issue Type: Bug Environment: iOS + Cordova Reporter: Shashwat Tripathi My app is related to weather condition that is used by pilots during flight. If user flew to a place with a different time zone, and his local device time zone changed, but my app didn’t pick up that his device time zone changed. Even tried force quit and restart up the app never detected the new time zone value. But If I manually change the time-zone from settings then application detects correct time-zone value. What can be an issue? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13068) Sunset cordova-plugin-device-motion
[ https://issues.apache.org/jira/browse/CB-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122972#comment-16122972 ] ASF GitHub Bot commented on CB-13068: - Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591 --- Diff: README.md --- @@ -27,6 +27,18 @@ description: Access accelerometer data. # cordova-plugin-device-motion +# Deprecation Notice + +With the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now +being supported on iOS, Android and Windows devices, this plugin is not needed any more. Migrating from this +plugin to the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) +is explained in this [PhoneGap blog post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed). --- End diff -- Why a Phonegap blogpost on a Cordova plugin deprecation? Shouldn't there at least be a Cordova "we deprecate those plugins" blog post linked here and then maybe additionally a Phonegap blogpost with "this is how you do it now" (although I would of course prefer those at Cordova as well, much less confusing for users re Cordova/Phonegap). > Sunset cordova-plugin-device-motion > --- > > Key: CB-13068 > URL: https://issues.apache.org/jira/browse/CB-13068 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-device-motion >Reporter: Filip Maj >Assignee: Vishal Mishra > Labels: plugins-next > > Todo (see subtasks): > 1. Deprecate JIRA components. > 2. Close out all github PRs and JIRA issues. > 3. What do we need to inform Apache Infra of? > 4. Update plugin README to reflect status of plugin and point to transition > blog post. > 5. Update coho to remove any references to the plugin. > 6. Update cordova-docs to remove plugin references / remove code generation > around cordova-plugin-device-motion > 7. Do one final release of the plugin. > 8. Ensure we deprecate the plugin in npm. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
