[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602511#comment-16602511 ] ASF GitHub Bot commented on CB-14140: - dpogue commented on issue #613: CB-14140 Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418212275 :tada: Thanks so much for your work on finishing this! :bowing_man: Do you want these squashed when merging, or kept as distinct commits for historical clarity? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602443#comment-16602443 ] ASF GitHub Bot commented on CB-14140: - raphinesse commented on issue #613: CB-14140 WIP: Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418190911 It is done! :champagne: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14172) save-exact preferences from .npmrc should be overridden
[ https://issues.apache.org/jira/browse/CB-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Salzburg resolved CB-14172. -- Resolution: Invalid .npmrc should be respected. The tests need to be adjusted. > save-exact preferences from .npmrc should be overridden > --- > > Key: CB-14172 > URL: https://issues.apache.org/jira/browse/CB-14172 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: 1.3.0 >Reporter: Oliver Salzburg >Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > When I add `save-exact=true` to my `.npmrc` and run the test suite for > cordova-fetch, it will fail, because the exact 5.1.1 version will be > persisted to the `package.json` instead of the expected semver range `^5.1.1`. > `save-exact` should be disabled explicitly by default unless the related > option was provided. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11347) Document Platform API
[ https://issues.apache.org/jira/browse/CB-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602215#comment-16602215 ] ASF subversion and git services commented on CB-11347: -- Commit 147299a504a52773854cecd0b7b96aee4829d725 in cordova-test-platform's branch refs/heads/master from Fil Maj [ https://gitbox.apache.org/repos/asf?p=cordova-test-platform.git;h=147299a ] CB-11347: a bit more documentation around platform API and additional reading. (#2) > Document Platform API > - > > Key: CB-11347 > URL: https://issues.apache.org/jira/browse/CB-11347 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs, cordova-lib >Reporter: Shazron Abdullah >Priority: Major > Labels: triaged > > Right now the Platform API is undocumented. Emerging platforms need to read > the source to find out how it all works. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11347) Document Platform API
[ https://issues.apache.org/jira/browse/CB-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602216#comment-16602216 ] ASF GitHub Bot commented on CB-11347: - janpio closed pull request #2: CB-11347: a bit more documentation around platform API URL: https://github.com/apache/cordova-test-platform/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index afaf50d..efc10c0 100644 --- a/README.md +++ b/README.md @@ -21,14 +21,27 @@ # cordova-test-platform -This repo contains the code for an [Apache Cordova](http://cordova.apache.org) platform that allows you to build applications that target NOTHING. This platform is purely for testing, although it is also a good resource to see the minimum requirements to implement a new platform. - +This repo contains the code for an [Apache Cordova](http://cordova.apache.org) +platform that allows you to build applications that target NOTHING. This +platform is purely for testing, although it is also a good resource to see the +minimum requirements to implement a new platform. [Apache Cordova](http://cordova.apache.org) is a project of [The Apache Software Foundation (ASF)](http://apache.org) +# How to Use This + +This repository contains a reference implementation of Cordova's Platform API. +The Platform API defines interfaces for Cordova tooling to be able to create, +build/compile, run/emulate and clean Cordova projects targeted at a specific +platform. Core Cordova platforms such as cordova-android and cordova-ios +implement this API. This API is then used by tools such as cordova-cli and +cordova-lib when managing platform-specific actions in cross-platform Cordova +projects. # Report Issues Report them at the [Apache Cordova Issue Tracker](https://issues.apache.org/jira/browse/CB). # Further Reading -- [Apache Cordova Documentation](http://docs.cordova.io) \ No newline at end of file +- [Apache Cordova Documentation](http://docs.cordova.io) +- https://github.com/cordova/cordova-discuss/pull/9 +- https://github.com/cordova/cordova-discuss/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Document Platform API > - > > Key: CB-11347 > URL: https://issues.apache.org/jira/browse/CB-11347 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs, cordova-lib >Reporter: Shazron Abdullah >Priority: Major > Labels: triaged > > Right now the Platform API is undocumented. Emerging platforms need to read > the source to find out how it all works. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9461) Cordova-Ubuntu Platform Release August 5, 2015
[ https://issues.apache.org/jira/browse/CB-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602206#comment-16602206 ] ASF GitHub Bot commented on CB-9461: janpio closed pull request #12: CB-9461 updated RELEASENOTES URL: https://github.com/apache/cordova-ubuntu/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 8e69c2a..693878a 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -20,6 +20,31 @@ --> ## Release Notes for Cordova Ubuntu ## +### 4.1.0 ### + +* CB-8965 Copy cordova-js-src directory to platform folder during create. This closes #11 +* add default icon +* build: split error message +* use 1.3 policy_version for ubuntu-sdk-15.04+ +* fix desktop file generator +* support ubuntu-sdk-15.04 +* CordovaViewInternal: provide ItemSelector for oxide +* build: misc fix +* build: suggest to install dependencies automatically +* support Orientation preference from config.xml +* add custom hooks into manifest.js +* CB-8417 moved platform specific js into platform +* Update JS snapshot to version 4.1.0-dev (via coho) +* Set VERSION to 4.1.0-dev (via coho) + +### 4.0.0 ### + +* port to oxide +* implement uri whitelist +* set ubuntu-sdk-14.10 as default framework +* ubuntu 14.10 support +* code cleanups + ### 3.6.0 ### * Set VERSION to 3.6.0 (via coho) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Ubuntu Platform Release August 5, 2015 > -- > > Key: CB-9461 > URL: https://issues.apache.org/jira/browse/CB-9461 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602192#comment-16602192 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214696483 ## File path: plugin.xml ## @@ -76,11 +76,31 @@ + Review comment: It just ensures that the default values defined by [`pluginInitialize()`](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L31) are set right away at app startup. I don't remember the exact reason it was needed (it's been a few months since I created this PR) but I'm pretty sure it was necessary. The change is minimal and will not cause side effects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602190#comment-16602190 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214695523 ## File path: README.md ## @@ -136,9 +136,10 @@ instance, or the system browser. iOS supports these additional options: +- __usewkwebview__: set to `yes` to use WKWebView engine for the InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this requires that a WKWebView engine plugin be installed in the Cordova project (e.g. [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine) or [cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)). Review comment: OK, I've made tweaks based on those suggestions This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602152#comment-16602152 ] ASF GitHub Bot commented on CB-7179: janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684105 ## File path: plugin.xml ## @@ -76,11 +76,31 @@ + Review comment: I learned something, thanks ;) Why this change? Could this have any side effects? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602151#comment-16602151 ] ASF GitHub Bot commented on CB-7179: janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684105 ## File path: plugin.xml ## @@ -76,11 +76,31 @@ + Review comment: I learned something, thanks ;) Why this change? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602148#comment-16602148 ] ASF GitHub Bot commented on CB-7179: janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684017 ## File path: README.md ## @@ -136,9 +136,10 @@ instance, or the system browser. iOS supports these additional options: +- __usewkwebview__: set to `yes` to use WKWebView engine for the InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this requires that a WKWebView engine plugin be installed in the Cordova project (e.g. [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine) or [cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)). Review comment: Ah, got it. 2 suggestions: 1. Change "this" in the note to "Using `usewkwebview=yes` requires ..." 2. Change the `loaderror` callback to not refer to the specific plugin, but just mention "... but no plugin that supplies a WKWebView engine present" (or similar) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602139#comment-16602139 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214682563 ## File path: plugin.xml ## @@ -76,11 +76,31 @@ + Review comment: `onload` specifies whether to initialize the plugin when the app controller initializes. There's some [docs about it here](https://cordova.apache.org/docs/en/latest/config_ref/index.html#feature). It ensures that [`pluginInitialize()`](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L31) is called on app startup, rather than the first plugin invocation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602127#comment-16602127 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214681185 ## File path: README.md ## @@ -136,9 +136,10 @@ instance, or the system browser. iOS supports these additional options: +- __usewkwebview__: set to `yes` to use WKWebView engine for the InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this requires that a WKWebView engine plugin be installed in the Cordova project (e.g. [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine) or [cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)). Review comment: If `usewkwebview=yes` and no WKWebView plugin is installed, [the `loaderror` callback will be invoked](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L48) with the error message "usewkwebview option specified but cordova-plugin-wkwebview-engine not present" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602121#comment-16602121 ] ASF GitHub Bot commented on CB-7179: janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214673605 ## File path: plugin.xml ## @@ -76,11 +76,31 @@ + Review comment: What does this `onload` param do? Couldn't find it anywhere else. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602120#comment-16602120 ] ASF GitHub Bot commented on CB-7179: janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214673605 ## File path: plugin.xml ## @@ -76,11 +76,31 @@ + Review comment: What does this `onload` param do? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602119#comment-16602119 ] ASF GitHub Bot commented on CB-7179: janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214673155 ## File path: README.md ## @@ -136,9 +136,10 @@ instance, or the system browser. iOS supports these additional options: +- __usewkwebview__: set to `yes` to use WKWebView engine for the InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this requires that a WKWebView engine plugin be installed in the Cordova project (e.g. [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine) or [cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)). Review comment: What will happen if no WKWebView plugin is installed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602098#comment-16602098 ] ASF GitHub Bot commented on CB-7179: dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-418098522 I have done my part and resolved the existing merge conflicts. Hopefully the rest of the steps can follow before more conflicts arise. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602069#comment-16602069 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-418090998 As soon as 1) @dpa99c had the time to fix the conflicts, 2) someone or multiple ones from Apache Cordova (or the community, like you @rafaelberrocalj!) had time to test and review (hopefully with Approval), 3) then someone from Apache Cordova who takes the responsibility of merging the PR and finally 4) someone from Apache Cordova creates a new release of the plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602068#comment-16602068 ] ASF GitHub Bot commented on CB-7179: rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-418090242 Hi, any news when this PR will be merged and released into a new version? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14198) Error when running simulate with --target parameter on non-US windows 10
[
https://issues.apache.org/jira/browse/CB-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601895#comment-16601895
]
ASF GitHub Bot commented on CB-14198:
-
raphinesse commented on a change in pull request #11: CB-14198: (all) Fix bug
when running simulate --target= under non-US…
URL: https://github.com/apache/cordova-serve/pull/11#discussion_r214612888
##
File path: src/browser.js
##
@@ -198,7 +198,7 @@ function edgeSupported () {
return prom;
}
-var regItemPattern = /\s*\(Default\)\s+(REG_SZ)\s+([^\s].*)\s*/;
+var regItemPattern = /\s*\(.*\)\s+(REG_SZ)\s+([^\s].*)\s*/;
Review comment:
I think this should use `[^)]+` or `.+?` instead of `.*`. Otherwise the
match could extend over the closing parenthesis.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Error when running simulate with --target parameter on non-US windows 10
>
>
> Key: CB-14198
> URL: https://issues.apache.org/jira/browse/CB-14198
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-serve
>Affects Versions: cordova-serve@2.0.1
> Environment: * Windows 10 German Version 1703
> * cordova@8.0.0
> * cordova-simulate@0.4.0
> * cordova-serve@2.0.1
>Reporter: Peter Kläs
>Priority: Major
> Labels: windows
>
> When running cordova simulate with a specific browser, e.g.
> {code:java}
> simulate android --target=chrome
> {code}
> the simulation does not start but instead throws an error:
> {code:java}
> C:\Users\pk\AppData\Roaming\npm\node_modules\cordova-simulate\node_modules\cordova-serve\src\browser.js:224
> if (fs.existsSync(trimRegPath(result[2]))) {
> ^
> TypeError: Cannot read property '2' of null
> at
> C:\Users\pk\AppData\Roaming\npm\node_modules\cordova-simulate\node_modules\cordova-serve\src\browser.js:224:57
> at ChildProcess.exithandler (child_process.js:267:7)
> at emitTwo (events.js:126:13)
> at ChildProcess.emit (events.js:214:7)
> at maybeClose (internal/child_process.js:925:16)
> at Socket.stream.socket.on (internal/child_process.js:346:11)
> at emitOne (events.js:116:13)
> at Socket.emit (events.js:211:7)
> at Pipe._handle.close [as _onclose] (net.js:557:12)
> {code}
> Reason is a language-dependent result from reg.exe when querying the
> path/to/browser in the regex line 201 in browser.js.The output from reg.exe
> for chrome (parameter stdout) is in my configuration:
> {code:java}
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App
> Paths\chrome.EXE
> (Standard) REG_SZ C:\Program Files
> (x86)\Google\Chrome\Application\chrome.exe
> {code}
> But the code expects (Note (Standard) vs. (Default)) :
> {code:java}
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App
> Paths\chrome.EXE
> (Default) REG_SZ C:\Program Files
> (x86)\Google\Chrome\Application\chrome.exe
> {code}
> To fix, i would suggest changing the regex in
> [https://github.com/apache/cordova-serve/blob/1667227ce3706cc0a27c065a300bce083c3799ee/src/browser.js#L201]
> from
> {code:javascript}
> var regItemPattern = /\s*\(Default\)\s+(REG_SZ)\s+([^\s].*)\s*/;
> {code}
> to
> {code:javascript}
> var regItemPattern = /\s*\(.*\)\s+(REG_SZ)\s+([^\s].*)\s*/;
> {code}
> to match most translations.
> Regards
> Peter
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14191) Project does not include the specified platform: android error.
[ https://issues.apache.org/jira/browse/CB-14191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601885#comment-16601885 ] ASF GitHub Bot commented on CB-14191: - raphinesse commented on issue #10: CB-14191 (android) Fix bug with module requiring URL: https://github.com/apache/cordova-serve/pull/10#issuecomment-418040427 Thanks for the fix and sorry for the long wait. :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Project does not include the specified platform: android error. > --- > > Key: CB-14191 > URL: https://issues.apache.org/jira/browse/CB-14191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-serve >Affects Versions: cordova-serve@2.0.1 > Environment: OS: Ubuntu 16.04 > Cordova CLI: 8.0.0 > >Reporter: Ruslan Bikkinin >Priority: Major > > Code on this this line: > [https://github.com/apache/cordova-serve/blob/master/src/util.js#L81] is > trying to require `cordova/api` module but actual filename generated by > cordova is Api.js and no file is being found on case-sensitive file systems > like ext4. It leads to _Project does not include the specified platform: > android_ error. > To reproduce issue please do the following: > > # Make sure that you are using case-sensitive file system > # Clone demo repo: https://github.com/ruslan-bikkinin/cordova-serve-repro > # cd cordova-serve-repro > # npm i > # node serve > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14191) Project does not include the specified platform: android error.
[
https://issues.apache.org/jira/browse/CB-14191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601883#comment-16601883
]
ASF GitHub Bot commented on CB-14191:
-
raphinesse closed pull request #10: CB-14191 (android) Fix bug with module
requiring
URL: https://github.com/apache/cordova-serve/pull/10
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/util.js b/src/util.js
index 57cdef2..fdb92fa 100644
--- a/src/util.js
+++ b/src/util.js
@@ -78,7 +78,7 @@ function getPlatformWwwRoot (cordovaProjectRoot,
platformName) {
}
try {
-var Api = require(path.join(cordovaProjectRoot, 'platforms',
platformName, 'cordova/api'));
+var Api = require(path.join(cordovaProjectRoot, 'platforms',
platformName, 'cordova/Api'));
return new Api().locations.www;
} catch (e) {
// Fallback on hardcoded paths if platform api not found
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Project does not include the specified platform: android error.
> ---
>
> Key: CB-14191
> URL: https://issues.apache.org/jira/browse/CB-14191
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-serve
>Affects Versions: cordova-serve@2.0.1
> Environment: OS: Ubuntu 16.04
> Cordova CLI: 8.0.0
>
>Reporter: Ruslan Bikkinin
>Priority: Major
>
> Code on this this line:
> [https://github.com/apache/cordova-serve/blob/master/src/util.js#L81] is
> trying to require `cordova/api` module but actual filename generated by
> cordova is Api.js and no file is being found on case-sensitive file systems
> like ext4. It leads to _Project does not include the specified platform:
> android_ error.
> To reproduce issue please do the following:
>
> # Make sure that you are using case-sensitive file system
> # Clone demo repo: https://github.com/ruslan-bikkinin/cordova-serve-repro
> # cd cordova-serve-repro
> # npm i
> # node serve
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14191) Project does not include the specified platform: android error.
[ https://issues.apache.org/jira/browse/CB-14191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601884#comment-16601884 ] ASF subversion and git services commented on CB-14191: -- Commit d05ce7c0517d9df147895216a60c2697645cd951 in cordova-serve's branch refs/heads/master from [~ruslan.bikkinin] [ https://gitbox.apache.org/repos/asf?p=cordova-serve.git;h=d05ce7c ] CB-14191 (android) Fix bug with module requiring (#10) > Project does not include the specified platform: android error. > --- > > Key: CB-14191 > URL: https://issues.apache.org/jira/browse/CB-14191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-serve >Affects Versions: cordova-serve@2.0.1 > Environment: OS: Ubuntu 16.04 > Cordova CLI: 8.0.0 > >Reporter: Ruslan Bikkinin >Priority: Major > > Code on this this line: > [https://github.com/apache/cordova-serve/blob/master/src/util.js#L81] is > trying to require `cordova/api` module but actual filename generated by > cordova is Api.js and no file is being found on case-sensitive file systems > like ext4. It leads to _Project does not include the specified platform: > android_ error. > To reproduce issue please do the following: > > # Make sure that you are using case-sensitive file system > # Clone demo repo: https://github.com/ruslan-bikkinin/cordova-serve-repro > # cd cordova-serve-repro > # npm i > # node serve > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14172) save-exact preferences from .npmrc should be overridden
[
https://issues.apache.org/jira/browse/CB-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601831#comment-16601831
]
ASF GitHub Bot commented on CB-14172:
-
raphinesse closed pull request #25: CB-14172: Disable save-exact explicitly
URL: https://github.com/apache/cordova-fetch/pull/25
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/index.js b/index.js
index dfa51f7..aa68c14 100644
--- a/index.js
+++ b/index.js
@@ -75,12 +75,17 @@ function npmArgs (target, userOptions) {
if (opts.production) {
args.push('--production');
}
+// save-exact could be enabled through .npmrc, so make sure to disable it
+// to match our desired behavior.
if (opts.save_exact) {
args.push('--save-exact');
-} else if (opts.save) {
-args.push('--save');
} else {
-args.push('--no-save');
+args.push('--save-exact=false');
+if (opts.save) {
+args.push('--save');
+} else {
+args.push('--no-save');
+}
}
return args;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> save-exact preferences from .npmrc should be overridden
> ---
>
> Key: CB-14172
> URL: https://issues.apache.org/jira/browse/CB-14172
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 1.3.0
>Reporter: Oliver Salzburg
>Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When I add `save-exact=true` to my `.npmrc` and run the test suite for
> cordova-fetch, it will fail, because the exact 5.1.1 version will be
> persisted to the `package.json` instead of the expected semver range `^5.1.1`.
> `save-exact` should be disabled explicitly by default unless the related
> option was provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14172) save-exact preferences from .npmrc should be overridden
[ https://issues.apache.org/jira/browse/CB-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601830#comment-16601830 ] ASF GitHub Bot commented on CB-14172: - raphinesse commented on issue #25: CB-14172: Disable save-exact explicitly URL: https://github.com/apache/cordova-fetch/pull/25#issuecomment-418022458 I agree with @dpogue here. We should only override user preferences if it's absolutely necessary to achieve our goal. Which in turn means we should not test behavior of npm, that we did not enforce e. g. by passing a command line option to it. My refactoring PR of the pkgJson-restore.spec in lib already removes some of that testing. Any issues flagging the tests we need to fix this would be highly appreciated. Thanks for bringing this to our attention @oliversalzburg! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > save-exact preferences from .npmrc should be overridden > --- > > Key: CB-14172 > URL: https://issues.apache.org/jira/browse/CB-14172 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: 1.3.0 >Reporter: Oliver Salzburg >Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > When I add `save-exact=true` to my `.npmrc` and run the test suite for > cordova-fetch, it will fail, because the exact 5.1.1 version will be > persisted to the `package.json` instead of the expected semver range `^5.1.1`. > `save-exact` should be disabled explicitly by default unless the related > option was provided. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
