[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694854#comment-14694854 ] Stephan Ewen commented on FLINK-2493: - Still, seeking consensus on the dev list is a

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694852#comment-14694852 ] Márton Balassi commented on FLINK-2493: --- Ok, fair enough then. Simplify names of

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694842#comment-14694842 ] Márton Balassi commented on FLINK-2493: --- Hey [~chenliang], please do not combine the

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694894#comment-14694894 ] ASF GitHub Bot commented on FLINK-1745: --- Github user tillrohrmann commented on the

[jira] [Commented] (FLINK-2306) Add support for named streams in Storm compatibility layer

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694850#comment-14694850 ] ASF GitHub Bot commented on FLINK-2306: --- GitHub user mjsax opened a pull request:

[jira] [Updated] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2015-08-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-1745: - Assignee: (was: Till Rohrmann) Add exact k-nearest-neighbours algorithm to machine learning

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694851#comment-14694851 ] Stephan Ewen commented on FLINK-2493: - I think there was a discussion about combining

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694886#comment-14694886 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

2015-08-13 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/flink/pull/1011 [FLINK-2306] Add support for named streams in Storm compatibility layer - enabled .declareStream() and connect via stream name - enabled multiplt output streams - added .split()

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694935#comment-14694935 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694936#comment-14694936 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694939#comment-14694939 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694938#comment-14694938 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

2015-08-13 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/696#issuecomment-130574663 @kno10 thanks for the pointer. Judging from the abstract it sounds really promising and it seems definitely worth exploring. Unfortunately, I don't have access to

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36955259 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694981#comment-14694981 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694934#comment-14694934 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36955515 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/util/BernoulliSampler.java --- @@ -0,0 +1,107 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695031#comment-14695031 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36955189 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36960527 --- Diff: flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java --- @@ -451,6 +454,53 @@ protected static File asFile(String path) {

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694932#comment-14694932 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694940#comment-14694940 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694943#comment-14694943 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36955316 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694974#comment-14694974 ] ASF GitHub Bot commented on FLINK-1819: --- Github user mxm commented on the pull

[jira] [Commented] (FLINK-2373) Add configuration parameter to createRemoteEnvironment method

2015-08-13 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694989#comment-14694989 ] Ufuk Celebi commented on FLINK-2373: Andreas, did you have a look at this? I have a

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695034#comment-14695034 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695003#comment-14695003 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36960080 --- Diff: flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java --- @@ -451,6 +454,53 @@ protected static File asFile(String path) {

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695069#comment-14695069 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the

[jira] [Commented] (FLINK-2451) Cleanup Gelly examples

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695067#comment-14695067 ] ASF GitHub Bot commented on FLINK-2451: --- Github user vasia commented on a diff in

[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...

2015-08-13 Thread samk3211
Github user samk3211 commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130632285 closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...

2015-08-13 Thread samk3211
Github user samk3211 closed the pull request at: https://github.com/apache/flink/pull/883 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36958345 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/util/BernoulliSampler.java --- @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36955334 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695196#comment-14695196 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the

[jira] [Created] (FLINK-2513) Extend state handle provider interface to list all state handles

2015-08-13 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-2513: -- Summary: Extend state handle provider interface to list all state handles Key: FLINK-2513 URL: https://issues.apache.org/jira/browse/FLINK-2513 Project: Flink

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695192#comment-14695192 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695211#comment-14695211 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695212#comment-14695212 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695133#comment-14695133 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull

[jira] [Created] (FLINK-2514) Local and Remote environment behave differently when re-triggering execution.

2015-08-13 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2514: --- Summary: Local and Remote environment behave differently when re-triggering execution. Key: FLINK-2514 URL: https://issues.apache.org/jira/browse/FLINK-2514 Project:

[jira] [Updated] (FLINK-2514) Local and Remote environment behave differently when re-triggering execution.

2015-08-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-2514: Priority: Critical (was: Major) Local and Remote environment behave differently when

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695166#comment-14695166 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36955221 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[GitHub] flink pull request: [FLINK-2512]Add client.close() before throw Ru...

2015-08-13 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1009#issuecomment-130509029 @uce @hsaputra Thanks. I have move the try up and rely on finally to close the client. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36950634 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala --- @@ -1182,6 +1184,60 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695231#comment-14695231 ] ASF GitHub Bot commented on FLINK-1819: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695232#comment-14695232 ] ASF GitHub Bot commented on FLINK-1819: --- Github user mxm commented on the pull

[jira] [Updated] (FLINK-2514) Local and Remote environment behave differently when re-triggering execution.

2015-08-13 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi updated FLINK-2514: -- Fix Version/s: 0.10 Local and Remote environment behave differently when re-triggering

[jira] [Assigned] (FLINK-2514) Local and Remote environment behave differently when re-triggering execution.

2015-08-13 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-2514: - Assignee: Márton Balassi Local and Remote environment behave differently when

[jira] [Closed] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-13 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-1819. - Resolution: Implemented Fix Version/s: (was: 0.9) 0.10

[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...

2015-08-13 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130623223 I've actually included this in #1000. Could you close this PR @samk3211? Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130644950 `StringBuilder` is only for single-threaded while `StringBuffer` enables multi-thread access. If you use `StringBuffer` in a single-threaded scenario it has worse

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695215#comment-14695215 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull

[jira] [Assigned] (FLINK-2508) Confusing sharing of StreamExecutionEnvironment

2015-08-13 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-2508: - Assignee: Márton Balassi Confusing sharing of StreamExecutionEnvironment

[jira] [Commented] (FLINK-2077) Rework Path class and add extend support for Windows paths

2015-08-13 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695236#comment-14695236 ] Fabian Hueske commented on FLINK-2077: -- Hi Lun, {{//host/dir1/dir2}} is an example

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

2015-08-13 Thread kno10
Github user kno10 commented on the pull request: https://github.com/apache/flink/pull/696#issuecomment-130469648 R-trees are hard to parallelize. For distributed and gigabyte size data, an approximative approach is preferable, like the one we discuss in this article: E.

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36955412 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/util/BernoulliSampler.java --- @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130588652 Thanks for your changes. I think we should use `read()` instead of `readLine()` because we are using a custom delimiter and not necessarily \n (newline symbol). The danger

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-13 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1010#issuecomment-130633384 Thanks Henry, please add this rule. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2451] [gelly] examples and library clea...

2015-08-13 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1000#discussion_r36963490 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java --- @@ -86,26 +72,35 @@ public void

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130524804 @mxm Hi, I fixed the StringBuffer and add the test. Take a look whether it`s correct. Thank you! --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695213#comment-14695213 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130626843 Hi Max, I fixed all as your reviews. And I retained the change of StringBuffer to StringBuilder. There is a question that as I see the StringBuilder just do

[jira] [Commented] (FLINK-2306) Add support for named streams in Storm compatibility layer

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695280#comment-14695280 ] ASF GitHub Bot commented on FLINK-2306: --- Github user StephanEwen commented on the

[jira] [Commented] (FLINK-2306) Add support for named streams in Storm compatibility layer

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695292#comment-14695292 ] ASF GitHub Bot commented on FLINK-2306: --- Github user mjsax commented on the pull

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130664351 @mxm Otherwise, I found the SocketClientSink didn`t have the retry. Is it necessary to get a retry? --- If your project is set up for it, you can reply to

[jira] [Created] (FLINK-2515) CheckpointCoordinator triggers checkpoints even if not all sources are running any more

2015-08-13 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2515: --- Summary: CheckpointCoordinator triggers checkpoints even if not all sources are running any more Key: FLINK-2515 URL: https://issues.apache.org/jira/browse/FLINK-2515

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36969808 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1057,7 +1061,68 @@ public long count() throws Exception { public

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36973279 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunctionTest.java ---

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36973254 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunctionTest.java ---

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36973430 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r36973377 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java --- @@

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2015-08-13 Thread Sheetal Parade (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695604#comment-14695604 ] Sheetal Parade commented on FLINK-2314: --- Can you provide some guidance? As I

[GitHub] flink pull request: Stale Synchronous Parallel Iterations

2015-08-13 Thread nltran
Github user nltran commented on the pull request: https://github.com/apache/flink/pull/967#issuecomment-130734997 The code now passes all the checks :smiley: I have addressed the previous comments you made previously. @StephanEwen , @fhueske could you give it a another review?

[GitHub] flink pull request: [FLINK-2480][test]Add tests for PrintSinkFunct...

2015-08-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/991#discussion_r36990804 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java --- @@ -0,0 +1,234

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-13 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130677380 Thanks for the contribution @sachingoel0101! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2015-08-13 Thread Sheetal Parade (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695941#comment-14695941 ] Sheetal Parade commented on FLINK-2314: --- I added split information in the checkpoint

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r37042816 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java ---

[GitHub] flink pull request: [FLINK-2480][test]Add tests for PrintSinkFunct...

2015-08-13 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/991#discussion_r37046489 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java --- @@ -0,0

[GitHub] flink pull request: [FLINK-2516]Remove unwanted log.isInfoEnabled ...

2015-08-13 Thread ffbin
GitHub user ffbin opened a pull request: https://github.com/apache/flink/pull/1012 [FLINK-2516]Remove unwanted log.isInfoEnabled check The function has call log.info() at the head of it.So i think the check of log.isInfoEnabled after call log.info() is unwanted. You can merge

[jira] [Commented] (FLINK-2516) Remove unwanted log.isInfoEnabled check

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696321#comment-14696321 ] ASF GitHub Bot commented on FLINK-2516: --- GitHub user ffbin opened a pull request:

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-13 Thread ChengXiangLi
Github user ChengXiangLi commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r37046195 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/operators/SampleITCase.scala --- @@ -0,0 +1,166 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696369#comment-14696369 ] ASF GitHub Bot commented on FLINK-1901: --- Github user ChengXiangLi commented on a

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696375#comment-14696375 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on a diff

[jira] [Created] (FLINK-2516) Remove unwanted log.isInfoEnabled check

2015-08-13 Thread fangfengbin (JIRA)
fangfengbin created FLINK-2516: -- Summary: Remove unwanted log.isInfoEnabled check Key: FLINK-2516 URL: https://issues.apache.org/jira/browse/FLINK-2516 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

2015-08-13 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1011#issuecomment-130692637 The CU reports 3 failures. 2 failures in storm-compatibility-core 1 failure in YARN (yarn not responding) --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

2015-08-13 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1011#issuecomment-130694237 Yes. It a weird compile error and it builds locally... The error is: `[ERROR]

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696519#comment-14696519 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-13 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130979827 Sure. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695412#comment-14695412 ] ASF GitHub Bot commented on FLINK-2480: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130663511 Ok, I add two cases(retry 10 and 0) since I thought retry 1 time just same as 10. And would you please take a look with another two

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-13 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130672880 Otherwise, I found the SocketClientSink didn`t have the retry. Is it necessary to get a retry? Yes, that might be an issue but let's keep it separate from our

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-08-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695410#comment-14695410 ] ASF GitHub Bot commented on FLINK-2480: --- Github user mxm commented on a diff in the