[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120520#comment-15120520
]
Subhobrata Dey commented on FLINK-2985:
---
Hello,
I want to work on this issue. Can somebody kindly
Github user rbraeunlich commented on the pull request:
https://github.com/apache/flink/pull/730#issuecomment-175473830
Well, someone could. I'm currently out of time to do this. Feel free to
apply any changes you think are necessary. Although I still think it's simply a
problem with
[
https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119719#comment-15119719
]
ASF GitHub Bot commented on FLINK-3179:
---
Github user ramkrish86 commented on the pull request:
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-175734134
I have changed the hash function to include that bit-magic that is done in
the other hash tables. (Originally, I thought that it is not needed here,
because I haven't
[
https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119716#comment-15119716
]
ASF GitHub Bot commented on FLINK-3179:
---
GitHub user ramkrish86 opened a pull request:
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/1553
FLINK-3179 Combiner is not injected if Reduce or GroupReduce input is
explicitly partitioned (Ram)
Followed the guidance given in the description in order to fix this. Is the
approach correct
[
https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119731#comment-15119731
]
ASF GitHub Bot commented on FLINK-2237:
---
Github user ggevay commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119736#comment-15119736
]
PJ Van Aeken commented on FLINK-2055:
-
What is the latest news on this?
Having read through the
GitHub user hczerpak opened a pull request:
https://github.com/apache/flink/pull/1554
[FLINK-2428] Clean up unused properties in StreamConfig
- Removed outEdges property as it looks totally unused
- Corrected spelling in 2 properties
Apologies for not squashed commits.
[
https://issues.apache.org/jira/browse/FLINK-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119441#comment-15119441
]
Robert Metzger commented on FLINK-3294:
---
I hacked a first approach to this here:
Robert Metzger created FLINK-3294:
-
Summary: KafkaConsumer (0.8) commit offsets using
SimpleConsumer.commitOffsets()
Key: FLINK-3294
URL: https://issues.apache.org/jira/browse/FLINK-3294
Project:
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1553#issuecomment-175730064
Also ensured that the related test cases passes and also the Wordcount
program output with and without partition remains the same.
---
If your project is set up
[
https://issues.apache.org/jira/browse/FLINK-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119765#comment-15119765
]
ASF GitHub Bot commented on FLINK-2428:
---
GitHub user hczerpak opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119821#comment-15119821
]
PJ Van Aeken commented on FLINK-2055:
-
It appears I was wrong in my first comment.
HBase provides two
[
https://issues.apache.org/jira/browse/FLINK-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-3295:
--
Description:
Zookeeper allows since V 3.2 to pass a base path (similar to chroot) with the
Robert Metzger created FLINK-3295:
-
Summary: Flink Kafka consumer fails with NoNodeException if
zkConnect string contains chroot-path
Key: FLINK-3295
URL: https://issues.apache.org/jira/browse/FLINK-3295
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119858#comment-15119858
]
ramkrishna.s.vasudevan commented on FLINK-2055:
---
[~vanaepi]
Using TableOutputFormat will be
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120010#comment-15120010
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user sbcd90 commented on the pull request:
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175810825
Hello zentol,
I have squashed all changes. Can you please merge now?
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119050#comment-15119050
]
Chengxiang Li commented on FLINK-3226:
--
[~fhueske] and [~twalthr] , this task should be blocked by me
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119154#comment-15119154
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user sbcd90 commented on the pull request:
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175592466
Hello zentol,
To answer your initial question,
```
is there any way to check which createStatement method is supported? what
happens if you use the
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/8b34d21e054bb1df3a86f975ff29a51807858a81#commitcomment-15702432
If you like, I can add a prominent note linking to a Wiki page, where we
list all required changes. Would you like to add the Wiki
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/8b34d21e054bb1df3a86f975ff29a51807858a81#commitcomment-15702724
That would be great if you could do that. I just wrote an email to the user
and dev mailing list.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119110#comment-15119110
]
ASF GitHub Bot commented on FLINK-3140:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1465#discussion_r50973634
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/NullAwareComparator.scala
---
@@ -0,0 +1,231 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119119#comment-15119119
]
ASF GitHub Bot commented on FLINK-3140:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119136#comment-15119136
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user sbcd90 commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1525#issuecomment-175518369
Looks good, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels closed FLINK-2940.
-
Resolution: Fixed
As of {{66b4420934ce3d30e4b3476bfcc5c3183de4f405}} we deploy multiple
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119105#comment-15119105
]
Timo Walther commented on FLINK-3226:
-
Yes, I think splitting the issue by operator is a good idea.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1465#discussion_r50974438
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowComparator.scala
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/8b34d21e054bb1df3a86f975ff29a51807858a81#commitcomment-15703496
OK, I've updated the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119132#comment-15119132
]
ASF GitHub Bot commented on FLINK-2935:
---
Github user chiwanpark commented on the pull request:
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-175588417
@tillrohrmann Thanks for review! I have addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175589833
Hello zentol,
I made changes according to your post. Kindly review now.
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119156#comment-15119156
]
ASF GitHub Bot commented on FLINK-3140:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1465#discussion_r50977035
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowComparator.scala
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118942#comment-15118942
]
ASF GitHub Bot commented on FLINK-3258:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118945#comment-15118945
]
ASF GitHub Bot commented on FLINK-3262:
---
Github user StephanEwen commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1538#issuecomment-175518107
Changes look good, test failure is unrelated.
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118884#comment-15118884
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1551#discussion_r50955346
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -92,6 +94,15 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118919#comment-15118919
]
ASF GitHub Bot commented on FLINK-3282:
---
Github user fhueske commented on the pull request:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1544#issuecomment-175506270
Ah, just saw that you committed already. Very good :-)
I think you can close this PR then.
---
If your project is set up for it, you can reply to this email and
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1544#issuecomment-175506011
Hi, you cannot push to the Apache mirror, only to the writable Apache
repository: https://git-wip-us.apache.org/repos/asf/flink.git
I added the Apache
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-175514254
Ah, true, the `ExecutionConfig` is currently grabed in a pretty
non-transparent way from the JobConfig.
I think it would be a good refactoring to pass the
[
https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chengxiang Li resolved FLINK-3282.
--
Resolution: Fixed
> Add FlinkRelNode interface.
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chengxiang Li closed FLINK-3282.
> Add FlinkRelNode interface.
> ---
>
> Key: FLINK-3282
>
[
https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119010#comment-15119010
]
ASF GitHub Bot commented on FLINK-3270:
---
Github user rmetzger commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119023#comment-15119023
]
ASF GitHub Bot commented on FLINK-2933:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels resolved FLINK-2933.
---
Resolution: Fixed
Fix Version/s: 1.0.0
Fixed in
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1552#discussion_r50959035
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java
---
@@ -70,10 +70,9 @@ public static RevisionInformation
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1538#issuecomment-175522661
Thanks for review. I'm going to merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118960#comment-15118960
]
ASF GitHub Bot commented on FLINK-3258:
---
Github user uce commented on the pull request:
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/a7d4334f1843fd341be49605c2814e01bc786ccf#commitcomment-15707254
The thing is that this requires checkstyle to be enabled for the tests as
well. I would like that. Let me ask on the mailing list what
[
https://issues.apache.org/jira/browse/FLINK-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-3290.
---
Resolution: Fixed
Implemented in 499b60fedd6db1cd0c1a4e1cc8c59a94b89c5c84
> [py] Generalize
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119286#comment-15119286
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user sbcd90 commented on the pull request:
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175653356
Hello zentol,
Can you check the code changes now? The changes look exactly similar to
what you suggest. Can you let me know if this can be merged? or do I
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175486665
is there any way to check which createStatement method is supported? what
happens if you use the wrong statement?
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118922#comment-15118922
]
ASF GitHub Bot commented on FLINK-3282:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118938#comment-15118938
]
ASF GitHub Bot commented on FLINK-2523:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-2871.
Implemented with eaf540fd1c9c7395a7f278b9a4f25e42cf8d56b0
> Add OuterJoin strategy with HashTable on
Github user ChengXiangLi closed the pull request at:
https://github.com/apache/flink/pull/1544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118993#comment-15118993
]
ASF GitHub Bot commented on FLINK-3282:
---
Github user ChengXiangLi closed the pull request at:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-175544829
I understand that argument, and I would be strongly against adding examples
for each connector.
The pull request is moving the example away from the Kafka
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1538
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119243#comment-15119243
]
ASF GitHub Bot commented on FLINK-3258:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-3258.
--
Resolution: Implemented
Implemented in 92a2544, f681d9b.
> Merge AbstractInvokable's
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1465#discussion_r50978510
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowComparator.scala
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175619319
In that case i would suggest the following:
- change the default values to TYPE_FORWARD_ONLY and CONCUR_READ_ONLY to be
in line with createStatement()
-allow the
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/8b34d21e054bb1df3a86f975ff29a51807858a81#commitcomment-15704256
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119177#comment-15119177
]
ASF GitHub Bot commented on FLINK-3140:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119176#comment-15119176
]
ASF GitHub Bot commented on FLINK-3140:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1465#issuecomment-175601474
Looks good to merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1465#issuecomment-175603356
I will merge it, once the build succeeded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119185#comment-15119185
]
ASF GitHub Bot commented on FLINK-3140:
---
Github user twalthr commented on the pull request:
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-175600967
About the type of number of containers for TaskManagers, it should be
optional because the user can the Scala Shell without specifying the number
when the user wants
[
https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119174#comment-15119174
]
ASF GitHub Bot commented on FLINK-2935:
---
Github user chiwanpark commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119195#comment-15119195
]
Timo Walther commented on FLINK-3226:
-
I will focus on expression code generation.
> Translate
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119211#comment-15119211
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user zentol commented on the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1551#discussion_r50993131
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -19,10 +19,7 @@
package
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119346#comment-15119346
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119354#comment-15119354
]
ASF GitHub Bot commented on FLINK-3292:
---
Github user zentol commented on the pull request:
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-17561
if you can revert the changes to the imports it's good to merge IMO.
you don't have to create a new PR. you can squash the commits if you wish,
otherwise I'll do
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-175671773
The `pdsh` section on [Environment
Variables](http://linux.die.net/man/1/pdsh) lists two options:
> PDSH_SSH_ARGS
> Override the standard arguments that
[
https://issues.apache.org/jira/browse/FLINK-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119390#comment-15119390
]
ASF GitHub Bot commented on FLINK-3161:
---
Github user greghogan commented on the pull request:
89 matches
Mail list logo
