[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197195#comment-15197195 ] ASF GitHub Bot commented on FLINK-2732: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: [FLINK-2732] Display TM logs in Dashboard

2016-03-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1790#issuecomment-197266303 @tillrohrmann i don't think we should do this now. We would have to change several method related to the creation of the JobManager (to return the BlobService),

[jira] [Commented] (FLINK-3115) Update Elasticsearch connector to 2.X

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197190#comment-15197190 ] ASF GitHub Bot commented on FLINK-3115: --- Github user smarthi commented on a diff in the pull

[GitHub] flink pull request: [WIP] FLINK-3115: Update ElasticSearch connect...

2016-03-16 Thread smarthi
Github user smarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/1792#discussion_r56316199 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml --- @@ -0,0 +1,107 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Resolved] (FLINK-3612) Fix/adjust Table API examples

2016-03-16 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3612. -- Resolution: Fixed Fix Version/s: 1.1.0 > Fix/adjust Table API examples >

[jira] [Commented] (FLINK-1964) Rework TwitterSource to use a Properties object instead of a file path

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197180#comment-15197180 ] ASF GitHub Bot commented on FLINK-1964: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-1964] Reimplement TwitterSource

2016-03-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1796#issuecomment-197261765 Thank you for making me feel like a French writer ;) I though about adding a test, but that would involve adding some kind of web server which behaves exactly

[jira] [Commented] (FLINK-3612) Fix/adjust Table API examples

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197178#comment-15197178 ] ASF GitHub Bot commented on FLINK-3612: --- Github user vasia closed the pull request at:

[GitHub] flink pull request: [FLINK-3612] Fix/adjust Table API examples

2016-03-16 Thread vasia
Github user vasia closed the pull request at: https://github.com/apache/flink/pull/1793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator

2016-03-16 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197171#comment-15197171 ] Aljoscha Krettek commented on FLINK-3614: - Yes, the parallel pre-aggregation will have to get its

[GitHub] flink pull request: [FLINK-2732] Display TM logs in Dashboard

2016-03-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1790#issuecomment-197258802 yeah...the changes in the jobmanager are fairly easy, albeit hacky and ugly. the FlinkMiniCluster however is pain. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197173#comment-15197173 ] ASF GitHub Bot commented on FLINK-2732: --- Github user zentol commented on the pull request:

[jira] [Commented] (FLINK-3503) ProjectJoinTransposeRule fails to push down project.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197167#comment-15197167 ] ASF GitHub Bot commented on FLINK-3503: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3503] [tableAPI] Add cost model for Dat...

2016-03-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1798#discussion_r56312918 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -66,8 +67,28 @@ class

[jira] [Commented] (FLINK-3609) Revisit selection of Calcite rules

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197162#comment-15197162 ] ASF GitHub Bot commented on FLINK-3609: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3609) Revisit selection of Calcite rules

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197161#comment-15197161 ] ASF GitHub Bot commented on FLINK-3609: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56312432 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets

[jira] [Assigned] (FLINK-3619) SavepointCoordinator test failure

2016-03-16 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-3619: -- Assignee: Ufuk Celebi > SavepointCoordinator test failure > -

[jira] [Created] (FLINK-3619) SavepointCoordinator test failure

2016-03-16 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-3619: - Summary: SavepointCoordinator test failure Key: FLINK-3619 URL: https://issues.apache.org/jira/browse/FLINK-3619 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-3428) Add fixed time trailing timestamp/watermark extractor

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197143#comment-15197143 ] ASF GitHub Bot commented on FLINK-3428: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: FLINK-3428: Adds a fixed time trailing waterma...

2016-03-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1764#issuecomment-197248226 Should this be referenced in the docs and perhaps also contain the example implementation of the LongExtractor? My gut feeling says that this might be dead code otherwise.

[jira] [Commented] (FLINK-3612) Fix/adjust Table API examples

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197140#comment-15197140 ] ASF GitHub Bot commented on FLINK-3612: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3612] Fix/adjust Table API examples

2016-03-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1793#issuecomment-197248063 Thanks! Added the name and merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197138#comment-15197138 ] ASF GitHub Bot commented on FLINK-2732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-3503) ProjectJoinTransposeRule fails to push down project.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197137#comment-15197137 ] ASF GitHub Bot commented on FLINK-3503: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2732] Display TM logs in Dashboard

2016-03-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1790#discussion_r56309084 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -0,0 +1,345 @@ +/* + *

[GitHub] flink pull request: [FLINK-3503] [tableAPI] Add cost model for Dat...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1798#discussion_r56309062 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -66,8 +67,28 @@ class DataSetCalc(

[jira] [Commented] (FLINK-3115) Update Elasticsearch connector to 2.X

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197136#comment-15197136 ] ASF GitHub Bot commented on FLINK-3115: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [WIP] FLINK-3115: Update ElasticSearch connect...

2016-03-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1792#issuecomment-197245618 Looks good to merge @smarthi! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Kafka-3375: Allows Watermark Generation in the...

2016-03-16 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1795#issuecomment-197244578 Thanks a lot @mxm ! If it is a problem, I can put the Watermark-related code in the FlinkConsumerBase class. It is just that this way it is clear which code is

[jira] [Commented] (FLINK-3115) Update Elasticsearch connector to 2.X

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197133#comment-15197133 ] ASF GitHub Bot commented on FLINK-3115: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [WIP] FLINK-3115: Update ElasticSearch connect...

2016-03-16 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1792#discussion_r56308507 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml --- @@ -0,0 +1,107 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request: [FLINK-2732] Display TM logs in Dashboard

2016-03-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1790#discussion_r56308139 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -0,0 +1,345 @@ +/* + *

[GitHub] flink pull request: Kafka-3375: Allows Watermark Generation in the...

2016-03-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1795#issuecomment-197241772 It looks like the change is API-breaking in terms of binary compatibility because it changes the base class of the `FlinkKafkaConsumer08` and `FlinkKafkaConsumer09`. I

[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197129#comment-15197129 ] ASF GitHub Bot commented on FLINK-2732: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2732] Display TM logs in Dashboard

2016-03-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1790#discussion_r56307836 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -0,0 +1,345 @@ +/* + *

[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197126#comment-15197126 ] ASF GitHub Bot commented on FLINK-2732: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-1964] Reimplement TwitterSource

2016-03-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1796#issuecomment-197237551 Classic case of "The Most Beautiful Code I Never Wrote": https://www.safaribooksonline.com/library/view/beautiful-code/9780596510046/ch03.html There is no test (old

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1797#issuecomment-197229421 I have some doubts about the filter/project merge rules and the `FlinkJoinUnionTransposeRule`. Otherwise looks good! --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197113#comment-15197113 ] ASF GitHub Bot commented on FLINK-2732: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-2732] Display TM logs in Dashboard

2016-03-16 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1790#issuecomment-197232389 The jobmanager/dashboard separation should be really easy to do. You just have to give the `WebRuntimeMonitor` a `BlobService` as a constructor parameter. And now

[jira] [Commented] (FLINK-3568) Hadoop's Bzip decompression is not thread safe

2016-03-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197105#comment-15197105 ] Robert Metzger commented on FLINK-3568: --- No, you can not overwrite the hadoop version property when

[jira] [Commented] (FLINK-3616) Python API version inconsistencies

2016-03-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197102#comment-15197102 ] Chesnay Schepler commented on FLINK-3616: - For python 2 Flink uses the python version that is

[jira] [Commented] (FLINK-3609) Revisit selection of Calcite rules

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197100#comment-15197100 ] ASF GitHub Bot commented on FLINK-3609: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56304469 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets {

[jira] [Commented] (FLINK-3609) Revisit selection of Calcite rules

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197096#comment-15197096 ] ASF GitHub Bot commented on FLINK-3609: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56304292 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets {

[jira] [Commented] (FLINK-3609) Revisit selection of Calcite rules

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197095#comment-15197095 ] ASF GitHub Bot commented on FLINK-3609: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-3609) Revisit selection of Calcite rules

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197091#comment-15197091 ] ASF GitHub Bot commented on FLINK-3609: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56304129 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets {

[jira] [Created] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation

2016-03-16 Thread Martin Junghanns (JIRA)
Martin Junghanns created FLINK-3618: --- Summary: Rename abstract UDF classes in Scatter-Gather implementation Key: FLINK-3618 URL: https://issues.apache.org/jira/browse/FLINK-3618 Project: Flink

[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator

2016-03-16 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197076#comment-15197076 ] Maximilian Michels commented on FLINK-3614: --- +1 > Remove Non-Keyed Window Operator >

[jira] [Closed] (FLINK-3315) Fix Slot Sharing in Streaming API

2016-03-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-3315. - Resolution: Fixed Merged in

[jira] [Reopened] (FLINK-3315) Fix Slot Sharing in Streaming API

2016-03-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reopened FLINK-3315: --- > Fix Slot Sharing in Streaming API > - > > Key:

[jira] [Updated] (FLINK-3315) Fix Slot Sharing in Streaming API

2016-03-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3315: -- Fix Version/s: 1.0.0 > Fix Slot Sharing in Streaming API > - >

[GitHub] flink pull request: Flink 3579 Improve String concatenation

2016-03-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1788#issuecomment-197206933 Hi @ramkrish86, the Table API is currently developed in a separate branch (which will be merged to master soon). Therefore, you have to open a PR against the

[jira] [Commented] (FLINK-3611) Wrong link in CONTRIBUTING.md

2016-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196988#comment-15196988 ] ASF GitHub Bot commented on FLINK-3611: --- Github user chiwanpark commented on the pull request:

[GitHub] flink pull request: [FLINK-3611] [docs] corrected link in CONTRIBU...

2016-03-16 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1786#issuecomment-197206450 +1 for your suggestion @s1ck. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does