[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309297#comment-15309297 ] ASF GitHub Bot commented on FLINK-3763: --- Github user subhankarb commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread subhankarb
Github user subhankarb commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65303646 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java

[jira] [Created] (FLINK-4000) Exception: Could not restore checkpointed state to operators and functions; during Job Restart (Job restart is triggered due to one of the task manager failure)

2016-05-31 Thread Aride Chettali (JIRA)
Aride Chettali created FLINK-4000: - Summary: Exception: Could not restore checkpointed state to operators and functions; during Job Restart (Job restart is triggered due to one of the task manager failure) Key: FLINK-4000

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309058#comment-15309058 ] ASF GitHub Bot commented on FLINK-1979: --- Github user chiwanpark commented on the pull request:

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1985 Hi @skavulya, I just quickly reviewed your updated PR and left few comments. They are not critical things but It would be better to fix them. Other things are very good. --- If your

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309056#comment-15309056 ] ASF GitHub Bot commented on FLINK-1979: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1985#discussion_r65291933 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/optimization/RegularizationPenaltyTest.scala --- @@ -0,0 +1,65 @@ +/* + *

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309054#comment-15309054 ] ASF GitHub Bot commented on FLINK-1979: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1985#discussion_r65291911 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/optimization/LossFunctionTest.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1985#discussion_r65291552 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/RegularizationPenalty.scala --- @@ -0,0 +1,215 @@ +/* + *

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309044#comment-15309044 ] ASF GitHub Bot commented on FLINK-1979: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309043#comment-15309043 ] ASF GitHub Bot commented on FLINK-1979: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1985#discussion_r65291461 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala --- @@ -47,21 +47,106 @@ object SquaredLoss

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1985#discussion_r65291353 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala --- @@ -47,21 +47,106 @@ object SquaredLoss

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309038#comment-15309038 ] ASF GitHub Bot commented on FLINK-1979: --- Github user chiwanpark commented on a diff in the pull

[jira] [Closed] (FLINK-3994) Instable KNNITSuite

2016-05-31 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park closed FLINK-3994. -- Resolution: Fixed Fixed via aedc0fd481a756ef2b1708f896d5500475715232. Thanks for guidance

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

2016-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2056 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3994) Instable KNNITSuite

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309020#comment-15309020 ] ASF GitHub Bot commented on FLINK-3994: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/2056 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-3994) Instable KNNITSuite

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309017#comment-15309017 ] ASF GitHub Bot commented on FLINK-3994: --- Github user chiwanpark commented on the pull request:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308581#comment-15308581 ] ASF GitHub Bot commented on FLINK-3758: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accumulators in...

2016-05-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1979 How about tagging the new method with `@PublicEvolving`. Since its a new API anyways, its good not to make it part of the stable interfaces. With Flink 2.0, we can remove the

[jira] [Commented] (FLINK-3054) Remove R (return) type variable from SerializationSchema

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308531#comment-15308531 ] ASF GitHub Bot commented on FLINK-3054: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable from Serial...

2016-05-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1406 I think you can use this class as a reference:

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308525#comment-15308525 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2054 Thank you for your contribution. There are still some open issues that need addressing before we can merge this. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308520#comment-15308520 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65253337 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -35,24

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65253122 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -35,24

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308514#comment-15308514 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308516#comment-15308516 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65253162 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -35,24

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308512#comment-15308512 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65253016 --- Diff: docs/apis/streaming/connectors/rabbitmq.md --- @@ -71,23 +71,25 @@ Example: {% highlight java %} +RMQConnectionConfig

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308506#comment-15308506 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65252614 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java ---

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65252489 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java ---

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308501#comment-15308501 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308485#comment-15308485 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65251121 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java ---

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308479#comment-15308479 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65250839 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java ---

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308478#comment-15308478 ] ASF GitHub Bot commented on FLINK-3763: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3763] RabbitMQ Source/Sink standardize connection...

2016-05-31 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2054#discussion_r65250708 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java ---

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308246#comment-15308246 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65233230 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308233#comment-15308233 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231707 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308232#comment-15308232 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231642 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231516 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -114,85 +118,133 @@ public void prepare() throws

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231501 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedReduceCombineDriver.java --- @@ -0,0 +1,305 @@ +/* + *

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308227#comment-15308227 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308229#comment-15308229 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308230#comment-15308230 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65231386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -42,34 +44,38 @@ * Combine operator for Reduce

[jira] [Created] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-05-31 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-3999: -- Summary: Rename the `running` flag in the drivers to `canceled` Key: FLINK-3999 URL: https://issues.apache.org/jira/browse/FLINK-3999 Project: Flink Issue Type:

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308199#comment-15308199 ] ASF GitHub Bot commented on FLINK-1979: --- Github user skavulya commented on the pull request:

[GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and regulariz...

2016-05-31 Thread skavulya
Github user skavulya commented on the pull request: https://github.com/apache/flink/pull/1985 @tillrohrmann @thvasilo I made the changes you recommended. Please let me know if they look ok. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308205#comment-15308205 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65229499 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -42,34 +44,38 @@ * Combine operator for Reduce

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308191#comment-15308191 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308193#comment-15308193 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65228287 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala --- @@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag]( }

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65228213 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/UnsortedGrouping.java --- @@ -135,10 +136,37 @@ public UnsortedGrouping(DataSet set,

[jira] [Commented] (FLINK-3806) Revert use of DataSet.count() in Gelly

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308181#comment-15308181 ] ASF GitHub Bot commented on FLINK-3806: --- Github user greghogan commented on the pull request:

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.count()

2016-05-31 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2036 All comments should now be addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [hotfix] Fix JSONDeserializationSchema for Kafka; Parame...

2016-05-31 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2057 [hotfix] Fix JSONDeserializationSchema for Kafka; ParameterTool usability The JSONDeserializationSchema was implementing the KeyedDeserializationSchema. However, it was not using the key or any

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65219886 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala --- @@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag]( }

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308080#comment-15308080 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[jira] [Created] (FLINK-3998) Access to gauges and counters in StatsDReporter#report() is not properly synchronized

2016-05-31 Thread Ted Yu (JIRA)
Ted Yu created FLINK-3998: - Summary: Access to gauges and counters in StatsDReporter#report() is not properly synchronized Key: FLINK-3998 URL: https://issues.apache.org/jira/browse/FLINK-3998 Project: Flink

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308038#comment-15308038 ] ASF GitHub Bot commented on FLINK-3477: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308039#comment-15308039 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/2020 The changes look good, we just have to figure out what to do about the methods on `StreamExecutionEnvironment`. One thing I'd like to get rid of is

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine strategy f...

2016-05-31 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r65216454 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java --- @@ -42,34 +44,38 @@ * Combine operator for Reduce

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65216093 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamFaultToleranceTestBase.java --- @@ -104,8 +106,21 @@ public void

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308035#comment-15308035 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-3993) [py] Add generateSequence() support to Python API

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308013#comment-15308013 ] ASF GitHub Bot commented on FLINK-3993: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: [FLINK-3993] [py] Add generateSequence() support to Pyth...

2016-05-31 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/2055 please add them as a separate commit, they will be squashed when merging. Good point regarding frm. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308005#comment-15308005 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308004#comment-15308004 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65212938 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -0,0 +1,336 @@

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65212915 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -0,0 +1,336 @@

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307995#comment-15307995 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65212384 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala --- @@ -483,28 +500,31 @@ class

[jira] [Closed] (FLINK-3886) Give a better error when the application Main class is not public.

2016-05-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3886. --- > Give a better error when the application Main class is not public. >

[jira] [Closed] (FLINK-3978) Add hasBroadcastVariable method to RuntimeContext

2016-05-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3978. --- > Add hasBroadcastVariable method to RuntimeContext > - >

[jira] [Resolved] (FLINK-3886) Give a better error when the application Main class is not public.

2016-05-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3886. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed via 6db9e6ae5c2f4968687a3fcae0520e05442bd9ab

[jira] [Resolved] (FLINK-3979) [documentation]add missed import classes in run_example_quickstart

2016-05-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3979. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed via ad52a5f0cebe6e5d593be0ae40656b28470af106

[jira] [Closed] (FLINK-3979) [documentation]add missed import classes in run_example_quickstart

2016-05-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3979. --- > [documentation]add missed import classes in run_example_quickstart >

[jira] [Resolved] (FLINK-3978) Add hasBroadcastVariable method to RuntimeContext

2016-05-31 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3978. - Resolution: Fixed Fixed via 5b0287971fa2beda360105d96e7bfbc7a110fae7 > Add hasBroadcastVariable

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307951#comment-15307951 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65209503 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -897,21 +900,21 @@ public

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307948#comment-15307948 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65209426 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -877,15 +880,15 @@ public

[GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persistent

2016-05-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2020#discussion_r65207037 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java --- @@ -82,6 +82,8 @@ */ private static int

[jira] [Commented] (FLINK-2314) Make Streaming File Sources Persistent

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307930#comment-15307930 ] ASF GitHub Bot commented on FLINK-2314: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-3994) Instable KNNITSuite

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307904#comment-15307904 ] ASF GitHub Bot commented on FLINK-3994: --- Github user chiwanpark commented on the pull request:

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

2016-05-31 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/2056 Thanks for clarifying @StephanEwen! I'll merge this after Travis succeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3994) Instable KNNITSuite

2016-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307899#comment-15307899 ] ASF GitHub Bot commented on FLINK-3994: --- Github user StephanEwen commented on the pull request:

  1   2   >