[GitHub] flink issue #2081: [FLINK-4020][streaming-connectors] Move shard list queryi...

2016-06-13 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2081 Hi @rmetzger, Thanks for letting me know. However, I'd like to close this PR for now for the following reasons: 1. The new shard-to-subtask assignment logic introduced with this change

[jira] [Commented] (FLINK-4020) Remove shard list querying from Kinesis consumer constructor

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328943#comment-15328943 ] ASF GitHub Bot commented on FLINK-4020: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328918#comment-15328918 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #1962: [FLINK-3857][Streaming Connectors]Add reconnect attempt t...

2016-06-13 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/1962 Hi @sbcd90, Sorry for the late reply, as I'm currently busy some other things. I'll be happy to help review again within the next 2~3 days. --- If your project is set up for it, you can reply

[jira] [Comment Edited] (FLINK-4069) Kafka Consumer should not initialize on construction

2016-06-13 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328840#comment-15328840 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4069 at 6/14/16 2:50 AM: -

[jira] [Comment Edited] (FLINK-4069) Kafka Consumer should not initialize on construction

2016-06-13 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328840#comment-15328840 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4069 at 6/14/16 2:50 AM: -

[jira] [Commented] (FLINK-4069) Kafka Consumer should not initialize on construction

2016-06-13 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328840#comment-15328840 ] Tzu-Li (Gordon) Tai commented on FLINK-4069: Thanks for creating this JIRA Shannon. However,

[jira] [Commented] (FLINK-4023) Move Kafka consumer partition discovery from constructor to open()

2016-06-13 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328831#comment-15328831 ] Tzu-Li (Gordon) Tai commented on FLINK-4023: https://issues.apache.org/jira/browse/FLINK-4069

[jira] [Commented] (FLINK-4061) about flink jdbc connect oracle db exists a crital bug

2016-06-13 Thread dengchangfu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328758#comment-15328758 ] dengchangfu commented on FLINK-4061: In china. flink can be integrated with traditional relational

[jira] [Commented] (FLINK-4061) about flink jdbc connect oracle db exists a crital bug

2016-06-13 Thread dengchangfu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328749#comment-15328749 ] dengchangfu commented on FLINK-4061: I also think this is the problem,the statement was not inited.but

[jira] [Commented] (FLINK-4061) about flink jdbc connect oracle db exists a crital bug

2016-06-13 Thread dengchangfu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328742#comment-15328742 ] dengchangfu commented on FLINK-4061: I have depend oracle jar in pom,but it is really a

[jira] [Commented] (FLINK-3971) Aggregates handle null values incorrectly.

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328667#comment-15328667 ] ASF GitHub Bot commented on FLINK-3971: --- Github user gallenvara commented on the issue:

[GitHub] flink issue #2049: [FLINK-3971] [tableAPI] Aggregates handle null values inc...

2016-06-13 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2049 @fhueske Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328612#comment-15328612 ] ASF GitHub Bot commented on FLINK-3921: --- Github user rekhajoshm commented on the issue:

[GitHub] flink issue #2060: [FLINK-3921] StringParser encoding

2016-06-13 Thread rekhajoshm
Github user rekhajoshm commented on the issue: https://github.com/apache/flink/pull/2060 Sorry for delay, got busy. Thank you @StephanEwen for your review.updated.Please have a look.thanks cc @greghogan --- If your project is set up for it, you can reply to this email and have

[jira] [Created] (FLINK-4069) Kafka Consumer should not initialize on construction

2016-06-13 Thread Shannon Carey (JIRA)
Shannon Carey created FLINK-4069: Summary: Kafka Consumer should not initialize on construction Key: FLINK-4069 URL: https://issues.apache.org/jira/browse/FLINK-4069 Project: Flink Issue

[jira] [Commented] (FLINK-3340) Fix object juggling in drivers

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328014#comment-15328014 ] ASF GitHub Bot commented on FLINK-3340: --- Github user greghogan commented on the issue:

[GitHub] flink issue #1626: [FLINK-3340] [runtime] Fix object juggling in drivers

2016-06-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1626 Thank you @xhumanoid for reporting this! I will make the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-3323) Add documentation for NiFi connector

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327932#comment-15327932 ] ASF GitHub Bot commented on FLINK-3323: --- GitHub user smarthi opened a pull request:

[jira] [Updated] (FLINK-3323) Add documentation for NiFi connector

2016-06-13 Thread Suneel Marthi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suneel Marthi updated FLINK-3323: - Summary: Add documentation for NiFi connector (was: Nifi connector not documented) > Add

[jira] [Closed] (FLINK-4066) RabbitMQ source, customize queue arguments

2016-06-13 Thread Kanstantsin Kamkou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanstantsin Kamkou closed FLINK-4066. - > RabbitMQ source, customize queue arguments > -- > >

[jira] [Commented] (FLINK-4051) RabbitMQ Source might not react to cancel signal

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327788#comment-15327788 ] Robert Metzger commented on FLINK-4051: --- Great, Thank you! > RabbitMQ Source might not react to

[jira] [Assigned] (FLINK-4045) Test AMQP connector using Apache ActiveMQ emebdded broker

2016-06-13 Thread Subhankar Biswas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Subhankar Biswas reassigned FLINK-4045: --- Assignee: Subhankar Biswas > Test AMQP connector using Apache ActiveMQ emebdded

[jira] [Commented] (FLINK-4051) RabbitMQ Source might not react to cancel signal

2016-06-13 Thread Subhankar Biswas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327758#comment-15327758 ] Subhankar Biswas commented on FLINK-4051: - OK i'll start working on it. > RabbitMQ Source might

[jira] [Commented] (FLINK-3944) Add optimization rules to reorder Cartesian products and joins

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327693#comment-15327693 ] ASF GitHub Bot commented on FLINK-3944: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #2098: [revert] [FLINK-3944] [tableAPI] Reverts "Add rewr...

2016-06-13 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/2098 [revert] [FLINK-3944] [tableAPI] Reverts "Add rewrite rules to reorder Cartesian products and joins." This reverts commit 85793a25a78ba5be96fabc2a26569318c6b53853. Added rewrite rules blow up

[jira] [Commented] (FLINK-3971) Aggregates handle null values incorrectly.

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327689#comment-15327689 ] ASF GitHub Bot commented on FLINK-3971: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2049: [FLINK-3971] [tableAPI] Aggregates handle null values inc...

2016-06-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2049 Hi @gallenvara, you have a merge commit in your changes. Can you rebase your changes to the current master and squash the commits? Thanks! --- If your project is set up for it, you can

[jira] [Commented] (FLINK-3944) Add optimization rules to reorder Cartesian products and joins

2016-06-13 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327687#comment-15327687 ] Fabian Hueske commented on FLINK-3944: -- I will open a PR to revert the commit. > Add optimization

[jira] [Reopened] (FLINK-3944) Add optimization rules to reorder Cartesian products and joins

2016-06-13 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reopened FLINK-3944: -- > Add optimization rules to reorder Cartesian products and joins >

[jira] [Commented] (FLINK-3944) Add optimization rules to reorder Cartesian products and joins

2016-06-13 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327666#comment-15327666 ] Fabian Hueske commented on FLINK-3944: -- I tried the fix on another query and found that the search

[jira] [Commented] (FLINK-3340) Fix object juggling in drivers

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327660#comment-15327660 ] ASF GitHub Bot commented on FLINK-3340: --- Github user xhumanoid commented on the issue:

[GitHub] flink issue #1626: [FLINK-3340] [runtime] Fix object juggling in drivers

2016-06-13 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/1626 Hi, I know than issue closed, but he maybe have small bug https://github.com/apache/flink/pull/1626/files#diff-4a133896fec62bcabc1120b0df8cb8daR205 in hashCode recursion on

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327635#comment-15327635 ] ASF GitHub Bot commented on FLINK-3859: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327625#comment-15327625 ] ASF GitHub Bot commented on FLINK-3859: --- Github user twalthr commented on a diff in the pull

[jira] [Created] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-06-13 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-4068: Summary: Move constant computations out of code-generated `flatMap` functions. Key: FLINK-4068 URL: https://issues.apache.org/jira/browse/FLINK-4068 Project: Flink

[jira] [Commented] (FLINK-4051) RabbitMQ Source might not react to cancel signal

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327604#comment-15327604 ] Robert Metzger commented on FLINK-4051: --- On the other hand, the Javadoc of take() states that the

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327591#comment-15327591 ] ASF GitHub Bot commented on FLINK-3859: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-3763) RabbitMQ Source/Sink standardize connection parameters

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327589#comment-15327589 ] Robert Metzger commented on FLINK-3763: --- Okay. I'll investigate this issue and then decide how to

[GitHub] flink issue #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger support to...

2016-06-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2088 Think we also need aggregation functions for `DECIMAL` otherwise this won't work: ``` SELECT sum(myInt * 1.23) FROM MyTable ``` --- If your project is set up for it, you can reply to

[jira] [Updated] (FLINK-4066) RabbitMQ source, customize queue arguments

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4066: -- Fix Version/s: 1.1.0 > RabbitMQ source, customize queue arguments >

[jira] [Resolved] (FLINK-4066) RabbitMQ source, customize queue arguments

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-4066. --- Resolution: Duplicate > RabbitMQ source, customize queue arguments >

[jira] [Commented] (FLINK-4066) RabbitMQ source, customize queue arguments

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327585#comment-15327585 ] Robert Metzger commented on FLINK-4066: --- I'm closing this JIRA as invalid. The requested feature has

[jira] [Commented] (FLINK-4064) Allow calling MetricGroup methods multiple times

2016-06-13 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327587#comment-15327587 ] Aljoscha Krettek commented on FLINK-4064: - You're right, that might be the way to go. > Allow

[jira] [Commented] (FLINK-4028) AbstractAlignedProcessingTimeWindowOperator creates wrong TimeWindow

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327584#comment-15327584 ] ASF GitHub Bot commented on FLINK-4028: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-4065) Unstable Kafka09ITCase.testMultipleSourcesOnePartition test

2016-06-13 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327583#comment-15327583 ] Kostas Kloudas commented on FLINK-4065: --- Thanks [~rmetzger] > Unstable

[GitHub] flink pull request #2097: [FLINK-4028] Create correct TimeWindow in Abstract...

2016-06-13 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2097 [FLINK-4028] Create correct TimeWindow in AbstractAlignedProcessingTimeWindowOperator You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-3971) Aggregates handle null values incorrectly.

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327580#comment-15327580 ] ASF GitHub Bot commented on FLINK-3971: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2049: [FLINK-3971] [tableAPI] Aggregates handle null values inc...

2016-06-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2049 Thanks for the fast update @gallenvara. Good to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (FLINK-4067) Add version header to savepoints

2016-06-13 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-4067: -- Summary: Add version header to savepoints Key: FLINK-4067 URL: https://issues.apache.org/jira/browse/FLINK-4067 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-3749) Improve decimal handling

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327574#comment-15327574 ] ASF GitHub Bot commented on FLINK-3749: --- Github user twalthr closed the pull request at:

[jira] [Commented] (FLINK-3749) Improve decimal handling

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327573#comment-15327573 ] ASF GitHub Bot commented on FLINK-3749: --- Github user twalthr commented on the issue:

[GitHub] flink issue #1881: [FLINK-3749] [table] Improve decimal handling

2016-06-13 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/1881 Yes, I will close this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request #1881: [FLINK-3749] [table] Improve decimal handling

2016-06-13 Thread twalthr
Github user twalthr closed the pull request at: https://github.com/apache/flink/pull/1881 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-4065) Unstable Kafka09ITCase.testMultipleSourcesOnePartition test

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-4065. - Resolution: Invalid > Unstable Kafka09ITCase.testMultipleSourcesOnePartition test >

[jira] [Commented] (FLINK-4065) Unstable Kafka09ITCase.testMultipleSourcesOnePartition test

2016-06-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327572#comment-15327572 ] Robert Metzger commented on FLINK-4065: --- 4 days ago, I improved the Kafka tests stability a bit

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327549#comment-15327549 ] ASF GitHub Bot commented on FLINK-3859: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger support to...

2016-06-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2088 Thanks for the PR, @twalthr! Looks mostly good. I found a few cases that needs to be fix. We also should think about how to handle SQL `DECIMAL` types with fixed precision / scale, e.g.,

[GitHub] flink pull request #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger sup...

2016-06-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2088#discussion_r66807225 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/expression/DecimalTypeTest.scala --- @@ -0,0 +1,262 @@ +/* + *

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327547#comment-15327547 ] ASF GitHub Bot commented on FLINK-3859: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327544#comment-15327544 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66806299 --- Diff: docs/apis/cli.md --- @@ -252,6 +256,12 @@ Action "list" lists running and scheduled programs. configuration.

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327539#comment-15327539 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327537#comment-15327537 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327538#comment-15327538 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805960 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -181,11 +198,30 @@ public boolean

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805953 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327536#comment-15327536 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink issue #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2085 Thanks for the review! I've addressed almost all your comments and will ping you once the PR get updated. Some more comments: > (1) When listing the yarn-session.sh cli options, I could not see

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327535#comment-15327535 ] ASF GitHub Bot commented on FLINK-3859: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805706 --- Diff: docs/setup/yarn_setup.md --- @@ -143,6 +143,34 @@ Note that in this case its not possible to stop the YARN session using Flink. Use the YARN

[GitHub] flink pull request #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger sup...

2016-06-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2088#discussion_r66805682 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala --- @@ -122,14 +125,14 @@ object

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327534#comment-15327534 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327530#comment-15327530 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327533#comment-15327533 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327531#comment-15327531 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805492 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -300,18 +309,82 @@ public static boolean

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327532#comment-15327532 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327529#comment-15327529 ] ASF GitHub Bot commented on FLINK-3937: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805499 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -300,18 +309,82 @@ public static boolean

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805479 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java --- @@ -211,18 +185,45 @@ public void run() {

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805455 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -415,62 +513,83 @@ public int run(String[] args) {

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805382 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java --- @@ -211,18 +185,45 @@ public void run() {

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66805417 --- Diff: docs/apis/cli.md --- @@ -105,6 +105,10 @@ The command line can be used to ./bin/flink list -r +- List running Flink jobs

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327524#comment-15327524 ] ASF GitHub Bot commented on FLINK-3859: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger sup...

2016-06-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2088#discussion_r66804777 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala --- @@ -143,15 +143,30 @@ object

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327518#comment-15327518 ] ASF GitHub Bot commented on FLINK-3859: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger sup...

2016-06-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2088#discussion_r66804568 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala --- @@ -97,11 +97,26 @@ object CodeGenUtils {

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327501#comment-15327501 ] ASF GitHub Bot commented on FLINK-3937: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2085 Thanks a lot for adding this feature. I looked through the code and tried it out on a cluster. Once my concerns are addressed (either through changes or comments) we can merge the change. ---

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327495#comment-15327495 ] ASF GitHub Bot commented on FLINK-3937: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66801768 --- Diff: docs/setup/yarn_setup.md --- @@ -143,6 +143,34 @@ Note that in this case its not possible to stop the YARN session using Flink. Use the

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327491#comment-15327491 ] ASF GitHub Bot commented on FLINK-3937: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2085 Detached per job submission is not working (`./bin/flink run -m yarn-cluster -yd -yn 1 ./examples/batch/WordCount.jar `) ``` 2016-06-13 07:28:22,423 INFO

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327487#comment-15327487 ] ASF GitHub Bot commented on FLINK-3937: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2085 While trying out your code, I noticed that the `.yarn-properties` file is not properly deleted, even though my previous yarn session was shutting down correctly: ``` 2016-06-13

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66800124 --- Diff: docs/apis/cli.md --- @@ -252,6 +256,12 @@ Action "list" lists running and scheduled programs.

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327477#comment-15327477 ] ASF GitHub Bot commented on FLINK-3937: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters

2016-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327463#comment-15327463 ] ASF GitHub Bot commented on FLINK-3937: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66799100 --- Diff: docs/apis/cli.md --- @@ -105,6 +105,10 @@ The command line can be used to ./bin/flink list -r +- List running Flink

  1   2   >