[GitHub] flink issue #2356: [FLINK-4378]Enable RollingSink to custom HDFS client conf...

2016-10-26 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/2356 @aljoscha i have rebase the newest master branch, and forward port the changes in rollingsink to bucketsink --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-4378) Enable RollingSink to custom HDFS client configuration

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610584#comment-15610584 ] ASF GitHub Bot commented on FLINK-4378: --- Github user wenlong88 commented on the issue:

[jira] [Commented] (FLINK-4378) Enable RollingSink to custom HDFS client configuration

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610428#comment-15610428 ] ASF GitHub Bot commented on FLINK-4378: --- Github user wenlong88 commented on the issue:

[GitHub] flink issue #2356: [FLINK-4378]Enable RollingSink to custom HDFS client conf...

2016-10-26 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/2356 sorry,@aljoscha, I have miss the last message in august, I will update the pr quite soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Created] (FLINK-4938) Unnecessary update() call for Views to be removed in ViewUpdater#run()

2016-10-26 Thread Ted Yu (JIRA)
Ted Yu created FLINK-4938: - Summary: Unnecessary update() call for Views to be removed in ViewUpdater#run() Key: FLINK-4938 URL: https://issues.apache.org/jira/browse/FLINK-4938 Project: Flink

[jira] [Commented] (FLINK-4887) Replace ActorGateway by TaskManagerGateway interface

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609992#comment-15609992 ] ASF GitHub Bot commented on FLINK-4887: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #2699: [FLINK-4887] [execution graph] Introduce TaskManag...

2016-10-26 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2699 [FLINK-4887] [execution graph] Introduce TaskManagerGateway to encapsulate communcation logic This PR is based on #2689 and #2698. This PR introduces the `TaskManagerGateway` which is

[jira] [Commented] (FLINK-4889) Make InstanceManager independent of ActorRef

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609950#comment-15609950 ] ASF GitHub Bot commented on FLINK-4889: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #2698: [FLINK-4889] [InstanceManager] Remove ActorRef dep...

2016-10-26 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2698 [FLINK-4889] [InstanceManager] Remove ActorRef dependency from InstanceManager The `InstanceManager` should not know about the underlying RPC abstraction, namely Akka. Therefore, the PR

[jira] [Commented] (FLINK-4283) ExecutionGraphRestartTest fails

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609926#comment-15609926 ] ASF GitHub Bot commented on FLINK-4283: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2661: [FLINK-4283] ExecutionGraphRestartTest fails

2016-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-4283) ExecutionGraphRestartTest fails

2016-10-26 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-4283. -- Resolution: Fixed Fixed via b5938b052dfd1b4e9450c430446062852bca8850 >

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609915#comment-15609915 ] ASF GitHub Bot commented on FLINK-3347: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #2696: [FLINK-3347] [akka] Add QuarantineMonitor which sh...

2016-10-26 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2696 [FLINK-3347] [akka] Add QuarantineMonitor which shuts a quarantined actor system and JVM down The QuarantineMonitor subscribes to the actor system's event bus and listens to

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609883#comment-15609883 ] ASF GitHub Bot commented on FLINK-3347: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink issue #2356: [FLINK-4378]Enable RollingSink to custom HDFS client conf...

2016-10-26 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2356 @wenlong88 Are there any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-4378) Enable RollingSink to custom HDFS client configuration

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609785#comment-15609785 ] ASF GitHub Bot commented on FLINK-4378: --- Github user aljoscha commented on the issue:

[jira] [Closed] (FLINK-4907) Add Test for Timers/State Provided by AbstractStreamOperator

2016-10-26 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4907. --- Resolution: Fixed Done in

[jira] [Closed] (FLINK-4892) Snapshot TimerService using Key-Grouped State

2016-10-26 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4892. --- Resolution: Fixed Done in

[jira] [Closed] (FLINK-4924) Simplify Operator Test Harness Constructors

2016-10-26 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4924. --- > Simplify Operator Test Harness Constructors > --- > >

[jira] [Resolved] (FLINK-4924) Simplify Operator Test Harness Constructors

2016-10-26 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-4924. - Resolution: Fixed Fix Version/s: 1.2.0 Implemented in

[jira] [Commented] (FLINK-4924) Simplify Operator Test Harness Constructors

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609732#comment-15609732 ] ASF GitHub Bot commented on FLINK-4924: --- Github user aljoscha closed the pull request at:

[jira] [Updated] (FLINK-4937) Add incremental group window aggregation for streaming Table API

2016-10-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-4937: - Description: Group-window aggregates for streaming tables are currently not done in an

[jira] [Created] (FLINK-4937) Add incremental group window aggregation for streaming Table API

2016-10-26 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-4937: Summary: Add incremental group window aggregation for streaming Table API Key: FLINK-4937 URL: https://issues.apache.org/jira/browse/FLINK-4937 Project: Flink

[jira] [Closed] (FLINK-4691) Add group-windows for streaming tables

2016-10-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-4691. Resolution: Implemented Fix Version/s: 1.2.0 Implemented for 1.2.0 with

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609692#comment-15609692 ] ASF GitHub Bot commented on FLINK-4691: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

2016-10-26 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609680#comment-15609680 ] Pattarawat Chormai commented on FLINK-4917: --- Yeah, I'm also thinking about that. However, I'm

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

2016-10-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609660#comment-15609660 ] Fabian Hueske commented on FLINK-4917: -- When deprecating interfaces it is good practice to add a

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2686#discussion_r85218584 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/PowerExpressionTest.scala --- @@ -0,0 +1,149 @@ +/* + *

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609647#comment-15609647 ] ASF GitHub Bot commented on FLINK-4743: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609646#comment-15609646 ] ASF GitHub Bot commented on FLINK-4743: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2686#discussion_r85217190 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/AggregationsITCase.scala --- @@ -258,4 +258,22 @@ class

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

2016-10-26 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609614#comment-15609614 ] Pattarawat Chormai commented on FLINK-4917: --- If I understand correctly, what we have to do here

[jira] [Commented] (FLINK-4920) Add a Scala Function Gauge

2016-10-26 Thread Pattarawat Chormai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609584#comment-15609584 ] Pattarawat Chormai commented on FLINK-4920: --- Hi [~StephanEwen], I would like to work on this

[jira] [Commented] (FLINK-4894) Don't block on buffer request after broadcastEvent

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609415#comment-15609415 ] ASF GitHub Bot commented on FLINK-4894: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2690: [FLINK-4894] [network] Don't request buffer after writing...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2690 This looks very good. To double check: Do we have tests for the following situations? - Records larger than buffers - Records such that they exactly line up with buffer size

[jira] [Commented] (FLINK-4894) Don't block on buffer request after broadcastEvent

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609402#comment-15609402 ] ASF GitHub Bot commented on FLINK-4894: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2690: [FLINK-4894] [network] Don't request buffer after ...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2690#discussion_r85199848 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java --- @@ -108,15 +108,25 @@ private void

[jira] [Created] (FLINK-4936) Operator names for Gelly inputs

2016-10-26 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4936: - Summary: Operator names for Gelly inputs Key: FLINK-4936 URL: https://issues.apache.org/jira/browse/FLINK-4936 Project: Flink Issue Type: Improvement

[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2541 Okay, this has binary compatibility now. Few things I would still suggest to do: - There is still a bug that the `parallelism` and `port` parameter are mixed up. - It still does

[jira] [Commented] (FLINK-4669) scala api createLocalEnvironment() function add default Configuration parameter

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609302#comment-15609302 ] ASF GitHub Bot commented on FLINK-4669: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4579) Add StateBackendFactory for RocksDB Backend

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609290#comment-15609290 ] ASF GitHub Bot commented on FLINK-4579: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2482 Looks good, thanks! Rebasing and merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-2608) Arrays.asList(..) does not work with CollectionInputFormat

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609265#comment-15609265 ] ASF GitHub Bot commented on FLINK-2608: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2623: [FLINK-2608] Updated Twitter Chill version.

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2623 @chermenin Do you plan to continue with this pull request? Would be great if you I would suggest to adjust it in the following way: - Update the Chill dependency (validate if they

[GitHub] flink issue #2625: [FLINK-4801] [types] Input type inference is faulty with ...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2625 Looks reasonable to me, Travis tests pass. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-4801) Input type inference is faulty with custom Tuples and RichFunctions

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609089#comment-15609089 ] ASF GitHub Bot commented on FLINK-4801: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...

2016-10-26 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2425#discussion_r85175840 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -108,6 +111,11 @@ private final Options ALL_OPTIONS;

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609088#comment-15609088 ] ASF GitHub Bot commented on FLINK-3930: --- Github user mxm commented on a diff in the pull request:

[jira] [Created] (FLINK-4935) Submit job with savepoint via REST API

2016-10-26 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-4935: -- Summary: Submit job with savepoint via REST API Key: FLINK-4935 URL: https://issues.apache.org/jira/browse/FLINK-4935 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...

2016-10-26 Thread vijikarthi
Github user vijikarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/2425#discussion_r85167083 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -108,6 +111,11 @@ private final Options

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608966#comment-15608966 ] ASF GitHub Bot commented on FLINK-3930: --- Github user vijikarthi commented on a diff in the pull

[jira] [Commented] (FLINK-4861) Package optional project artifacts

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608896#comment-15608896 ] ASF GitHub Bot commented on FLINK-4861: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2664: [FLINK-4861] [build] Package optional project artifacts

2016-10-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2664 The mailing list conversation only included an indirect reference to including connectors in this `opt` directory. I was just trying to verify that we did in fact wish to include these.

[GitHub] flink issue #2460: [FLINK-4562] table examples make an divided module in fli...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2460 The repackaging is good. Unfortunately this breaks the Table API tests, because they use one of the examples. The Table API IT cases probably need to use their own programs, rather

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608887#comment-15608887 ] ASF GitHub Bot commented on FLINK-4562: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2452 @liuyuzhong Because we proceed with #2439 , can you close this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608867#comment-15608867 ] ASF GitHub Bot commented on FLINK-4521: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2664: [FLINK-4861] [build] Package optional project artifacts

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2664 What do you mean by "We should also consider allowing jars to be placed in subdirectories of Flink's lib folder."? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2431 @rmetzger and @iampeter What do you think about this pull request? Does this fit with the current Web UI efforts? --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-4861) Package optional project artifacts

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608863#comment-15608863 ] ASF GitHub Bot commented on FLINK-4861: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4861) Package optional project artifacts

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608864#comment-15608864 ] ASF GitHub Bot commented on FLINK-4861: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2664: [FLINK-4861] [build] Package optional project artifacts

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2664 Connectors are already included, correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2650: [FLINK-4563] [metrics] scope caching not adjusted for mul...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2650 I would suggest to not cache the filters and try to catch the "reporter uses changing filters" case: - It sounds like pre-mature optimization. Since one can use multiple reporters,

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608842#comment-15608842 ] ASF GitHub Bot commented on FLINK-4563: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2445: [FLINK-4544] Refactor old CPU metric initialization

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2445 The approach looks good, but I think it would be good to adjust a few things: - We are migrating most of the Scala code in `flink-runtime` to Java (for example in FLIP-6), so would be good

[jira] [Commented] (FLINK-4544) TaskManager metrics are vulnerable to custom JMX bean installation

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608808#comment-15608808 ] ASF GitHub Bot commented on FLINK-4544: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4861) Package optional project artifacts

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608782#comment-15608782 ] ASF GitHub Bot commented on FLINK-4861: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-4245) Metric naming improvements

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608758#comment-15608758 ] ASF GitHub Bot commented on FLINK-4245: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2418: [FLINK-4245] JMXReporter exposes all defined variables

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2418 Looks good, +1 to add this with minor comments. Two comments inline, and I would suggest to call `getLogicalName()` simply `getName()` or `getGroupName()`. --- If your project is set

[jira] [Commented] (FLINK-4245) Metric naming improvements

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608752#comment-15608752 ] ASF GitHub Bot commented on FLINK-4245: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4245) Metric naming improvements

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608751#comment-15608751 ] ASF GitHub Bot commented on FLINK-4245: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2418: [FLINK-4245] JMXReporter exposes all defined varia...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2418#discussion_r85145059 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -112,6 +116,43 @@ public

[GitHub] flink pull request #2418: [FLINK-4245] JMXReporter exposes all defined varia...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2418#discussion_r85146695 --- Diff: flink-metrics/flink-metrics-jmx/src/main/java/org/apache/flink/metrics/jmx/JMXReporter.java --- @@ -206,27 +211,24 @@ public void

[jira] [Commented] (FLINK-4913) Per-job Yarn clusters: include user jar in system class loader

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608702#comment-15608702 ] ASF GitHub Bot commented on FLINK-4913: --- Github user mxm commented on the issue:

[GitHub] flink issue #2692: [FLINK-4913][yarn] include user jar in system class loade...

2016-10-26 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2692 Thanks for checking out the changes. Yes, it is handled correctly. Indeed, I started off just thinking about the user-provided jar but then discovered that the `PackagedProgram` extracts nested

[jira] [Commented] (FLINK-4497) Add support for Scala tuples and case classes to Cassandra sink

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608662#comment-15608662 ] ASF GitHub Bot commented on FLINK-4497: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2633: [FLINK-4497] CassadraSink support for scala tuples/case c...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2633 Look pretty good. I think it would be good to try to make the Cassandra Module to the user Scala independent. That way, we don't introduce a hard requirement for Scala versioning and

[GitHub] flink issue #2661: [FLINK-4283] ExecutionGraphRestartTest fails

2016-10-26 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2661 Changes look good to me 👍 Thanks for your contribution @AlexanderShoshin :-) The failing tests are unrelated. Will merge this PR with the next batch. --- If your project is set up

[jira] [Commented] (FLINK-4283) ExecutionGraphRestartTest fails

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608632#comment-15608632 ] ASF GitHub Bot commented on FLINK-4283: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2664: [FLINK-4861] [build] Package optional project artifacts

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2664 I think this is a good idea. However, having all the individual dependency jar files in the folder makes it very hard to use. To actually use the libs (from an IDE without maven) it is very

[jira] [Commented] (FLINK-4861) Package optional project artifacts

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608623#comment-15608623 ] ASF GitHub Bot commented on FLINK-4861: --- Github user StephanEwen commented on the issue:

[jira] [Created] (FLINK-4934) Triadic Census

2016-10-26 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4934: - Summary: Triadic Census Key: FLINK-4934 URL: https://issues.apache.org/jira/browse/FLINK-4934 Project: Flink Issue Type: New Feature Components: Gelly

[jira] [Commented] (FLINK-4876) Allow web interface to be bound to a specific ip/interface/inetHost

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608314#comment-15608314 ] ASF GitHub Bot commented on FLINK-4876: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2680: [FLINK-4876] Allow web interface to be bound to a specifi...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2680 I added a new way to define configuration options (see below). It is a much more maintainable way of defining configuration options. Would be great if we used that for all new options

[jira] [Created] (FLINK-4933) ExecutionGraph.scheduleOrUpdateConsumers can fail the ExecutionGraph

2016-10-26 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4933: Summary: ExecutionGraph.scheduleOrUpdateConsumers can fail the ExecutionGraph Key: FLINK-4933 URL: https://issues.apache.org/jira/browse/FLINK-4933 Project: Flink

[jira] [Created] (FLINK-4932) Don't let ExecutionGraph fail when in state Restarting

2016-10-26 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4932: Summary: Don't let ExecutionGraph fail when in state Restarting Key: FLINK-4932 URL: https://issues.apache.org/jira/browse/FLINK-4932 Project: Flink Issue

[jira] [Assigned] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

2016-10-26 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-3347: Assignee: Till Rohrmann > TaskManager (or its ActorSystem) need to restart in case they

[jira] [Updated] (FLINK-4928) Implement FLIP-6 YARN Application Master Runner

2016-10-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-4928: Summary: Implement FLIP-6 YARN Application Master Runner (was: Implement YARN Application Master

[jira] [Updated] (FLINK-4929) Implement FLIP-6 YARN TaskManager Runner

2016-10-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-4929: Summary: Implement FLIP-6 YARN TaskManager Runner (was: Implement YARN TaskManager Runner) >

[jira] [Updated] (FLINK-4927) Implement FLI-6 YARN Resource Manager

2016-10-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-4927: Summary: Implement FLI-6 YARN Resource Manager (was: Implement YARN Resource Manager) > Implement

[jira] [Created] (FLINK-4930) Implement FLIP-6 YARN client

2016-10-26 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4930: --- Summary: Implement FLIP-6 YARN client Key: FLINK-4930 URL: https://issues.apache.org/jira/browse/FLINK-4930 Project: Flink Issue Type: Sub-task

[jira] [Closed] (FLINK-4931) Implement FLIP-6 YARN client

2016-10-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4931. --- Resolution: Duplicate Duplicate of FLINK-4930 > Implement FLIP-6 YARN client >

[jira] [Created] (FLINK-4931) Implement FLIP-6 YARN client

2016-10-26 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4931: --- Summary: Implement FLIP-6 YARN client Key: FLINK-4931 URL: https://issues.apache.org/jira/browse/FLINK-4931 Project: Flink Issue Type: Sub-task

[jira] [Assigned] (FLINK-4911) Non-disruptive JobManager Failures via Reconciliation

2016-10-26 Thread Zhijiang Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhijiang Wang reassigned FLINK-4911: Assignee: Zhijiang Wang > Non-disruptive JobManager Failures via Reconciliation >

[jira] [Created] (FLINK-4929) Implement YARN TaskManager Runner

2016-10-26 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4929: --- Summary: Implement YARN TaskManager Runner Key: FLINK-4929 URL: https://issues.apache.org/jira/browse/FLINK-4929 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-4924) Simplify Operator Test Harness Constructors

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608180#comment-15608180 ] ASF GitHub Bot commented on FLINK-4924: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #2695: [FLINK-4924] Simplify Operator Test Harness Constr...

2016-10-26 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2695 [FLINK-4924] Simplify Operator Test Harness Constructors R: @StefanRRichter for review, please. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (FLINK-4928) Implement YARN Application Master Runner

2016-10-26 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4928: --- Summary: Implement YARN Application Master Runner Key: FLINK-4928 URL: https://issues.apache.org/jira/browse/FLINK-4928 Project: Flink Issue Type: Sub-task

  1   2   >