[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906128#comment-15906128 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3484 @kl0u @chenqin I cleaned up the commits, distributed the fixes from the comments to the right commits. I also added more tests/ITCases for: detecting name clashes in side output IDs, side outputs

[jira] [Created] (FLINK-6024) Need more fine-grained info for "InvalidProgramException: This type (...) cannot be used as key"

2017-03-10 Thread Luke Hutchison (JIRA)
Luke Hutchison created FLINK-6024: - Summary: Need more fine-grained info for "InvalidProgramException: This type (...) cannot be used as key" Key: FLINK-6024 URL: https://issues.apache.org/jira/browse/FLINK-6024

[jira] [Updated] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-03-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5541: -- Description: {code} if (localJar == null) { try { for (final URL url :

[jira] [Closed] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-6023. - Resolution: Fixed Fix Version/s: (was: 1.2.1) > Fix Scala snippet into Process Function

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906019#comment-15906019 ] ASF GitHub Bot commented on FLINK-6023: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3510 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Comment Edited] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2017-03-10 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905779#comment-15905779 ] Luke Hutchison edited comment on FLINK-4785 at 3/10/17 11:48 PM: - I'm

[jira] [Closed] (FLINK-5954) Always assign names to the window in the Stream SQL API

2017-03-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5954. Resolution: Implemented Fix Version/s: 1.3.0 Implemented with

[GitHub] flink pull request #3461: [FLINK-5954] Always assign names to the window in ...

2017-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5954) Always assign names to the window in the Stream SQL API

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905871#comment-15905871 ] ASF GitHub Bot commented on FLINK-5954: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6007) ConcurrentModificationException in WatermarkCallbackService

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905848#comment-15905848 ] ASF GitHub Bot commented on FLINK-6007: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3514 [FLINK-6007] Allow key removal from within the watermark callback. When deleting a key from the InternalWatermarkCallbackService, the deleted key is put into a separate set, and the actual deletion

[GitHub] flink pull request #3513: [hotfix] [doc] Fix error in ProcessFunction exampl...

2017-03-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3513 [hotfix] [doc] Fix error in ProcessFunction example. Fixes an error in the `ProcessFunction` documentation that was reported in the mailing list. You can merge this pull request into a Git repository

[GitHub] flink issue #3433: [FLINK-5911] [gelly] Command-line parameters

2017-03-10 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3433 @vasia reusable parameters will make it much easier to add drivers and inputs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5911) Command-line parameters

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905792#comment-15905792 ] ASF GitHub Bot commented on FLINK-5911: --- Github user greghogan commented on the issue:

[jira] [Closed] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-10 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-5874. - Resolution: Fixed > Reject arrays as keys in DataStream API to avoid inconsistent hashing >

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-10 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905789#comment-15905789 ] Kostas Kloudas commented on FLINK-5874: --- Merged at f15a7d2d9c9aae72bb3ac3eb2478b3ec4759401b >

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905788#comment-15905788 ] ASF GitHub Bot commented on FLINK-5874: --- Github user asfgit closed the pull request at:

[jira] [Issue Comment Deleted] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2017-03-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-4785: - Comment: was deleted (was: Copying the issue description of FLINK-6017 {quote} The RFC for the

[jira] [Commented] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2017-03-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905787#comment-15905787 ] Fabian Hueske commented on FLINK-4785: -- Oh, yes. Sorry for the confusion. I'll delete my comment. >

[jira] [Commented] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2017-03-10 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905779#comment-15905779 ] Luke Hutchison commented on FLINK-4785: --- I'm pretty sure I have seen backslash escaping in CSV

[jira] [Commented] (FLINK-6017) CSV reader does not support quoted double quotes

2017-03-10 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905775#comment-15905775 ] Luke Hutchison commented on FLINK-6017: --- Thanks, sorry for the dup! > CSV reader does not support

[jira] [Commented] (FLINK-2814) DeltaIteration: DualInputPlanNode cannot be cast to SingleInputPlanNode

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905762#comment-15905762 ] ASF GitHub Bot commented on FLINK-2814: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2029: [FLINK-2814] Fix for DualInputPlanNode cannot be cast to ...

2017-03-10 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2029 @StephanEwen should I create an alternate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Closed] (FLINK-6017) CSV reader does not support quoted double quotes

2017-03-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6017. Resolution: Duplicate Thanks for reporting this issue [~lukehutch]. This is a duplicate of

[jira] [Commented] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2017-03-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905696#comment-15905696 ] Fabian Hueske commented on FLINK-4785: -- Copying the issue description of FLINK-6017 {quote} The RFC

[jira] [Commented] (FLINK-5995) Get a Exception when creating the ListStateDescriptor with a TypeInformation

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905681#comment-15905681 ] ASF GitHub Bot commented on FLINK-5995: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

2017-03-10 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3503 That sounds reasonable! On Mar 10, 2017 4:07 PM, "Jincheng Sun" wrote: > Hi,@StephanEwen , Thanks a lot for your >

[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3484 Thanks @kl0u for the (already) quite thorough review! I'll push a commit with fixes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905414#comment-15905414 ] ASF GitHub Bot commented on FLINK-4460: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105441679 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905412#comment-15905412 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105441456 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905390#comment-15905390 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905381#comment-15905381 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105436408 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -539,5 +625,26 @@ public void

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105436193 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -387,14 +403,25 @@ public int

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905380#comment-15905380 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905378#comment-15905378 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105435806 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java --- @@ -72,6 +76,11 @@ public

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905376#comment-15905376 ] ASF GitHub Bot commented on FLINK-6008: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-03-10 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3512 [FLINK-6008] collection of BlobServer improvements This PR improves the following things around the `BlobServer`/`BlobCache`: * replaces config uptions in `config.md` with non-deprecated

[jira] [Updated] (FLINK-6008) collection of BlobServer improvements

2017-03-10 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6008: --- Description: The following things should be improved around the BlobServer/BlobCache: * update config

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905315#comment-15905315 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #3510: [FLINK-6023] Fix Scala snippet into Process Function Doc

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3510 Thanks @maocorte for the quick fix, looks good to merge now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Closed] (FLINK-5910) Framework for Gelly examples

2017-03-10 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-5910. - Resolution: Implemented Implemented in 70e78a620df503f06e298dd5537f24a56a8cc866 > Framework for Gelly

[jira] [Closed] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-03-10 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-5890. - Resolution: Fixed Fixed in 694794eb6cbb63dace5a3389a99878f952f0faa5 > GatherSumApply broken when object

[jira] [Commented] (FLINK-5910) Framework for Gelly examples

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905299#comment-15905299 ] ASF GitHub Bot commented on FLINK-5910: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905298#comment-15905298 ] ASF GitHub Bot commented on FLINK-5890: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3431: [FLINK-5910] [gelly] Framework for Gelly examples

2017-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3402: [FLINK-5890] [gelly] GatherSumApply broken when ob...

2017-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905288#comment-15905288 ] ASF GitHub Bot commented on FLINK-6023: --- Github user maocorte commented on the issue:

[GitHub] flink issue #3510: [FLINK-6023] Fix Scala snippet into Process Function Doc

2017-03-10 Thread maocorte
Github user maocorte commented on the issue: https://github.com/apache/flink/pull/3510 thank you @KurtYoung for your review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3446: [FLINK-5940] [checkpoint] Harden ZooKeeperCompletedCheckp...

2017-03-10 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3446 The mocking is indeed a little bit complex in this case. The problem is that you also want to check that a state handle which fails to retrieve its state, is properly discarded. This discard

[jira] [Commented] (FLINK-5940) ZooKeeperCompletedCheckpointStore cannot handle broken state handles

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905282#comment-15905282 ] ASF GitHub Bot commented on FLINK-5940: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105422108 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905279#comment-15905279 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105419777 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905271#comment-15905271 ] ASF GitHub Bot commented on FLINK-6023: --- Github user maocorte commented on a diff in the pull

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread maocorte
Github user maocorte commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105420747 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905267#comment-15905267 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105420103 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905265#comment-15905265 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105420011 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905263#comment-15905263 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5940) ZooKeeperCompletedCheckpointStore cannot handle broken state handles

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905258#comment-15905258 ] ASF GitHub Bot commented on FLINK-5940: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3446: [FLINK-5940] [checkpoint] Harden ZooKeeperComplete...

2017-03-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3446#discussion_r105419062 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java --- @@ -226,16 +200,43 @@ public

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905257#comment-15905257 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105418830 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-5940) ZooKeeperCompletedCheckpointStore cannot handle broken state handles

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905251#comment-15905251 ] ASF GitHub Bot commented on FLINK-5940: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3446: [FLINK-5940] [checkpoint] Harden ZooKeeperComplete...

2017-03-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3446#discussion_r105417543 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java --- @@ -226,16 +200,43 @@ public

[jira] [Commented] (FLINK-5942) Harden ZooKeeperStateHandleStore to deal with corrupted data

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905242#comment-15905242 ] ASF GitHub Bot commented on FLINK-5942: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3510: [FLINK-6023] Fix Scala snippet into Process Functi...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3510#discussion_r105417009 --- Diff: docs/dev/stream/process_function.md --- @@ -176,56 +176,57 @@ public class CountWithTimeoutFunction extends RichProcessFunction

[jira] [Commented] (FLINK-6023) Fix Scala snippet into Process Function (Low-level Operations) Doc

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905244#comment-15905244 ] ASF GitHub Bot commented on FLINK-6023: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3447: [FLINK-5942] [checkpoint] Harden ZooKeeperStateHan...

2017-03-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3447#discussion_r105416999 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java --- @@ -240,7 +241,7 @@ public int

[jira] [Commented] (FLINK-5995) Get a Exception when creating the ListStateDescriptor with a TypeInformation

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905216#comment-15905216 ] ASF GitHub Bot commented on FLINK-5995: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

2017-03-10 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3503 Hi,@StephanEwen, Thanks a lot for your comment. I seriously think about where to add the test more is reasonable, because the change of this PR is `OperatorStateBackend`, so I added the test

[jira] [Commented] (FLINK-5971) JobLeaderIdService should time out registered jobs

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905211#comment-15905211 ] ASF GitHub Bot commented on FLINK-5971: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #3488: [FLINK-5971] [flip-6] Add timeout for registered jobs on ...

2017-03-10 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3488 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #3511: Flink 5734 code generation for normalizedkey sorte...

2017-03-10 Thread heytitle
GitHub user heytitle opened a pull request: https://github.com/apache/flink/pull/3511 Flink 5734 code generation for normalizedkey sorter You can merge this pull request into a Git repository by running: $ git pull https://github.com/heytitle/flink

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105398836 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java --- @@ -300,6 +303,36 @@ private StreamGraph

[GitHub] flink issue #3501: [FLINK-5874] Restrict key types in the DataStream API.

2017-03-10 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3501 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402746 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1528,14 +1572,16 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105409533 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java --- @@ -72,6 +76,11 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105401808 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -441,26 +491,55 @@ public void close() {

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905201#comment-15905201 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905199#comment-15905199 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397306 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105403355 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/MockOutput.java --- @@ -40,6 +41,12 @@ public void collect(StreamRecord record) {

[jira] [Commented] (FLINK-5936) Can't pass keyed vectors to KNN join algorithm

2017-03-10 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905191#comment-15905191 ] Till Rohrmann commented on FLINK-5936: -- The {{PredictDataSetOperation}} is used in the {{KNN}} as

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905177#comment-15905177 ] ASF GitHub Bot commented on FLINK-5874: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105399457 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SideOutputTransformation.java --- @@ -0,0 +1,72 @@ +/* + *

[GitHub] flink issue #3501: [FLINK-5874] Restrict key types in the DataStream API.

2017-03-10 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3501 Done! Let me know if you have any additional comments @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105407025 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,243 @@ public void testChannelSelectors()

[jira] [Commented] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905180#comment-15905180 ] ASF GitHub Bot commented on FLINK-5874: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905145#comment-15905145 ] ASF GitHub Bot commented on FLINK-4460: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105407208 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors() {

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397096 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeHint.java --- @@ -46,7 +46,15 @@ public TypeHint() {

  1   2   3   >