[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4240 @aljoscha It is also a problem for 1.3. It's even worse since it still uses the scala.binary.version property, which thus may try to fetch a 2.11 version of quasiquotes which just doesn't exist.

[jira] [Commented] (FLINK-7178) Datadog Metric Reporter Jar is Lacking Dependencies

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089864#comment-16089864 ] ASF GitHub Bot commented on FLINK-7178: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4326: [FLINK-7178] [metrics] Do not create separate shaded jars

2017-07-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4326 @zentol What's the plan for merging this? (Asking because it's one of the remaining blockers for `1.3.2`) --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089852#comment-16089852 ] ASF GitHub Bot commented on FLINK-7058: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4240 This is not relevant for the `release-1.3` branch? (I'm asking because that one still has some issues) --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089829#comment-16089829 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r127709120 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java --- @@ -18,20 +18,40 @@ package

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089828#comment-16089828 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r127708906 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java --- @@ -18,20 +18,40 @@ package

[jira] [Commented] (FLINK-7212) JobManagerLeaderSessionIDITSuite not executed

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089811#comment-16089811 ] ASF GitHub Bot commented on FLINK-7212: --- Github user zentol commented on the issue:

[GitHub] flink issue #4354: [FLINK-7212][tests] re-enable JobManagerLeaderSessionIDIT...

2017-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4354 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-7212) JobManagerLeaderSessionIDITSuite not executed

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089803#comment-16089803 ] ASF GitHub Bot commented on FLINK-7212: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4354: [FLINK-7212][tests] re-enable JobManagerLeaderSess...

2017-07-17 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4354 [FLINK-7212][tests] re-enable JobManagerLeaderSessionIDITCase This test was previously named JobManagerLeaderSessionIDITSuite and has not been executed for a while by maven because of it having

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089800#comment-16089800 ] ASF GitHub Bot commented on FLINK-7213: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4353: [FLINK-7213] Introduce state management by OperatorID in ...

2017-07-17 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4353 CC @StephanEwen @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-7205) Add UUID supported in TableAPI/SQL

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089799#comment-16089799 ] Fabian Hueske commented on FLINK-7205: -- The spatial uniqueness could be obtained from the id of the

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089798#comment-16089798 ] ASF GitHub Bot commented on FLINK-7213: --- GitHub user StefanRRichter opened a pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-17 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4353 [FLINK-7213] Introduce state management by OperatorID in TaskManager Flink-5892 introduced the job manager / checkpoint coordinator part of managing state on the operator level instead of

[jira] [Created] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-17 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-7213: - Summary: Introduce state management by OperatorID in TaskManager Key: FLINK-7213 URL: https://issues.apache.org/jira/browse/FLINK-7213 Project: Flink

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089763#comment-16089763 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4263 Hi @rtudoran, you are right, I said we will need retraction for OFFSET and FETCH. However, it is only required for the general case and the special case of `ORDER BY *time ASC` without updates

[jira] [Created] (FLINK-7212) JobManagerLeaderSessionIDITSuite not executed

2017-07-17 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7212: -- Summary: JobManagerLeaderSessionIDITSuite not executed Key: FLINK-7212 URL: https://issues.apache.org/jira/browse/FLINK-7212 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089733#comment-16089733 ] ASF GitHub Bot commented on FLINK-6725: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3993: [FLINK-6725][table] make requiresOver as a contracted met...

2017-07-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3993 No worries. Thanks for the update! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089732#comment-16089732 ] Fabian Hueske commented on FLINK-7194: -- In what sense is {{ScalarFunction.getResultType()}} different

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089712#comment-16089712 ] ASF GitHub Bot commented on FLINK-7058: --- Github user zentol commented on the issue:

[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4240 LGTM, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-7203) Remove useless "flink-avro" module

2017-07-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089700#comment-16089700 ] Aljoscha Krettek commented on FLINK-7203: - How do you mean? I still see {{AvroInputFormat}} and

[jira] [Assigned] (FLINK-7151) FLINK SQL support create temporary function and table

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-7151: Assignee: yuemeng > FLINK SQL support create temporary function and table >

[jira] [Commented] (FLINK-7151) FLINK SQL support create temporary function and table

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089680#comment-16089680 ] Fabian Hueske commented on FLINK-7151: -- Sure Can you briefly describe how you are planning to address

[GitHub] flink issue #4350: [FLINK-7204] [core] CombineHint.NONE

2017-07-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4350 Hi @greghogan, I think this is definitely a valuable improvement. However, I looked at the plan of a query with a `ReduceFunction` with `CombineHint.None` and found that it still has a combine

[jira] [Commented] (FLINK-7204) CombineHint.NONE

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089678#comment-16089678 ] ASF GitHub Bot commented on FLINK-7204: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089646#comment-16089646 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4324: [FLINK-6232] [table] Add processing time window inner joi...

2017-07-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4324 Hi @hongyuhong, thanks for your feedback! I agree, passing good error messages to users is important. However, this is very difficult in the optimizer because the optimizer is exploring different

[jira] [Commented] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089625#comment-16089625 ] Fabian Hueske commented on FLINK-7101: -- Hi [~sunjincheng121], is [PR

[jira] [Commented] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089622#comment-16089622 ] ASF GitHub Bot commented on FLINK-7101: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...

2017-07-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4348#discussion_r127677326 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala --- @@ -131,7 +131,8 @@ class

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089603#comment-16089603 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3829: [FLINK-6442] [table] Extend TableAPI Support Sink Table R...

2017-07-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3829 Thanks for the reply @lincoln-lil. I agree, it is possible that a `TableSink` defines its schema when it is created instead of when it is configured by the optimizer. However, I think

[jira] [Closed] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

2017-07-17 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-6887. -- Resolution: Fixed Fixed in 527e7499c5807be138d1ba0a278917190a7d4cf1 > Split up CodeGenerator into several

[GitHub] flink pull request #4171: [FLINK-6887] [table] Split up CodeGenerator into s...

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089590#comment-16089590 ] ASF GitHub Bot commented on FLINK-6887: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7175) Add simple benchmark suite for Flink

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089566#comment-16089566 ] ASF GitHub Bot commented on FLINK-7175: --- Github user pnowojski commented on the issue:

[jira] [Commented] (FLINK-7175) Add simple benchmark suite for Flink

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089567#comment-16089567 ] ASF GitHub Bot commented on FLINK-7175: --- Github user pnowojski closed the pull request at:

[GitHub] flink issue #4323: [FLINK-7175] Add first simplest Flink benchmark

2017-07-17 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4323 Closing this PR. Benchmarks will be in separate repository. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #4323: [FLINK-7175] Add first simplest Flink benchmark

2017-07-17 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/4323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7211) Exclude Gelly javadoc jar from release

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089544#comment-16089544 ] ASF GitHub Bot commented on FLINK-7211: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #4352: [FLINK-7211] [build] Exclude Gelly javadoc jar fro...

2017-07-17 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4352 [FLINK-7211] [build] Exclude Gelly javadoc jar from release You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[jira] [Created] (FLINK-7211) Exclude Gelly javadoc jar from release

2017-07-17 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-7211: - Summary: Exclude Gelly javadoc jar from release Key: FLINK-7211 URL: https://issues.apache.org/jira/browse/FLINK-7211 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-07-17 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7210: -- Description: To implement exactly-once sink there is a re-occurring pattern for doing it - two

[jira] [Commented] (FLINK-5775) NullReferenceException when running job on local cluster

2017-07-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089534#comment-16089534 ] Aljoscha Krettek commented on FLINK-5775: - Please re-open if there's more information. >

[jira] [Created] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-07-17 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-7210: - Summary: Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way) Key: FLINK-7210 URL: https://issues.apache.org/jira/browse/FLINK-7210

[jira] [Closed] (FLINK-5775) NullReferenceException when running job on local cluster

2017-07-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-5775. --- Resolution: Cannot Reproduce > NullReferenceException when running job on local cluster >

[jira] [Updated] (FLINK-7209) Support DataView in Java and Scala Tuples and case classes or as the accumulator of AggregateFunction itself

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-7209: -- Issue Type: Sub-task (was: Improvement) Parent: FLINK-6544 > Support DataView in Java and

[jira] [Updated] (FLINK-7207) Support getAccumulatorType when use DataView

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-7207: -- Issue Type: Sub-task (was: Improvement) Parent: FLINK-6544 > Support getAccumulatorType when

[jira] [Updated] (FLINK-7208) Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-7208: -- Issue Type: Sub-task (was: Improvement) Parent: FLINK-6544 > Refactor build-in

[jira] [Updated] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-7206: -- Issue Type: Sub-task (was: Improvement) Parent: FLINK-6544 > Implementation of DataView to

[jira] [Created] (FLINK-7209) Support DataView in Java and Scala Tuples and case classes or as the accumulator of AggregateFunction itself

2017-07-17 Thread Kaibo Zhou (JIRA)
Kaibo Zhou created FLINK-7209: - Summary: Support DataView in Java and Scala Tuples and case classes or as the accumulator of AggregateFunction itself Key: FLINK-7209 URL:

[jira] [Commented] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089495#comment-16089495 ] ASF GitHub Bot commented on FLINK-6887: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4171: [FLINK-6887] [table] Split up CodeGenerator into several ...

2017-07-17 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4171 @fhueske thanks for reviewing. I had fixed the code style issue. I will merge this once the CI pass. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Created] (FLINK-7208) Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView

2017-07-17 Thread Kaibo Zhou (JIRA)
Kaibo Zhou created FLINK-7208: - Summary: Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView Key: FLINK-7208 URL: https://issues.apache.org/jira/browse/FLINK-7208

[jira] [Created] (FLINK-7207) Support getAccumulatorType when use DataView

2017-07-17 Thread Kaibo Zhou (JIRA)
Kaibo Zhou created FLINK-7207: - Summary: Support getAccumulatorType when use DataView Key: FLINK-7207 URL: https://issues.apache.org/jira/browse/FLINK-7207 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-7206: -- Description: Implementation of MapView and ListView to support state access for UDAGG. >

[jira] [Updated] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-7206: -- Environment: (was: Implementation of MapView and ListView to support state access for UDAGG.) >

[jira] [Created] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-07-17 Thread Kaibo Zhou (JIRA)
Kaibo Zhou created FLINK-7206: - Summary: Implementation of DataView to support state access for UDAGG Key: FLINK-7206 URL: https://issues.apache.org/jira/browse/FLINK-7206 Project: Flink Issue

[jira] [Commented] (FLINK-6544) Expose State Backend Interface for UDAGG

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089489#comment-16089489 ] Kaibo Zhou commented on FLINK-6544: --- Hi all, as discussed in the documentation, I will create some

[jira] [Updated] (FLINK-6544) Expose State Backend Interface for UDAGG

2017-07-17 Thread Kaibo Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaibo Zhou updated FLINK-6544: -- Description: Currently UDAGG users can not access state, it's necessary to provide users with a

[GitHub] flink pull request #4351: [FLINK-6544] [table] Expose State Backend Interfac...

2017-07-17 Thread kaibozhou
Github user kaibozhou closed the pull request at: https://github.com/apache/flink/pull/4351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6544) Expose State Backend Interface for UDAGG

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089475#comment-16089475 ] ASF GitHub Bot commented on FLINK-6544: --- Github user kaibozhou closed the pull request at:

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089482#comment-16089482 ] ASF GitHub Bot commented on FLINK-6075: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-17 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4263 @rtudoran "SELECT x FROM stream ORDER BY *time FETCH 2" do not need retraction. Because it is order by ascending time. The query will only emit the first 2 rows and after that drop all rows. We

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089436#comment-16089436 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on the issue:

[GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-17 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/4263 @fhueske You were the one that argue that retraction support is needed for offset and fetch. When we were discussing this i was not into having the retraction. I think finally it depends on what

[jira] [Closed] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-07-17 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-6725. Resolution: Won't Fix > make requiresOver as a contracted method in udagg >

[jira] [Commented] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089427#comment-16089427 ] ASF GitHub Bot commented on FLINK-6725: --- Github user shaoxuan-wang commented on the issue:

[jira] [Commented] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089428#comment-16089428 ] ASF GitHub Bot commented on FLINK-6725: --- Github user shaoxuan-wang closed the pull request at:

[GitHub] flink issue #3993: [FLINK-6725][table] make requiresOver as a contracted met...

2017-07-17 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3993 @fhueske @sunjincheng121 @wuchong, thanks for the valuable inputs. We talked offline and get an agreement that we'd better to put `getAccumulatorType()`, `getResultType()` etc. in

[GitHub] flink pull request #3993: [FLINK-6725][table] make requiresOver as a contrac...

2017-07-17 Thread shaoxuan-wang
Github user shaoxuan-wang closed the pull request at: https://github.com/apache/flink/pull/3993 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-17 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089419#comment-16089419 ] Ruidong Li commented on FLINK-7194: --- [~fhueske]I agree to your suggestion, but the {{getResultType()}}

[GitHub] flink pull request #3672: [Flink-6072] TestCase CheckpointStateRestoreTest::...

2017-07-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3672#discussion_r127641370 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskState.java --- @@ -20,6 +20,7 @@ import

[GitHub] flink pull request #3672: [Flink-6072] TestCase CheckpointStateRestoreTest::...

2017-07-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3672#discussion_r127641519 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -949,8 +949,6 @@ public void run() {

[GitHub] flink pull request #3672: [Flink-6072] TestCase CheckpointStateRestoreTest::...

2017-07-17 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3672#discussion_r127641085 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointStateRestoreTest.java --- @@ -66,10 +66,19 @@ public void

[jira] [Commented] (FLINK-6923) Kafka connector needs to expose information about in-flight record in AbstractFetcher base class

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089387#comment-16089387 ] ASF GitHub Bot commented on FLINK-6923: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4149: [FLINK-6923] [Kafka Connector] Expose in-processing/in-fl...

2017-07-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4149 +1 agree with @aljoscha here. The main problem with this change is that there is no usages of it in other parts of the codebase, and can very easily be removed "accidentally" in the future.

[jira] [Updated] (FLINK-5878) Add stream-stream inner/left-out join

2017-07-17 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-5878: - Summary: Add stream-stream inner/left-out join (was: Add stream-stream inner join on TableAPI)

[jira] [Assigned] (FLINK-5878) Add stream-stream inner/left-out join

2017-07-17 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-5878: Assignee: Hequn Cheng (was: Shaoxuan Wang) > Add stream-stream inner/left-out join >

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089359#comment-16089359 ] ASF GitHub Bot commented on FLINK-6998: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089358#comment-16089358 ] ASF GitHub Bot commented on FLINK-6998: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089356#comment-16089356 ] ASF GitHub Bot commented on FLINK-6998: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089357#comment-16089357 ] ASF GitHub Bot commented on FLINK-6998: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-17 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127636481 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --- @@

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-17 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127636725 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -505,6

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-17 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127636859 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java --- @@

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-17 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127636523 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -185,6

<    1   2