[GitHub] flink pull request #5222: Fix typo in docs/dev/api_concepts.md

2017-12-31 Thread okumin
GitHub user okumin opened a pull request: https://github.com/apache/flink/pull/5222 Fix typo in docs/dev/api_concepts.md *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in

[GitHub] flink pull request #5221: [hotfix] [docs] Format Scala programs in docs

2017-12-31 Thread okumin
GitHub user okumin opened a pull request: https://github.com/apache/flink/pull/5221 [hotfix] [docs] Format Scala programs in docs *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your

[jira] [Closed] (FLINK-8227) Optimize the performance of SharedBufferSerializer

2017-12-31 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-8227. -- > Optimize the performance of SharedBufferSerializer > -- > >

[jira] [Resolved] (FLINK-8227) Optimize the performance of SharedBufferSerializer

2017-12-31 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu resolved FLINK-8227. Resolution: Fixed > Optimize the performance of SharedBufferSerializer >

[jira] [Commented] (FLINK-8226) Dangling reference generated after NFA clean up timed out SharedBufferEntry

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307367#comment-16307367 ] ASF GitHub Bot commented on FLINK-8226: --- Github user dianfu commented on a diff in the pull request:

[GitHub] flink pull request #5141: [FLINK-8226] [cep] Dangling reference generated af...

2017-12-31 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/5141#discussion_r159149194 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -191,22 +191,28 @@ public boolean isEmpty() {

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148351 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307349#comment-16307349 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307346#comment-16307346 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307348#comment-16307348 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307351#comment-16307351 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148499 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala --- @@ -58,4 +58,22 @@ object

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307354#comment-16307354 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148345 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307347#comment-16307347 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307353#comment-16307353 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307350#comment-16307350 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307355#comment-16307355 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307352#comment-16307352 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148353 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148352 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148346 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148340 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148053 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala --- @@ -1216,6 +1216,69 @@ class

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148349 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -109,4 +110,75 @@ object

[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5202#discussion_r159148500 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala --- @@ -58,4 +58,22 @@ object

[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-12-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307281#comment-16307281 ] Ted Yu commented on FLINK-6105: --- In

[jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307274#comment-16307274 ] ASF GitHub Bot commented on FLINK-8333: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...

2017-12-31 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5220 [FLINK-8333] [flip6] Separate deployment options from command options ## What is the purpose of the change This commit separates the parsing of command options and deployment options

[jira] [Created] (FLINK-8333) Split command options from deployment options in CliFrontend

2017-12-31 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8333: Summary: Split command options from deployment options in CliFrontend Key: FLINK-8333 URL: https://issues.apache.org/jira/browse/FLINK-8333 Project: Flink

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307269#comment-16307269 ] ASF GitHub Bot commented on FLINK-8332: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2017-12-31 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5219 [FLINK-8332] [flip6] Move savepoint dispose into ClusterClient ## What is the purpose of the change Move the savepoint disposal logic from the CliFrontend into the ClusterClient. This

[jira] [Created] (FLINK-8332) Move dispose savepoint into ClusterClient

2017-12-31 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8332: Summary: Move dispose savepoint into ClusterClient Key: FLINK-8332 URL: https://issues.apache.org/jira/browse/FLINK-8332 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8329) Move YarnClient out of YarnClusterClient

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307268#comment-16307268 ] ASF GitHub Bot commented on FLINK-8329: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5216: [FLINK-8329] [flip6] Move YarnClient to AbstractYarnClust...

2017-12-31 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5216 Corrected the checkstyle violations. ---

[jira] [Closed] (FLINK-8330) Remove FlinkYarnCLI

2017-12-31 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8330. Resolution: Fixed Removed via ce62945ae6c1b1878bebc9a528e63ef7a54cb897 > Remove FlinkYarnCLI >

[jira] [Commented] (FLINK-8330) Remove FlinkYarnCLI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307246#comment-16307246 ] ASF GitHub Bot commented on FLINK-8330: --- Github user tillrohrmann closed the pull request at:

[GitHub] flink pull request #5217: [FLINK-8330] [flip6] Remove FlinkYarnCLI

2017-12-31 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/5217 ---

[jira] [Commented] (FLINK-8330) Remove FlinkYarnCLI

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307243#comment-16307243 ] ASF GitHub Bot commented on FLINK-8330: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5217: [FLINK-8330] [flip6] Remove FlinkYarnCLI

2017-12-31 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5217 Thanks for the review @GJL. Merging this PR. ---

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2017-12-31 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307241#comment-16307241 ] Till Rohrmann commented on FLINK-8268: -- Just for the record: Another test failure on Travis:

[jira] [Closed] (FLINK-8171) Remove work arounds in Flip6LocalStreamEnvironment

2017-12-31 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8171. Resolution: Fixed Fixed via 8e7a71c053135fdce4073eaf8022d5727d87b5fa > Remove work arounds in

[jira] [Commented] (FLINK-8171) Remove work arounds in Flip6LocalStreamEnvironment

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307238#comment-16307238 ] ASF GitHub Bot commented on FLINK-8171: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5101: [FLINK-8171] [flip6] Remove work arounds from Flip...

2017-12-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5101 ---

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307217#comment-16307217 ] ASF GitHub Bot commented on FLINK-8331: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #5218: [FLINK-8331][core] FieldParser do not correctly set EMPT_...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5218 @fhueske thanks for your explanation, make sense to me. I updated the PR. The changes as follows: - Revert the change of `RowCsvInputFormatTest.testTailingEmptyFields`. - Unity

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307201#comment-16307201 ] ASF GitHub Bot commented on FLINK-8331: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159139198 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java --- @@ -407,26 +407,47 @@ public void

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307198#comment-16307198 ] ASF GitHub Bot commented on FLINK-8331: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159139167 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java --- @@ -362,61 +365,95 @@ public void

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307168#comment-16307168 ] ASF GitHub Bot commented on FLINK-8331: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159137345 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java --- @@ -407,26 +407,47 @@ public void

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307162#comment-16307162 ] ASF GitHub Bot commented on FLINK-8331: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159136839 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java --- @@ -407,26 +407,47 @@ public void

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307153#comment-16307153 ] ASF GitHub Bot commented on FLINK-8331: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307155#comment-16307155 ] ASF GitHub Bot commented on FLINK-8331: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307154#comment-16307154 ] ASF GitHub Bot commented on FLINK-8331: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159135944 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java --- @@ -407,26 +407,47 @@ public void

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159135908 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java --- @@ -407,26 +407,47 @@ public void

[GitHub] flink pull request #5218: [FLINK-8331][core] FieldParser do not correctly se...

2017-12-31 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5218#discussion_r159136001 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java --- @@ -362,61 +365,95 @@ public void

[jira] [Commented] (FLINK-7155) Add Influxdb metrics reporter

2017-12-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307152#comment-16307152 ] ASF GitHub Bot commented on FLINK-7155: --- Github user gobozov commented on a diff in the pull

[GitHub] flink pull request #4299: [FLINK-7155] [metrics] Add Influxdb reporter

2017-12-31 Thread gobozov
Github user gobozov commented on a diff in the pull request: https://github.com/apache/flink/pull/4299#discussion_r159136038 --- Diff: flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporter.java --- @@ -0,0 +1,76 @@ +/* + *