[GitHub] flink pull request #5309: [FLINK-8450] [flip6] Make JobMaster/DispatcherGate...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5309#discussion_r163902431 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java --- @@ -30,62 +30,69 @@ import

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339477#comment-16339477 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8450) Make JobMaster/DispatcherGateway#requestJob type safe

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339481#comment-16339481 ] ASF GitHub Bot commented on FLINK-8450: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5309: [FLINK-8450] [flip6] Make JobMaster/DispatcherGate...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5309#discussion_r163899592 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -331,13 +331,13 @@ public void start() throws

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163899364 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/DescriptorsTest.scala --- @@ -0,0 +1,245 @@ +/* + * Licensed to the

[jira] [Created] (FLINK-8512) HAQueryableStateFsBackendITCase unstable on Travis

2018-01-25 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8512: Summary: HAQueryableStateFsBackendITCase unstable on Travis Key: FLINK-8512 URL: https://issues.apache.org/jira/browse/FLINK-8512 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339430#comment-16339430 ] ASF GitHub Bot commented on FLINK-8449: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to accept...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5308 Thanks for the review @GJL. I've rebased onto the latest master and addressed your feedback in 72bebc0. ---

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5347#discussion_r163880920 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/CorrelateUtil.scala --- @@ -0,0 +1,79 @@ +/* + *

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5347#discussion_r163880994 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/CorrelateUtil.scala --- @@ -0,0 +1,79 @@ +/* + *

[jira] [Commented] (FLINK-8492) [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339418#comment-16339418 ] ASF GitHub Bot commented on FLINK-8492: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8492) [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339416#comment-16339416 ] ASF GitHub Bot commented on FLINK-8492: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8492) [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339417#comment-16339417 ] ASF GitHub Bot commented on FLINK-8492: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8492) [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339420#comment-16339420 ] ASF GitHub Bot commented on FLINK-8492: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5347#discussion_r163879206 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala --- @@ -141,6 +143,7 @@ trait CommonCalc { }

[jira] [Commented] (FLINK-8492) [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339419#comment-16339419 ] ASF GitHub Bot commented on FLINK-8492: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8492) [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339421#comment-16339421 ] ASF GitHub Bot commented on FLINK-8492: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5347#discussion_r163877879 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala --- @@ -149,26 +152,42 @@ trait CommonCalc {

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5347#discussion_r163878119 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala --- @@ -149,26 +152,42 @@ trait CommonCalc {

[GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5347#discussion_r163880732 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/CorrelateUtil.scala --- @@ -0,0 +1,79 @@ +/* + *

[jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339386#comment-16339386 ] ASF GitHub Bot commented on FLINK-8449: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5308#discussion_r163877367 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerMockTest.java --- @@ -250,19 +255,15 @@ public void

[jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339383#comment-16339383 ] ASF GitHub Bot commented on FLINK-8449: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5308#discussion_r163877071 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -1701,40 +1705,4 @@ void

[jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339374#comment-16339374 ] ASF GitHub Bot commented on FLINK-8449: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5308#discussion_r163874024 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -752,16 +751,21 @@ public Executor

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339370#comment-16339370 ] ASF GitHub Bot commented on FLINK-8345: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163872816 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/BackendWritableBroadcastState.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163870691 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/BroadcastState.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339360#comment-16339360 ] ASF GitHub Bot commented on FLINK-8345: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163870666 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java --- @@ -513,17 +630,100 @@ public void addAll(List

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339358#comment-16339358 ] ASF GitHub Bot commented on FLINK-8345: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339353#comment-16339353 ] ASF GitHub Bot commented on FLINK-8449: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5308#discussion_r163869963 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/AccumulatorHelper.java --- @@ -173,4 +173,23 @@ public static String

[jira] [Assigned] (FLINK-8472) Extend migration tests for Flink 1.4

2018-01-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-8472: -- Assignee: Tzu-Li (Gordon) Tai > Extend migration tests for Flink 1.4 >

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339331#comment-16339331 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163866463 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339323#comment-16339323 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7858) Port JobVertexTaskManagersHandler to REST endpoint

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339324#comment-16339324 ] ASF GitHub Bot commented on FLINK-7858: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5149: [FLINK-7858][flp6] Port JobVertexTaskManagersHandler to R...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5149 Thanks for your contribution @zjureel. Changes look good. Rebasing and merging your PR. ---

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163865339 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableSourceDescriptor.scala --- @@ -0,0 +1,66 @@ +/* + *

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339316#comment-16339316 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163863728 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Schema.scala --- @@ -0,0 +1,95 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6464) Metric name is not stable

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339295#comment-16339295 ] ASF GitHub Bot commented on FLINK-6464: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5332: [FLINK-6464][streaming] Stabilize default window operator...

2018-01-25 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5332 Looks good 👍 ---

[jira] [Commented] (FLINK-6623) BlobCacheSuccessTest fails on Windows

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339286#comment-16339286 ] ASF GitHub Bot commented on FLINK-6623: --- Github user zentol commented on the issue:

[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5351 So the `FIleBaseUtilsTest` ran without a hitch 3000 times in a row, which is _really_ nice. ---

[jira] [Commented] (FLINK-8485) Running Flink inside Intellij no longer works after upgrading from 1.3.2 to 1.4.0

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339281#comment-16339281 ] ASF GitHub Bot commented on FLINK-8485: --- Github user tillrohrmann closed the pull request at:

[jira] [Resolved] (FLINK-8485) Running Flink inside Intellij no longer works after upgrading from 1.3.2 to 1.4.0

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8485. -- Resolution: Fixed 1.5.0: c1734f4bf474fda30712a103f87e8fcfb984b956 1.4.1: 

[jira] [Comment Edited] (FLINK-7949) AsyncWaitOperator is not restarting when queue is full

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326323#comment-16326323 ] Till Rohrmann edited comment on FLINK-7949 at 1/25/18 2:27 PM: --- Fixed in

[GitHub] flink pull request #5360: [backport-1.4] [FLINK-8485] [client] Unblock JobSu...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/5360 ---

[jira] [Commented] (FLINK-8485) Running Flink inside Intellij no longer works after upgrading from 1.3.2 to 1.4.0

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339275#comment-16339275 ] ASF GitHub Bot commented on FLINK-8485: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8485) Running Flink inside Intellij no longer works after upgrading from 1.3.2 to 1.4.0

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339274#comment-16339274 ] ASF GitHub Bot commented on FLINK-8485: --- Github user tillrohrmann closed the pull request at:

[GitHub] flink issue #5360: [backport-1.4] [FLINK-8485] [client] Unblock JobSubmissio...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5360 Travis passed. Merging this PR. ---

[GitHub] flink pull request #5359: [FLINK-8485] [client] Unblock JobSubmissionClientA...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/5359 ---

[GitHub] flink issue #5359: [FLINK-8485] [client] Unblock JobSubmissionClientActor#tr...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5359 Travis passed. Merging this change. ---

[jira] [Commented] (FLINK-8485) Running Flink inside Intellij no longer works after upgrading from 1.3.2 to 1.4.0

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339272#comment-16339272 ] ASF GitHub Bot commented on FLINK-8485: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8488) Dispatcher does not recover Jobs

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339268#comment-16339268 ] ASF GitHub Bot commented on FLINK-8488: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5363: [FLINK-8488] [flip6] Fix Dispatcher job recovery b...

2018-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5363 [FLINK-8488] [flip6] Fix Dispatcher job recovery bug ## What is the purpose of the change Instead of only accepting job submissions if the RunningJobRegistry signals that the job's

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163841958 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/BackendWritableBroadcastState.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339257#comment-16339257 ] ASF GitHub Bot commented on FLINK-8345: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339255#comment-16339255 ] ASF GitHub Bot commented on FLINK-8345: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339256#comment-16339256 ] ASF GitHub Bot commented on FLINK-8345: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339259#comment-16339259 ] ASF GitHub Bot commented on FLINK-8345: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339258#comment-16339258 ] ASF GitHub Bot commented on FLINK-8345: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339254#comment-16339254 ] ASF GitHub Bot commented on FLINK-8345: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163850320 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/OperatorStateBackendTest.java --- @@ -753,4 +935,27 @@ private static Environment

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163849551 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java --- @@ -601,21 +805,43 @@ public void addAll(List

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163840020 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java --- @@ -513,17 +630,100 @@ public void addAll(List

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163839057 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/RoundRobinOperatorStateRepartitioner.java --- @@ -228,36 +221,58 @@ private

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163838390 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/BroadcastState.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #:

2018-01-25 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/commit/b5caaef82add4a6f424094d526700c77b011724e#commitcomment-27100256 In

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339239#comment-16339239 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8421) HeapInternalTimerService should reconfigure compatible key / namespace serializers on restore

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339236#comment-16339236 ] ASF GitHub Bot commented on FLINK-8421: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163847018 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/JSON.scala --- @@ -0,0 +1,140 @@ +/* + * Licensed to the

[GitHub] flink pull request #5362: [FLINK-8421] [DataStream] Make timer serializers r...

2018-01-25 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5362 [FLINK-8421] [DataStream] Make timer serializers reconfigurable on restore ## What is the purpose of the change Previously, key and namespace serializers of the `HeapInternalTimerService`

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339212#comment-16339212 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163841505 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/JSON.scala --- @@ -0,0 +1,140 @@ +/* + * Licensed to the

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163840224 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/JSON.scala --- @@ -0,0 +1,140 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339205#comment-16339205 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339200#comment-16339200 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163838489 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Descriptor.scala --- @@ -0,0 +1,32 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339195#comment-16339195 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163836869 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Descriptor.scala --- @@ -0,0 +1,32 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339193#comment-16339193 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163836415 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptor.scala --- @@ -0,0 +1,47 @@ +/* + *

[jira] [Comment Edited] (FLINK-8439) Document using a custom AWS Credentials Provider with flink-3s-fs-hadoop

2018-01-25 Thread Dyana Rose (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339188#comment-16339188 ] Dyana Rose edited comment on FLINK-8439 at 1/25/18 1:07 PM: I should add that

[jira] [Commented] (FLINK-8439) Document using a custom AWS Credentials Provider with flink-3s-fs-hadoop

2018-01-25 Thread Dyana Rose (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339188#comment-16339188 ] Dyana Rose commented on FLINK-8439: --- I should add that I believe the issue with permissions also affects

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339183#comment-16339183 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[jira] [Assigned] (FLINK-8488) Dispatcher does not recover Jobs

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-8488: Assignee: Till Rohrmann > Dispatcher does not recover Jobs >

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163835834 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptor.scala --- @@ -0,0 +1,47 @@ +/* + *

[jira] [Commented] (FLINK-8506) fullRestarts Gauge not incremented when jobmanager got killed

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339177#comment-16339177 ] Till Rohrmann commented on FLINK-8506: -- In case of a JobManager failover the {{fullRestarts}} gauge

[jira] [Created] (FLINK-8511) Remove legacy code for the TableType annotation

2018-01-25 Thread Timo Walther (JIRA)
Timo Walther created FLINK-8511: --- Summary: Remove legacy code for the TableType annotation Key: FLINK-8511 URL: https://issues.apache.org/jira/browse/FLINK-8511 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8504) TaskExecutor does not properly deregisters JobManager from JobLeaderService

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339175#comment-16339175 ] ASF GitHub Bot commented on FLINK-8504: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5361: [FLINK-8504] [flip6] Deregister jobs from the JobL...

2018-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5361 [FLINK-8504] [flip6] Deregister jobs from the JobLeaderService when no more slots allocated ## What is the purpose of the change Let the TaskExecutor deregister jobs from the

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339165#comment-16339165 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...

2018-01-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r163830189 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -107,6 +111,16 @@ abstract class

[jira] [Commented] (FLINK-6623) BlobCacheSuccessTest fails on Windows

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339148#comment-16339148 ] ASF GitHub Bot commented on FLINK-6623: --- Github user zentol commented on the issue:

[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5351 Taking a look at the moment. I tried it with the `BlobCacheSuccessTest` and get about 30-50% less failures, but this could also be due to some leak in the BlobServer we haven't found yet.

[GitHub] flink pull request #5144: [Minor][cleanup] Remove unnecessary semicolons

2018-01-25 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/5144 ---

<    1   2   3   >