[jira] [Commented] (FLINK-8523) Stop assigning floating buffers for blocked input channels in exactly-once mode

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344611#comment-16344611 ] ASF GitHub Bot commented on FLINK-8523: --- GitHub user zhijiangW opened a pull request:

[GitHub] flink pull request #5381: [FLINK-8523][network] Stop assigning floating buff...

2018-01-29 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/5381 [FLINK-8523][network] Stop assigning floating buffers for blocked input channels in exactly-once mode ## What is the purpose of the change In exactly-once mode, the input channel is set

[jira] [Created] (FLINK-8523) Stop assigning floating buffers for blocked input channels in exactly-once mode

2018-01-29 Thread zhijiang (JIRA)
zhijiang created FLINK-8523: --- Summary: Stop assigning floating buffers for blocked input channels in exactly-once mode Key: FLINK-8523 URL: https://issues.apache.org/jira/browse/FLINK-8523 Project: Flink

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-01-29 Thread yanxiaobin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344591#comment-16344591 ] yanxiaobin commented on FLINK-8500: --- As shown below(Kafka010Fetcher):

[jira] [Updated] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

2018-01-29 Thread yanxiaobin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yanxiaobin updated FLINK-8500: -- Attachment: image-2018-01-30-14-58-58-167.png > Get the timestamp of the Kafka message from kafka

[jira] [Commented] (FLINK-8428) Implement stream-stream non-window left outer join

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344587#comment-16344587 ] ASF GitHub Bot commented on FLINK-8428: --- Github user hequn8128 commented on the issue:

[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...

2018-01-29 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 Hi, @twalthr It would be great if you can take a look at the pr. I'm looking forward to finish outer join (left/right/full) before the end of March. Besides, there are a few PRs planed to

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344501#comment-16344501 ] ASF GitHub Bot commented on FLINK-8479: --- Github user bowenli86 commented on a diff in the pull

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344500#comment-16344500 ] ASF GitHub Bot commented on FLINK-8479: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164639453 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398 @@ +/*

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164639439 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398 @@ +/*

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1636#comment-1636 ] ASF GitHub Bot commented on FLINK-8479: --- Github user hequn8128 commented on a diff in the pull

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1638#comment-1638 ] ASF GitHub Bot commented on FLINK-8479: --- Github user hequn8128 commented on a diff in the pull

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164631861 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398 @@ +/*

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164631864 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398 @@ +/*

[jira] [Commented] (FLINK-8479) Implement time-bounded inner join of streams as a TwoInputStreamOperator

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1637#comment-1637 ] ASF GitHub Bot commented on FLINK-8479: --- Github user hequn8128 commented on a diff in the pull

[GitHub] flink pull request #5342: [FLINK-8479] Timebounded stream join

2018-01-29 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/5342#discussion_r164631884 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java --- @@ -0,0 +1,398 @@ +/*

[GitHub] flink issue #5357: [hotfix][JobGraph] Eliminate the conditions of parallelis...

2018-01-29 Thread maqingxiang
Github user maqingxiang commented on the issue: https://github.com/apache/flink/pull/5357 Thanks for your review @zentol As far as I know, If the partitioner of the edge is forward, then their parallelism must be the same. Maybe I'm completely missing something... ---

[jira] [Commented] (FLINK-7095) Add proper command line parsing tool to TaskManagerRunner.main

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344406#comment-16344406 ] ASF GitHub Bot commented on FLINK-7095: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #5375: [FLINK-7095] [TaskManager] Add Command line parsing tool ...

2018-01-29 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5375 Thanks @tillrohrmann . I will take a look based on your suggestions. ---

[jira] [Commented] (FLINK-8431) Allow to specify # GPUs for TaskManager in Mesos

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344388#comment-16344388 ] ASF GitHub Bot commented on FLINK-8431: --- Github user eastcirclek commented on the issue:

[GitHub] flink issue #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for TaskMana...

2018-01-29 Thread eastcirclek
Github user eastcirclek commented on the issue: https://github.com/apache/flink/pull/5307 @tillrohrmann As you pointed out, the discussion we had in the mailing list was about JM not starting TMs on GPU-equipped agents. It turned out that a Mesos framework needs to specify

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2018-01-29 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344368#comment-16344368 ] mingleizhang commented on FLINK-4084: - Yea. > Add configDir parameter to CliFrontend and flink shell

[jira] [Commented] (FLINK-8431) Allow to specify # GPUs for TaskManager in Mesos

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344188#comment-16344188 ] ASF GitHub Bot commented on FLINK-8431: --- Github user eastcirclek commented on a diff in the pull

[GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...

2018-01-29 Thread eastcirclek
Github user eastcirclek commented on a diff in the pull request: https://github.com/apache/flink/pull/5307#discussion_r164597051 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -238,6 +254,12 @@ public

[jira] [Commented] (FLINK-8431) Allow to specify # GPUs for TaskManager in Mesos

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343854#comment-16343854 ] ASF GitHub Bot commented on FLINK-8431: --- Github user EronWright commented on the issue:

[GitHub] flink issue #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for TaskMana...

2018-01-29 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/5307 @tillrohrmann regarding your general question, you are right that Flink could, in concept, deploy to GPU hosts even if Flink doesn't require any GPUs. But we should keep in mind the intent of

[jira] [Commented] (FLINK-8431) Allow to specify # GPUs for TaskManager in Mesos

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343821#comment-16343821 ] ASF GitHub Bot commented on FLINK-8431: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...

2018-01-29 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/5307#discussion_r164529293 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -238,6 +254,12 @@ public

[jira] [Commented] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read.

2018-01-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343622#comment-16343622 ] Stefan Richter commented on FLINK-8522: --- I don't think that we ever need to read the int, it was

[jira] [Commented] (FLINK-7856) Port JobVertexBackPressureHandler to REST endpoint

2018-01-29 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343592#comment-16343592 ] Gary Yao commented on FLINK-7856: - [~zjureel] Thank you for your work so far. I will rebase your changes

[jira] [Comment Edited] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read.

2018-01-29 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343584#comment-16343584 ] Tzu-Li (Gordon) Tai edited comment on FLINK-8522 at 1/29/18 4:28 PM: -

[jira] [Comment Edited] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read.

2018-01-29 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343584#comment-16343584 ] Tzu-Li (Gordon) Tai edited comment on FLINK-8522 at 1/29/18 4:27 PM: -

[jira] [Assigned] (FLINK-7856) Port JobVertexBackPressureHandler to REST endpoint

2018-01-29 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7856: --- Assignee: Gary Yao (was: Fang Yong) > Port JobVertexBackPressureHandler to REST endpoint >

[jira] [Commented] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read.

2018-01-29 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343584#comment-16343584 ] Tzu-Li (Gordon) Tai commented on FLINK-8522: Don't we need to do both options? i.e., 1. We

[jira] [Commented] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read.

2018-01-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343580#comment-16343580 ] Stefan Richter commented on FLINK-8522: --- Option 1 looks good for me. > DefaultOperatorStateBackend

[jira] [Created] (FLINK-8522) DefaultOperatorStateBackend writes data in checkpoint that is never read.

2018-01-29 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-8522: - Summary: DefaultOperatorStateBackend writes data in checkpoint that is never read. Key: FLINK-8522 URL: https://issues.apache.org/jira/browse/FLINK-8522 Project:

[jira] [Commented] (FLINK-6160) Retry JobManager/ResourceManager connection in case of timeout

2018-01-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343559#comment-16343559 ] Till Rohrmann commented on FLINK-6160: -- The {{TaskExecutor}} retries a timed out connection to the

[jira] [Assigned] (FLINK-8478) Add support for time-bounded joins in DataStream API

2018-01-29 Thread Florian Schmidt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Schmidt reassigned FLINK-8478: -- Assignee: Florian Schmidt > Add support for time-bounded joins in DataStream API >

[jira] [Commented] (FLINK-8505) SlotManager can reach inconsistent state

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343549#comment-16343549 ] ASF GitHub Bot commented on FLINK-8505: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5354: [FLINK-8505] [flip6] Prevent SlotManager from reaching an...

2018-01-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5354 Thanks for the review @GJL. I've addressed your comments and rebased onto the latest master. Merging once Travis gives green light. ---

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2018-01-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343540#comment-16343540 ] Till Rohrmann commented on FLINK-4084: -- The PR has been abandoned. I think we should close the PR and

[jira] [Commented] (FLINK-7095) Add proper command line parsing tool to TaskManagerRunner.main

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343532#comment-16343532 ] ASF GitHub Bot commented on FLINK-7095: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5375: [FLINK-7095] [TaskManager] Add Command line parsin...

2018-01-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5375#discussion_r164473535 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java --- @@ -213,10 +226,11 @@ public static void

[jira] [Commented] (FLINK-8431) Allow to specify # GPUs for TaskManager in Mesos

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343523#comment-16343523 ] ASF GitHub Bot commented on FLINK-8431: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...

2018-01-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5307#discussion_r164469976 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -238,6 +254,12 @@ public

[GitHub] flink issue #5357: [hotfix][JobGraph] Eliminate the conditions of parallelis...

2018-01-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5357 I would be in favor of closing this PR. This change doesn't _really_ improve anything, but removes a simple (and intuitive) sanity check. ---

[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343492#comment-16343492 ] ASF GitHub Bot commented on FLINK-8472: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5364: [FLINK-8472] [test] Extend all migration tests for Flink ...

2018-01-29 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5364 It seems like we'll also need to extend these migration tests for 1.4: - All subclasses of `AbstractKeyedOperatorRestoreTestBase` - All subclasses of

[GitHub] flink issue #5296: [FLINK-8432] [filesystem-connector] Add support for opens...

2018-01-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5296 Great. Thanks a lot for addressing my comments so fast @jelmerk and @etiennecarriere. Thanks a lot for your contribution. Merging this PR. ---

[jira] [Commented] (FLINK-8432) Add openstack swift filesystem

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343435#comment-16343435 ] ASF GitHub Bot commented on FLINK-8432: --- Github user tillrohrmann commented on the issue:

[jira] [Assigned] (FLINK-8432) Add openstack swift filesystem

2018-01-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-8432: Assignee: Jelmer Kuperus > Add openstack swift filesystem > --

[jira] [Created] (FLINK-8521) FlinkKafkaProducer011ITCase.testRunOutOfProducersInThePool timed out on Travis

2018-01-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8521: Summary: FlinkKafkaProducer011ITCase.testRunOutOfProducersInThePool timed out on Travis Key: FLINK-8521 URL: https://issues.apache.org/jira/browse/FLINK-8521

[jira] [Commented] (FLINK-8364) Add iterator() to ListState which returns empty iterator when it has no value

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343410#comment-16343410 ] ASF GitHub Bot commented on FLINK-8364: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343409#comment-16343409 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #5356: [FLINK-8364][state backend] Add iterator() to ListState w...

2018-01-29 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5356 Ok, that is not so nice IMHO for an API, but if you think this might break some code then we have to keep it. Nevertheless, I still doubt about any additional value from the new method that

[GitHub] flink issue #4649: [FLINK-6116] Watermarks don't work when unioning with sam...

2018-01-29 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4649 @aljoscha FYI, this might be an abandoned, yet simple bug fix for some critical (according to jira) bug in the Flink. It might be a good idea to take over it, write some proper tests and merge it

[jira] [Commented] (FLINK-8505) SlotManager can reach inconsistent state

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343381#comment-16343381 ] ASF GitHub Bot commented on FLINK-8505: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8505) SlotManager can reach inconsistent state

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343382#comment-16343382 ] ASF GitHub Bot commented on FLINK-8505: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5354: [FLINK-8505] [flip6] Prevent SlotManager from reac...

2018-01-29 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5354#discussion_r164438991 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -485,7 +477,10 @@ protected TaskManagerSlot

[GitHub] flink pull request #5354: [FLINK-8505] [flip6] Prevent SlotManager from reac...

2018-01-29 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5354#discussion_r164434005 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -388,6 +378,8 @@ public boolean

[jira] [Commented] (FLINK-8364) Add iterator() to ListState which returns empty iterator when it has no value

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343380#comment-16343380 ] ASF GitHub Bot commented on FLINK-8364: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5356: [FLINK-8364][state backend] Add iterator() to ListState w...

2018-01-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5356 @StefanRRichter that would be an (IMO unnecessary) API breaking change. See the comments on FLINK-8364. ---

[jira] [Commented] (FLINK-8364) Add iterator() to ListState which returns empty iterator when it has no value

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343373#comment-16343373 ] ASF GitHub Bot commented on FLINK-8364: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5356: [FLINK-8364][state backend] Add iterator() to ListState w...

2018-01-29 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5356 I wonder why we need to introduce a separate method for an iterator instead of just changing the `get()` method to return `Collections.emptyList()` as iterable in case of null value. Wouldn't

[jira] [Commented] (FLINK-8515) update RocksDBMapState to replace deprecated remove() with delete()

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343364#comment-16343364 ] ASF GitHub Bot commented on FLINK-8515: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5365: [FLINK-8515] update RocksDBMapState to replace deprecated...

2018-01-29 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5365 In general, LGTM. I just have the exact same change already in on sub-commit of another open PR, so this change will get in one way or the other. ---

[jira] [Commented] (FLINK-8489) Data is not emitted by second ElasticSearch connector

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343361#comment-16343361 ] ASF GitHub Bot commented on FLINK-8489: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5378: [FLINK-8489][ES] Prevent side-effects when modifying user...

2018-01-29 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5378 LGTM, once Travis is green. ---

[jira] [Updated] (FLINK-7829) Remove (or at least deprecate) DataStream.writeToFile/Csv

2018-01-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7829: Issue Type: Improvement (was: Bug) > Remove (or at least deprecate)

[GitHub] flink issue #5380: [hotfix][connectors] Fix log format strings

2018-01-29 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5380 LGTM, will merge this. ---

[jira] [Updated] (FLINK-7286) Flink Dashboard fails to display bytes/records received by sources

2018-01-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7286: Issue Type: Improvement (was: Bug) > Flink Dashboard fails to display bytes/records

[jira] [Updated] (FLINK-8047) Create HTTP Sink

2018-01-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8047: Issue Type: New Feature (was: Improvement) > Create HTTP Sink > > >

[jira] [Updated] (FLINK-4874) Document how to enable Flink web interface in local execution

2018-01-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-4874: Fix Version/s: (was: 1.1.2) > Document how to enable Flink web interface in local

[GitHub] flink pull request #5380: [hotfix][connectors] Fix log format strings

2018-01-29 Thread patricklucas
GitHub user patricklucas opened a pull request: https://github.com/apache/flink/pull/5380 [hotfix][connectors] Fix log format strings Log4j uses '{}' instead of '%s' for interpolating values, meaning these logging statements currently result in log entries with the literal string

[jira] [Commented] (FLINK-6160) Retry JobManager/ResourceManager connection in case of timeout

2018-01-29 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343323#comment-16343323 ] mingleizhang commented on FLINK-6160: - I found all components such as {{TaskExecutor}}, {{JobMaster}}

[jira] [Commented] (FLINK-8489) Data is not emitted by second ElasticSearch connector

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343322#comment-16343322 ] ASF GitHub Bot commented on FLINK-8489: --- Github user zentol commented on the issue:

[GitHub] flink issue #5378: [FLINK-8489][ES] Prevent side-effects when modifying user...

2018-01-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5378 Added a test for the `ElasticSearchSinkBase` that passes an unmodifiable map containing all properties that we currently try to remove. I also modified the `ElasticSearchTestBase` to pass an

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343309#comment-16343309 ] ASF GitHub Bot commented on FLINK-8494: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8130) Javadocs link for snapshot release is not correct

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343308#comment-16343308 ] ASF GitHub Bot commented on FLINK-8130: --- GitHub user zentol opened a pull request:

[GitHub] flink issue #5377: [FLINK-8494][config] Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5377 merging. ---

[GitHub] flink pull request #5379: [FLINK-8130][docs] Fix snapshot javadoc link

2018-01-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5379 [FLINK-8130][docs] Fix snapshot javadoc link ## What is the purpose of the change This PR fixes the snapshot javadoc link that is currently broken. Currently the website tries to access

[jira] [Updated] (FLINK-8357) enable rolling in default log settings

2018-01-29 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-8357: Fix Version/s: 1.5.0 > enable rolling in default log settings >

[jira] [Commented] (FLINK-8489) Data is not emitted by second ElasticSearch connector

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343273#comment-16343273 ] ASF GitHub Bot commented on FLINK-8489: --- Github user zentol commented on the issue:

[GitHub] flink issue #5378: [FLINK-8489][ES] Prevent side-effects when modifying user...

2018-01-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5378 I'll add a test where we pass an unmodifiable map to the sink, that should cover it. ---

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343270#comment-16343270 ] ASF GitHub Bot commented on FLINK-8357: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-29 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Thanks @StephanEwen ~ ---

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 Looks good! ---

[jira] [Commented] (FLINK-8357) enable rolling in default log settings

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343265#comment-16343265 ] ASF GitHub Bot commented on FLINK-8357: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343262#comment-16343262 ] ASF GitHub Bot commented on FLINK-8494: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5377: [FLINK-8494][config] Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5377 +1 ---

[jira] [Commented] (FLINK-8489) Data is not emitted by second ElasticSearch connector

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343261#comment-16343261 ] ASF GitHub Bot commented on FLINK-8489: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5378: [FLINK-8489][ES] Prevent side-effects when modifying user...

2018-01-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5378 Looks good, but can this be guarded by a test? Otherwise I can see a someone in the future going like "oh, I have an idea how to 'optimize' this" and remove that copying operation. ---

[jira] [Assigned] (FLINK-8130) Javadocs link for snapshot release is not correct

2018-01-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-8130: --- Assignee: Chesnay Schepler > Javadocs link for snapshot release is not correct >

[jira] [Commented] (FLINK-8082) Bump version compatibility check to 1.4

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343254#comment-16343254 ] ASF GitHub Bot commented on FLINK-8082: --- Github user zentol commented on the issue:

[GitHub] flink issue #5262: [FLINK-8082][build] Bump flink version for japicmp plugin

2018-01-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5262 @greghogan What's the state of your checklist? (Is it accessible/modifiable somewhere? ---

[jira] [Updated] (FLINK-7521) Remove the 10MB limit from the current REST implementation.

2018-01-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7521: Issue Type: Improvement (was: Bug) > Remove the 10MB limit from the current REST

[jira] [Commented] (FLINK-6321) RocksDB state backend Checkpointing is not working with KeyedCEP.

2018-01-29 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343248#comment-16343248 ] Kostas Kloudas commented on FLINK-6321: --- Hi [~shashank734], as I wrote to another thread in the ML,

[jira] [Commented] (FLINK-8101) Elasticsearch 6.x support

2018-01-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343247#comment-16343247 ] ASF GitHub Bot commented on FLINK-8101: --- Github user cjolif commented on the issue:

[GitHub] flink issue #5374: [FLINK-8101][flink-connectors] Elasticsearch 5.3+ (Transp...

2018-01-29 Thread cjolif
Github user cjolif commented on the issue: https://github.com/apache/flink/pull/5374 thanks @tzulitai. Let me know if you have any question. ---

  1   2   >