[GitHub] [flink] godfreyhe commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch

2019-04-01 Thread GitBox
godfreyhe commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch URL: https://github.com/apache/flink/pull/8092#discussion_r271142489 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch

2019-04-01 Thread GitBox
godfreyhe commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch URL: https://github.com/apache/flink/pull/8092#discussion_r271138175 ## File path:

[jira] [Updated] (FLINK-11309) Make SpillableSubpartition repeatably read to enable

2019-04-01 Thread ryantaocer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ryantaocer updated FLINK-11309: --- Summary: Make SpillableSubpartition repeatably read to enable (was: Batch Job Failover Using

[jira] [Closed] (FLINK-11898) Support code generation for all Blink built-in functions and operators

2019-04-01 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11898. -- > Support code generation for all Blink built-in functions and operators >

[jira] [Closed] (FLINK-11994) Introduce TableImpl and remove Table in flink-table-planner-blink

2019-04-01 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11994. -- > Introduce TableImpl and remove Table in flink-table-planner-blink >

[jira] [Closed] (FLINK-12079) Add support for generating optimized logical plan for join on batch

2019-04-01 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12079. -- Resolution: Fixed Fix Version/s: 1.9.0 fixed in 79d09b5ab04aa60e26cb2fd529c5469f840edcd2 >

[GitHub] [flink] KurtYoung closed pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
KurtYoung closed pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094 This is an automated message from

[GitHub] [flink] KurtYoung commented on issue #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
KurtYoung commented on issue #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#issuecomment-478835260 LGTM, +1 This

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271119916 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271121048 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,286 @@ The `OverWindow`

[GitHub] [flink] sunjincheng121 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-478833186 @flinkbot approve-until This is an automated message from

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271119602 ## File path:

[GitHub] [flink] sunjincheng121 edited a comment on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 edited a comment on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-478785719 @flinkbot approve description @flinkbot approve consensus

[GitHub] [flink] zsq12138 commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
zsq12138 commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#discussion_r271123021 ## File path: docs/dev/stream/operators/process_function.md ## @@ -86,7 +86,7 @@ The following

[GitHub] [flink] zsq12138 commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
zsq12138 commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#discussion_r271123021 ## File path: docs/dev/stream/operators/process_function.md ## @@ -86,7 +86,7 @@ The following

[GitHub] [flink] zsq12138 commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
zsq12138 commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#discussion_r271122583 ## File path: docs/dev/stream/operators/process_function.md ## @@ -199,14 +199,14 @@ case class

[GitHub] [flink] zhijiangW commented on issue #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
zhijiangW commented on issue #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#issuecomment-478829716 Thanks for efficient review @azagrebin ! I submitted the fixup commit for addressing

[GitHub] [flink] zhijiangW commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
zhijiangW commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#discussion_r271118936 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink

2019-04-01 Thread GitBox
JingsongLi commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink URL: https://github.com/apache/flink/pull/8093#discussion_r271117459 ## File path: flink-table/flink-table-planner-blink/pom.xml

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271086764 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,286 @@ The `OverWindow`

[GitHub] [flink] sunjincheng121 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-478819447 @flinkbot attention @twalthr This is an automated

[GitHub] [flink] flinkbot edited a comment on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
flinkbot edited a comment on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-478332056 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] KurtYoung commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch URL: https://github.com/apache/flink/pull/8092#discussion_r27334 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8092: [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch URL: https://github.com/apache/flink/pull/8092#discussion_r27545 ## File path:

[jira] [Closed] (FLINK-12072) Unable to Capture Metrics of AsyncIO

2019-04-01 Thread sravan.korumilli (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sravan.korumilli closed FLINK-12072. Resolution: Not A Bug It is a problem with the underlying statsd server being used,

[GitHub] [flink] JingsongLi commented on issue #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink

2019-04-01 Thread GitBox
JingsongLi commented on issue #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink URL: https://github.com/apache/flink/pull/8093#issuecomment-478815197 Compile failed because `LongHashJoinGeneratorTest`(in planner test) can't find

[GitHub] [flink] sravankorumilli closed pull request #8085: [FLINK-12072] Change asyncio operator name without whitespaces to help capture the metrics properly

2019-04-01 Thread GitBox
sravankorumilli closed pull request #8085: [FLINK-12072] Change asyncio operator name without whitespaces to help capture the metrics properly URL: https://github.com/apache/flink/pull/8085 This is an automated message from

[jira] [Updated] (FLINK-12079) Add support for generating optimized logical plan for join on batch

2019-04-01 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12079: --- Description: Currently, there are 3 types of batch physical join nodes: {{BatchExecHashJoin}},

[GitHub] [flink] JingsongLi commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink

2019-04-01 Thread GitBox
JingsongLi commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink URL: https://github.com/apache/flink/pull/8093#discussion_r271110129 ## File path: flink-table/flink-table-planner-blink/pom.xml

[GitHub] [flink] godfreyhe commented on issue #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
godfreyhe commented on issue #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#issuecomment-478810631 @KurtYoung Thanks for your suggestion, I have updated this PR based on

[GitHub] [flink] KurtYoung commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink URL: https://github.com/apache/flink/pull/8093#discussion_r271105182 ## File path: flink-table/flink-table-planner-blink/pom.xml

[GitHub] [flink] KurtYoung commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8093: [FLINK-12077][table-runtime-blink] Introduce HashJoinOperator and LongHashJoinGenerator to blink URL: https://github.com/apache/flink/pull/8093#discussion_r271105975 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#discussion_r271103625 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#discussion_r271103903 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#discussion_r271103643 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
KurtYoung commented on a change in pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#discussion_r271103821 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
tillrohrmann commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8096#discussion_r271102177 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
tillrohrmann commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8096#discussion_r271102157 ## File path:

[GitHub] [flink] tweise merged pull request #8081: [FLINK-11501] [kafka] Add ratelimiting to Kafka consumer

2019-04-01 Thread GitBox
tweise merged pull request #8081: [FLINK-11501] [kafka] Add ratelimiting to Kafka consumer URL: https://github.com/apache/flink/pull/8081 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] aljoscha commented on issue #8081: [FLINK-11501] [kafka] Add ratelimiting to Kafka consumer

2019-04-01 Thread GitBox
aljoscha commented on issue #8081: [FLINK-11501] [kafka] Add ratelimiting to Kafka consumer URL: https://github.com/apache/flink/pull/8081#issuecomment-478799599 +1, please merge this on release-1.8 This is an automated

[GitHub] [flink] flinkbot edited a comment on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
flinkbot edited a comment on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-478332056 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] sunjincheng121 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-478785719 @flinkbot approve description @flinkbot approve consensus Hi, @hequn8128 Thanks for the PR,before starting the

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271086764 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,286 @@ The `OverWindow`

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r271086764 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,286 @@ The `OverWindow`

[jira] [Closed] (FLINK-12028) Add Column Operators(add/rename/drop)

2019-04-01 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12028. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master:

[GitHub] [flink] asfgit closed pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-04-01 Thread GitBox
asfgit closed pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] sunjincheng121 removed a comment on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-04-01 Thread GitBox
sunjincheng121 removed a comment on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#issuecomment-478780483 @flinkbot approve all This is an

[GitHub] [flink] sunjincheng121 commented on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-04-01 Thread GitBox
sunjincheng121 commented on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#issuecomment-478780483 @flinkbot approve all This is an automated

[GitHub] [flink] sunjincheng121 edited a comment on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-04-01 Thread GitBox
sunjincheng121 edited a comment on issue #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#issuecomment-478546055 Great thanks for your quick review @dawidwys! Will fixed your comments before merging the PR.

[GitHub] [flink] walterddr commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
walterddr commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8096#discussion_r271081666 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
walterddr commented on a change in pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8096#discussion_r271081645 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8097#discussion_r271081459 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8097#discussion_r271081429 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8097#discussion_r271081459 ## File path:

[GitHub] [flink] walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
walterddr commented on a change in pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8097#discussion_r271081429 ## File path:

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r271059377 ## File path:

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r27105 ## File path:

[GitHub] [flink] Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-478754392 Hi @becketqin Thanks for the review! I've addressed most of them. Some I have not

[GitHub] [flink] haf commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
haf commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-478754289 Very thorough review, indeed! Will there be a way to use this code in the currently

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r271056623 ## File path:

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r271056349 ## File path:

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r271056321 ## File path:

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r271056291 ## File path:

[GitHub] [flink] flinkbot commented on issue #8098: [BP-1.7][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
flinkbot commented on issue #8098: [BP-1.7][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8098#issuecomment-478732060 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] tillrohrmann opened a new pull request #8098: [BP-1.7][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
tillrohrmann opened a new pull request #8098: [BP-1.7][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8098 Backport of #8096 for `release-1.7`. This is an

[GitHub] [flink] flinkbot commented on issue #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
flinkbot commented on issue #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8097#issuecomment-478732074 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12075: --- Labels: pull-request-available (was: ) > Not able to submit jobs on YARN when there's a

[GitHub] [flink] flinkbot commented on issue #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
flinkbot commented on issue #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8096#issuecomment-478731723 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] tillrohrmann opened a new pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
tillrohrmann opened a new pull request #8097: [BP-1.8][FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8097 Backport of #8096 for `release-1.8`. This is an

[GitHub] [flink] tillrohrmann opened a new pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified

2019-04-01 Thread GitBox
tillrohrmann opened a new pull request #8096: [FLINK-12075][yarn] Set RestOptions.BIND_PORT only to 0 if not specified URL: https://github.com/apache/flink/pull/8096 ## What is the purpose of the change This PR changes the YarnEntrypointUtils#loadConfiguration so that it only

[jira] [Commented] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807100#comment-16807100 ] Till Rohrmann commented on FLINK-12075: --- I agree that we should fix this problem for the {{1.8.0}}

[jira] [Assigned] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-12075: - Assignee: Till Rohrmann > Not able to submit jobs on YARN when there's a firewall >

[jira] [Closed] (FLINK-10484) New latency tracking metrics format causes metrics cardinality explosion

2019-04-01 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Grier closed FLINK-10484. --- Resolution: Duplicate > New latency tracking metrics format causes metrics cardinality explosion >

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-01 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r270996549 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
azagrebin commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#discussion_r270968264 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
azagrebin commented on a change in pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#discussion_r270964380 ## File path:

[GitHub] [flink] Myasuka commented on issue #8085: [FLINK-12072] Change asyncio operator name without whitespaces to help capture the metrics properly

2019-04-01 Thread GitBox
Myasuka commented on issue #8085: [FLINK-12072] Change asyncio operator name without whitespaces to help capture the metrics properly URL: https://github.com/apache/flink/pull/8085#issuecomment-478660762 @sravankorumilli Glad to know this, please feel free to close original JIRA

[GitHub] [flink] sravankorumilli commented on issue #8085: [FLINK-12072] Change asyncio operator name without whitespaces to help capture the metrics properly

2019-04-01 Thread GitBox
sravankorumilli commented on issue #8085: [FLINK-12072] Change asyncio operator name without whitespaces to help capture the metrics properly URL: https://github.com/apache/flink/pull/8085#issuecomment-478659131 Hi, I have validated my understanding with a different statsd server &

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-01 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r270959880 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-01 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r270958976 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-01 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r270958659 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-01 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r270958314 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-01 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r270957214 ## File path:

[jira] [Commented] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806869#comment-16806869 ] Aljoscha Krettek commented on FLINK-12075: -- Relevant ML thread:

[jira] [Commented] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806868#comment-16806868 ] Aljoscha Krettek commented on FLINK-12075: -- I'd say this is a regression and a blocker if it

[jira] [Updated] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-12075: - Fix Version/s: 1.8.0 > Not able to submit jobs on YARN when there's a firewall >

[GitHub] [flink] zhijiangW commented on issue #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
zhijiangW commented on issue #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#issuecomment-478612152 cc @azagrebin This is

[jira] [Updated] (FLINK-12075) Not able to submit jobs on YARN when there's a firewall

2019-04-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-12075: - Priority: Blocker (was: Major) > Not able to submit jobs on YARN when there's a

[GitHub] [flink] flinkbot commented on issue #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
flinkbot commented on issue #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095#issuecomment-478609770 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] zhijiangW opened a new pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread GitBox
zhijiangW opened a new pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment URL: https://github.com/apache/flink/pull/8095 ## What is the purpose of the change *Currently `TaskEventDispatcher` is maintained in

[jira] [Updated] (FLINK-12078) Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12078: --- Labels: pull-request-available (was: ) > Abstract TaskEventPublisher interface for

[jira] [Updated] (FLINK-12078) Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

2019-04-01 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-12078: - Summary: Abstract TaskEventPublisher interface for simplifying NetworkEnvironment (was: Abstract

[GitHub] [flink] Myasuka commented on issue #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
Myasuka commented on issue #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#issuecomment-478553794 BTW, @zsq12138 please fill the description of this PR completely which should have `Brief change log`, `Verifying this change` section

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8070: [FLINK-12026][table]Remove the `xxxInternal` method from TableImpl

2019-04-01 Thread GitBox
sunjincheng121 commented on a change in pull request #8070: [FLINK-12026][table]Remove the `xxxInternal` method from TableImpl URL: https://github.com/apache/flink/pull/8070#discussion_r270836495 ## File path:

[GitHub] [flink] Myasuka commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
Myasuka commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#discussion_r270835508 ## File path: docs/dev/stream/operators/process_function.md ## @@ -86,7 +86,7 @@ The following

[GitHub] [flink] Myasuka commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
Myasuka commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#discussion_r270832051 ## File path: docs/dev/stream/operators/process_function.md ## @@ -199,14 +199,14 @@ case class

[GitHub] [flink] Myasuka commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc

2019-04-01 Thread GitBox
Myasuka commented on a change in pull request #8091: [hotfix][docs] fix error in Process Function Doc URL: https://github.com/apache/flink/pull/8091#discussion_r270832331 ## File path: docs/dev/stream/operators/process_function.md ## @@ -199,14 +199,14 @@ case class

[GitHub] [flink] flinkbot commented on issue #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
flinkbot commented on issue #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094#issuecomment-478549239 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] godfreyhe opened a new pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch

2019-04-01 Thread GitBox
godfreyhe opened a new pull request #8094: [FLINK-12079] [table-planner-blink] Add support for generating optimized logical plan for join on batch URL: https://github.com/apache/flink/pull/8094 ## What is the purpose of the change *Add support for generating optimized logical

[jira] [Updated] (FLINK-12079) Add support for generating optimized logical plan for join on batch

2019-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12079: --- Labels: pull-request-available (was: ) > Add support for generating optimized logical plan

  1   2   >