[GitHub] [flink] yanghua commented on a change in pull request #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-06-30 Thread GitBox
yanghua commented on a change in pull request #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector URL: https://github.com/apache/flink/pull/8871#discussion_r298900461 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/fli

[jira] [Commented] (FLINK-12953) View logs from Job view in Web Dashboard

2019-06-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875970#comment-16875970 ] vinoyang commented on FLINK-12953: -- [~chadrik] Thanks for clarifying my questions. They

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298897378 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/upsert/QueryE

[GitHub] [flink] wuchong commented on issue #7550: [FLINK-10245] [Streaming Connector] Add Pojo, Tuple, Row and Scala Product DataStream Sink and Upsert Table Sink for HBase

2019-06-30 Thread GitBox
wuchong commented on issue #7550: [FLINK-10245] [Streaming Connector] Add Pojo, Tuple, Row and Scala Product DataStream Sink and Upsert Table Sink for HBase URL: https://github.com/apache/flink/pull/7550#issuecomment-507135403 @Clark do you have time to update the pull request? --

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298892482 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/upsert/Que

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298891291 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsert

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298891195 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsert

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298890782 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsert

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298889986 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsert

[GitHub] [flink] JingsongLi commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#issuecomment-507119365 >Why we should expose JdbcDialect to users? IMO, this is an internal interface to handle different databases (well-know databa

[GitHub] [flink] asfgit closed pull request #8919: [FLINK-13022][table][hive] unify catalog function implementations

2019-06-30 Thread GitBox
asfgit closed pull request #8919: [FLINK-13022][table][hive] unify catalog function implementations URL: https://github.com/apache/flink/pull/8919 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink] bowenli86 commented on issue #8919: [FLINK-13022][table][hive] unify catalog function implementations

2019-06-30 Thread GitBox
bowenli86 commented on issue #8919: [FLINK-13022][table][hive] unify catalog function implementations URL: https://github.com/apache/flink/pull/8919#issuecomment-507116655 The Travis failure is unrelated. Merging This

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298877631 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJD

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298877518 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJD

[GitHub] [flink] JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298877538 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJD

[GitHub] [flink] wuchong edited a comment on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong edited a comment on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#issuecomment-507110081 > 1.The only difference between databases is just quoteIdentifier and the upsert mechanism now. Maybe we will encou

[GitHub] [flink] wuchong commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#issuecomment-507110081 > 1.The only difference between databases is just quoteIdentifier and the upsert mechanism now. Maybe we will encounter the sa

[jira] [Closed] (FLINK-12897) Improve the Python Table API docs by adding more examples

2019-06-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12897. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 534d53bf828404ef3dcd7aad9e7a8b6528606

[GitHub] [flink] asfgit closed pull request #8916: [FLINK-12897][python][docs] Improve the Python Table API docs by adding more examples

2019-06-30 Thread GitBox
asfgit closed pull request #8916: [FLINK-12897][python][docs] Improve the Python Table API docs by adding more examples URL: https://github.com/apache/flink/pull/8916 This is an automated message from the Apache Git Service.

[jira] [Commented] (FLINK-12953) View logs from Job view in Web Dashboard

2019-06-30 Thread Chad Dombrova (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875930#comment-16875930 ] Chad Dombrova commented on FLINK-12953: --- {quote}Does the web UI you showed is not

[GitHub] [flink] JingsongLi commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
JingsongLi commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#issuecomment-507106994 Thanks @wuchong 's great code and review, The reason why I don't introduce JdbcDialect first is: 1.The only difference betw

[jira] [Commented] (FLINK-12953) View logs from Job view in Web Dashboard

2019-06-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875916#comment-16875916 ] vinoyang commented on FLINK-12953: -- Hi [~chadrik], thanks for providing a clear gif exa

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-30 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298865535 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongr

[jira] [Commented] (FLINK-13032) Allow Access to Per-Window State in mergeable window ProcessWindowFunction

2019-06-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875909#comment-16875909 ] vinoyang commented on FLINK-13032: -- Do you meet some scenarios which need to this featu

[jira] [Commented] (FLINK-13034) Improve the performance when checking whether mapstate is empty for RocksDBStateBackend

2019-06-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875905#comment-16875905 ] Jark Wu commented on FLINK-13034: - +1 to {{isEmtpy()}}. > Improve the performance when

[GitHub] [flink] flinkbot edited a comment on issue #8916: [FLINK-12897][python][docs] Improve the Python Table API docs by adding more examples

2019-06-30 Thread GitBox
flinkbot edited a comment on issue #8916: [FLINK-12897][python][docs] Improve the Python Table API docs by adding more examples URL: https://github.com/apache/flink/pull/8916#issuecomment-506327371 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help th

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8916: [FLINK-12897][python][docs] Improve the Python Table API docs by adding more examples

2019-06-30 Thread GitBox
sunjincheng121 commented on a change in pull request #8916: [FLINK-12897][python][docs] Improve the Python Table API docs by adding more examples URL: https://github.com/apache/flink/pull/8916#discussion_r298852934 ## File path: docs/dev/table/common.md ## @@ -202,10 +259

[jira] [Created] (FLINK-13034) Improve the performance when checking whether mapstate is empty for RocksDBStateBackend

2019-06-30 Thread Yun Tang (JIRA)
Yun Tang created FLINK-13034: Summary: Improve the performance when checking whether mapstate is empty for RocksDBStateBackend Key: FLINK-13034 URL: https://issues.apache.org/jira/browse/FLINK-13034 Proje

[jira] [Updated] (FLINK-11696) Avoid to send mkdir requests to DFS from task side

2019-06-30 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-11696: - Summary: Avoid to send mkdir requests to DFS from task side (was: [checkpoint] Avoid to send mkdir requ

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-06-30 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-507046084 thanks for the reminder @danny0405. will try to take a look and create another PR asap. ---

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831640 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasKe

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831625 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasKe

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831489 ## File path: flink-ml-parent/flink-ml-lib/pom.xml ## @@ -0,0 +1,65 @@ + + +http://maven.apache

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831635 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasKe

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831709 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasPr

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831509 ## File path: flink-ml-parent/flink-ml-lib/pom.xml ## @@ -0,0 +1,65 @@ + + +http://maven.apache

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#discussion_r298831785 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasPr

[GitHub] [flink] shaoxuan-wang commented on issue #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-30 Thread GitBox
shaoxuan-wang commented on issue #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#issuecomment-507031331 Thanks for the contribution, @xuyang1706 The PR looks good to me in general. But I have a few concerns about the naming of int

[jira] [Commented] (FLINK-12939) Translate "Apache Kafka Connector" page into Chinese

2019-06-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875762#comment-16875762 ] Jark Wu commented on FLINK-12939: - Sure [~xujiang] > Translate "Apache Kafka Connector"

[jira] [Closed] (FLINK-12947) Translate "Twitter Connector" page into Chinese

2019-06-30 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12947. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 8315f38e89f897e32cfa0f23990cb3fb44db0d72 > Tr

[GitHub] [flink] asfgit closed pull request #8842: [FLINK-12947][docs] Translate Twitter Connector page into Chinese

2019-06-30 Thread GitBox
asfgit closed pull request #8842: [FLINK-12947][docs] Translate Twitter Connector page into Chinese URL: https://github.com/apache/flink/pull/8842 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Closed] (FLINK-12881) Add more functionalities for ML Params and ParamInfo class

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-12881. - Resolution: Fixed Fix Version/s: 1.9.0 > Add more functionalities for ML Params and Param

[jira] [Commented] (FLINK-12881) Add more functionalities for ML Params and ParamInfo class

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875719#comment-16875719 ] Shaoxuan Wang commented on FLINK-12881: --- Fixed in master:1660c6b47af789fa5c9bf

[jira] [Issue Comment Deleted] (FLINK-12470) FLIP39: Flink ML pipeline and ML libs

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-12470: -- Comment: was deleted (was: Fixed in master:1660c6b47af789fa5c9bf6a3ff77e868ca90) > FLIP39

[jira] [Commented] (FLINK-12470) FLIP39: Flink ML pipeline and ML libs

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875717#comment-16875717 ] Shaoxuan Wang commented on FLINK-12470: --- Fixed in master:1660c6b47af789fa5c9bf

[GitHub] [flink] asfgit closed pull request #8776: [FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class

2019-06-30 Thread GitBox
asfgit closed pull request #8776: [FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class URL: https://github.com/apache/flink/pull/8776 This is an automated message from the Apache Git Service. To respo

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822550 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -23,30 +23,23 @@ speci

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822984 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -84,55 +77,41 @@ input

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822925 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -84,55 +77,41 @@ input

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822449 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -23,30 +23,23 @@ speci

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822673 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -84,55 +77,41 @@ input

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822620 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -84,55 +77,41 @@ input

[GitHub] [flink] wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8918: [FLINK-12944][docs]Translate Streaming File Sink page into Chinese URL: https://github.com/apache/flink/pull/8918#discussion_r298822464 ## File path: docs/dev/connectors/streamfile_sink.zh.md ## @@ -23,30 +23,23 @@ speci

[GitHub] [flink] wuchong commented on a change in pull request #8837: [FLINK-12938][docs]Translate "Streaming Connectors" page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8837: [FLINK-12938][docs]Translate "Streaming Connectors" page into Chinese URL: https://github.com/apache/flink/pull/8837#discussion_r298821987 ## File path: docs/dev/connectors/index.zh.md ## @@ -28,16 +28,15 @@ under the Li

[GitHub] [flink] wuchong commented on a change in pull request #8837: [FLINK-12938][docs]Translate "Streaming Connectors" page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8837: [FLINK-12938][docs]Translate "Streaming Connectors" page into Chinese URL: https://github.com/apache/flink/pull/8837#discussion_r298822366 ## File path: docs/dev/connectors/index.zh.md ## @@ -48,39 +47,31 @@ Connectors p

[GitHub] [flink] wuchong commented on a change in pull request #8837: [FLINK-12938][docs]Translate "Streaming Connectors" page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8837: [FLINK-12938][docs]Translate "Streaming Connectors" page into Chinese URL: https://github.com/apache/flink/pull/8837#discussion_r298822152 ## File path: docs/dev/connectors/index.zh.md ## @@ -48,39 +47,31 @@ Connectors p

[GitHub] [flink] wuchong commented on a change in pull request #8842: [FLINK-12947][docs] Translate Twitter Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8842: [FLINK-12947][docs] Translate Twitter Connector page into Chinese URL: https://github.com/apache/flink/pull/8842#discussion_r298821892 ## File path: docs/dev/connectors/twitter.zh.md ## @@ -35,24 +35,21 @@ To use this co

[GitHub] [flink] wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese URL: https://github.com/apache/flink/pull/8838#discussion_r298821775 ## File path: docs/dev/connectors/nifi.zh.md ## @@ -23,9 +23,8 @@ specific languag

[GitHub] [flink] wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese URL: https://github.com/apache/flink/pull/8838#discussion_r298821782 ## File path: docs/dev/connectors/nifi.zh.md ## @@ -35,30 +34,23 @@ following depe

[GitHub] [flink] wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese URL: https://github.com/apache/flink/pull/8838#discussion_r298821853 ## File path: docs/dev/connectors/nifi.zh.md ## @@ -89,18 +81,17 @@ val nifiSource

[GitHub] [flink] wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese URL: https://github.com/apache/flink/pull/8838#discussion_r298821868 ## File path: docs/dev/connectors/nifi.zh.md ## @@ -135,6 +126,6 @@ streamExecEnv.

[GitHub] [flink] wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese URL: https://github.com/apache/flink/pull/8838#discussion_r298821829 ## File path: docs/dev/connectors/nifi.zh.md ## @@ -35,30 +34,23 @@ following depe

[GitHub] [flink] wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8838: [FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese URL: https://github.com/apache/flink/pull/8838#discussion_r298821790 ## File path: docs/dev/connectors/nifi.zh.md ## @@ -35,30 +34,23 @@ following depe

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821621 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -47,44 +43,30 @@ This connect

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821680 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -47,44 +43,30 @@ This connect

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821743 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -170,6 +151,6 @@ stream.addSi

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821645 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -47,44 +43,30 @@ This connect

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821204 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -23,21 +23,17 @@ specific lan

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821487 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -47,44 +43,30 @@ This connect

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821423 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -47,44 +43,30 @@ This connect

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821736 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -132,8 +114,7 @@ val stream =

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821407 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -47,44 +43,30 @@ This connect

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821048 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -23,21 +23,17 @@ specific lan

[GitHub] [flink] wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8843: [FLINK-12945][docs] Translate RabbitMQ Connector page into Chinese URL: https://github.com/apache/flink/pull/8843#discussion_r298821325 ## File path: docs/dev/connectors/rabbitmq.zh.md ## @@ -23,21 +23,17 @@ specific lan

[jira] [Closed] (FLINK-13014) ChainBreakTest failed on Travis

2019-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-13014. Resolution: Duplicate > ChainBreakTest failed on Travis > ---

[jira] [Closed] (FLINK-13020) UT Failure: ChainLengthDecreaseTest

2019-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-13020. Resolution: Duplicate Fix Version/s: (was: 1.9.0) > UT Failure: ChainLengthDecr

[jira] [Closed] (FLINK-13033) Unstable test ChainOrderTest

2019-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-13033. Resolution: Duplicate Fix Version/s: (was: 1.9.0) > Unstable test ChainOrderTes

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298525853 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJDBCO

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298554434 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertTab

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298569122 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertOut

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298554776 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertTab

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298524951 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJDBCO

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298557117 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJDBCO

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298556877 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/AbstractJDBCO

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298570308 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertOut

[GitHub] [flink] wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-06-30 Thread GitBox
wuchong commented on a change in pull request #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#discussion_r298520541 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/upsert/QueryE