[GitHub] [flink] flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig URL: https://github.com/apache/flink/pull/9212#issuecomment-514486972 ## CI report: * 68443427c89cca6ef5c1c39685c57c9884e101af : FAILURE

[jira] [Commented] (FLINK-13159) java.lang.ClassNotFoundException when restore job

2019-07-26 Thread Liu Bo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894254#comment-16894254 ] Liu Bo commented on FLINK-13159: I'm using flink 1.8.1 on yarn session with rocksdb as state backend.

[GitHub] [flink] flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig URL: https://github.com/apache/flink/pull/9212#issuecomment-514486972 ## CI report: * 68443427c89cca6ef5c1c39685c57c9884e101af : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515486131 ## CI report: * ae2528ac686c28a60641e8ea295221a510043e76 : FAILURE

[jira] [Commented] (FLINK-13273) Allow switching planners in SQL Client

2019-07-26 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894235#comment-16894235 ] Tzu-Li (Gordon) Tai commented on FLINK-13273: - It seems like the decision is to include this

[jira] [Updated] (FLINK-13444) Translate English content of FLINK-13396 into Chinese

2019-07-26 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13444: Issue Type: Sub-task (was: Task) Parent: FLINK-11529 > Translate English content of FLINK-13396

[jira] [Created] (FLINK-13444) Translate English content of FLINK-13396 into Chinese

2019-07-26 Thread Jark Wu (JIRA)
Jark Wu created FLINK-13444: --- Summary: Translate English content of FLINK-13396 into Chinese Key: FLINK-13444 URL: https://issues.apache.org/jira/browse/FLINK-13444 Project: Flink Issue Type: Task

[GitHub] [flink] flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig URL: https://github.com/apache/flink/pull/9212#issuecomment-514486972 ## CI report: * 68443427c89cca6ef5c1c39685c57c9884e101af : FAILURE

[jira] [Commented] (FLINK-13432) Set max polling interval threshold for job result polling

2019-07-26 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894226#comment-16894226 ] vinoyang commented on FLINK-13432: -- [~zjffdu] I think it's reasonable. cc [~aljoscha] > Set max

[GitHub] [flink] flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig URL: https://github.com/apache/flink/pull/9212#issuecomment-514486972 ## CI report: * 68443427c89cca6ef5c1c39685c57c9884e101af : FAILURE

[GitHub] [flink] yanghua edited a comment on issue #9238: [FLINK-13387][WebUI] Fix log download for old UI

2019-07-26 Thread GitBox
yanghua edited a comment on issue #9238: [FLINK-13387][WebUI] Fix log download for old UI URL: https://github.com/apache/flink/pull/9238#issuecomment-515641316 Hi @zentol When clicking the download button, the behavior is that it will open a new web page and show the content of the whole

[GitHub] [flink] yanghua commented on issue #9238: [FLINK-13387][WebUI] Fix log download for old UI

2019-07-26 Thread GitBox
yanghua commented on issue #9238: [FLINK-13387][WebUI] Fix log download for old UI URL: https://github.com/apache/flink/pull/9238#issuecomment-515641316 Hi @zentol When clicking the download button, the behavior is open a new web page and show the content of the whole log file. There is a

[GitHub] [flink] danny0405 commented on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig

2019-07-26 Thread GitBox
danny0405 commented on issue #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig URL: https://github.com/apache/flink/pull/9212#issuecomment-515641356 Hi @twalthr , i have updated for your review address, please review again if you have time, thanks ~

[GitHub] [flink] danny0405 commented on a change in pull request #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig

2019-07-26 Thread GitBox
danny0405 commented on a change in pull request #9212: [FLINK-13338][table-api] Sql conformance is hard to config in TableConfig URL: https://github.com/apache/flink/pull/9212#discussion_r307948160 ## File path:

[jira] [Commented] (FLINK-13387) Can not download taskmanger & jobmanager's logs in the old UI

2019-07-26 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894221#comment-16894221 ] vinoyang commented on FLINK-13387: -- [~Zentol] OK, Glad to sound this message. > Can not download

[GitHub] [flink] flinkbot edited a comment on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot URL: https://github.com/apache/flink/pull/9245#issuecomment-515507399 ## CI report: * 2c7c67a0d15016887e9c917fee0bfe34e9d0e131 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515486131 ## CI report: * ae2528ac686c28a60641e8ea295221a510043e76 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot URL: https://github.com/apache/flink/pull/9245#issuecomment-515507399 ## CI report: * 2c7c67a0d15016887e9c917fee0bfe34e9d0e131 : FAILURE

[jira] [Updated] (FLINK-13334) Remove legacy slot implementation

2019-07-26 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TisonKun updated FLINK-13334: - Summary: Remove legacy slot implementation (was: Remove legacy implementation of slot) > Remove

[GitHub] [flink] flinkbot edited a comment on issue #9210: [FLINK-12746][docs] Getting Started - DataStream Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9210: [FLINK-12746][docs] Getting Started - DataStream Example Walkthrough URL: https://github.com/apache/flink/pull/9210#issuecomment-514437706 ## CI report: * 5eb979da047c442c0205464c92b5bd9ee3a740dc : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9210: [FLINK-12746][docs] Getting Started - DataStream Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9210: [FLINK-12746][docs] Getting Started - DataStream Example Walkthrough URL: https://github.com/apache/flink/pull/9210#issuecomment-514437706 ## CI report: * 5eb979da047c442c0205464c92b5bd9ee3a740dc : FAILURE

[GitHub] [flink] xuefuz commented on issue #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn

2019-07-26 Thread GitBox
xuefuz commented on issue #9237: [FLINK-13431][hive] NameNode HA configuration was not loaded when running HiveConnector on Yarn URL: https://github.com/apache/flink/pull/9237#issuecomment-515591055 Thanks for the contribution! The are a couple of high-level suggestions: 1. Please

[GitHub] [flink] flinkbot edited a comment on issue #9169: [FLINK-12998][docs] Update documentation for file systems loading as plugins

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9169: [FLINK-12998][docs] Update documentation for file systems loading as plugins URL: https://github.com/apache/flink/pull/9169#issuecomment-512820058 ## CI report: * a7bfcd7a2605fe9299655cb26d3f829b4751ecd6 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651 ## CI report: * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot URL: https://github.com/apache/flink/pull/9245#issuecomment-515507399 ## CI report: * 2c7c67a0d15016887e9c917fee0bfe34e9d0e131 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515486131 ## CI report: * ae2528ac686c28a60641e8ea295221a510043e76 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651 ## CI report: * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9022: [FLINK-13127] Fix --yarnship classpath

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9022: [FLINK-13127] Fix --yarnship classpath URL: https://github.com/apache/flink/pull/9022#issuecomment-512166531 ## CI report: * 277d92daa0e31cc2fced052a1b311cdba0f567e1 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119436815)

[GitHub] [flink] flinkbot edited a comment on issue #9244: [FLINK-13396] Deprecate the BucketingSink.

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9244: [FLINK-13396] Deprecate the BucketingSink. URL: https://github.com/apache/flink/pull/9244#issuecomment-515493269 ## CI report: * 8e3b712c5c2e003747737d2fb77752a3e10a3279 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651 ## CI report: * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS

[jira] [Updated] (FLINK-13278) add Chinese documentation for Hive source/sink

2019-07-26 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-13278: Priority: Major (was: Blocker) > add Chinese documentation for Hive source/sink >

[jira] [Commented] (FLINK-13443) Support/Map Hive INTERVAL type in Hive connector

2019-07-26 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894012#comment-16894012 ] Xuefu Zhang commented on FLINK-13443: - cc: [~Terry1897], [~twalthr], [~phoenixjiangnan] >

[jira] [Created] (FLINK-13443) Support/Map Hive INTERVAL type in Hive connector

2019-07-26 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created FLINK-13443: --- Summary: Support/Map Hive INTERVAL type in Hive connector Key: FLINK-13443 URL: https://issues.apache.org/jira/browse/FLINK-13443 Project: Flink Issue Type:

[jira] [Updated] (FLINK-13438) Fix Hive connector with DataTypes.DATE/TIME/TIMESTAMP support

2019-07-26 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-13438: Priority: Blocker (was: Major) > Fix Hive connector with DataTypes.DATE/TIME/TIMESTAMP support >

[jira] [Updated] (FLINK-13278) add Chinese documentation for Hive source/sink

2019-07-26 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-13278: Priority: Blocker (was: Major) > add Chinese documentation for Hive source/sink >

[jira] [Commented] (FLINK-9017) FlinkKafkaProducer011ITCase.testFlinkKafkaProducer011FailBeforeNotify times out on Travis

2019-07-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894014#comment-16894014 ] Jiangjie Qin commented on FLINK-9017: - >From the stack trace, the issue seems on the test harness

[GitHub] [flink] zhijiangW commented on issue #9132: [FLINK-13245][network] Fix the bug of resource leak while releasing partition and view reader

2019-07-26 Thread GitBox
zhijiangW commented on issue #9132: [FLINK-13245][network] Fix the bug of resource leak while releasing partition and view reader URL: https://github.com/apache/flink/pull/9132#issuecomment-515536932 I adjusted the PR description based on the latest modifications, and all the commits

[GitHub] [flink] StephanEwen commented on issue #9170: [FLINK-13325][test] Add test to guard the fix for FLINK-13249

2019-07-26 Thread GitBox
StephanEwen commented on issue #9170: [FLINK-13325][test] Add test to guard the fix for FLINK-13249 URL: https://github.com/apache/flink/pull/9170#issuecomment-515535529 I validated that the test indeed fails without the original fix. Will address @zhijiangW's comments and merge

[GitHub] [flink] flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515486131 ## CI report: * ae2528ac686c28a60641e8ea295221a510043e76 : FAILURE

[GitHub] [flink] xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-26 Thread GitBox
xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r307836551 ## File path: docs/dev/table/catalog.md ## @@ -179,10 +179,11 @@ Currently `HiveCatalog`

[GitHub] [flink] flinkbot edited a comment on issue #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired URL: https://github.com/apache/flink/pull/9242#issuecomment-515479114 ## CI report: *

[GitHub] [flink] xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-26 Thread GitBox
xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r307830806 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-26 Thread GitBox
xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r307832232 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

2019-07-26 Thread GitBox
xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37 URL: https://github.com/apache/flink/pull/9239#discussion_r307832232 ## File path:

[jira] [Commented] (FLINK-12396) KafkaITCase.testOneSourceMultiplePartitions doesn't fail properly

2019-07-26 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893972#comment-16893972 ] Jiangjie Qin commented on FLINK-12396: -- This is probably related to FLINK-13226, which has a PR to

[GitHub] [flink] tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired URL: https://github.com/apache/flink/pull/9242#discussion_r307811139 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired URL: https://github.com/apache/flink/pull/9242#discussion_r307822497 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired URL: https://github.com/apache/flink/pull/9242#discussion_r307821474 ## File path:

[jira] [Created] (FLINK-13442) Remove unnecessary notifySubpartitionConsumed method from view reader

2019-07-26 Thread zhijiang (JIRA)
zhijiang created FLINK-13442: Summary: Remove unnecessary notifySubpartitionConsumed method from view reader Key: FLINK-13442 URL: https://issues.apache.org/jira/browse/FLINK-13442 Project: Flink

[GitHub] [flink] tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired URL: https://github.com/apache/flink/pull/9242#discussion_r307812176 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-511875353 ## CI report: * 3f40e06e867f0b661c62e8ba690156b3819135d5 : FAILURE

[jira] [Commented] (FLINK-13436) Add TPC-H queries as E2E tests

2019-07-26 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893962#comment-16893962 ] Yu Li commented on FLINK-13436: --- Sorry but just noticed your reply [~xuefuz]. FWIW, I think using Hive

[GitHub] [flink] flinkbot edited a comment on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-511875353 ## CI report: * 3f40e06e867f0b661c62e8ba690156b3819135d5 : FAILURE

[jira] [Commented] (FLINK-13436) Add TPC-H queries as E2E tests

2019-07-26 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893957#comment-16893957 ] Yu Li commented on FLINK-13436: --- After some offline discussion with [~till.rohrmann] and [~twalthr], we

[GitHub] [flink] xintongsong commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-26 Thread GitBox
xintongsong commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#discussion_r307812100 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9169: [FLINK-12998][docs] Update documentation for file systems loading as plugins

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9169: [FLINK-12998][docs] Update documentation for file systems loading as plugins URL: https://github.com/apache/flink/pull/9169#issuecomment-512820058 ## CI report: * a7bfcd7a2605fe9299655cb26d3f829b4751ecd6 : FAILURE

[GitHub] [flink] StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request

2019-07-26 Thread GitBox
StephanEwen commented on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-515511582 From my side, +1 to commit this

[GitHub] [flink] tillrohrmann commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-26 Thread GitBox
tillrohrmann commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#issuecomment-515509225 @xintongsong please also open a PR against the `master`

[GitHub] [flink] tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#discussion_r307803681 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#discussion_r307803611 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#discussion_r307806934 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-26 Thread GitBox
tillrohrmann commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#discussion_r307805904 ## File path:

[jira] [Commented] (FLINK-13436) Add TPC-H queries as E2E tests

2019-07-26 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893934#comment-16893934 ] Xuefu Zhang commented on FLINK-13436: - Maybe we can use Hive data for this, which can verify both

[GitHub] [flink] flinkbot commented on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot

2019-07-26 Thread GitBox
flinkbot commented on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot URL: https://github.com/apache/flink/pull/9245#issuecomment-515507399 ## CI report: * 2c7c67a0d15016887e9c917fee0bfe34e9d0e131 : PENDING

[jira] [Commented] (FLINK-13437) Add Hive SQL E2E test

2019-07-26 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893932#comment-16893932 ] Xuefu Zhang commented on FLINK-13437: - There seems to be a JIRA (FLINK-13303) covering this. We are

[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651 ## CI report: * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS

[GitHub] [flink] flinkbot commented on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot

2019-07-26 Thread GitBox
flinkbot commented on issue #9245: [FLINK-13334][coordination] Remove legacy implementation of slot URL: https://github.com/apache/flink/pull/9245#issuecomment-515505238 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Updated] (FLINK-13334) Remove legacy implementation of slot

2019-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13334: --- Labels: pull-request-available (was: ) > Remove legacy implementation of slot >

[GitHub] [flink] walterddr commented on a change in pull request #9227: [FLINK-13347] [table-planner] should handle SEMI/ANTI JoinRelType in switch case

2019-07-26 Thread GitBox
walterddr commented on a change in pull request #9227: [FLINK-13347] [table-planner] should handle SEMI/ANTI JoinRelType in switch case URL: https://github.com/apache/flink/pull/9227#discussion_r307800633 ## File path:

[jira] [Comment Edited] (FLINK-13334) Remove legacy implementation of slot

2019-07-26 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893922#comment-16893922 ] TisonKun edited comment on FLINK-13334 at 7/26/19 3:43 PM: --- Change the purpose

[jira] [Commented] (FLINK-13334) Remove legacy implementation of slot

2019-07-26 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893922#comment-16893922 ] TisonKun commented on FLINK-13334: -- Change the purpose of this JIRA into remove the whole legacy slot

[GitHub] [flink] TisonKun opened a new pull request #9245: [FLINK-13334][coordination] Remove legacy implementation of slot

2019-07-26 Thread GitBox
TisonKun opened a new pull request #9245: [FLINK-13334][coordination] Remove legacy implementation of slot URL: https://github.com/apache/flink/pull/9245 ## What is the purpose of the change Remove legacy implementation of slot ## Verifying this change This change is a

[GitHub] [flink] sjwiesman edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
sjwiesman edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-515499428 Thanks for taking a look @fhueske, I believe I have addressed all of your points. In particular, I've added

[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651 ## CI report: * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS

[jira] [Updated] (FLINK-13334) Remove legacy implementation of slot

2019-07-26 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TisonKun updated FLINK-13334: - Summary: Remove legacy implementation of slot (was: Remove legacy implementation of slot sharing) >

[jira] [Created] (FLINK-13441) Add batch E2E test which runs with fewer slots than parallelism

2019-07-26 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-13441: - Summary: Add batch E2E test which runs with fewer slots than parallelism Key: FLINK-13441 URL: https://issues.apache.org/jira/browse/FLINK-13441 Project: Flink

[jira] [Commented] (FLINK-9900) Failed to testRestoreBehaviourWithFaultyStateHandles (org.apache.flink.test.checkpointing.ZooKeeperHighAvailabilityITCase)

2019-07-26 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893912#comment-16893912 ] Till Rohrmann commented on FLINK-9900: -- Another instance:

[GitHub] [flink] sjwiesman commented on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
sjwiesman commented on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-515499428 Thanks for taking a look @fhueske, I believe I have addressed all of your points. In particular, I've added

[GitHub] [flink] flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515486131 ## CI report: * ae2528ac686c28a60641e8ea295221a510043e76 : PENDING

[GitHub] [flink] flinkbot edited a comment on issue #9241: [FLINK-13429][table-common] Fix BoundedOutOfOrderTimestamps watermark strategy

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9241: [FLINK-13429][table-common] Fix BoundedOutOfOrderTimestamps watermark strategy URL: https://github.com/apache/flink/pull/9241#issuecomment-515451295 ## CI report: * 0e7253d2000a50c620e1f889242dd88225cac335 : FAILURE

[jira] [Commented] (FLINK-13384) The back pressure monitoring does not work for StreamSources

2019-07-26 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893897#comment-16893897 ] Gary Yao commented on FLINK-13384: -- Currently, we sample the stacktrace in

[GitHub] [flink] flinkbot edited a comment on issue #9022: [FLINK-13127] Fix --yarnship classpath

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9022: [FLINK-13127] Fix --yarnship classpath URL: https://github.com/apache/flink/pull/9022#issuecomment-512166531 ## CI report: * 277d92daa0e31cc2fced052a1b311cdba0f567e1 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119436815)

[GitHub] [flink] flinkbot commented on issue #9244: [FLINK-13396] Deprecate the BucketingSink.

2019-07-26 Thread GitBox
flinkbot commented on issue #9244: [FLINK-13396] Deprecate the BucketingSink. URL: https://github.com/apache/flink/pull/9244#issuecomment-515493269 ## CI report: * 8e3b712c5c2e003747737d2fb77752a3e10a3279 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/120873450)

[GitHub] [flink] flinkbot edited a comment on issue #9240: [FLINK-13440] Add test that fails job when in-flight sync savepoint is discarded.

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9240: [FLINK-13440] Add test that fails job when in-flight sync savepoint is discarded. URL: https://github.com/apache/flink/pull/9240#issuecomment-515444385 ## CI report: * 183d83b2c0abf0804c8ce3b68c3546cd05b46741 : SUCCESS

[jira] [Commented] (FLINK-12858) Potential distributed deadlock in case of synchronous savepoint failure

2019-07-26 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893881#comment-16893881 ] Kostas Kloudas commented on FLINK-12858: The test is ready and there is a PR for it here

[GitHub] [flink] flinkbot commented on issue #9244: [FLINK-13396] Deprecate the BucketingSink.

2019-07-26 Thread GitBox
flinkbot commented on issue #9244: [FLINK-13396] Deprecate the BucketingSink. URL: https://github.com/apache/flink/pull/9244#issuecomment-515489951 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We

[GitHub] [flink] flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough URL: https://github.com/apache/flink/pull/8903#issuecomment-510464651 ## CI report: * b2821a6ae97fd943f3a66b672e85fbd2374126c4 : SUCCESS

[GitHub] [flink] dmvk commented on issue #9022: [FLINK-13127] Fix --yarnship classpath

2019-07-26 Thread GitBox
dmvk commented on issue #9022: [FLINK-13127] Fix --yarnship classpath URL: https://github.com/apache/flink/pull/9022#issuecomment-515490263 @xintongsong done ;) thanks This is an automated message from the Apache Git Service.

[jira] [Updated] (FLINK-13396) Deprecate BucketingSink

2019-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13396: --- Labels: pull-request-available (was: ) > Deprecate BucketingSink > ---

[GitHub] [flink] kl0u opened a new pull request #9244: [FLINK-13396] Deprecate the BucketingSink.

2019-07-26 Thread GitBox
kl0u opened a new pull request #9244: [FLINK-13396] Deprecate the BucketingSink. URL: https://github.com/apache/flink/pull/9244 ## What is the purpose of the change It marks the `BucketingSink` as deprecated in favour of the `StreamingFileSink` and updates the documentation

[GitHub] [flink] zhijiangW commented on a change in pull request #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request

2019-07-26 Thread GitBox
zhijiangW commented on a change in pull request #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#discussion_r307782071 ## File path:

[GitHub] [flink] flinkbot commented on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot commented on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515486131 ## CI report: * ae2528ac686c28a60641e8ea295221a510043e76 : PENDING

[GitHub] [flink] flinkbot edited a comment on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request

2019-07-26 Thread GitBox
flinkbot edited a comment on issue #9132: [FLINK-13245][network] Fix the bug of file resource leak while canceling partition request URL: https://github.com/apache/flink/pull/9132#issuecomment-511875353 ## CI report: * 3f40e06e867f0b661c62e8ba690156b3819135d5 : FAILURE

[GitHub] [flink] flinkbot commented on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
flinkbot commented on issue #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#issuecomment-515483799 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-13335) Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13335: --- Labels: pull-request-available (was: ) > Align the SQL CREATE TABLE DDL with FLIP-37 >

[GitHub] [flink] danny0405 opened a new pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-26 Thread GitBox
danny0405 opened a new pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243 ## What is the purpose of the change Support parse all the data types defined in FLINK-37 - STRING - BYTES - TIME

[GitHub] [flink] xintongsong commented on issue #9022: [FLINK-13127] Fix --yarnship classpath

2019-07-26 Thread GitBox
xintongsong commented on issue #9022: [FLINK-13127] Fix --yarnship classpath URL: https://github.com/apache/flink/pull/9022#issuecomment-515482406 Maybe also rebase to the latest master? There is a travis test failure, which is not caused by this PR and should been fixed on master branch.

[GitHub] [flink] twalthr commented on a change in pull request #9219: [FLINK-13404] [table] Port csv factories and descriptors to flink-csv

2019-07-26 Thread GitBox
twalthr commented on a change in pull request #9219: [FLINK-13404] [table] Port csv factories and descriptors to flink-csv URL: https://github.com/apache/flink/pull/9219#discussion_r307774075 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #9219: [FLINK-13404] [table] Port csv factories and descriptors to flink-csv

2019-07-26 Thread GitBox
twalthr commented on a change in pull request #9219: [FLINK-13404] [table] Port csv factories and descriptors to flink-csv URL: https://github.com/apache/flink/pull/9219#discussion_r307774266 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #9219: [FLINK-13404] [table] Port csv factories and descriptors to flink-csv

2019-07-26 Thread GitBox
twalthr commented on a change in pull request #9219: [FLINK-13404] [table] Port csv factories and descriptors to flink-csv URL: https://github.com/apache/flink/pull/9219#discussion_r307773251 ## File path: flink-formats/flink-csv/pom.xml ## @@ -58,31 +58,24 @@ under the

  1   2   3   4   >