[jira] [Comment Edited] (FLINK-18027) ROW value constructor cannot deal with complex expressions

2023-04-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711200#comment-17711200 ] Aitozi edited comment on FLINK-18027 at 4/12/23 5:43 AM: - The content is

[jira] [Commented] (FLINK-18027) ROW value constructor cannot deal with complex expressions

2023-04-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711200#comment-17711200 ] Aitozi commented on FLINK-18027: The content is modified from 

[GitHub] [flink] Aitozi commented on a diff in pull request #22378: [FLINK-31344][planner] Support to update nested columns in update sta…

2023-04-11 Thread via GitHub
Aitozi commented on code in PR #22378: URL: https://github.com/apache/flink/pull/22378#discussion_r1162597631 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/RowLevelUpdateTest.xml: ## @@ -20,17 +20,17 @@ limitations under the

[GitHub] [flink] Aitozi commented on a diff in pull request #22378: [FLINK-31344][planner] Support to update nested columns in update sta…

2023-04-11 Thread via GitHub
Aitozi commented on code in PR #22378: URL: https://github.com/apache/flink/pull/22378#discussion_r1162702918 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/RowLevelUpdateTest.xml: ## @@ -20,17 +20,17 @@ limitations under the

[GitHub] [flink-ml] lindong28 opened a new pull request, #232: [hotfix] Update pattern matching in test_ml_lib_completeness to work with release branch

2023-04-11 Thread via GitHub
lindong28 opened a new pull request, #232: URL: https://github.com/apache/flink-ml/pull/232 ## What is the purpose of the change Update pattern matching in test_ml_lib_completeness to work with release branch ## Brief change log Updated test_ml_lib_completeness.

[jira] [Commented] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-11 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711185#comment-17711185 ] Weihua Hu commented on FLINK-31775: --- Thanks [~sergiosp] report this. IMHO, this is the same issue as

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-04-11 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1163517899 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -980,8 +963,7 @@ protected CompletableFuture getCompletionFuture()

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-04-11 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1163517899 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -980,8 +963,7 @@ protected CompletableFuture getCompletionFuture()

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-04-11 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1163517899 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -980,8 +963,7 @@ protected CompletableFuture getCompletionFuture()

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-04-11 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1163517899 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -980,8 +963,7 @@ protected CompletableFuture getCompletionFuture()

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-04-11 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1163517899 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -980,8 +963,7 @@ protected CompletableFuture getCompletionFuture()

[jira] [Updated] (FLINK-31762) Subscribe to multiple Kafka topics may cause partition assignment skew

2023-04-11 Thread Liam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liam updated FLINK-31762: - Description: To simplify the demonstration, let us assume that there are two topics, and each topic has four

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-11 Thread via GitHub
jiangxin369 commented on code in PR #229: URL: https://github.com/apache/flink-ml/pull/229#discussion_r1161619708 ## flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/OperatorUtils.java: ## @@ -104,6 +107,33 @@ public static StreamConfig

[GitHub] [flink-ml] jiangxin369 commented on pull request #231: [FLINK-31374] ProxyStreamPartitioner should implement ConfigurableStreamPartitioner

2023-04-11 Thread via GitHub
jiangxin369 commented on PR #231: URL: https://github.com/apache/flink-ml/pull/231#issuecomment-1504431951 @zhipeng93 Thanks for the review, I've updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-31301) Unsupported nested columns in column list of insert statement

2023-04-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711166#comment-17711166 ] lincoln lee commented on FLINK-31301: - [~aitozi] thanks for fixing this! I'll try to find some time

[jira] [Comment Edited] (FLINK-31533) CREATE TABLE AS SELECT should support to define partition

2023-04-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711161#comment-17711161 ] luoyuxia edited comment on FLINK-31533 at 4/12/23 1:27 AM: --- [~aitozi] Thanks

[jira] [Comment Edited] (FLINK-31533) CREATE TABLE AS SELECT should support to define partition

2023-04-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711161#comment-17711161 ] luoyuxia edited comment on FLINK-31533 at 4/12/23 1:27 AM: --- [~aitozi] Thanks

[jira] [Commented] (FLINK-31533) CREATE TABLE AS SELECT should support to define partition

2023-04-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711161#comment-17711161 ] luoyuxia commented on FLINK-31533: -- [~aitozi] Thanks for voluntering,  but please remember with the

[jira] [Assigned] (FLINK-31774) Add document for delete and update statement

2023-04-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-31774: Assignee: Aitozi > Add document for delete and update statement >

[jira] [Commented] (FLINK-31774) Add document for delete and update statement

2023-04-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711159#comment-17711159 ] luoyuxia commented on FLINK-31774: -- [~aitozi] Thanks for raising it and voluntering. I miss to add

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
lindong28 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1163455375 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/sort/CoGroupOperator.java: ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
lindong28 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1163453972 ## flink-ml-core/src/test/java/org/apache/flink/ml/common/datastream/DataStreamUtilsTest.java: ## @@ -59,6 +64,54 @@ public void testMapPartition() throws Exception {

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
lindong28 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1163453972 ## flink-ml-core/src/test/java/org/apache/flink/ml/common/datastream/DataStreamUtilsTest.java: ## @@ -59,6 +64,54 @@ public void testMapPartition() throws Exception {

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
lindong28 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1163453277 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/sort/CoGroupOperator.java: ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
lindong28 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1163450592 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/sort/CoGroupOperator.java: ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
lindong28 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1163449957 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/sort/CoGroupOperator.java: ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#issuecomment-1504292430 Merged via https://github.com/apache/flink-connector-kafka/commit/a7785630e714af303b224c38d9a6caa89a551265 I squashed my changes along with your comment. Please let me

[GitHub] [flink-connector-kafka] tzulitai closed pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai closed pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink URL: https://github.com/apache/flink-connector-kafka/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#issuecomment-1504282565 @AlexAxeman thanks a lot for your contribution! +1 LGTM. Since there's other work that is sort of depending on this feature, I'll proceed to merge this PR and address

[jira] [Comment Edited] (FLINK-28171) Adjust Job and Task manager port definitions to work with Istio+mTLS

2023-04-11 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710375#comment-17710375 ] Sergio Sainz edited comment on FLINK-28171 at 4/11/23 11:46 PM: Hello

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163427396 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java: ## @@ -86,6 +89,16 @@ public

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-04-11 Thread via GitHub
rkhachatryan commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1163352135 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -980,8 +963,7 @@ protected CompletableFuture

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21833: [FLINK-30852][runtime] Checking task cancelation explicitly rather than failing the cancel method

2023-04-11 Thread via GitHub
rkhachatryan commented on code in PR #21833: URL: https://github.com/apache/flink/pull/21833#discussion_r1163338534 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java: ## @@ -1300,9 +1304,7 @@ public TestInvokableCorrect(Environment environment) {

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #563: [FLINK-31716] Event UID field is missing the first time that an event…

2023-04-11 Thread via GitHub
morhidi commented on PR #563: URL: https://github.com/apache/flink-kubernetes-operator/pull/563#issuecomment-1504075103 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22377: [FLINK-31765][runtime][test] Disable changelog backend for RocksDB migration tests

2023-04-11 Thread via GitHub
rkhachatryan commented on code in PR #22377: URL: https://github.com/apache/flink/pull/22377#discussion_r1163316537 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/StatefulJobSnapshotMigrationITCase.java: ## @@ -136,6 +136,9 @@ public void testSavepoint()

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #563: [FLINK-31716] Event UID field is missing the first time that an event…

2023-04-11 Thread via GitHub
morhidi commented on code in PR #563: URL: https://github.com/apache/flink-kubernetes-operator/pull/563#discussion_r1163279331 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/EventUtilsTest.java: ## @@ -72,6 +72,7 @@ public void

[GitHub] [flink-connector-opensearch] reta commented on pull request #18: [hotfix] Use 1.0.0-1.16 baseline for API compatibility checks

2023-04-11 Thread via GitHub
reta commented on PR #18: URL: https://github.com/apache/flink-connector-opensearch/pull/18#issuecomment-1504021457 @MartijnVisser if you have time, super small one, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-kubernetes-operator] rodmeneses opened a new pull request, #563: [FLINK-31716] Event UID field is missing the first time that an event…

2023-04-11 Thread via GitHub
rodmeneses opened a new pull request, #563: URL: https://github.com/apache/flink-kubernetes-operator/pull/563 What is the purpose of the change Fixes a bug reported on https://issues.apache.org/jira/browse/FLINK-31716 where the event being consumed for the first time didn't have

[jira] [Commented] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-04-11 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711097#comment-17711097 ] Roman Khachatryan commented on FLINK-31743: --- [~assassinj] are you still planning to work on

[jira] [Updated] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-11 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Sainz updated FLINK-31775: - Description: When using native kubernetes deployment mode with high-availability (HA), and

[jira] [Reopened] (FLINK-31716) Event UID field is missing the first time that an event is consumed

2023-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reopened FLINK-31716: > Event UID field is missing the first time that an event is consumed >

[jira] [Updated] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-11 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Sainz updated FLINK-31775: - Description: When using native kubernetes deployment mode with high-availability, and when new

[jira] [Updated] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-11 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Sainz updated FLINK-31775: - Description: When using native kubernetes deployment mode, and when new TaskManager pod is

[jira] [Updated] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-11 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Sainz updated FLINK-31775: - Description: When using native kubernetes deployment mode, and when new TaskManager pod is

[jira] [Created] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-11 Thread Sergio Sainz (Jira)
Sergio Sainz created FLINK-31775: Summary: High-Availability not supported in kubernetes when istio enabled Key: FLINK-31775 URL: https://issues.apache.org/jira/browse/FLINK-31775 Project: Flink

[GitHub] [flink] MartijnVisser closed pull request #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

2023-04-11 Thread via GitHub
MartijnVisser closed pull request #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion URL: https://github.com/apache/flink/pull/22371 -- This is an automated message from the Apache Git Service. To

[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on pull request #59: [FLINK-31696] ElasticSearch nightly CI failure

2023-04-11 Thread via GitHub
MartijnVisser commented on PR #59: URL: https://github.com/apache/flink-connector-elasticsearch/pull/59#issuecomment-1503913242 Nightly triggered at https://github.com/apache/flink-connector-elasticsearch/actions/runs/4670944068 -- This is an automated message from the Apache Git

[jira] [Assigned] (FLINK-17508) Develop Oracle Catalog

2023-04-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-17508: -- Assignee: (was: RocMarshal) > Develop Oracle Catalog > -- >

[jira] [Closed] (FLINK-31696) ElasticSearch nightly CI failure

2023-04-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31696. -- Fix Version/s: elasticsearch-4.0.0 Resolution: Fixed Fixed in main:

[GitHub] [flink-connector-elasticsearch] MartijnVisser merged pull request #59: [FLINK-31696] ElasticSearch nightly CI failure

2023-04-11 Thread via GitHub
MartijnVisser merged PR #59: URL: https://github.com/apache/flink-connector-elasticsearch/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-elasticsearch] reta commented on pull request #59: [FLINK-31696] ElasticSearch nightly CI failure

2023-04-11 Thread via GitHub
reta commented on PR #59: URL: https://github.com/apache/flink-connector-elasticsearch/pull/59#issuecomment-1503855950 > @reta Can you include setting the version for the connector to 4.0-SNAPSHOT, given that we'll drop support for Flink 1.16 with this PR? @MartijnVisser it was done

[GitHub] [flink] flinkbot commented on pull request #22381: [FLINK-31763][runtime] Ensure that the total number of requested buffers does not exceed poolSize + maxOverdraftBuffersPerGate

2023-04-11 Thread via GitHub
flinkbot commented on PR #22381: URL: https://github.com/apache/flink/pull/22381#issuecomment-1503852904 ## CI report: * d4ac5891e842a21920525a5ed5f0ccce5206718c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31763) Ensure that the total number of requested buffers does not exceed poolSize + maxOverdraftBuffersPerGate

2023-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31763: --- Labels: pull-request-available (was: ) > Ensure that the total number of requested buffers

[GitHub] [flink] reswqa opened a new pull request, #22381: [FLINK-31763][runtime] Ensure that the total number of requested buffers does not exceed poolSize + maxOverdraftBuffersPerGate

2023-04-11 Thread via GitHub
reswqa opened a new pull request, #22381: URL: https://github.com/apache/flink/pull/22381 ## What is the purpose of the change *As we discussed in [FLINK-31610](https://issues.apache.org/jira/browse/FLINK-31610), new buffers can be requested only when `numOfRequestedMemorySegments +

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163104861 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163104861 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-kafka] AlexAxeman commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
AlexAxeman commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163100734 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-kafka] AlexAxeman commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
AlexAxeman commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163098741 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163096185 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink] mohsenrezaeithe commented on pull request #22302: [hotfix] [docs] Fix `ROW()` decleration syntax

2023-04-11 Thread via GitHub
mohsenrezaeithe commented on PR #22302: URL: https://github.com/apache/flink/pull/22302#issuecomment-1503771608 @wuchong could you please approve this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-connector-opensearch] reta opened a new pull request, #18: [hotfix] Use 1.0.0-1.16 baseline for API compatibility checks

2023-04-11 Thread via GitHub
reta opened a new pull request, #18: URL: https://github.com/apache/flink-connector-opensearch/pull/18 Use 1.0.0-1.16 baseline for API compatibility checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163083277 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-31696) ElasticSearch nightly CI failure

2023-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31696: --- Labels: pull-request-available (was: ) > ElasticSearch nightly CI failure >

[GitHub] [flink-connector-elasticsearch] reta opened a new pull request, #59: [FLINK-31696] ElasticSearch nightly CI failure

2023-04-11 Thread via GitHub
reta opened a new pull request, #59: URL: https://github.com/apache/flink-connector-elasticsearch/pull/59 ElasticSearch nightly CI failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
reta commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1163061352 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -flink:

[jira] [Commented] (FLINK-18027) ROW value constructor cannot deal with complex expressions

2023-04-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711040#comment-17711040 ] Aitozi commented on FLINK-18027: [~libenchao] do you know why the explicit ROW construct is removed from

[jira] [Updated] (FLINK-17508) Develop Oracle Catalog

2023-04-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-17508: --- Summary: Develop Oracle Catalog (was: Develop OracleCatalog) > Develop Oracle Catalog >

[jira] [Closed] (FLINK-29672) Support oracle catalog

2023-04-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-29672. -- Resolution: Duplicate > Support oracle catalog > --- > >

[GitHub] [flink-shaded] MartijnVisser commented on a diff in pull request #120: [FLINK-31719][Build/Shaded] Update Netty to 4.1.91.Final

2023-04-11 Thread via GitHub
MartijnVisser commented on code in PR #120: URL: https://github.com/apache/flink-shaded/pull/120#discussion_r1163023881 ## pom.xml: ## @@ -355,6 +355,20 @@ under the License. + + +org.cyclonedx +

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
tzulitai commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1163021963 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-31774) Add document for delete and update statement

2023-04-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711033#comment-17711033 ] Aitozi commented on FLINK-31774: I think we should add the description for this two statements similar

[jira] [Updated] (FLINK-31774) Add document for delete and update statement

2023-04-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-31774: --- Parent: FLINK-30648 Issue Type: Sub-task (was: Improvement) > Add document for delete and update

[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
MartijnVisser commented on PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#issuecomment-1503642528 > may I ask you please to trigger nightly action manually https://github.com/apache/flink-connector-opensearch/actions/runs/4669419298 is started! -- This

[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
MartijnVisser commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1163012687 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -

[jira] [Created] (FLINK-31774) Add document for delete and update statement

2023-04-11 Thread Aitozi (Jira)
Aitozi created FLINK-31774: -- Summary: Add document for delete and update statement Key: FLINK-31774 URL: https://issues.apache.org/jira/browse/FLINK-31774 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-31760) COALESCE() with NULL arguments throws error

2023-04-11 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711022#comment-17711022 ] Mohsen Rezaei commented on FLINK-31760: --- [~lincoln.86xy], if I understand correctly, the error

[GitHub] [flink-connector-opensearch] reta commented on pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
reta commented on PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#issuecomment-1503618001 > LGTM Thanks a lot, may I ask you please to trigger nightly action manually when you have an opportunity, thank you (once it is green, I will replicate changes to

[GitHub] [flink-connector-opensearch] MartijnVisser merged pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
MartijnVisser merged PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
MartijnVisser commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162981670 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -

[jira] [Commented] (FLINK-31760) COALESCE() with NULL arguments throws error

2023-04-11 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711014#comment-17711014 ] Mohsen Rezaei commented on FLINK-31760: --- Hi [~lemonjing], thanks for the quick response. I'm

[jira] (FLINK-31760) COALESCE() with NULL arguments throws error

2023-04-11 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31760 ] Mohsen Rezaei deleted comment on FLINK-31760: --- was (Author: JIRAUSER298550): Hi [~lemonjing], thanks for the quick response. I'm interested in providing a fix, but I need to dig a bit and

[jira] [Commented] (FLINK-31533) CREATE TABLE AS SELECT should support to define partition

2023-04-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711002#comment-17711002 ] Aitozi commented on FLINK-31533: [~luoyuxia] I think it's a useful feature, and I'd like to support

[GitHub] [flink] godfreyhe commented on a diff in pull request #22376: [FLINK-31767][table-planner] Improve the implementation for "analyze table" execution on partitioned table

2023-04-11 Thread via GitHub
godfreyhe commented on code in PR #22376: URL: https://github.com/apache/flink/pull/22376#discussion_r1162913583 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/AnalyzeTableUtil.java: ## @@ -137,13 +138,46 @@ private static

[GitHub] [flink-connector-kafka] AlexAxeman commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
AlexAxeman commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1162890942 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-kafka] AlexAxeman commented on a diff in pull request #18: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-04-11 Thread via GitHub
AlexAxeman commented on code in PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#discussion_r1162889963 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/HeaderProducer.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-pulsar] nikolasten commented on pull request #16: [BK-3.0][FLINK-30552][Connector/Pulsar] drop batch message size assertion, better set the cursor position.

2023-04-11 Thread via GitHub
nikolasten commented on PR #16: URL: https://github.com/apache/flink-connector-pulsar/pull/16#issuecomment-1503435012 Disregard my latest comment. When used with flink 1.17 works fine. If anybody else has a problem and waiting for release, we used snapshot version with flink

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-11 Thread via GitHub
zhipeng93 commented on code in PR #230: URL: https://github.com/apache/flink-ml/pull/230#discussion_r1162850039 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/sort/CoGroupOperator.java: ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] Aitozi commented on pull request #20246: [FLINK-28074][table-planner] show statistics details for DESCRIBE EXTENDED

2023-04-11 Thread via GitHub
Aitozi commented on PR #20246: URL: https://github.com/apache/flink/pull/20246#issuecomment-1503403992 I think it's a very useful auxiliary command, can we move this PR forward @swuferhong @godfreyhe ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] Aitozi commented on a diff in pull request #22376: [FLINK-31767][table-planner] Improve the implementation for "analyze table" execution on partitioned table

2023-04-11 Thread via GitHub
Aitozi commented on code in PR #22376: URL: https://github.com/apache/flink/pull/22376#discussion_r1162852786 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/AnalyzeTableUtil.java: ## @@ -137,13 +138,46 @@ private static

[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data

2023-04-11 Thread via GitHub
reswqa commented on PR #17: URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503369425 In fact, I prefer this approach, which is what I propose

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
reta commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162830988 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -flink:

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
reta commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162829801 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -flink:

[GitHub] [flink] dmvk commented on a diff in pull request #22364: [FLINK-31744] Include JobVertex info in sparse EG

2023-04-11 Thread via GitHub
dmvk commented on code in PR #22364: URL: https://github.com/apache/flink/pull/22364#discussion_r1162826386 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -195,6 +195,34 @@ void

[jira] [Commented] (FLINK-31655) Adaptive Channel selection for partitioner

2023-04-11 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710956#comment-17710956 ] Anton Kalashnikov commented on FLINK-31655: --- Hi [~tartarus] thanks for this discussion. I

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
reta commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162826956 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -flink:

[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data

2023-04-11 Thread via GitHub
MartijnVisser commented on PR #17: URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503352188 > So my main question is, if we modify a major bug in the document, do we have to wait for the next connector release so that users can see the correct version doc.

[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
MartijnVisser commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162816269 ## .github/workflows/release.yml: ## @@ -24,7 +24,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -

[GitHub] [flink-connector-opensearch] reswqa commented on pull request #17: [hotfix] Add opensearch.yml to enable flink to find the data

2023-04-11 Thread via GitHub
reswqa commented on PR #17: URL: https://github.com/apache/flink-connector-opensearch/pull/17#issuecomment-1503347392 I know --branch can point to both branch names and tags. If I understand correctly, we only push tags like v3.0.0 forward during each release. So my main question is, if

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-11 Thread via GitHub
reta commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162810174 ## .github/workflows/weekly.yml: ## @@ -26,7 +26,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -flink:

[jira] [Resolved] (FLINK-22727) SerializableAvroSchema cannot handle large schema

2023-04-11 Thread Serge Travin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Serge Travin resolved FLINK-22727. -- Resolution: Duplicate > SerializableAvroSchema cannot handle large schema >

  1   2   >