[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722998#comment-17722998 ] Matthias Pohl edited comment on FLINK-32069 at 5/16/23 5:57 AM: Ok, I

[jira] [Comment Edited] (FLINK-32104) stop-with-savepoint fails and times out with simple reproducible example

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722993#comment-17722993 ] Weijie Guo edited comment on FLINK-32104 at 5/16/23 5:55 AM: - Hi Kurt, I

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722998#comment-17722998 ] Matthias Pohl commented on FLINK-32069: --- Ok, I was too lazy to switch to the 1.15 branch because I

[jira] [Comment Edited] (FLINK-32104) stop-with-savepoint fails and times out with simple reproducible example

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722993#comment-17722993 ] Weijie Guo edited comment on FLINK-32104 at 5/16/23 5:49 AM: - Hi Kurt, I

[jira] [Commented] (FLINK-32104) stop-with-savepoint fails and times out with simple reproducible example

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722993#comment-17722993 ] Weijie Guo commented on FLINK-32104: Hi Kurt, I have tested the uploaded job without any code

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #237: [Flink-27826] Support training very high dimensional logistic regression

2023-05-15 Thread via GitHub
lindong28 commented on code in PR #237: URL: https://github.com/apache/flink-ml/pull/237#discussion_r1194570809 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/updater/ModelUpdater.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722985#comment-17722985 ] Matthias Pohl edited comment on FLINK-32069 at 5/16/23 5:43 AM: For the

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722985#comment-17722985 ] Matthias Pohl edited comment on FLINK-32069 at 5/16/23 5:03 AM: Can you

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722985#comment-17722985 ] Matthias Pohl commented on FLINK-32069: --- Can you provide debug logs of the case? >

[GitHub] [flink] flinkbot commented on pull request #22588: [FLINK-31663][table] Add ARRAY_EXCEPT function

2023-05-15 Thread via GitHub
flinkbot commented on PR #22588: URL: https://github.com/apache/flink/pull/22588#issuecomment-1548979423 ## CI report: * 965fc11fe20d8b962b2a4c2ca67342051b130201 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-pulsar] reswqa merged pull request #50: [BP-4.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread via GitHub
reswqa merged PR #50: URL: https://github.com/apache/flink-connector-pulsar/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] bvarghese1 opened a new pull request, #22588: [FLINK-31663][table] Add ARRAY_EXCEPT function

2023-05-15 Thread via GitHub
bvarghese1 opened a new pull request, #22588: URL: https://github.com/apache/flink/pull/22588 ## What is the purpose of the change This is an implementation of ARRAY_EXCEPT ## Brief change log ARRAY_EXCEPT for Table API and SQL ``` Flink SQL> SELECT

[jira] [Updated] (FLINK-32104) stop-with-savepoint fails and times out with simple reproducible example

2023-05-15 Thread Kurt Ostfeld (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Ostfeld updated FLINK-32104: - Description: I've put together a simple demo app that reproduces the issue with instructions

[jira] [Created] (FLINK-32104) stop-with-savepoint fails and times out with simple reproducible example

2023-05-15 Thread Kurt Ostfeld (Jira)
Kurt Ostfeld created FLINK-32104: Summary: stop-with-savepoint fails and times out with simple reproducible example Key: FLINK-32104 URL: https://issues.apache.org/jira/browse/FLINK-32104 Project:

[GitHub] [flink] flinkbot commented on pull request #22587: [FLINK-31892][runtime] Introduce AdaptiveScheduler global failure enrichment/labeling

2023-05-15 Thread via GitHub
flinkbot commented on PR #22587: URL: https://github.com/apache/flink/pull/22587#issuecomment-1548949084 ## CI report: * 99f41cfb94b20162cce28f7e9ec5662afe385689 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Myracle commented on a diff in pull request #22560: [FLINK-32023][API / DataStream] Support negative Duration for special usage, such as -1ms for execution.buffer-timeout

2023-05-15 Thread via GitHub
Myracle commented on code in PR #22560: URL: https://github.com/apache/flink/pull/22560#discussion_r1194578196 ## flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java: ## @@ -92,6 +92,17 @@ public class ExecutionOptions {

[GitHub] [flink-connector-pulsar] reswqa commented on pull request #50: [BP-4.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread via GitHub
reswqa commented on PR #50: URL: https://github.com/apache/flink-connector-pulsar/pull/50#issuecomment-1548938191 Reviewed in #49. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-connector-pulsar] reswqa opened a new pull request, #50: [BP-4.0][FLINK-32024][docs] Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread via GitHub
reswqa opened a new pull request, #50: URL: https://github.com/apache/flink-connector-pulsar/pull/50 Backport to `v4.0` as flink track this branch to render documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #22586: [FLINK-31880][tests] Fixes unit test so it will pass regardless of ti…

2023-05-15 Thread via GitHub
flinkbot commented on PR #22586: URL: https://github.com/apache/flink/pull/22586#issuecomment-1548929471 ## CI report: * 6e8d876beb9ff0f2c5eddf4833ec572068629616 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] yangjf2019 opened a new pull request, #601: [hotfix][docs] fix some typos

2023-05-15 Thread via GitHub
yangjf2019 opened a new pull request, #601: URL: https://github.com/apache/flink-kubernetes-operator/pull/601 ## What is the purpose of the change * I have updated some typos in the `docs/content/docs/custom-resource/autoscaler.md` file. ## Verifying this change

[jira] [Commented] (FLINK-31880) Bad Test in OrcColumnarRowSplitReaderTest

2023-05-15 Thread Kurt Ostfeld (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722973#comment-17722973 ] Kurt Ostfeld commented on FLINK-31880: -- Updated PR https://github.com/apache/flink/pull/22586 >

[GitHub] [flink] kurtostfeld opened a new pull request, #22586: [FLINK-31880][tests] Fixes unit test so it will pass regardless of ti…

2023-05-15 Thread via GitHub
kurtostfeld opened a new pull request, #22586: URL: https://github.com/apache/flink/pull/22586 Fixes unit test so it will pass regardless of time zone it is run in. Also use a better testing date. I submitted this before, I'm resubmitting with issues fixed. This should follow commit

[jira] [Updated] (FLINK-31893) Placeholder

2023-05-15 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31893: --- Summary: Placeholder (was: Introduce AdaptiveScheduler global failure

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22560: [FLINK-32023][API / DataStream] Support negative Duration for special usage, such as -1ms for execution.buffer-timeout

2023-05-15 Thread via GitHub
1996fanrui commented on code in PR #22560: URL: https://github.com/apache/flink/pull/22560#discussion_r1194556471 ## flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java: ## @@ -92,6 +92,17 @@ public class ExecutionOptions {

[jira] [Updated] (FLINK-31892) Introduce AdaptiveScheduler global failure enrichment/labeling

2023-05-15 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31892: --- Summary: Introduce AdaptiveScheduler global failure enrichment/labeling

[GitHub] [flink] kurtostfeld closed pull request #22451: FLINK-31880: Fixed broken date test. It was failing when run in CST time zone.

2023-05-15 Thread via GitHub
kurtostfeld closed pull request #22451: FLINK-31880: Fixed broken date test. It was failing when run in CST time zone. URL: https://github.com/apache/flink/pull/22451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] JunRuiLee commented on a diff in pull request #16593: [FLINK-23425][streaming-java] The impact of cpu cores on test results…

2023-05-15 Thread via GitHub
JunRuiLee commented on code in PR #16593: URL: https://github.com/apache/flink/pull/16593#discussion_r1194546629 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1291,7 +1291,7 @@ public void

[GitHub] [flink] reswqa commented on pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on PR #22574: URL: https://github.com/apache/flink/pull/22574#issuecomment-1548891764 Rebased on `origin/master`, will be merged after AZP green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (FLINK-32101) FlinkKafkaInternalProducerITCase.testInitTransactionId test failed

2023-05-15 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722966#comment-17722966 ] Yuxin Tan commented on FLINK-32101: --- [~mapohl] Yes, exactly. Thanks for tracking it. >

[jira] [Updated] (FLINK-32101) FlinkKafkaInternalProducerITCase.testInitTransactionId test failed

2023-05-15 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-32101: -- Labels: test-stability (was: test) > FlinkKafkaInternalProducerITCase.testInitTransactionId test

[GitHub] [flink] godfreyhe commented on a diff in pull request #22566: [FLINK-32052][table-runtime] Introduce left and right state retention time to StreamingJoinOperator

2023-05-15 Thread via GitHub
godfreyhe commented on code in PR #22566: URL: https://github.com/apache/flink/pull/22566#discussion_r1194510238 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperatorTestBase.java: ## @@ -0,0 +1,124 @@ +/* +

[GitHub] [flink] pgaref commented on pull request #22506: [FLINK-31890][runtime] Introduce DefaultScheduler failure enrichment/labeling

2023-05-15 Thread via GitHub
pgaref commented on PR #22506: URL: https://github.com/apache/flink/pull/22506#issuecomment-1548830252 Thanks for the comments once again @zhuzhurk ! PTAL on latest PR: * introducing async task failure labeling as part of ExecutionFailureHandler#handleFailure (for local and global

[jira] [Comment Edited] (FLINK-32103) RBAC flinkdeployments/finalizers missing for OpenShift Deployment

2023-05-15 Thread James Busche (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722952#comment-17722952 ] James Busche edited comment on FLINK-32103 at 5/16/23 1:07 AM: --- Can fix

[jira] [Commented] (FLINK-32103) RBAC flinkdeployments/finalizers missing for OpenShift Deployment

2023-05-15 Thread James Busche (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722952#comment-17722952 ] James Busche commented on FLINK-32103: -- Can fix this on an existing OpenShift install by adding "-

[jira] [Commented] (FLINK-32103) RBAC flinkdeployments/finalizers missing for OpenShift Deployment

2023-05-15 Thread James Busche (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722951#comment-17722951 ] James Busche commented on FLINK-32103: -- Created PR

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-15 Thread via GitHub
jbusche commented on PR #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600#issuecomment-1548743480 OpenShift 4.10.54 is looking good with the PR: ``` oc get pods,flinkdeployments -n default

[GitHub] [flink-connector-kafka] RamanVerma commented on a diff in pull request #29: [FLINK-32021][Connectors/Kafka] Improvement the Javadoc for SpecifiedOffsetsInitializer and TimestampOffsetsInitial

2023-05-15 Thread via GitHub
RamanVerma commented on code in PR #29: URL: https://github.com/apache/flink-connector-kafka/pull/29#discussion_r119366 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/initializer/SpecifiedOffsetsInitializer.java: ## @@ -38,6

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-15 Thread via GitHub
jbusche commented on PR #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600#issuecomment-1548682654 OK - the KIND cluster looks good - still deploying the samples fine. ``` NAME READY STATUS RESTARTS AGE

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-15 Thread via GitHub
jbusche commented on PR #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600#issuecomment-1548632061 Trying a new deployment on both a KIND cluster (non OpenShift) as well as two OpenShift clusters to verify the change. Will post results here. -- This is an automated

[GitHub] [flink-kubernetes-operator] jbusche opened a new pull request, #600: FLINK-32103 Update RBAC for OpenShift Deployment

2023-05-15 Thread via GitHub
jbusche opened a new pull request, #600: URL: https://github.com/apache/flink-kubernetes-operator/pull/600 ## What is the purpose of the change Noticing in the 1.5.0-rc1 and 1.5.0-rc2 that we're having a problem deploying on OpenShift. The solution is to either manually

[jira] [Updated] (FLINK-31890) Introduce DefaultScheduler failure enrichment/labeling

2023-05-15 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31890: --- Summary: Introduce DefaultScheduler failure enrichment/labeling (was:

[jira] [Created] (FLINK-32103) RBAC flinkdeployments/finalizers missing for OpenShift Deployment

2023-05-15 Thread James Busche (Jira)
James Busche created FLINK-32103: Summary: RBAC flinkdeployments/finalizers missing for OpenShift Deployment Key: FLINK-32103 URL: https://issues.apache.org/jira/browse/FLINK-32103 Project: Flink

[GitHub] [flink] reswqa commented on pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on PR #22574: URL: https://github.com/apache/flink/pull/22574#issuecomment-1548347105 Thanks @snuyanzin very much for your patient review  . Without you, I didn't even realize that the number of tests wouldn't be right (my mistake)  -- This is an automated message

[GitHub] [flink] snuyanzin commented on pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on PR #22574: URL: https://github.com/apache/flink/pull/22574#issuecomment-1548342955 I checked that now number of tests before the change is equal to number of tests after per changed class no more findings from my side lgtm -- This is an automated message from

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194200879 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194197548 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194197548 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194178109 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194170872 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194169663 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194168520 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194168520 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194167000 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194163579 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194160609 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] reswqa commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
reswqa commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194117257 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java: ## @@ -69,22 +72,18 @@ import static

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Aleksandr Iushmanov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722858#comment-17722858 ] Aleksandr Iushmanov edited comment on FLINK-32069 at 5/15/23 4:47 PM:

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Aleksandr Iushmanov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722858#comment-17722858 ] Aleksandr Iushmanov commented on FLINK-32069: - Thanks a lot [~mapohl] for this detailed

[jira] [Commented] (FLINK-31946) DynamoDB Sink Allow Multiple Item Writes

2023-05-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722855#comment-17722855 ] Hong Liang Teoh commented on FLINK-31946: - Hi [~cjensen] ! Thanks for creating this issue. 

[jira] [Comment Edited] (FLINK-31810) RocksDBException: Bad table magic number on checkpoint rescale

2023-05-15 Thread David Artiga (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722771#comment-17722771 ] David Artiga edited comment on FLINK-31810 at 5/15/23 4:22 PM: --- Not sure

[GitHub] [flink-kubernetes-operator] mxm opened a new pull request, #598: [FLINK-32102] Aggregate multiple pendingRecords metric per source if present

2023-05-15 Thread via GitHub
mxm opened a new pull request, #598: URL: https://github.com/apache/flink-kubernetes-operator/pull/598 Some source expose multiple `.pendingRecords` metrics. If that is the case, we must sum up these records to yield the correct internal pending records count. -- This is an automated

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722820#comment-17722820 ] Matthias Pohl edited comment on FLINK-32069 at 5/15/23 3:25 PM: Thanks

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722820#comment-17722820 ] Matthias Pohl edited comment on FLINK-32069 at 5/15/23 3:24 PM: Thanks

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722820#comment-17722820 ] Matthias Pohl edited comment on FLINK-32069 at 5/15/23 3:23 PM: Thanks

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722820#comment-17722820 ] Matthias Pohl commented on FLINK-32069: --- Thanks for sharing your train of thought here, [~izeren].

[jira] [Created] (FLINK-32102) Aggregate multiple pendingRecords metric per source if present

2023-05-15 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-32102: -- Summary: Aggregate multiple pendingRecords metric per source if present Key: FLINK-32102 URL: https://issues.apache.org/jira/browse/FLINK-32102 Project:

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722820#comment-17722820 ] Matthias Pohl edited comment on FLINK-32069 at 5/15/23 3:15 PM:

[jira] [Closed] (FLINK-31609) Fatal error in ResourceManager caused YARNSessionFIFOSecuredITCase.testDetachedMode to fail

2023-05-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-31609. - > Fatal error in ResourceManager caused > YARNSessionFIFOSecuredITCase.testDetachedMode to fail >

[jira] [Resolved] (FLINK-31609) Fatal error in ResourceManager caused YARNSessionFIFOSecuredITCase.testDetachedMode to fail

2023-05-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-31609. --- Fix Version/s: 1.18.0 Resolution: Fixed 4415c5150eda071b219db5532c359ca29730a378 on

[GitHub] [flink] gaborgsomogyi merged pull request #22550: [FLINK-31609][yarn][test] Extend log whitelist for expected AMRM heartbeat interrupt

2023-05-15 Thread via GitHub
gaborgsomogyi merged PR #22550: URL: https://github.com/apache/flink/pull/22550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] tweise commented on a diff in pull request #22556: [FLINK-32030][sql-client] Add URLs support for SQL Client gateway mode

2023-05-15 Thread via GitHub
tweise commented on code in PR #22556: URL: https://github.com/apache/flink/pull/22556#discussion_r1193954446 ## flink-core/src/main/java/org/apache/flink/util/NetUtils.java: ## @@ -120,6 +120,18 @@ private static URL validateHostPortString(String hostPort) { } }

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722691#comment-17722691 ] Matthias Pohl edited comment on FLINK-32069 at 5/15/23 2:42 PM: Thanks

[jira] [Assigned] (FLINK-24696) Translate how to configure unaligned checkpoints into Chinese

2023-05-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-24696: -- Assignee: lijie > Translate how to configure unaligned checkpoints into Chinese >

[jira] [Commented] (FLINK-24696) Translate how to configure unaligned checkpoints into Chinese

2023-05-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722802#comment-17722802 ] Piotr Nowojski commented on FLINK-24696: Sure! Thanks :) > Translate how to configure unaligned

[GitHub] [flink] pnowojski commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
pnowojski commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193934653 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperationTest.java: ## @@ -785,6 +789,130 @@ public void

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
StefanRRichter commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193925009 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -136,19 +136,24 @@ public void assignStates() {

[jira] [Comment Edited] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-15 Thread Gil Shmaya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722785#comment-17722785 ] Gil Shmaya edited comment on FLINK-32047 at 5/15/23 2:26 PM: - We run with

[jira] [Comment Edited] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-15 Thread Gil Shmaya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722785#comment-17722785 ] Gil Shmaya edited comment on FLINK-32047 at 5/15/23 2:25 PM: - We run with

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
rkhachatryan commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193902234 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -136,19 +136,24 @@ public void assignStates() {

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
rkhachatryan commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193908276 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperationTest.java: ## @@ -1029,6 +1192,15 @@ private JobVertex createJobVertex(

[jira] [Comment Edited] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722691#comment-17722691 ] Matthias Pohl edited comment on FLINK-32069 at 5/15/23 2:05 PM: Thanks

[jira] [Commented] (FLINK-32101) FlinkKafkaInternalProducerITCase.testInitTransactionId test failed

2023-05-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722790#comment-17722790 ] Matthias Pohl commented on FLINK-32101: --- [~tanyuxin] this looks like a Kafka-internal instability,

[jira] [Commented] (FLINK-32069) jobClient.getJobStatus() can return status RUNNING for finished insert operation

2023-05-15 Thread Aleksandr Iushmanov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722788#comment-17722788 ] Aleksandr Iushmanov commented on FLINK-32069: - I can provide more details on the code path

[jira] [Commented] (FLINK-32047) Fix args in JobSpec not being passed through to Flink in Standalone mode - 1.4.0

2023-05-15 Thread Gil Shmaya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722785#comment-17722785 ] Gil Shmaya commented on FLINK-32047: We run with 1.14.6, sorry for the confusion. > Fix args in

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

2023-05-15 Thread via GitHub
XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1193867705 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderBase.java: ## @@ -80,6 +84,20 @@ public Throwable getError() { return error

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

2023-05-15 Thread via GitHub
XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1193866384 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -270,65 +390,73 @@ public void

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

2023-05-15 Thread via GitHub
XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1193863651 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -32,49 +31,73 @@ import javax.annotation.Nullable;

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
StefanRRichter commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193856106 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperationTest.java: ## @@ -785,6 +789,130 @@ public void

[jira] [Commented] (FLINK-32094) startScheduling.BATCH performance regression since May 11th

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722782#comment-17722782 ] Weijie Guo commented on FLINK-32094: master(1.18) via 1a3b539fa43b4e1c8f07accf2d4aa352b7f63858. >

[jira] [Updated] (FLINK-32094) startScheduling.BATCH performance regression since May 11th

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32094: --- Affects Version/s: 1.18.0 > startScheduling.BATCH performance regression since May 11th >

[jira] [Resolved] (FLINK-32094) startScheduling.BATCH performance regression since May 11th

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-32094. Fix Version/s: 1.18.0 Resolution: Fixed > startScheduling.BATCH performance regression

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22584: [FLINK-31963][state] Fix rescaling bug in recovery from unaligned checkpoints.

2023-05-15 Thread via GitHub
StefanRRichter commented on code in PR #22584: URL: https://github.com/apache/flink/pull/22584#discussion_r1193845132 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperationTest.java: ## @@ -785,6 +789,130 @@ public void

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager

2023-05-15 Thread via GitHub
TanYuxin-tyx commented on code in PR #22352: URL: https://github.com/apache/flink/pull/22352#discussion_r1193828115 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java: ## @@ -0,0 +1,224 @@ +/* +

[jira] [Comment Edited] (FLINK-32024) Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722774#comment-17722774 ] Weijie Guo edited comment on FLINK-32024 at 5/15/23 1:28 PM: - master(1.18)

[jira] [Updated] (FLINK-32024) Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32024: --- Affects Version/s: 1.16.1 > Short code related to externalized connector retrieve version from its

[jira] [Updated] (FLINK-32024) Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32024: --- Fix Version/s: 1.16.2 > Short code related to externalized connector retrieve version from its own

[jira] [Updated] (FLINK-32024) Short code related to externalized connector retrieve version from its own data yaml

2023-05-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32024: --- Affects Version/s: 1.17.0 > Short code related to externalized connector retrieve version from its

  1   2   3   >