[GitHub] [flink] haishui126 commented on pull request #22925: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-05 Thread via GitHub
haishui126 commented on PR #22925: URL: https://github.com/apache/flink/pull/22925#issuecomment-1623037626 Thank you for fixing this. I have packaged and tested in my local environment, It works well. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] TanYuxin-tyx commented on pull request #22958: [FLINK-32541][network] Fix the buffer leaking when buffer accumulator is released

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on PR #22958: URL: https://github.com/apache/flink/pull/22958#issuecomment-1623018365 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on code in PR #22851: URL: https://github.com/apache/flink/pull/22851#discussion_r1253951614 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/SubpartitionRemoteCacheManager.java: ## @@ -0,0 +1,187 @@

[GitHub] [flink] TanYuxin-tyx commented on pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on PR #22851: URL: https://github.com/apache/flink/pull/22851#issuecomment-1623011886 @reswqa Thanks for helping review, I have addressed the comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on code in PR #22851: URL: https://github.com/apache/flink/pull/22851#discussion_r1253947705 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/file/SegmentPartitionFileWriter.java: ## @@ -0,0 +1,231 @@ +/* + *

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on code in PR #22851: URL: https://github.com/apache/flink/pull/22851#discussion_r1253947408 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/SubpartitionRemoteCacheManager.java: ## @@ -0,0 +1,187 @@

[jira] [Created] (FLINK-32547) Add missing doc for Timestamp support in ProtoBuf format

2023-07-05 Thread Benchao Li (Jira)
Benchao Li created FLINK-32547: -- Summary: Add missing doc for Timestamp support in ProtoBuf format Key: FLINK-32547 URL: https://issues.apache.org/jira/browse/FLINK-32547 Project: Flink Issue

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on code in PR #22851: URL: https://github.com/apache/flink/pull/22851#discussion_r1253922911 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/SubpartitionRemoteCacheManager.java: ## @@ -0,0 +1,187 @@

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on code in PR #22851: URL: https://github.com/apache/flink/pull/22851#discussion_r1253922689 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/file/SegmentPartitionFile.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed

[GitHub] [flink] lincoln-lil commented on a diff in pull request #22894: [FLINK-30598][table-planner] Fix wrong code generated for WatermarkGenerator due to inconsistent source type info when deserial

2023-07-05 Thread via GitHub
lincoln-lil commented on code in PR #22894: URL: https://github.com/apache/flink/pull/22894#discussion_r1253912150 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java: ## @@ -483,8 +483,11 @@ private static void

[jira] [Resolved] (FLINK-32464) AssertionError when converting between Table and SQL with selection and type cast

2023-07-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32464. -- Resolution: Duplicate Should similar to FLINK-31830. Feel free to open it if not. > AssertionError

[GitHub] [flink] reswqa commented on a diff in pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
reswqa commented on code in PR #22851: URL: https://github.com/apache/flink/pull/22851#discussion_r1253009389 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/common/TieredStorageConfiguration.java: ## @@ -30,18 +32,38 @@ public class

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #22937: [FLINK-32428] Introduce base interfaces for CatalogStore

2023-07-05 Thread via GitHub
ruanhang1993 commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1253856457 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogStoreFactoryTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed

[GitHub] [flink] hanyuzheng7 commented on pull request #22922: [FLINK-32256][table] Add built-in ARRAY_ MIN function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22922: URL: https://github.com/apache/flink/pull/22922#issuecomment-1622901153 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] swuferhong commented on a diff in pull request #22894: [FLINK-30598][table-planner] Fix wrong code generated for WatermarkGenerator due to inconsistent source type info when deseriali

2023-07-05 Thread via GitHub
swuferhong commented on code in PR #22894: URL: https://github.com/apache/flink/pull/22894#discussion_r1253845465 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java: ## @@ -483,8 +483,11 @@ private static void

[jira] [Commented] (FLINK-30238) Unified Sink committer does not clean up state on final savepoint

2023-07-05 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740371#comment-17740371 ] Yun Gao commented on FLINK-30238: - Hi [~jingge]  may I have a double confirmation on the detailed issue

[GitHub] [flink] dianfu commented on pull request #22957: [FLINK-32544][python] Fix test_java_sql_ddl to works in JDK17

2023-07-05 Thread via GitHub
dianfu commented on PR #22957: URL: https://github.com/apache/flink/pull/22957#issuecomment-1622826150 @zentol Great . Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] swuferhong commented on a diff in pull request #22918: [FLINK-32501][table-planner] Fix wrong plan of a proctime window aggregation generated due to incorrect cost evaluation

2023-07-05 Thread via GitHub
swuferhong commented on code in PR #22918: URL: https://github.com/apache/flink/pull/22918#discussion_r1253827159 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdSelectivity.scala: ## @@ -256,6 +257,13 @@ class

[GitHub] [flink] swuferhong commented on a diff in pull request #22918: [FLINK-32501][table-planner] Fix wrong plan of a proctime window aggregation generated due to incorrect cost evaluation

2023-07-05 Thread via GitHub
swuferhong commented on code in PR #22918: URL: https://github.com/apache/flink/pull/22918#discussion_r1253827159 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdSelectivity.scala: ## @@ -256,6 +257,13 @@ class

[jira] [Commented] (FLINK-32502) Remove AbstractLeaderElectionService

2023-07-05 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740367#comment-17740367 ] Wencong Liu commented on FLINK-32502: - Hello [~mapohl]  Are you suggesting merging the methods of

[GitHub] [flink] hackergin commented on pull request #22937: [FLINK-32428] Introduce base interfaces for CatalogStore

2023-07-05 Thread via GitHub
hackergin commented on PR #22937: URL: https://github.com/apache/flink/pull/22937#issuecomment-1622791724 @ruanhang1993 Thank you very much for your thoughtful and detailed comments. I update the code, I will pay more attention to annotations and documentation. -- This is an automated

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1622756809 @snuyanzin do you know why Test - table report error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1622492472 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1622483121 @snuyanzin solve all comments now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253617456 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -74,4 +74,32 @@ public

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253620252 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253620252 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253620252 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253617904 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253617456 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -74,4 +74,32 @@ public

[GitHub] [flink] tweise commented on a diff in pull request #22810: [FLINK-32035][sql-client] Support HTTPS endpoints in SQL Client gateway mode

2023-07-05 Thread via GitHub
tweise commented on code in PR #22810: URL: https://github.com/apache/flink/pull/22810#discussion_r1253612690 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestClientTest.java: ## @@ -84,6 +89,26 @@ public void testConnectionTimeout() throws Exception {

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253603314 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253603314 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [flink] elkhand commented on a diff in pull request #22816: [FLINK-32373][sql-client] Support passing headers with SQL Client gateway requests

2023-07-05 Thread via GitHub
elkhand commented on code in PR #22816: URL: https://github.com/apache/flink/pull/22816#discussion_r1253525351 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ExecutorImpl.java: ## @@ -577,4 +593,29 @@ private void closeSession() throws

[GitHub] [flink] snuyanzin commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-07-05 Thread via GitHub
snuyanzin commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1253446621 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromEntriesFunction.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] [flink] snuyanzin commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-07-05 Thread via GitHub
snuyanzin commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1253446621 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromEntriesFunction.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to

[jira] [Created] (FLINK-32546) update Code Style Guide with Java properties naming convention

2023-07-05 Thread Jing Ge (Jira)
Jing Ge created FLINK-32546: --- Summary: update Code Style Guide with Java properties naming convention Key: FLINK-32546 URL: https://issues.apache.org/jira/browse/FLINK-32546 Project: Flink Issue

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1622117991 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] hanyuzheng7 commented on pull request #22922: [FLINK-32256][table] Add built-in ARRAY_ MIN function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22922: URL: https://github.com/apache/flink/pull/22922#issuecomment-1622101928 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] XComp commented on a diff in pull request #22893: [FLINK-31814][runtime] Enables Precondition that checks that the issuedLeaderSessionID is set on revoke processing

2023-07-05 Thread via GitHub
XComp commented on code in PR #22893: URL: https://github.com/apache/flink/pull/22893#discussion_r1253347147 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -247,38 +247,33 @@ void

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1622069560 @snuyanzin , do you think the code is ok now? If ok, I can remove CommonMapInputTypeStrategy and CommonArrayInputTypeStrategy these two Class. -- This is an automated message from

[jira] [Closed] (FLINK-31476) AdaptiveScheduler should take lower bound parallelism settings into account

2023-07-05 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31476. Fix Version/s: 1.18.0 Resolution: Fixed master:

[GitHub] [flink] zentol merged pull request #22883: [FLINK-31476] AdaptiveScheduler respects minimum parallelism

2023-07-05 Thread via GitHub
zentol merged PR #22883: URL: https://github.com/apache/flink/pull/22883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-32421) EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-07-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32421. --- Fix Version/s: 1.18.0 1.16.3 1.17.2 Assignee:

[GitHub] [flink] XComp merged pull request #22872: [BP-1.16][FLINK-32421][test] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-07-05 Thread via GitHub
XComp merged PR #22872: URL: https://github.com/apache/flink/pull/22872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on pull request #22872: [BP-1.16][FLINK-32421][test] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-07-05 Thread via GitHub
XComp commented on PR #22872: URL: https://github.com/apache/flink/pull/22872#issuecomment-1622039161 test failure happened in connect module which doesn't include this change. Merging anyway -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] XComp merged pull request #22871: [BP-1.17][FLINK-32421][test] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-07-05 Thread via GitHub
XComp merged PR #22871: URL: https://github.com/apache/flink/pull/22871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp merged pull request #22865: [FLINK-32421][test] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-07-05 Thread via GitHub
XComp merged PR #22865: URL: https://github.com/apache/flink/pull/22865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1253311533 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -1050,4 +1051,209 @@ public static

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1622035418 @snuyanzin it support third args optional now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (FLINK-32537) Add compatibility annotation for REST API classes

2023-07-05 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740266#comment-17740266 ] Hong Liang Teoh edited comment on FLINK-32537 at 7/5/23 3:42 PM: - > We

[jira] [Commented] (FLINK-32537) Add compatibility annotation for REST API classes

2023-07-05 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740266#comment-17740266 ] Hong Liang Teoh commented on FLINK-32537: - > We already know that though due to the

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1621998471 true, probably missed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] liuyongvs commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-07-05 Thread via GitHub
liuyongvs commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1621991941 This function have i supported in calcite -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] liuyongvs commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-07-05 Thread via GitHub
liuyongvs commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1621990748 Hi @snuyanzin will you help look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1621967689 @snuyanzin can you help me polish the description? `Returns a subarray of the input array between 'start_offset' and 'end_offset' inclusive. The 'end_offset' is an optional one.

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1621965984 >so third arg optional is a specific situation offset-end set right bound of array. > and start-offset behavior not change? correct in this situation ```

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1621958121 > if the third is optional the result should be same as the third arg is equal to length of the array (same as in case of `substring`) the result should be > > ``` >

[GitHub] [flink] afedulov commented on a diff in pull request #22816: [FLINK-32373][sql-client] Support passing headers with SQL Client gateway requests

2023-07-05 Thread via GitHub
afedulov commented on code in PR #22816: URL: https://github.com/apache/flink/pull/22816#discussion_r1253253546 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java: ## @@ -411,30 +413,31 @@ private static Request createRequest( String

[jira] [Comment Edited] (FLINK-32353) Make Cassandra connector tests compatible with archunit rules

2023-07-05 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740251#comment-17740251 ] Etienne Chauchot edited comment on FLINK-32353 at 7/5/23 3:05 PM: -- The

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1621949525 if the third is optional the result should be same as the third arg is equal to length of the array (same as in case of `substring`) the result should be ```

[jira] [Commented] (FLINK-32353) Make Cassandra connector tests compatible with archunit rules

2023-07-05 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740251#comment-17740251 ] Etienne Chauchot commented on FLINK-32353: -- Regarding [this

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-05 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1621939482 @snuyanzin if third optional, can you tell me the specific function behavior at this time? ``` array_slice(ARRAY[1,2,3] , -3) -> [1,2,3] array_slice(ARRAY[1,2,3] , 1) ->

[GitHub] [flink] XComp commented on pull request #22873: [FLINK-32419][runtime] Removal of obsolete/unused classes/interfaces/fields

2023-07-05 Thread via GitHub
XComp commented on PR #22873: URL: https://github.com/apache/flink/pull/22873#issuecomment-1621920280 args, I screwed up and force pushed the wrong version. I fixed that a force-pushed the squashed version once more. I'm gonna go ahead and rebased to the most-recent version of FLINK-32409

[GitHub] [flink] XComp commented on pull request #22848: [FLINK-32409][runtime] Makes DefaultLeaderElectionService not rely on MultipleComponentLeaderElectionDriverAdapter anymore

2023-07-05 Thread via GitHub
XComp commented on PR #22848: URL: https://github.com/apache/flink/pull/22848#issuecomment-1621887334 I added the hotfix for the shutdown logic and squashed the commits together. I will do a separate rebase to most-recent (stable) version of `master`

[GitHub] [flink] XComp commented on a diff in pull request #22848: [FLINK-32409][runtime] Makes DefaultLeaderElectionService not rely on MultipleComponentLeaderElectionDriverAdapter anymore

2023-07-05 Thread via GitHub
XComp commented on code in PR #22848: URL: https://github.com/apache/flink/pull/22848#discussion_r1253200918 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesMultipleComponentLeaderElectionHaServices.java: ## @@ -69,75 +59,72 @@ public

[GitHub] [flink] XComp commented on pull request #22919: [FLINK-31837][runtime] Makes LeaderElectionDriver instantiation happen lazily

2023-07-05 Thread via GitHub
XComp commented on PR #22919: URL: https://github.com/apache/flink/pull/22919#issuecomment-1621865441 @zentol I addressed your comments. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] XComp commented on a diff in pull request #22919: [FLINK-31837][runtime] Makes LeaderElectionDriver instantiation happen lazily

2023-07-05 Thread via GitHub
XComp commented on code in PR #22919: URL: https://github.com/apache/flink/pull/22919#discussion_r1253187439 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -180,25 +186,117 @@ void testCloseGrantDeadlock()

[GitHub] [flink] XComp commented on a diff in pull request #22919: [FLINK-31837][runtime] Makes LeaderElectionDriver instantiation happen lazily

2023-07-05 Thread via GitHub
XComp commented on code in PR #22919: URL: https://github.com/apache/flink/pull/22919#discussion_r1253186428 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -125,7 +126,12 @@ void testCloseGrantDeadlock()

[GitHub] [flink-kubernetes-operator] darenwkt commented on pull request #620: [FLINK-32317] Enrich metadata in CR error field

2023-07-05 Thread via GitHub
darenwkt commented on PR #620: URL: https://github.com/apache/flink-kubernetes-operator/pull/620#issuecomment-1621854611 Hi Gyula, thank you for the review and apology for addressing them so late... -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Closed] (FLINK-32484) AdaptiveScheduler combined restart during scaling out

2023-07-05 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32484. -- Resolution: Duplicate > AdaptiveScheduler combined restart during scaling out >

[jira] [Commented] (FLINK-32484) AdaptiveScheduler combined restart during scaling out

2023-07-05 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740232#comment-17740232 ] Gyula Fora commented on FLINK-32484: I think this is related to

[GitHub] [flink-kubernetes-operator] darenwkt closed pull request #566: [FLINK-31798] Add config to disable EventRecorder

2023-07-05 Thread via GitHub
darenwkt closed pull request #566: [FLINK-31798] Add config to disable EventRecorder URL: https://github.com/apache/flink-kubernetes-operator/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] darenwkt closed pull request #568: [FLINK-31845] Make KubernetesStepDecorator Pluggable

2023-07-05 Thread via GitHub
darenwkt closed pull request #568: [FLINK-31845] Make KubernetesStepDecorator Pluggable URL: https://github.com/apache/flink-kubernetes-operator/pull/568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-kubernetes-operator] darenwkt closed pull request #570: [FLINK-31857] Observer plugin

2023-07-05 Thread via GitHub
darenwkt closed pull request #570: [FLINK-31857] Observer plugin URL: https://github.com/apache/flink-kubernetes-operator/pull/570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-07-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan closed FLINK-32362. --- Fix Version/s: 1.18.0 1.16.3 1.17.2 Resolution: Fixed >

[jira] [Commented] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-07-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740225#comment-17740225 ] Rui Fan commented on FLINK-32362: - Merged via master 1.18: 5509c61 1.17: 7219ca1 1.16: 1847b84 >

[GitHub] [flink] 1996fanrui merged pull request #22953: FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-07-05 Thread via GitHub
1996fanrui merged PR #22953: URL: https://github.com/apache/flink/pull/22953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on pull request #22953: FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-07-05 Thread via GitHub
1996fanrui commented on PR #22953: URL: https://github.com/apache/flink/pull/22953#issuecomment-1621794711 Thanks @LoveHeat for the fix, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] 1996fanrui merged pull request #22954: FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-07-05 Thread via GitHub
1996fanrui merged PR #22954: URL: https://github.com/apache/flink/pull/22954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on pull request #22954: FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-07-05 Thread via GitHub
1996fanrui commented on PR #22954: URL: https://github.com/apache/flink/pull/22954#issuecomment-1621791793 Thanks @LoveHeat for the fix, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] 1996fanrui merged pull request #22806: [FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-07-05 Thread via GitHub
1996fanrui merged PR #22806: URL: https://github.com/apache/flink/pull/22806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on pull request #22806: [FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-07-05 Thread via GitHub
1996fanrui commented on PR #22806: URL: https://github.com/apache/flink/pull/22806#issuecomment-1621789482 Thanks to @LoveHeat for the fix, and thanks @pnowojski for the review. CI passed, merging~ -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-32545) Improves the performance by optimizing row operations

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32545: --- Labels: pull-request-available (was: ) > Improves the performance by optimizing row

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #246: [FLINK-32545] Improves the performance by optimizing row operations

2023-07-05 Thread via GitHub
jiangxin369 opened a new pull request, #246: URL: https://github.com/apache/flink-ml/pull/246 ## What is the purpose of the change Improves the performance by optimizing row operations. ## Brief change log - Adds RowUtils to help with Row operations. -

[GitHub] [flink] flinkbot commented on pull request #22958: [FLINK-32541][network] Fix the buffer leaking when buffer accumulator is released

2023-07-05 Thread via GitHub
flinkbot commented on PR #22958: URL: https://github.com/apache/flink/pull/22958#issuecomment-1621740989 ## CI report: * 6bac655adf8d4704a242aeba82896a83b9905268 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32541) Fix the buffer leaking in buffer accumulators when a failover occurs

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32541: --- Labels: pull-request-available (was: ) > Fix the buffer leaking in buffer accumulators

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22958: [FLINK-32541][network] Fix the buffer leaking when buffer accumulator is released

2023-07-05 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22958: URL: https://github.com/apache/flink/pull/22958 ## What is the purpose of the change *Fix the buffer leaking when buffer accumulator is released* ## Brief change log - *Fix the buffer leaking when

[jira] [Updated] (FLINK-32545) Improves the performance by optimizing row operations

2023-07-05 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Xin updated FLINK-32545: -- Summary: Improves the performance by optimizing row operations (was: Removes the expensive Row

[GitHub] [flink] luoyuxia commented on a diff in pull request #22949: [FLINK-32517][table] Support to execute [CREATE OR] REPLACE TABLE AS statement

2023-07-05 Thread via GitHub
luoyuxia commented on code in PR #22949: URL: https://github.com/apache/flink/pull/22949#discussion_r1253044112 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlRTASNodeToOperationConverterTest.java: ## @@ -0,0 +1,130 @@ +/* + *

[jira] [Created] (FLINK-32545) Removes the expensive Row operations like join

2023-07-05 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-32545: - Summary: Removes the expensive Row operations like join Key: FLINK-32545 URL: https://issues.apache.org/jira/browse/FLINK-32545 Project: Flink Issue Type:

[GitHub] [flink] zentol commented on pull request #22957: [FLINK-32544][python] Fix test_java_sql_ddl to works in JDK17

2023-07-05 Thread via GitHub
zentol commented on PR #22957: URL: https://github.com/apache/flink/pull/22957#issuecomment-1621672385 CI run :crossed_fingers: : https://dev.azure.com/chesnay/flink/_build/results?buildId=3679=results -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] TanYuxin-tyx commented on pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-07-05 Thread via GitHub
TanYuxin-tyx commented on PR #22851: URL: https://github.com/apache/flink/pull/22851#issuecomment-1621671524 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #22957: [FLINK-32544][python] Fix test_java_sql_ddl to works in JDK17

2023-07-05 Thread via GitHub
flinkbot commented on PR #22957: URL: https://github.com/apache/flink/pull/22957#issuecomment-1621657961 ## CI report: * df82b2f3100904517fff667f0c40e48dc20adac2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] dianfu commented on pull request #22957: [FLINK-32544][python] Fix test_java_sql_ddl to works in JDK17

2023-07-05 Thread via GitHub
dianfu commented on PR #22957: URL: https://github.com/apache/flink/pull/22957#issuecomment-1621643609 cc @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-32544) PythonFunctionFactoryTest fails on Java 17

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32544: --- Labels: pull-request-available (was: ) > PythonFunctionFactoryTest fails on Java 17 >

[GitHub] [flink] dianfu opened a new pull request, #22957: [FLINK-32544][python] Fix test_java_sql_ddl to works in JDK17

2023-07-05 Thread via GitHub
dianfu opened a new pull request, #22957: URL: https://github.com/apache/flink/pull/22957 ## What is the purpose of the change *This pull request fixes test_java_sql_ddl to works in JDK17* ## Brief change log *(for example:)* - *The TaskInfo is stored in the

[jira] [Resolved] (FLINK-32388) Add the ability to pass parameters to CUSTOM PartitionCommitPolicy

2023-07-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32388. -- Resolution: Fixed master: ec222eae3f6f501d8681a40a7c528003e1006736 Thanks for the pr. > Add the

[GitHub] [flink] luoyuxia merged pull request #22831: [FLINK-32388]Add the ability to pass parameters to CUSTOM PartitionCommitPolicy

2023-07-05 Thread via GitHub
luoyuxia merged PR #22831: URL: https://github.com/apache/flink/pull/22831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-25322) Support no-claim mode in changelog state backend

2023-07-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740173#comment-17740173 ] Piotr Nowojski commented on FLINK-25322: Fair enough. In that case I would suggest to write a

  1   2   >