[jira] [Updated] (FLINK-33297) FLIP-366: Support standard YAML for FLINK configuration

2023-11-14 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-33297: Labels: pull-request-available (was: pull-request-available stale-assigned) > FLIP-366: Support standard

Re: [PR] Add maven release package plugin [flink-connector-pulsar]

2023-11-14 Thread via GitHub
tisonkun commented on PR #64: URL: https://github.com/apache/flink-connector-pulsar/pull/64#issuecomment-1811893500 Please created this PR against streamnaive/flink-connector-pulsar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add maven release package plugin [flink-connector-pulsar]

2023-11-14 Thread via GitHub
tisonkun closed pull request #64: Add maven release package plugin URL: https://github.com/apache/flink-connector-pulsar/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add maven release package plugin [flink-connector-pulsar]

2023-11-14 Thread via GitHub
boring-cyborg[bot] commented on PR #64: URL: https://github.com/apache/flink-connector-pulsar/pull/64#issuecomment-1811891776 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Updated] (FLINK-33537) Docs version nav is missing 1.18 as an option

2023-11-14 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-33537: -- Affects Version/s: 1.19.0 > Docs version nav is missing 1.18 as an option >

Re: [PR] [FLINK-33537][docs] Fix missing 1.18 doc link [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23715: URL: https://github.com/apache/flink/pull/23715#issuecomment-1811882974 ## CI report: * 977a22cfe44da9000c77f3a050d027e1d17c0bdd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33537) Docs version nav is missing 1.18 as an option

2023-11-14 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786187#comment-17786187 ] Yuxin Tan commented on FLINK-33537: --- [~rmoff] Thanks for reporting this issue. I will take a look. >

[jira] [Updated] (FLINK-33537) Docs version nav is missing 1.18 as an option

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33537: --- Labels: pull-request-available (was: ) > Docs version nav is missing 1.18 as an option >

[PR] [FLINK-33537][docs] Fix missing 1.18 doc link [flink]

2023-11-14 Thread via GitHub
TanYuxin-tyx opened a new pull request, #23715: URL: https://github.com/apache/flink/pull/23715 ## What is the purpose of the change *Fix missing 1.18 doc link* ## Brief change log - *Fix missing 1.18 doc link* ## Verifying this change

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-14 Thread via GitHub
LadyForest commented on PR #23620: URL: https://github.com/apache/flink/pull/23620#issuecomment-1811876102 Hi @xuyangzhong, could you pick the fix to release-1.18 and release-1.17 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-27056. Fix Version/s: 1.19.0 Assignee: Zhanghao Chen Resolution: Fixed Fixed via

Re: [PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-14 Thread via GitHub
boring-cyborg[bot] commented on PR #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20#issuecomment-1811862808 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-14 Thread via GitHub
leonardBang merged PR #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-27056] "pipeline.time-characteristic" should be deprecated have EVENT_TIME as default value [flink]

2023-11-14 Thread via GitHub
libenchao closed pull request #20231: [FLINK-27056] "pipeline.time-characteristic" should be deprecated have EVENT_TIME as default value URL: https://github.com/apache/flink/pull/20231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786179#comment-17786179 ] Benchao Li commented on FLINK-27056: [~Zhanghao Chen] Thanks for the clarification, sounds good to

[jira] [Updated] (FLINK-30460) Support writing HBase's CEIL TTL metadata

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30460: --- Labels: pull-request-available (was: ) > Support writing HBase's CEIL TTL metadata >

[PR] [FLINK-30460] Support the writable metadata ttl. [flink-connector-hbase]

2023-11-14 Thread via GitHub
Tan-JiaLiang opened a new pull request, #33: URL: https://github.com/apache/flink-connector-hbase/pull/33 ## What is the purpose of the change Support the hbase writable metadata ttl, allow user to set the cell ttl. ## Brief change log - *support the writable metadata

[jira] [Comment Edited] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786178#comment-17786178 ] Zhanghao Chen edited comment on FLINK-27056 at 11/15/23 5:54 AM: -

[jira] [Commented] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786178#comment-17786178 ] Zhanghao Chen commented on FLINK-27056: --- [~libenchao] Thanks for your attention here. The option's

[jira] [Commented] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786172#comment-17786172 ] Benchao Li commented on FLINK-27056: [~Zhanghao Chen] I saw in FLINK-33240 you are proposing to also

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
1996fanrui commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393549254 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/state/KubernetesAutoScalerStateStoreTest.java: ## @@

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786165#comment-17786165 ] Benchao Li commented on FLINK-33365: [~davidradl] I take a quick glance at the PR, it looks

[jira] [Resolved] (FLINK-33146) FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-11-14 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen resolved FLINK-33146. --- Release Note: Unify the representation of TaskManager location in REST API and Web UI. The

[jira] [Updated] (FLINK-33263) Implement ParallelismProvider for sources in the table planner

2023-11-14 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33263: -- Summary: Implement ParallelismProvider for sources in the table planner (was: Implement

[jira] [Commented] (FLINK-33263) Implement ParallelismProvider for sources in Blink planner

2023-11-14 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786163#comment-17786163 ] Zhanghao Chen commented on FLINK-33263: --- [~yunta] Thanks for pointing out. I'll rephrase it as

Re: [PR] [FLINK-33482] Flink benchmark regression check in new machines hosted on Aliyun [flink-benchmarks]

2023-11-14 Thread via GitHub
fredia merged PR #81: URL: https://github.com/apache/flink-benchmarks/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33498) Do not allow manually triggering incremental checkpoints with full checkpoint configured

2023-11-14 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786162#comment-17786162 ] Zakelly Lan commented on FLINK-33498: - I'm afraid the exception should be thrown around the

[jira] [Commented] (FLINK-33547) SQL primitive array type after upgrading to Flink 1.18.0

2023-11-14 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786159#comment-17786159 ] xuyang commented on FLINK-33547: Maybe caused by FLINK-31835.  > SQL primitive array type after

[jira] [Created] (FLINK-33548) Replaces taskManager/jobmanager.resource with resources conforming to ResourceRequirements

2023-11-14 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33548: -- Summary: Replaces taskManager/jobmanager.resource with resources conforming to ResourceRequirements Key: FLINK-33548 URL: https://issues.apache.org/jira/browse/FLINK-33548

[jira] [Comment Edited] (FLINK-33263) Implement ParallelismProvider for sources in Blink planner

2023-11-14 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784448#comment-17784448 ] Yun Tang edited comment on FLINK-33263 at 11/15/23 4:01 AM: [~Zhanghao Chen]

[jira] [Resolved] (FLINK-33148) Update Web UI to adopt the new "endpoint" field in REST API

2023-11-14 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-33148. --- Resolution: Fixed resolved in master: 5f9bef4288f59f428d4b2036f6eb9b30adf08287,

Re: [PR] [FLINK-33148] Update Web UI to adopt the new "endpoint" field in REST API [flink]

2023-11-14 Thread via GitHub
huwh merged PR #23698: URL: https://github.com/apache/flink/pull/23698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31835) DataTypeHint don't support Row>

2023-11-14 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786151#comment-17786151 ] xuyang commented on FLINK-31835: Hi, [~aitozi]. Sorry for this noise, can you check if the incompatible

Re: [PR] [FLINK-33492][docs] Fix unavailable links in connector download page [flink]

2023-11-14 Thread via GitHub
liyubin117 commented on PR #23693: URL: https://github.com/apache/flink/pull/23693#issuecomment-1811739862 @MartijnVisser After 1.19 released, the new links will be exposed to users, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-33512) Update download link in doc of Kafka connector

2023-11-14 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786144#comment-17786144 ] Yuxin Tan commented on FLINK-33512: --- Fixed in https://issues.apache.org/jira/browse/FLINK-33401. >

[jira] [Updated] (FLINK-33547) SQL primitive array type after upgrading to Flink 1.18.0

2023-11-14 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui updated FLINK-33547: Summary: SQL primitive array type after upgrading to Flink 1.18.0 (was: Primitive SQL array type

[jira] [Created] (FLINK-33547) Primitive SQL array type after upgrading to Flink 1.18.0

2023-11-14 Thread Xingcan Cui (Jira)
Xingcan Cui created FLINK-33547: --- Summary: Primitive SQL array type after upgrading to Flink 1.18.0 Key: FLINK-33547 URL: https://issues.apache.org/jira/browse/FLINK-33547 Project: Flink Issue

[jira] [Commented] (FLINK-33395) The join hint doesn't work when appears in subquery

2023-11-14 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786143#comment-17786143 ] Jane Chan commented on FLINK-33395: --- Master: 1d08b8bf6a67c6a1874e8003868d5735248a7e45 > The join hint

Re: [PR] [FLINK-33395][table-planner] fix the join hint doesn't work when appears in subquery [flink]

2023-11-14 Thread via GitHub
LadyForest merged PR #23620: URL: https://github.com/apache/flink/pull/23620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
liuyongvs commented on PR #23713: URL: https://github.com/apache/flink/pull/23713#issuecomment-1811692348 LGTM, only left one minor comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
liuyongvs commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1393547905 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/OverTypeStrategy.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the

Re: [PR] W.I.P [flink]

2023-11-14 Thread via GitHub
JunRuiLee closed pull request #23708: W.I.P URL: https://github.com/apache/flink/pull/23708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
1996fanrui commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393545577 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -44,13 +43,44 @@ public class

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
liuyongvs commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1393543354 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

[jira] [Created] (FLINK-33546) Implement type inference for order(asc/desc) function

2023-11-14 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-33546: - Summary: Implement type inference for order(asc/desc) function Key: FLINK-33546 URL: https://issues.apache.org/jira/browse/FLINK-33546 Project: Flink Issue Type:

[jira] [Commented] (FLINK-33198) Add timestamp with local time zone support in Avro converters

2023-11-14 Thread James Johnston (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786128#comment-17786128 ] James Johnston commented on FLINK-33198: The proposal in FLIP-378 sounds good to me. > Add

Re: [PR] [FLINK-27529] Fix Intger Comparison For Source Index in Hybrid Source [flink]

2023-11-14 Thread via GitHub
varun1729DD commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1811575198 > Earlier PR for this: #19654 > > Would you mind updating the JIRA number on this PR to refer to https://issues.apache.org/jira/browse/FLINK-27529? > > Do you see a

Re: [PR] [FLINK-33508] [HistoryServer] Support for wildcard paths in Flink History Server for multi cluster environment [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23714: URL: https://github.com/apache/flink/pull/23714#issuecomment-1811524180 ## CI report: * b15b9ec378ac519dc04200c0d219f74433020199 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33508) Support for wildcard paths in Flink History Server for multi cluster environment

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33508: --- Labels: pull-request-available (was: ) > Support for wildcard paths in Flink History

[PR] [FLINK-33508] [HistoryServer] Support for wildcard paths in Flink History Server for multi cluster environment [flink]

2023-11-14 Thread via GitHub
anikakelhanka opened a new pull request, #23714: URL: https://github.com/apache/flink/pull/23714 ## What is the purpose of the change This pull request updates Flink's History Server logic to enable getting logs and data from multiple directories at a time by using a path with

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Tseng updated FLINK-33545: Description: In the current implementation of KafkaSource and KafkaSink there are some

Re: [PR] [FLINK-33402] Fix Intger Comparison For Source Index in Hybrid Source [flink]

2023-11-14 Thread via GitHub
tweise commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1811489076 Earlier PR for this: https://github.com/apache/flink/pull/19654 Would you mind updating the JIRA number on this PR to refer to https://issues.apache.org/jira/browse/FLINK-27529?

Re: [PR] [FLINK-33402] Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss [flink]

2023-11-14 Thread via GitHub
tweise commented on PR #23687: URL: https://github.com/apache/flink/pull/23687#issuecomment-1811435516 @varun1729DD the thread name of the coordinator in the logs is `[SourceCoordinator-Source: parquet-source]` - can you please check if there is any other thread executing enumerator code?

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Tseng updated FLINK-33545: Description: In the current implementation of KafkaSource and KafkaSink there are some

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Tseng updated FLINK-33545: Description: In the current implementation of KafkaSource and KafkaSink there are some

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Tseng updated FLINK-33545: Description: In the current implementation of KafkaSource and KafkaSink there are some

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786084#comment-17786084 ] Kevin Tseng edited comment on FLINK-33545 at 11/14/23 9:26 PM: --- we have a

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Tseng updated FLINK-33545: Description: In the current implementation of KafkaSource and KafkaSink there are some

[jira] [Updated] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Tseng updated FLINK-33545: Description: In the current implementation of KafkaSource and KafkaSink there are some

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786084#comment-17786084 ] Kevin Tseng commented on FLINK-33545: - we have a fix to address this issue, can anyone able assign

[jira] [Created] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-11-14 Thread Kevin Tseng (Jira)
Kevin Tseng created FLINK-33545: --- Summary: KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching Key: FLINK-33545 URL:

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
afedulov commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1811283881 @gyfora I'd like to propose to use this format: ``` scalingTracking: |

[jira] [Commented] (FLINK-30483) Make Avro format support for TIMESTAMP_LTZ

2023-11-14 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786078#comment-17786078 ] Mingliang Liu commented on FLINK-30483: --- Just a heads up there is a FLIP for this

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
afedulov commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810934027 Sounds reasonable. If we are optimizing state size at this level, how about we also remove `RECOMMENDED_PARALLELISM` and `PARALLELISM` from the history metrics, since

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393033026 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393033026 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393033026 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393029595 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393023182 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] [FLINK-33543][core] Move Java record related tests into their own module since they only compile under JDK17 [flink]

2023-11-14 Thread via GitHub
XComp commented on PR #23709: URL: https://github.com/apache/flink/pull/23709#issuecomment-1810839048 Thanks for the approval. I squashed the commits and removed the debug commit (which modified the CI run). -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
gyfora commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r139300 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/state/ConfigMapView.java: ## @@ -0,0 +1,111 @@ +/* + *

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1393008678 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392984223 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/OverConvertRule.java: ## @@ -182,57 +191,59 @@ private RexNode

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392963092 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/OverTypeStrategy.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392962059 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/OverTypeStrategy.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
dawidwys commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392950951 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
dawidwys commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392950951 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
dawidwys commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392950507 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2302,7 +2302,8 @@ ANY,

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
dawidwys commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392940264 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/PlannerExpressionConverter.scala: ## @@ -79,12 +79,6 @@ class

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392939706 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392936413 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2302,7 +2302,8 @@ ANY,

Re: [PR] add failed offset to Flink error messages [flink-statefun]

2023-11-14 Thread via GitHub
kazimirov999 commented on code in PR #336: URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1392929689 ## statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java:

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392931305 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/PlannerExpressionConverter.scala: ## @@ -79,12 +79,6 @@ class

Re: [PR] add failed offset to Flink error messages [flink-statefun]

2023-11-14 Thread via GitHub
kazimirov999 commented on code in PR #336: URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1392929689 ## statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java:

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
dawidwys commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392930722 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

Re: [PR] add failed offset to Flink error messages [flink-statefun]

2023-11-14 Thread via GitHub
kazimirov999 commented on code in PR #336: URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1392929689 ## statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java:

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23713: URL: https://github.com/apache/flink/pull/23713#issuecomment-1810695279 ## CI report: * 671eca40d099b2c3303a410ada5cbd321843b65e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33410) Implement type inference for Over function

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33410: --- Labels: pull-request-available (was: ) > Implement type inference for Over function >

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392927090 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY,

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810690806 > Got it, this is how it actually works currently (modulo additional target vertices parallelism tracking that I will attempt to fetch from the history instead) - I thought

[PR] Over window [flink]

2023-11-14 Thread via GitHub
dawidwys opened a new pull request, #23713: URL: https://github.com/apache/flink/pull/23713 ## What is the purpose of the change It implements type inference for `OVER`, `STREAM_RECORD` and `THROW_EXCEPTION` functions. ## Verifying this change * all available tests pass

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:50 PM:

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:49 PM:

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
afedulov commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810668734 >I meant a flag in the ConfigMap. I guess something like startTime: endTime would be sufficient? The endTime would initially be null. Got it, this is how it

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810649406 >Are we talking about having a field in the ScalingExecutor? Because fetching scalingHistory won't be sufficient - we need some indication that a new rescaling was applied

[jira] [Updated] (FLINK-33410) Implement type inference for Over function

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33410: - Description:

[jira] [Assigned] (FLINK-33410) Implement type inference for Over offsets functions

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-33410: Assignee: Dawid Wysakowicz > Implement type inference for Over offsets functions

[jira] [Updated] (FLINK-33410) Implement type inference for Over function

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33410: - Summary: Implement type inference for Over function (was: Implement type inference for

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:33 PM:

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:32 PM:

  1   2   >