Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24077: URL: https://github.com/apache/flink/pull/24077#discussion_r1467317080 ## docs/content.zh/docs/dev/table/sql/queries/hints.md: ## @@ -108,6 +108,39 @@ hintOption: | stringLiteral ``` +### 查询提示使用中的冲突 + Key-value

[jira] [Commented] (FLINK-34113) Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces

2024-01-25 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811151#comment-17811151 ] Jiabao Sun commented on FLINK-34113: [~martijnvisser] We can use TestSinkInitContext instead of

[jira] [Updated] (FLINK-34113) Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34113: --- Labels: pull-request-available (was: ) > Update flink-connector-elasticsearch to be

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

2024-01-25 Thread via GitHub
boring-cyborg[bot] commented on PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#issuecomment-1911606536 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) --

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24077: URL: https://github.com/apache/flink/pull/24077#discussion_r1467302542 ## docs/content/docs/dev/table/sql/queries/hints.md: ## @@ -114,6 +114,42 @@ hintOption: | stringLiteral ``` +### Conflict Cases In Query Hints +

Re: [PR] [FLINK-32743][Connectors/Kafka] Parse data from kafka connect and convert it into regular JSON data [flink-connector-kafka]

2024-01-25 Thread via GitHub
sunxiaojian commented on PR #42: URL: https://github.com/apache/flink-connector-kafka/pull/42#issuecomment-1911592095 > > Thanks for your review, it has been processed > > CI is failing, will you take a look? @MartijnVisser fixed -- This is an automated message from the

Re: [PR] [hotfix][docs] Fix scan.bounded.mode missing forward options [flink-connector-kafka]

2024-01-25 Thread via GitHub
Tan-JiaLiang commented on PR #60: URL: https://github.com/apache/flink-connector-kafka/pull/60#issuecomment-1911588128 @MartijnVisser Sorry late. > Do we have tests for them? To be honest, I checked all connectors(e.g. jdbc/hbase/filesystem...) but there is no test case for

Re: [PR] [FLINK-34209] Migrate FileSink to the new SinkV2 API [flink]

2024-01-25 Thread via GitHub
Jiabao-Sun commented on code in PR #24180: URL: https://github.com/apache/flink/pull/24180#discussion_r1467184292 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/TestSinkInitContext.java: ## @@ -48,7 +48,7 @@ import

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1467286142 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RelTreeWriterImpl.scala: ## @@ -149,7 +149,16 @@ class

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1911579714 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33263][bugfix][table-planner] Update the flink shaded guava version used to 32 [flink]

2024-01-25 Thread via GitHub
flinkbot commented on PR #24200: URL: https://github.com/apache/flink/pull/24200#issuecomment-1911578061 ## CI report: * 5b43ccb1014c5a8be9ae9a19470b38877beeadb2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34216) Support fine-grained configuration to control filter push down for MongoDB Connector

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34216: --- Labels: pull-request-available (was: ) > Support fine-grained configuration to control

[PR] [FLINK-34216][connectors/mongodb] FLIP-377: Support fine-grained configuration to control filter push down for MongoDB Connector [flink-connector-mongodb]

2024-01-25 Thread via GitHub
Jiabao-Sun opened a new pull request, #23: URL: https://github.com/apache/flink-connector-mongodb/pull/23 [FLINK-34216][connectors/mongodb] FLIP-377: Support fine-grained configuration to control filter push down for MongoDB Connector This improvement implements [FLIP-377 Support

Re: [PR] [FLINK-34059][docs][table] Add documentation on STATE_TTL hint [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24198: URL: https://github.com/apache/flink/pull/24198#discussion_r1467276024 ## docs/content/docs/dev/table/sql/queries/hints.md: ## @@ -597,6 +597,131 @@ SELECT /*+ BROADCAST(t1) SHUFFLE_HASH(t1) */ * FROM t1 FULL OUTER JOIN t2 ON t1.

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
LadyForest commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1467207831 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RelTreeWriterImpl.scala: ## @@ -149,7 +149,16 @@ class

Re: [PR] [FLINK-33263][bugfix][table-planner] Update the flink shaded guava version used to 32 [flink]

2024-01-25 Thread via GitHub
BIOINSu commented on PR #24200: URL: https://github.com/apache/flink/pull/24200#issuecomment-1911564412 Hi @libenchao , this PR is a hotfix for the wrong version usage of flink shaded guava and change the version to 32. Please review this commit. Thanks a lot. -- This is an automated

[jira] [Commented] (FLINK-34214) FLIP-377: Support fine-grained configuration to control filter push down for Table/SQL Sources

2024-01-25 Thread Rascal Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811142#comment-17811142 ] Rascal Wu commented on FLINK-34214: --- Hi, may i consulting one question that if we disable the push

[PR] [FLINK-33263][bugfix][table-planner] Update the flink shaded guava version used to 32 [flink]

2024-01-25 Thread via GitHub
BIOINSu opened a new pull request, #24200: URL: https://github.com/apache/flink/pull/24200 ## What is the purpose of the change Bugfix for FLINK-33263. Update the flink shaded guava version used in `SourceTransformationWrapper` to 32. ## Brief change log -

Re: [PR] [Draft][configuration] Change standard YAML parser to support YAML 1.2. [flink]

2024-01-25 Thread via GitHub
flinkbot commented on PR #24199: URL: https://github.com/apache/flink/pull/24199#issuecomment-1911560589 ## CI report: * a5f6ccf25c195d05cc1f64e59284c09b413dfccc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [Draft][configuration] Change standard YAML parser to support YAML 1.2. [flink]

2024-01-25 Thread via GitHub
JunRuiLee opened a new pull request, #24199: URL: https://github.com/apache/flink/pull/24199 ## What is the purpose of the change Change standard YAML parser to support YAML 1.2. ## Brief change log - Change snakeyaml to snakeyaml engine 2.6 to support YAML

Re: [PR] [FLINK-34145][connector/filesystem] support dynamic source parallelism inference in batch jobs [flink]

2024-01-25 Thread via GitHub
SinBex commented on PR #24186: URL: https://github.com/apache/flink/pull/24186#issuecomment-1911552066 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1467258035 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -112,6 +112,7 @@ class

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1467257676 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MinibatchUtil.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on PR #24183: URL: https://github.com/apache/flink/pull/24183#issuecomment-1911536124 BTW, can you update the description of this pr? Currently they seem to come with the template. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-34240) The example of sliding windows with offset in documentation is not correct

2024-01-25 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-34240: -- Summary: The example of sliding windows with offset in documentation is not correct Key: FLINK-34240 URL: https://issues.apache.org/jira/browse/FLINK-34240 Project:

[jira] [Updated] (FLINK-34058) Support optional parameters for named parameters

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34058: --- Labels: pull-request-available (was: ) > Support optional parameters for named parameters

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1467163962 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java: ## @@ -1073,6 +1073,25 @@ void

Re: [PR] [FLINK-33899][connectors/mongodb] Java 17 and 21 support for mongodb connector [flink-connector-mongodb]

2024-01-25 Thread via GitHub
Jiabao-Sun commented on code in PR #21: URL: https://github.com/apache/flink-connector-mongodb/pull/21#discussion_r1467234659 ## .github/workflows/push_pr.yml: ## @@ -25,7 +25,14 @@ jobs: compile_and_test: strategy: matrix: -flink: [1.16-SNAPSHOT,

Re: [PR] [FLINK-34237][connectors/mongodb] Fix compile failed with Flink 1.19-SNAPSHOT [flink-connector-mongodb]

2024-01-25 Thread via GitHub
WencongLiu commented on PR #22: URL: https://github.com/apache/flink-connector-mongodb/pull/22#issuecomment-1911458296 Hi @Jiabao-Sun , I've opened another pull request to revert the breaking changes in flink repo. All connectors won't meet this issue after the PR is merged. -- This is

Re: [PR] [FLINK-34237][connectors/mongodb] Fix compile failed with Flink 1.19-SNAPSHOT [flink-connector-mongodb]

2024-01-25 Thread via GitHub
Jiabao-Sun commented on PR #22: URL: https://github.com/apache/flink-connector-mongodb/pull/22#issuecomment-1911448586 The modification to MongoWriterITCase is due to https://github.com/apache/flink/pull/24180#discussion_r1467184292. @leonardBang please help take a look. -- This

Re: [PR] [FLINK-34059][docs][table] Add documentation on STATE_TTL hint [flink]

2024-01-25 Thread via GitHub
flinkbot commented on PR #24198: URL: https://github.com/apache/flink/pull/24198#issuecomment-1911441439 ## CI report: * 3a87f3409f768c3e1eead3f281e6d326b48b7d89 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34209] Migrate FileSink to the new SinkV2 API [flink]

2024-01-25 Thread via GitHub
Jiabao-Sun commented on code in PR #24180: URL: https://github.com/apache/flink/pull/24180#discussion_r1467200868 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/TestSinkInitContext.java: ## @@ -48,7 +48,7 @@ import

[jira] [Updated] (FLINK-34222) Get minibatch join operator involved

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34222: --- Labels: pull-request-available (was: ) > Get minibatch join operator involved >

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1466284522 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/QueryHintsResolver.java: ## @@ -83,21 +85,50 @@ final List

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
lsyldliu commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1467198322 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -112,6 +112,7 @@ class

Re: [PR] [FLINK-33682][metrics] Reuse source operator input records/bytes metrics for SourceOperatorStreamTask [flink]

2024-01-25 Thread via GitHub
X-czh closed pull request #23823: [FLINK-33682][metrics] Reuse source operator input records/bytes metrics for SourceOperatorStreamTask URL: https://github.com/apache/flink/pull/23823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-34053][table-planner] Support state ttl hint for group aggregate [flink]

2024-01-25 Thread via GitHub
LadyForest commented on code in PR #24179: URL: https://github.com/apache/flink/pull/24179#discussion_r1467200085 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/QueryHintsResolver.java: ## @@ -83,21 +85,50 @@ final List

[jira] [Assigned] (FLINK-34235) Not using Optional as input arguments in QueryHintsResolver

2024-01-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34235: - Assignee: xuyang > Not using Optional as input arguments in QueryHintsResolver >

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1787#comment-1787 ] Jane Chan commented on FLINK-34115: --- {quote}1.18 build that didn't include the fix, yet:

[jira] [Commented] (FLINK-34229) Duplicate entry in InnerClasses attribute in class file FusionStreamOperator

2024-01-25 Thread Dan Zou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1785#comment-1785 ] Dan Zou commented on FLINK-34229: - [~xiasun], I could not reproduce in my environment, could you please

Re: [PR] [FLINK-34237] Revert the breaking changes to SourceReaderContext [flink]

2024-01-25 Thread via GitHub
flinkbot commented on PR #24197: URL: https://github.com/apache/flink/pull/24197#issuecomment-1911434979 ## CI report: * 486d33707572c3b6cfd2f286d34d9c3648ba14ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34059) Add documentation on how to use state TTL hint

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34059: --- Labels: pull-request-available (was: ) > Add documentation on how to use state TTL hint >

[PR] [FLINK-34059][docs][table] Add documentation on STATE_TTL hint [flink]

2024-01-25 Thread via GitHub
LadyForest opened a new pull request, #24198: URL: https://github.com/apache/flink/pull/24198 ## What is the purpose of the change This PR adds a doc to the `STATE_TTL` hint. ## Brief change log Add doc. ## Verifying this change This change is

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1782#comment-1782 ] Jane Chan commented on FLINK-34115: --- Hi [~mapohl], Thank you for pointing out that the bug fix did not

[jira] [Updated] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34237: --- Labels: pull-request-available (was: ) > MongoDB connector compile failed with Flink

[PR] [FLINK-34237] Revert the breaking changes to SourceReaderContext [flink]

2024-01-25 Thread via GitHub
WencongLiu opened a new pull request, #24197: URL: https://github.com/apache/flink/pull/24197 ## What is the purpose of the change *Revert the breaking changes to SourceReaderContext.* ## Does this pull request potentially affect one of the following parts: -

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811109#comment-17811109 ] Rui Fan commented on FLINK-34200: - Thanks [~mapohl] for adding more failed cases. As [~srichter]

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-25 Thread via GitHub
libenchao commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1467192709 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SourceTransformationWrapper.java: ## @@ -0,0 +1,72 @@ +/* +Licensed to the

[jira] [Created] (FLINK-34239) Introduce a deep copy method of SerializerConfig for merging with Table configs in org.apache.flink.table.catalog.DataTypeFactoryImpl

2024-01-25 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-34239: - Summary: Introduce a deep copy method of SerializerConfig for merging with Table configs in org.apache.flink.table.catalog.DataTypeFactoryImpl Key: FLINK-34239 URL:

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-25 Thread via GitHub
libenchao commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1467192424 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SourceTransformationWrapper.java: ## @@ -0,0 +1,72 @@ +/* +Licensed to the

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-25 Thread via GitHub
RocMarshal commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1467191595 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SourceTransformationWrapper.java: ## @@ -0,0 +1,72 @@ +/* +Licensed to the

[jira] [Closed] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2024-01-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-33465. - Resolution: Duplicate > Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as >

[jira] [Updated] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2024-01-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-33465: -- Fix Version/s: (was: 1.19.0) > Make SingleThreadFetcherManager and

[jira] [Commented] (FLINK-34230) Update flink-docs README: add -Pskip-webui-build to the config doc generation command

2024-01-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811104#comment-17811104 ] Zhanghao Chen commented on FLINK-34230: --- [~Weijie Guo] Could you help take a look when you are

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811103#comment-17811103 ] Leonard Xu commented on FLINK-34237: [~martijnvisser] ,this issue is different with  FLINK-34149,

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-25 Thread via GitHub
ruanhang1993 commented on code in PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#discussion_r1467189983 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java: ## @@ -350,6 +352,26 @@ public

[jira] [Commented] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811102#comment-17811102 ] Qingsheng Ren commented on FLINK-34196: --- Merged to master:

[jira] [Updated] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-34237: --- Description: {code:java} Error: Failed to execute goal

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811101#comment-17811101 ] Wencong Liu commented on FLINK-34237: - Thanks for the reminder. I'll fix it as soon as possible. >

[jira] [Resolved] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-25 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-34196. --- Resolution: Fixed > FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving. >

Re: [PR] [FLINK-34196][Connectors][FLIP-389] Annotate SingleThreadFetcherManager as PublicEvolving. [flink]

2024-01-25 Thread via GitHub
PatrickRen merged PR #24171: URL: https://github.com/apache/flink/pull/24171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34209] Migrate FileSink to the new SinkV2 API [flink]

2024-01-25 Thread via GitHub
Jiabao-Sun commented on code in PR #24180: URL: https://github.com/apache/flink/pull/24180#discussion_r1467184292 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/TestSinkInitContext.java: ## @@ -48,7 +48,7 @@ import

Re: [PR] [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [flink]

2024-01-25 Thread via GitHub
reswqa commented on PR #24187: URL: https://github.com/apache/flink/pull/24187#issuecomment-1911329138 @X-czh Thanks for the review! I have removed the unused option in `test_controller.sh` and squashed all commits. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [flink]

2024-01-25 Thread via GitHub
reswqa commented on code in PR #24187: URL: https://github.com/apache/flink/pull/24187#discussion_r1467177600 ## tools/ci/test_controller.sh: ## @@ -105,7 +105,7 @@ if [ $STAGE == $STAGE_PYTHON ]; then run_with_watchdog "./flink-python/dev/lint-python.sh"

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-25 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467160375 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java: ## @@ -110,4 +114,67 @@ void

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-25 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467160375 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java: ## @@ -110,4 +114,67 @@ void

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-25 Thread via GitHub
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467174161 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-25 Thread via GitHub
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467171751 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-25 Thread via GitHub
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467171607 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -581,6 +588,27 @@ void

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-25 Thread via GitHub
libenchao commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467163104 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the

Re: [PR] [FLINK-34196][Connectors][FLIP-389] Annotate SingleThreadFetcherManager as PublicEvolving. [flink]

2024-01-25 Thread via GitHub
loserwang1024 commented on PR #24171: URL: https://github.com/apache/flink/pull/24171#issuecomment-191130 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-33263) Implement ParallelismProvider for sources in the table planner

2024-01-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33263. Fix Version/s: 1.19.0 Resolution: Fixed Implemented via

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-25 Thread via GitHub
libenchao closed pull request #24128: [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner URL: https://github.com/apache/flink/pull/24128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-25 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1911291438 > @libenchao a question to you before merging `squash` also removed the info about all the authors, are you ok if I add you as a co-author since it is based on your work? Or

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-25 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811084#comment-17811084 ] Zhu Zhu commented on FLINK-34206: - We will take a look. >

[jira] [Updated] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-34237: - Fix Version/s: 1.19.0 (was: mongodb-1.1.0) > MongoDB connector compile

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811082#comment-17811082 ] Xintong Song commented on FLINK-34237: -- Thanks for reporting. This is indeed an unintended breaking

[jira] [Assigned] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-34237: Assignee: Wencong Liu > MongoDB connector compile failed with Flink 1.19-SNAPSHOT >

[jira] [Closed] (FLINK-34221) Introduce operator for minibatch join

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu closed FLINK-34221. - Assignee: Shuai Xu Resolution: Fixed > Introduce operator for minibatch join >

[jira] [Commented] (FLINK-34221) Introduce operator for minibatch join

2024-01-25 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811081#comment-17811081 ] dalongliu commented on FLINK-34221: --- Merged in master: 8170c457cb70bb8fd88b98baf3acc612eaab8ec5 >

[jira] [Updated] (FLINK-34221) Introduce operator for minibatch join

2024-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34221: --- Labels: pull-request-available (was: ) > Introduce operator for minibatch join >

Re: [PR] [FLINK-34221][table-runtime] Introduce MiniBatchStreamingJoinOperator [flink]

2024-01-25 Thread via GitHub
lsyldliu closed pull request #24160: [FLINK-34221][table-runtime] Introduce MiniBatchStreamingJoinOperator URL: https://github.com/apache/flink/pull/24160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-34100][table] Support session window table function without pulling up with window agg [flink]

2024-01-25 Thread via GitHub
xuyangzhong commented on code in PR #24162: URL: https://github.com/apache/flink/pull/24162#discussion_r1467143192 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.xml: ## @@ -2170,6 +2360,386 @@

[jira] [Updated] (FLINK-34238) In streaming mode, redundant exchange nodes can be optimally deleted in some cases

2024-01-25 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34238: --- Description: Take the following plan as an example: {code:java} Calc(select=[window_start, window_end, a,

[jira] [Created] (FLINK-34238) In streaming mode, redundant exchange nodes can be optimally deleted in some cases

2024-01-25 Thread xuyang (Jira)
xuyang created FLINK-34238: -- Summary: In streaming mode, redundant exchange nodes can be optimally deleted in some cases Key: FLINK-34238 URL: https://issues.apache.org/jira/browse/FLINK-34238 Project:

[jira] [Commented] (FLINK-34233) HybridShuffleITCase.testHybridSelectiveExchangesRestart failed due to a IllegalStateException

2024-01-25 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811073#comment-17811073 ] Yunfeng Zhou commented on FLINK-34233: -- Hi [~mapohl], truly this is also a bug caused by

Re: [PR] [FLINK-34223][dist] Introduce a migration tool to transfer legacy config file to new config file. [flink]

2024-01-25 Thread via GitHub
JunRuiLee commented on PR #24185: URL: https://github.com/apache/flink/pull/24185#issuecomment-1911249227 Picked the latest fix https://github.com/apache/flink/pull/24194 and rebased onto master. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-34122][core] Deprecate old serialization config methods and options [flink]

2024-01-25 Thread via GitHub
X-czh commented on PR #24193: URL: https://github.com/apache/flink/pull/24193#issuecomment-1911227577 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33882] UT/IT for checkpointing statistics [flink]

2024-01-25 Thread via GitHub
JingGe commented on code in PR #24007: URL: https://github.com/apache/flink/pull/24007#discussion_r1467074403 ## flink-runtime/src/test/java/org/apache/flink/runtime/metrics/DescriptiveStatisticsHistogramStatisticsTest.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (FLINK-33843) Promote release 1.18.1

2024-01-25 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33843. - Resolution: Fixed > Promote release 1.18.1 > -- > > Key:

[jira] [Resolved] (FLINK-33838) Finalize release 1.18.1

2024-01-25 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33838. - Resolution: Fixed > Finalize release 1.18.1 > --- > > Key:

[jira] [Resolved] (FLINK-33842) Publish the Dockerfiles for the new release

2024-01-25 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33842. - Resolution: Fixed > Publish the Dockerfiles for the new release >

[jira] [Comment Edited] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2024-01-25 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798545#comment-17798545 ] Jing Ge edited comment on FLINK-33588 at 1/25/24 11:03 PM: --- [~zhutong66]

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811041#comment-17811041 ] Martijn Visser commented on FLINK-34237: For context, we had a similar issue with FLINK-34149 >

Re: [PR] [FLINK-32743][Connectors/Kafka] Parse data from kafka connect and convert it into regular JSON data [flink-connector-kafka]

2024-01-25 Thread via GitHub
MartijnVisser commented on PR #42: URL: https://github.com/apache/flink-connector-kafka/pull/42#issuecomment-1911093338 > Thanks for your review, it has been processed CI is failing, will you take a look? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-01-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811037#comment-17811037 ] Martijn Visser commented on FLINK-33545: [~mason6345] WDYT about [~aeolus811tw] his last

Re: [PR] [FLINK-33692][Connectors/Kafka] FlinkKafkaProducer could miss super.close [flink-connector-kafka]

2024-01-25 Thread via GitHub
MartijnVisser commented on PR #74: URL: https://github.com/apache/flink-connector-kafka/pull/74#issuecomment-1911089667 @mas-chen Any thoughts on this? Is this indeed a bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-25 Thread via GitHub
MartijnVisser commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1911088576 @mas-chen @ruanhang1993 I've brought this discussion (and my proposal) back to the Dev mailing list, see https://lists.apache.org/thread/0hp782dv6kjcv3ypthhfhyp7kglg83d0

[jira] [Commented] (FLINK-34237) MongoDB connector compile failed with Flink 1.19-SNAPSHOT

2024-01-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811035#comment-17811035 ] Martijn Visser commented on FLINK-34237: [~leonard] This looks like a blocker for Flink 1.19,

[jira] [Updated] (FLINK-32289) The metadata column type is incorrect in Kafka table connector example

2024-01-25 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32289: --- Fix Version/s: kafka-3.1.0 (was: kafka-4.0.0) > The metadata column

  1   2   3   4   >