[jira] [Assigned] (FLINK-34258) Incorrect example of accumulator usage within emitUpdateWithRetract for TableAggregateFunction

2024-01-28 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34258: - Assignee: (was: Jane Chan) > Incorrect example of accumulator usage within

[jira] [Closed] (FLINK-34052) Missing TopSpeedWindowing and SessionWindowing JARs in Flink Maven Repository

2024-01-28 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34052. -- Fix Version/s: 1.19.0 Resolution: Fixed master(1.19) via

Re: [PR] [FLINK-34052][examples] Install the shaded streaming example jars in the maven repo [flink]

2024-01-28 Thread via GitHub
reswqa merged PR #24206: URL: https://github.com/apache/flink/pull/24206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-34258) Incorrect example of accumulator usage within emitUpdateWithRetract for TableAggregateFunction

2024-01-28 Thread Jane Chan (Jira)
Jane Chan created FLINK-34258: - Summary: Incorrect example of accumulator usage within emitUpdateWithRetract for TableAggregateFunction Key: FLINK-34258 URL: https://issues.apache.org/jira/browse/FLINK-34258

Re: [PR] [FLINK-34115][table-planner] Fix TableAggregateITCase unstable test [flink]

2024-01-28 Thread via GitHub
flinkbot commented on PR #24214: URL: https://github.com/apache/flink/pull/24214#issuecomment-1914082399 ## CI report: * f62f6452c985a79242c1d9fc3ec57bc1ca13 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34115][table-planner] Fix TableAggregateITCase unstable test [flink]

2024-01-28 Thread via GitHub
LadyForest opened a new pull request, #24214: URL: https://github.com/apache/flink/pull/24214 ## What is the purpose of the change This PR tries to fix the unstable ITCase `TableAggregateITCase`. ## Brief change log Replace table source. ## Verifying this

[jira] [Commented] (FLINK-34238) In streaming mode, redundant exchange nodes can be optimally deleted in some cases

2024-01-28 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811750#comment-17811750 ] dalongliu commented on FLINK-34238: --- +1, [~libenchao] Looks forward to your team contribution if

[jira] [Commented] (FLINK-34222) Supports mini-batch for streaming regular join

2024-01-28 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811749#comment-17811749 ] dalongliu commented on FLINK-34222: --- Merged in master: 20450485b20cb213b96318b0c3275e42c0300e15 >

[jira] [Closed] (FLINK-34222) Supports mini-batch for streaming regular join

2024-01-28 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu closed FLINK-34222. - Resolution: Fixed > Supports mini-batch for streaming regular join >

Re: [PR] [FLINK-34222][table-planner] Supports mini-batch for streaming regular join [flink]

2024-01-28 Thread via GitHub
lsyldliu closed pull request #24161: [FLINK-34222][table-planner] Supports mini-batch for streaming regular join URL: https://github.com/apache/flink/pull/24161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-34222) Supports mini-batch for streaming regular join

2024-01-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34222: - Summary: Supports mini-batch for streaming regular join (was: End to end implementation of minibatch

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469124707 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +106,33 @@ public

Re: [PR] [FLINK-34257][core] Update Flink YAML Parser to Support YAML 1.2 Specification. [flink]

2024-01-28 Thread via GitHub
flinkbot commented on PR #24213: URL: https://github.com/apache/flink/pull/24213#issuecomment-1914044726 ## CI report: * 6862748059d638419ac98ecfbd67643cb540c0ce UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34222) End to end implementation of minibatch join

2024-01-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34222: - Description: Implement minibatch join in E2E which includes both plan and runtime parts. (was: Get

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469121295 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -55,17 +59,32 @@ public class

[jira] [Updated] (FLINK-34257) Update Flink YAML Parser to Support YAML 1.2 Specification

2024-01-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34257: --- Labels: pull-request-available (was: ) > Update Flink YAML Parser to Support YAML 1.2

[PR] [FLINK-34257][core] Update Flink YAML Parser to Support YAML 1.2 Specification. [flink]

2024-01-28 Thread via GitHub
JunRuiLee opened a new pull request, #24213: URL: https://github.com/apache/flink/pull/24213 ## What is the purpose of the change Change standard YAML parser to support YAML 1.2. ## Brief change log - Change snakeyaml to snakeyaml engine 2.6 to

Re: [PR] [Draft][configuration] Change standard YAML parser to support YAML 1.2. [flink]

2024-01-28 Thread via GitHub
JunRuiLee closed pull request #24199: [Draft][configuration] Change standard YAML parser to support YAML 1.2. URL: https://github.com/apache/flink/pull/24199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-34257) Update Flink YAML Parser to Support YAML 1.2 Specification

2024-01-28 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Li updated FLINK-34257: -- Description: FLINK-33364 and FLINK-33577 added snakeyaml and pyyaml dependencies to support a

[jira] [Created] (FLINK-34257) Update Flink YAML Parser to Support YAML 1.2 Specification

2024-01-28 Thread Junrui Li (Jira)
Junrui Li created FLINK-34257: - Summary: Update Flink YAML Parser to Support YAML 1.2 Specification Key: FLINK-34257 URL: https://issues.apache.org/jira/browse/FLINK-34257 Project: Flink Issue

[jira] [Created] (FLINK-34256) Add a documentation section for minibatch join

2024-01-28 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34256: Summary: Add a documentation section for minibatch join Key: FLINK-34256 URL: https://issues.apache.org/jira/browse/FLINK-34256 Project: Flink Issue Type: Sub-task

[PR] [hotfix] Update copyright year to 2024 [flink-connector-pulsar]

2024-01-28 Thread via GitHub
ruanhang1993 opened a new pull request, #82: URL: https://github.com/apache/flink-connector-pulsar/pull/82 ## Purpose of the change Update copyright year to 2024. ## Brief change log Update copyright year to 2024 in NOTICE. ## Verifying this change

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-28 Thread via GitHub
xintongsong commented on PR #24163: URL: https://github.com/apache/flink/pull/24163#issuecomment-1914013482 @zhougit86 , If you need any help in understanding the comments, feel free to reach out to my email (tonysong...@gmail.com). We may exchange WeChat ID and have an offline phone

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-28 Thread via GitHub
xintongsong commented on code in PR #24163: URL: https://github.com/apache/flink/pull/24163#discussion_r1469101401 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClientTest.java: ## @@ -454,6 +451,22 @@ void testWatchPodsAndDoCallback()

[jira] [Created] (FLINK-34255) FLIP-406: Reorganize State & Checkpointing & Recovery Configuration

2024-01-28 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34255: --- Summary: FLIP-406: Reorganize State & Checkpointing & Recovery Configuration Key: FLINK-34255 URL: https://issues.apache.org/jira/browse/FLINK-34255 Project: Flink

[jira] [Commented] (FLINK-34219) Introduce a new join operator to support minibatch

2024-01-28 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811741#comment-17811741 ] lincoln lee commented on FLINK-34219: - [~xu_shuai_] For this new optimization, can we add some user

[jira] [Commented] (FLINK-34109) FileSystem sink connector restore job from historical checkpoint failure

2024-01-28 Thread Sergey Paryshev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811732#comment-17811732 ] Sergey Paryshev commented on FLINK-34109: - I guess this is same:

[jira] [Comment Edited] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-28 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811725#comment-17811725 ] Jane Chan edited comment on FLINK-34115 at 1/29/24 4:02 AM: The root cause

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-28 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811725#comment-17811725 ] Jane Chan commented on FLINK-34115: --- The root cause of the unstable case is the source used.

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469047743 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public

Re: [PR] [FLINK-34007][k8s] Adds workaround that fixes the deadlock when renewing the leadership lease fails [flink]

2024-01-28 Thread via GitHub
wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1469043488 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ## @@ -86,12 +117,38 @@ public

[jira] [Updated] (FLINK-34254) `DESCRIBE` syntaxes like `DESCRIBE CATALOG xxx` throws strange exceptions

2024-01-28 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34254: --- Description: Add the test following to CalcITCase to re-produce this bug. {code:java} @Test def test():

[jira] [Updated] (FLINK-34254) `DESCRIBE` syntaxes like `DESCRIBE CATALOG xxx` throws strange exceptions

2024-01-28 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34254: --- Description: Add the test following to CalcITCase to re-produce this bug.   {code:java} @Test def

[jira] [Updated] (FLINK-34254) `DESCRIBE` syntaxes like `DESCRIBE CATALOG xxx` throws strange exceptions

2024-01-28 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34254: --- Description: Add the test following to CalcITCase to re-produce this bug.   {code:java} @Test def

[jira] [Created] (FLINK-34254) `DESCRIBE` syntaxes like `DESCRIBE CATALOG xxx` throws strange exceptions

2024-01-28 Thread xuyang (Jira)
xuyang created FLINK-34254: -- Summary: `DESCRIBE` syntaxes like `DESCRIBE CATALOG xxx` throws strange exceptions Key: FLINK-34254 URL: https://issues.apache.org/jira/browse/FLINK-34254 Project: Flink

Re: [PR] [hotfix] Update copyright year to 2024 [flink-connector-opensearch]

2024-01-28 Thread via GitHub
boring-cyborg[bot] commented on PR #40: URL: https://github.com/apache/flink-connector-opensearch/pull/40#issuecomment-1913891222 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) --

Re: [PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-01-28 Thread via GitHub
flinkbot commented on PR #24212: URL: https://github.com/apache/flink/pull/24212#issuecomment-1913877869 ## CI report: * 3d66ebaffc112e0b3777fc3e3841b64f045357bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34253) Offsets out of range with no configured reset policy for partitions

2024-01-28 Thread Jepson (Jira)
Jepson created FLINK-34253: -- Summary: Offsets out of range with no configured reset policy for partitions Key: FLINK-34253 URL: https://issues.apache.org/jira/browse/FLINK-34253 Project: Flink

[jira] [Updated] (FLINK-33981) File Descriptor References Not Released After Job Execution in MiniCluster Mode

2024-01-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33981: --- Labels: pull-request-available (was: ) > File Descriptor References Not Released After Job

[PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-01-28 Thread via GitHub
fengjiajie opened a new pull request, #24212: URL: https://github.com/apache/flink/pull/24212 ## What is the purpose of the change When using MiniCluster mode, file descriptors like /tmp/minicluster_6e62ab17ab058e0d5df56b97e9ccef71/tm_0/localState are not released after a

[jira] [Resolved] (FLINK-34249) Remove DefaultSlotTracker related logic.

2024-01-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34249. - Fix Version/s: 1.19.0 Resolution: Fixed > Remove DefaultSlotTracker related logic. >

Re: [PR] [hotfix] Update copyright year to 2024 [flink-connector-mongodb]

2024-01-28 Thread via GitHub
Jiabao-Sun commented on PR #24: URL: https://github.com/apache/flink-connector-mongodb/pull/24#issuecomment-1913860680 Hi @leonardBang, please help take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-34249) Remove DefaultSlotTracker related logic.

2024-01-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811711#comment-17811711 ] Rui Fan commented on FLINK-34249: - Merged to master(1.19.0) via :

[jira] [Assigned] (FLINK-34249) Remove DefaultSlotTracker related logic.

2024-01-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-34249: --- Assignee: RocMarshal > Remove DefaultSlotTracker related logic. >

[jira] [Closed] (FLINK-24223) Client should throw exception to warn users when the configurations set by program options conflict with those set by -D

2024-01-28 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen closed FLINK-24223. - Resolution: Later > Client should throw exception to warn users when the configurations set by

[jira] [Commented] (FLINK-24223) Client should throw exception to warn users when the configurations set by program options conflict with those set by -D

2024-01-28 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811710#comment-17811710 ] Zhanghao Chen commented on FLINK-24223: --- Closing it as Flink 2.0 has a plan to refactor the CLI

Re: [PR] [FLINK-34249][runtime] Remove DefaultSlotTracker related logic. [flink]

2024-01-28 Thread via GitHub
1996fanrui merged PR #24204: URL: https://github.com/apache/flink/pull/24204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-01-28 Thread via GitHub
flinkbot commented on PR #24211: URL: https://github.com/apache/flink/pull/24211#issuecomment-1913851473 ## CI report: * 3b898a0c74a5dcb957ab7ab30b79dd82d01e8c0e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34252) WatermarkAssignerOperator should not emit WatermarkStatus.IDLE under continuous data flow

2024-01-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34252: --- Labels: pull-request-available (was: ) > WatermarkAssignerOperator should not emit

[PR] [FLINK-34252] [table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-01-28 Thread via GitHub
dchristle opened a new pull request, #24211: URL: https://github.com/apache/flink/pull/24211 ## What is the purpose of the change In the current implementation, the lastRecordTime variable, which tracks the time of the last received data element, is updated only when the

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
fsk119 commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1469008084 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionSignatureTemplate.java: ## @@ -44,19 +45,24 @@ final class

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
fsk119 commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1469006005 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/BaseMappingExtractor.java: ## @@ -323,6 +327,37 @@ private void

Re: [PR] [FLINK-33899][connectors/mongodb] Java 17 and 21 support for mongodb connector [flink-connector-mongodb]

2024-01-28 Thread via GitHub
Jiabao-Sun commented on PR #21: URL: https://github.com/apache/flink-connector-mongodb/pull/21#issuecomment-1913831390 Thanks @leonardBang for the review. Rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33899][connectors/mongodb] Java 17 and 21 support for mongodb connector [flink-connector-mongodb]

2024-01-28 Thread via GitHub
leonardBang commented on PR #21: URL: https://github.com/apache/flink-connector-mongodb/pull/21#issuecomment-1913828923 @Jiabao-Sun could you help rebase this PR to latest master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-34237][connectors/mongodb] Update MongoWriterITCase to be compatible with updated SinkV2 interfaces [flink-connector-mongodb]

2024-01-28 Thread via GitHub
leonardBang merged PR #22: URL: https://github.com/apache/flink-connector-mongodb/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913822230 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468995720 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/BaseMappingExtractor.java: ## @@ -323,6 +327,37 @@ private void

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468994767 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionSignatureTemplate.java: ## @@ -44,19 +45,24 @@ final class

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468994153 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/BaseMappingExtractor.java: ## @@ -143,6 +144,9 @@ protected Map

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468993636 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionSignatureTemplate.java: ## @@ -44,19 +45,24 @@ final class

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468992167 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/StringCallGen.scala: ## @@ -237,6 +238,9 @@ object StringCallGen {

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-28 Thread via GitHub
swuferhong commented on PR #24077: URL: https://github.com/apache/flink/pull/24077#issuecomment-1913790623 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-34252) WatermarkAssignerOperator should not emit WatermarkStatus.IDLE under continuous data flow

2024-01-28 Thread David Christle (Jira)
David Christle created FLINK-34252: -- Summary: WatermarkAssignerOperator should not emit WatermarkStatus.IDLE under continuous data flow Key: FLINK-34252 URL: https://issues.apache.org/jira/browse/FLINK-34252

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913631542 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33981) File Descriptor References Not Released After Job Execution in MiniCluster Mode

2024-01-28 Thread Feng Jiajie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811659#comment-17811659 ] Feng Jiajie commented on FLINK-33981: - I found the issue and will submit a fix later. Please assign

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-28 Thread via GitHub
zhougit86 commented on PR #24163: URL: https://github.com/apache/flink/pull/24163#issuecomment-1913601244 @xintongsong Hi , I got a chance to modify my commit, would you please bother to review for another time? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-34158][table] Migrate WindowAggregateReduceFunctionsRule to java [flink]

2024-01-28 Thread via GitHub
JingGe commented on code in PR #24140: URL: https://github.com/apache/flink/pull/24140#discussion_r1468850983 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java: ## @@ -0,0 +1,90 @@ +/* + *

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913572174 > @xishuaidelin The failure case is an known issue (https://issues.apache.org/jira/browse/FLINK-34206), you can rebase the latest master and rerun the tests. @lincoln-lil

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913571547 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-28 Thread via GitHub
JingGe commented on code in PR #24139: URL: https://github.com/apache/flink/pull/24139#discussion_r1468823507 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkLimit0RemoveRule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-28 Thread via GitHub
JingGe commented on code in PR #24139: URL: https://github.com/apache/flink/pull/24139#discussion_r1468823507 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkLimit0RemoveRule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-28 Thread via GitHub
JingGe commented on code in PR #24139: URL: https://github.com/apache/flink/pull/24139#discussion_r1468823507 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkLimit0RemoveRule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-28 Thread via GitHub
JingGe commented on code in PR #24139: URL: https://github.com/apache/flink/pull/24139#discussion_r1468823507 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkLimit0RemoveRule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] [FLINK-34157][table] Migrate FlinkLimit0RemoveRule to java [flink]

2024-01-28 Thread via GitHub
JingGe commented on code in PR #24139: URL: https://github.com/apache/flink/pull/24139#discussion_r1468823507 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkLimit0RemoveRule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
xuyangzhong commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468816825 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java: ## @@ -1527,11 +1605,37 @@ public String

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
fsk119 commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468808120 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInference.java: ## @@ -46,6 +46,8 @@ public final class TypeInference {

[jira] [Commented] (FLINK-34123) Introduce built-in serializers for common composited data types

2024-01-28 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811651#comment-17811651 ] Zhanghao Chen commented on FLINK-34123: --- [~zjureel] May I take this? I'll start working on it

[jira] [Updated] (FLINK-34123) Introduce built-in serializers for common composited data types

2024-01-28 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-34123: -- Affects Version/s: 1.19.0 > Introduce built-in serializers for common composited data types >

[jira] [Commented] (FLINK-34239) Introduce a deep copy method of SerializerConfig for merging with Table configs in org.apache.flink.table.catalog.DataTypeFactoryImpl

2024-01-28 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811650#comment-17811650 ] Zhanghao Chen commented on FLINK-34239: --- [~mallikarjuna] Welcome to the community! Go ahead~

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-28 Thread via GitHub
fsk119 commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468800471 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionSignatureTemplate.java: ## @@ -44,19 +45,24 @@ final class

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-01-28 Thread Yang LI (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811646#comment-17811646 ] Yang LI commented on FLINK-33545: - Hello, If I understand correctly, [~mason6345] 's proposal doesn't

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-01-28 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811642#comment-17811642 ] Kevin Tseng commented on FLINK-33545: - Hi [~mason6345]  I'm not sure that's possible without going

[jira] [Closed] (FLINK-34245) CassandraSinkTest.test_cassandra_sink fails under JDK17 and JDK21 due to InaccessibleObjectException

2024-01-28 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-34245. --- Fix Version/s: 1.19.0 Assignee: Junrui Li Resolution: Fixed Fixed via

Re: [PR] [FLINK-34245][python] Fix config retrieval logic from nested YAML in pyflink_gateway_server with flattened keys. [flink]

2024-01-28 Thread via GitHub
zhuzhurk closed pull request #24209: [FLINK-34245][python] Fix config retrieval logic from nested YAML in pyflink_gateway_server with flattened keys. URL: https://github.com/apache/flink/pull/24209 -- This is an automated message from the Apache Git Service. To respond to the message, please