GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/4820
[FLINK-7834] [table] cost model extends network cost and memory cost
## What is the purpose of the change
*This pull request makes cost model (RelOptCost) extends network cost and
memory
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/4815
[FLINK-7802] [hotfix] Exception occur when empty field collection was
pushed into CSVTableSource
## What is the purpose of the change
*This pull request fix the bug: Exception occur when
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/4572#discussion_r141783154
--- Diff: flink-connectors/flink-parquet/pom.xml ---
@@ -0,0 +1,81 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/4682
[FLINK-7620] [table] Supports user defined optimization phase
## What is the purpose of the change
*This pull request makes Flink supports user defined optimization phase.
before this PR
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139301067
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala
---
@@ -0,0 +1,193
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139301022
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala
---
@@ -0,0 +1,193
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139301007
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala
---
@@ -0,0 +1,193
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/4667#discussion_r139300836
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -55,4 +55,9 @@ trait
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3860#discussion_r138843966
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/PhysicalTableSourceScan.scala
---
@@ -70,4 +73,18 @@ abstract
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/4667
[FLINK-5859] [table] Add PartitionableTableSource for partition pruning
## What is the purpose of the change
This pull request adds PartitionableTableSource for partition pruning when
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/4572
[Flink-7243] [connectors] Add ParquetInputFormat
## What is the purpose of the change
Add ParquetInputFormat to read from parquet files
## Brief change log
- *Supports
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3860#discussion_r116451558
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/PhysicalTableSourceScan.scala
---
@@ -70,4 +73,18 @@ abstract
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3569#discussion_r114697342
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -44,6 +43,8 @@ case class
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3569#discussion_r114695239
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalCatalogTablePartition.scala
---
@@ -0,0 +1,44
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3818
[FLINK-5514] [table] Implement an efficient physical execution for
CUBE/ROLLUP/GROUPING SETS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3815
[FLINK-6436] [table] Bug in CommonCorrelate's generateCollector method when
using udtf with udf
You can merge this pull request into a Git repository by running:
$ git pull https
Github user godfreyhe commented on the issue:
https://github.com/apache/flink/pull/3660
@twalthr, I had update this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user godfreyhe commented on the issue:
https://github.com/apache/flink/pull/3660
@twalthr do you mean that sql like ```select a, rand(a) from table``` does
not work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3740
[FLINK-6327] [table] Bug in CommonCalc's estimateRowCount() method
(rowCnt * 0.75).min(1.0) should be changed to (rowCnt * 0.75).max(1.0)
You can merge this pull request into a Git repository
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3739
[FLINK-6326] [table] add ProjectMergeRule at logical optimization stage
add ProjectMergeRule to merge projections
You can merge this pull request into a Git repository by running:
$ git pull
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3696#discussion_r110534557
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRetractionRule.scala
---
@@ -0,0 +1,341
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3696#discussion_r110534493
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRetractionRule.scala
---
@@ -0,0 +1,341
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3699
[FLINK-6279] [table] fix bug: the digest of VolcanoRuleMatch matched â¦
toString of TableSourceScan should contain table name and result of
explainSource to distinguish the difference of table
Github user godfreyhe commented on the issue:
https://github.com/apache/flink/pull/3660
thanks for your advice @fhueske @twalthr. I had update the PR.
I will implement rand and rand_integer functions for the Scala and Java
Table API next immediately, or should I submit a new PR
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3660#discussion_r109898654
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/SqlExpressionTest.scala
---
@@ -168,6 +168,18 @@ class
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3660
[FLINK-6237] [table] support RAND and RAND_INTEGER on SQL
support RAND and RAND_INTEGER with and without seed on SQL.
like:
RAND([seed]),
RAND_INTEGER([seed, ] bound)
You can merge
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106100087
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -57,17 +60,24 @@ class
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106149747
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -34,14 +34,24 @@ trait
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106074574
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -19,31 +19,34
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106073030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106072764
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
@@ -0,0 +1,184
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r105811515
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r105814436
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -0,0
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r105812230
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -0,0
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3166#discussion_r102886003
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/PushFilterIntoStreamTableSourceScanRule.scala
Github user godfreyhe commented on the issue:
https://github.com/apache/flink/pull/3176
Thanks for the suggestions @twalthr, I have updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r101437939
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -122,6 +123,18 @@ class CodeGenerator
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r101437890
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UDFContext.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r101428511
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user godfreyhe commented on the issue:
https://github.com/apache/flink/pull/3101
Done, thanks for the suggest @fhueske
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3101#discussion_r100488613
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/NormalizationRulesTests.scala
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r100478286
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r100469073
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user godfreyhe commented on the issue:
https://github.com/apache/flink/pull/3176
Hi @wuchong , thanks for this review.
I think `UserDefinedScalarFunctionTest` is not enough, because `open` ,
`close` methods and job parameters are strongly depend on runtime, so it's
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r99548048
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/UserDefinedTableFunctionITCase.scala
---
@@ -0,0 +1,106
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r99544629
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -24,4 +24,19 @@ package
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r99532146
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -220,56 +247,105 @@ class CodeGenerator
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3101#discussion_r99524112
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RuleSetConfig.scala
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3101#discussion_r99522172
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/AggregationTest.scala
---
@@ -165,14 +165,20 @@ class AggregationTest extends
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3176
[FLINK-5571] [table] add open and close methods for UserDefinedFunction
Currently, a User Defined Function (UDF) in table API & SQL works on zero,
one, or multiple values in custom evalua
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/3101
[FLINK-5406] [table] add normalization phase for predicate logical plan
rewriting
Normalization phase is for predicate logical plan rewriting and is
independent of cost module. The rules
GitHub user godfreyhe opened a pull request:
https://github.com/apache/flink/pull/2894
[FLINK-5184] fix bug: Error result of compareSerialized in RowComparator
class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/godfreyhe
52 matches
Mail list logo
