Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3490
@kdombeck thank you for this PR! We now have [official Docker
images](https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/docker.html)
and I see that the contrib Dockerfile no longer
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3954
This affects more than Windows ... at least MacOS and I expect Linux as
well.
Also need to update `rotateLogFilesWithPrefix` in `config.sh` to:
`rotateLogFile "$log"`.
-
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3946#discussion_r117504104
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade
---
@@ -28,10 +28,10 @@ split
a(ui-sref=".subtasks({n
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3941
Thanks for the review @zentol. The mistake was caused by not performing a
case-sensitive find-replace. I redid the file with variable rename.
---
If your project is set up for it, you can reply
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3907#discussion_r117479119
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java
---
@@ -86,6 +86,9 @@ int
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
@rmetzger latest commit is simpler and tested successfully for java and
scala: `mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate
-DarchetypeGroupId=org.apache.flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3887
master: 47cb7347d8e02195088b2dc1900ac53bd5d02b0d
1.3.0: 542068760901cba2fd6f2b3f3ff6a980aee0e23e
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
@rmetzger I am seeing the same issue and will look into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3907
Does an `InputGate` contain both local and remote `InputChannel` such that
the minimum positive value might be more desirable in that case?
---
If your project is set up for it, you can reply
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3932
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3887
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3875
@StephanEwen I see that you +1'd the ticket but this PR has not been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3941
[FLINK-6603] [streaming] Enable checkstyle on test sources
Follow-up to FLINK-6107.
The first commit sets the import order as
[discussed](https://issues.apache.org/jira/browse/FLINK-6107
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
After asking the question I added the second commit which inherits the
scala version as is the current / expected behavior.
---
If your project is set up for it, you can reply to this email
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3906
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3914
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3932
[FLINK-6616] [docs] Clarify provenance of official Docker images
Note that the official Docker images for Flink are community supported and
not an official release of the Apache Flink PMC.
You
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3920
Perhaps we should enable checkstyle on test sources when upgrading to the
strict checkstyle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3920
@sunjincheng121 thanks for this PR. @fhueske what do you think of enabling
checkstyle's `includeTestSourceDirectory`?
---
If your project is set up for it, you can reply to this email and have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
@rmetzger what is happening in `create_release_files.sh:deploy_to_maven`?
Are we overwriting the 2.11 quickstart jars with 2.10 jars? Are we still
looking to publish against Scala 2.10 rather than
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3910
[FLINK-6582] [docs] Project from maven archetype is not buildable by default
The pom.xml for flink-quickstart-java and flink-quickstart-scala must
specify scala.version and scala.binary.version
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3034
@aljoscha can the new behavior be demonstrated by a test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3583#discussion_r116251216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -955,14 +950,33 @@ public void stop() throws
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3583#discussion_r116250328
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3865#discussion_r116233068
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -111,34 +111,32 @@ private BlobServer(Configuration config
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3865#discussion_r11627
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/BlobServerOptions.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3865#discussion_r116224135
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -111,34 +111,32 @@ private BlobServer(Configuration config
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3875
[FLINK-6560] [build] Restore maven parallelism in flink-tests
Configure a default value for Maven variable 'flink.forkCountTestPackage'.
You can merge this pull request into a Git repository
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
@rmetzger +1, agree that these changes are best made at the beginning of
the release cycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3866
@rbonifacio thanks for this contribution! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3800
@StephanEwen does the recent discussion on packaging shaded dependencies
mean that `force-shading` will go away? Or do we keep that even if dependencies
are no longer being shaded? Or will only
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2422
We would need INFRA to enable a daily cron build for Flink. How will we use
FindBugs (which may be dead)? Is a goal to export the site artifacts to S3?
---
If your project is set up for it, you
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3866
@rbonifacio changes look good except for a few missing spaces after `catch`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3858
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3857
@alpinegizmo changes look good. Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3751#discussion_r115801773
--- Diff: docs/page/css/syntax.css ---
@@ -77,3 +77,6 @@
.highlight .vg { color: #008080 } /* Name.Variable.Global */
.highlight .vi { color
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3369
@nellboy and also thanks for this contribution! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3367
@nellboy thanks for this contribution! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3751#discussion_r115750993
--- Diff: docs/page/css/syntax.css ---
@@ -77,3 +77,6 @@
.highlight .vg { color: #008080 } /* Name.Variable.Global */
.highlight .vi { color
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol yes, and the release release 16 days from now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol, perhaps "feature freeze" is better named "major feature freeze"
and next week's "code freeze" as "minor feature freeze". My understanding is
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3736
@zentol @StephanEwen why not also merge this into 1.3? There are literally
no modified or removed lines of code.
---
If your project is set up for it, you can reply to this email and have your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2422
@smarthi are you still able to work on this PR? We could enable in a
profile when `TRAVIS_EVENT_TYPE=cron` is set in the
[environment](https://docs.travis-ci.com/user/environment-variables
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2705
@rmetzger is this feature still desired for a rebase and review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2742
@StephanEwen @tillrohrmann is this ready for 1.3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3688
@barcahead would it be safer to also normalize the value of
`jobmanager.rpc.address`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3669
@kl0u how important is this for 1.3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3719
@mtunique please manually close this PR since it is subsumed by #3751.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3858#discussion_r115543214
--- Diff: docs/dev/best_practices.md ---
@@ -284,30 +284,30 @@ Change your projects `pom.xml` file like this:
The following changes were done
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3858#discussion_r115544603
--- Diff: docs/dev/stream/checkpointing.md ---
@@ -124,8 +124,8 @@ env.getCheckpointConfig.setMaxConcurrentCheckpoints(1)
## Selecting a State
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3858#discussion_r115538538
--- Diff: docs/dev/best_practices.md ---
@@ -31,13 +31,13 @@ This page contains a collection of best practices for
Flink programmers on how t
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3858#discussion_r115541319
--- Diff: docs/dev/best_practices.md ---
@@ -31,13 +31,13 @@ This page contains a collection of best practices for
Flink programmers on how t
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3751
@patricklucas when will the link be available? It would be great to have
this merged for 1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3830
Is there a [JIRA](https://issues.apache.org/jira/browse/FLINK) associated
with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3831
Will this also be merged to 1.3.0? If not, 1.4 will need to replace and
deprecate `JOB_MANAGER_WEB_ACCESS_CONTROL_ALLOW_ORIGIN`.
---
If your project is set up for it, you can reply to this email
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3821
@alpinegizmo nice fix! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3617
@WangTaoTheTonic it looks like this PR can now be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3852
Should we add a stronger attribution as in Flink's main `LICENSE` file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
@StephanEwen changes made, and I rebased back a few commits for stable
tests and also made yarn-tests non-optional.
---
If your project is set up for it, you can reply to this email and have your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
@rmetzger @StephanEwen thoughts on releasing 2.8 binaries for Flink 1.3?
Are there old versions we can drop for 1.4?
---
If your project is set up for it, you can reply to this email and have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3823
@alpinegizmo understood, and meant to say that with an eye to the future.
Was only confirming that the community is not giving special consideration to
data Artisians.
---
If your project is set
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3802
Am working on merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3823#discussion_r115064578
--- Diff: docs/index.md ---
@@ -33,9 +33,13 @@ Apache Flink is an open source platform for distributed
stream and batch data pr
- **Concepts
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3823#discussion_r115065489
--- Diff: docs/index.md ---
@@ -33,9 +33,13 @@ Apache Flink is an open source platform for distributed
stream and batch data pr
- **Concepts
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3832
[FLINK-6466] [build] Build Hadoop 2.8.0 convenience binaries
Add Hadoop 2.8 to the create_release_files.sh script and TravisCI test
matrix.
Hadoop updated the `httpclient` and `httpcore
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3831
+1 to merge for 1.3.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3831
Are we also deprecating use of the default values in `ConfigConstants`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3828#discussion_r114860033
--- Diff: docs/setup/aws.md ---
@@ -32,17 +32,23 @@ Amazon Web Services offers cloud computing services on
which you can run Flink.
[Amazon
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3828#discussion_r114861195
--- Diff: docs/setup/aws.md ---
@@ -32,17 +32,23 @@ Amazon Web Services offers cloud computing services on
which you can run Flink.
[Amazon
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3828#discussion_r114861184
--- Diff: docs/setup/aws.md ---
@@ -32,17 +32,23 @@ Amazon Web Services offers cloud computing services on
which you can run Flink.
[Amazon
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3828#discussion_r114827396
--- Diff: docs/setup/aws.md ---
@@ -32,17 +32,23 @@ Amazon Web Services offers cloud computing services on
which you can run Flink.
[Amazon
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3802
What makes this graph 'evenly'? See
`org.apache.flink.graph.drivers.input.CompleteGraph` for creating an input for
`Runner` (the default class executed when doing a `/bin/flink run` on the
flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3511
@heytitle yes, let's try that first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3511
@heytitle, the code generation is only for a few methods, right? So the
other methods in the sorter template could be moved into a
`NormalizedKeySorterBase` which would be subclasses
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114324999
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,161 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114323050
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r11412
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3802
The tests sometimes fail. The build matrix splits the tests into three
groups, each run with four different configurations. As you have noted, based
on the changed code the single error can
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114085668
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114085607
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073710
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073211
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073233
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073291
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073660
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073355
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114073386
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3802
@fanzhidongyzby are you using IntelliJ? You'll want to setup
[checkstyle](https://ci.apache.org/projects/flink/flink-docs-release-1.3/internals/ide_setup.html#checkstyle)
which should note
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3367
@nellboy please rebase to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3369
@nellboy please rebase to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3619
+1 LGTM.
My only thought is if a user passes test data with more than one
implementation of `TypeInformation` (and passing the `canEquals` test) then the
check for `hashCode` and `equals
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3795
@zentol, doesn't look to be an option:
https://github.com/scalastyle/scalastyle/issues/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3795
@zentol we are not enabling
[includeTestSourceDirectory](https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#includeTestSourceDirectory).
---
If your project is set up
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114030670
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java
---
@@ -41,17 +43,41 @@
@Rule
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114030564
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/input/GridGraph.java
---
@@ -82,11 +81,27 @@ public void
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3800
[FLINK-6414] [build] Use scala.binary.version in place of
change-scala-version.sh
Use scala.binary.version as defined in the parent POM and remove the script
to swap scala version identifiers
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3788
@fanzhidongyzby that sounds good except I would leave the `EmptyGraph` as
it is. In addition we'll want to add the new generators as driver inputs in
`flink-gelly-examples`, add to the list
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3788
@fanzhidongyzby, what do you think about generalizing this to the
`CirculantGraph`? The graph could be initialized with a vertex count and the
configured with one or more ranges. Each range would
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3784
Any ideas why we can't just reference `scala.binary.version` in the Maven
configurations rather than specifying `2.10` and modifying this in the change
script? I don't see why `change-scala
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3511
@heytitle, you can `rebase -i dd20^` and then delete the first two lines
which removes those commits from the history.
An initial thought from skimming the code: should we create
401 - 500 of 1173 matches
Mail list logo
