Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191972
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,22 +1,16 @@
/*
- * Licensed to the Apache Software
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38193714
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38193807
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphConstructionTest.java
---
@@ -450,8 +414,8 @@ private void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38204935
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135852748
I just pushed an update addressing your comments. I additionally rework all
TaskManager and JobManager test.
Open issues:
1. how to deal with (potentially blocking
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135901379
Travis fails due to instable test. Own Travis is green:
https://travis-ci.org/mjsax/flink/builds/77750320
---
If your project is set up for it, you can reply
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38227043
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38119693
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38132263
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38130678
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -363,7 +363,135 @@ protected void run
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135523032
I just pushed three commits on top addressing your comment. The first two,
include reworking all test cases in a whole package each, to change the test
pattern from catch
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-135399187
I think the `byte[]`converting approach is the correct way to go. Storm
config keys must not be `String`, thus the specific prefix trick cannot be
applied.
---
If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1037#issuecomment-135360613
Hmmm... I will have a look. Sounds weird, because the Travis from the PR is
actually green... I never saw this error message before...
---
If your project is set up
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1037#issuecomment-135342844
I just saw that the header in `FiniteStormFileSpout.java` got reformatted
what should not be. Can you fix this when merging?
---
If your project is set up for it, you
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37996420
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135075011
Thanks for your review. I will add some more answers to the specific
comments (if necessary) and address all others. Do you want me to put a new
commit on top or should I
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37976623
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37976536
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-135000384
Can anyone have a look at `Configuration.java`. Not sure if the changes are
ok.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37990248
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988911
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -536,6 +541,68 @@ public int compare(JobStatusMessage o1
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991061
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991348
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1037#issuecomment-135035210
Just rebased. Please merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-135006223
@ffbin Can you extend `ExclamationTopology` such that the number of added
`! `in `ExclamationBolt` and `ExclamationWithStormSpout.ExclamationMap` is
configurable
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-135034643
I agree with @rmetzger and @uce
https://issues.apache.org/jira/browse/FLINK-2512 is already closed via #1009
---
If your project is set up for it, you can reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135032541
Just rebased. Failing test in unrelated (Yarn and instable test in
flink-runtime). Both have alread a JIRA.
This PR is ready to get merged from my point of view
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991819
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37993145
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37995477
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37746515
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37745589
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-134190885
It fails in two test. You should actually see it, if you execute test
locally. You should run test each time before you open/update an PR (at least
for the module you did
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37745701
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37746137
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37741197
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37741352
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37741303
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37741464
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37741748
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-134162565
I don't see changes in `FlinkClient`. Only in `FlinkLocalCluster`. Did you
test by starting Flink via `bin/start-local.sh` (it would be even better to
test in a real
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-134162997
Travis fails because you broke something...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1037#discussion_r37640464
--- Diff: docs/apis/storm_compatibility.md ---
@@ -224,4 +224,12 @@ DataStreamString rawInput = env.addSource(
You can find more examples in Maven
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1037#issuecomment-133477238
I got it now. Can be merged from my point of view.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1041
[FLINK-2560] Flink-Avro Plugin cannot be handled by Eclipse
- disabled avro-maven-plugin within Eclipse via pluginManagement ...
lifecyleMappingMetaData
You can merge this pull request into a Git
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1037#discussion_r37687901
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1037
[FLINK-2553] Example Jars not build correctly
- reworked package structure of utils and wordcount.stormoperators package
- reword class hierarchy of *FileSpout and *InMemorySpout
- fixed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1037#discussion_r37573869
--- Diff: docs/apis/storm_compatibility.md ---
@@ -224,4 +224,12 @@ DataStreamString rawInput = env.addSource(
You can find more examples in Maven
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-131800322
Failing KafkaConnector test. This in unrelated. Failing run is green on
personal Travis ((https://travis-ci.org/mjsax/flink/builds/75910791).
---
If your project is set
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1011#issuecomment-131623875
Fixed. This should be ready to get merged. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-131633170
I just rebased to current master. What is the status of this PR? Can it get
merged (from my point of view, yes)?
---
If your project is set up for it, you can reply
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1011
[FLINK-2306] Add support for named streams in Storm compatibility layer
- enabled .declareStream() and connect via stream name
- enabled multiplt output streams
- added .split
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1011#issuecomment-130694237
Yes. It a weird compile error and it builds locally... The error is:
`[ERROR]
/home/travis/build/mjsax/flink/flink-contrib/flink-storm-compatibility/flink-storm
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-130323723
I did the following changes:
- added Tuple0 to `TupleGenerator.modifyTupleType()`
- changes `LinkedList` to `ArrayList` in TupleGenerator to create code
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-130211866
Any news about this PR? @twalthr : Are you going to review it again?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-130298853
I modified by hand. Was not aware of `TupleGenerator`. Just had a look into
it. Not sure if `Tuple0` can be included appropriately. For example, it is no
generic class
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1002
[FLINK-2502] FiniteStormSpout documenation does not render correclty
- added missing empty lines
- additional minor improvements
You can merge this pull request into a Git repository by running
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/853#issuecomment-128692750
Nice :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-128387669
- changed `LinkedList` to `ArrayList` in **all** `TupleXBuilder` classes
- removed WS formatting
- changed `Tuple0` **and** `Tuple0Serializer` to singleton
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-128405666
You are right about `newInstance`. I removed private constructor. Soft
singleton is used now. Also added `readResolve()` (something new I learned
today :) ).
---
If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-128407712
Ups. That was not intended at all... Does not make any sense. Sorry. I
didn't realize that I edited the wrong class because Tuple0Serializer is
singleton, too... Just
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127992002
Added serialization and extended tests. I tested the serialization part by
writing Tuple0 as result of one batch program to disc and consumed those Tuple0
recored
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127905311
Thanks for conforming my observations and even dive deeper into it. What
should the next step be?
---
If your project is set up for it, you can reply to this email
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127951144
There is nothing bad about it. I just would like to have a breaking
example...
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/983
[FLINK-2457] Integrate Tuple0
- extended TypeExtractor to handle Tuple0
- extended .getTupleClass(int) to hanlde arity zero
- simplified Receiver.createTuple(int)
You can merge this pull
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/983#discussion_r36190666
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -391,6 +392,10 @@ protected TypeExtractor
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127623565
@twalthr thanks for the hint to `TypeInfoParser`. I will have a lock. But
your statement about introduce multiple bugs, seems to be a little bit to
general... I did
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/983#discussion_r36195314
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -391,6 +392,10 @@ protected TypeExtractor
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127605738
I used different dop for source/consumer and double check that multiple TMs
are involved to make sure data is really going over the network...
Batch example
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127597013
I double checked with two different programs and it worked... Not sure if I
am missing something. Please see dev mailing list. Otherwise, please help me to
come up
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-127680821
I just tried using `TypeSerializerOutputFormat` for a DataSet sink. There
is no error. The system only creates an empty file. How can I force the usage
of a file-channel
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/974#issuecomment-127283992
Failing test is unrelated. This should be ready for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/976#issuecomment-127414537
This only update documentation. Failing test in unrelated. Should be ready
to get merged.
---
If your project is set up for it, you can reply to this email and have your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-127331090
Addressed @hsaputra comments and rebased to current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/974
[FLINK-2467] Example WordCountStorm.jar is not packaged correctly
- fixed assembly xml file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/976
[FLINK-2095] Screenshots missing in webcient documentation
- updated WebClient docu to include screenshots
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/940#issuecomment-126262365
Thanks for reporting the bug and providing a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/940#issuecomment-125261373
+1 for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/932#issuecomment-125145074
There is a new PR #940 for this issue . This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/940#discussion_r35519188
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyBuilder.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/940#issuecomment-125146338
LGTM. Let's see if Travis passes. Before merging, you need to update your
commit message to be meaningful.
---
If your project is set up for it, you can reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/932#issuecomment-125038777
I would like to get this fixed soon. Are you still interested in
contributing a fix?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/932#issuecomment-124218025
Your second commit reverted your first commit. I don't see any changes.
File changed 0.
---
If your project is set up for it, you can reply to this email and have your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-123646720
You are right. I just updated it.
What about the failing YARN test. Is there already a JIRA for it?
https://travis-ci.org/apache/flink/builds/72019686
---
If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-123674841
I don't know exactly. My changes should not influence YARN component (as
fas as I can tell). YARN test have been instable a lot -- I would guess, it is
a general issue
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/932#discussion_r35205049
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyBuilder.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/932#issuecomment-123692979
I can reproduce the bug. But the fix is incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/932#discussion_r35204796
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyBuilder.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-123703823
Ok. So this PR can be merged, I guess. I will open a JIRA for the failing
test.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/853#issuecomment-123705638
Can you also extend documentation for this feature? (I followed a
only-1-sentence-in-1-line approach; please do the same). I would suggest to
open a new section Flink
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/929
[FLINK-1658] Rename AbstractEvent to AbstractTaskEvent and AbstractJobEvent
- deleted AbstractEvent in org.apache.flink.runtime.event.job
(see comment section in
https://issues.apache.org
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123306327
Hi @rainiraj. We want to rework and unify client code. This PR would be
part of it. Can you update your code soon so it can be merged? Otherwise, it
might get reworked
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-18243
Any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-122071560
Added fix for https://issues.apache.org/jira/browse/FLINK-2338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-121534709
@StephanEwen Any news on this PR? It applies some changes to JobManager
WebFrontend. Would be great, if this could be merged before #677 and/or #297
---
If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-120958268
Just updated this PR:
- renamed Options to Flink Options and Arguments to Program
Arguments in WebUI
- removed redundant code and integrated CliFrontend
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/884#issuecomment-120940126
@gyfora merged this already! PR is not closed because Github is behind
aft-git!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/878#issuecomment-120999607
Update this PR (- added documentation). Should be ready to get merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-120706769
Right now, there is only `-c` that must be used if no Manifest
(program-class or Main-Class argument) is given. We can also clarify via
tooltips or help-popup
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-120731470
Btw: CliFontend support the follows options: -c / --class , -m /
--jobmanager , -p / -- paralleslism
To have the same options, we might want to extend CliFontend
501 - 600 of 694 matches
Mail list logo
