Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5718
I don't want to make a fuss over a single test, so for the purposes of this
test it's fine to just remote the timeout.
In general however i think it would be pretty neat if we would add
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5690
merging...
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5722
[FLINK-8958][tests] Port TaskCancelAsyncProducerConsumerITCase to flip6
## What is the purpose of the change
This PR ports the `TaskCancelAsyncProducerConsumerITCase` to flip6. The
existing
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5710
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5696#discussion_r17544
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotProvider.java
---
@@ -46,9 +46,10 @@
/**
* Allocating
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5708
What would happen if
`taskmanager.network.credit-based-flow-control.enabled` is enabled, but
`taskmanager.exactly-once.blocking.data.enabled` is disabled?
Is this an invalid setting?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5718
This change appears to be focus mostly around Travis which i dislike a bit.
I'd rather add a custom `Timeout` that prints the thread-dump so we still
get nice behavior when running things locally
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5720
[FLINK-8957][tests] Port JMXJobManagerMetricTest to flip6
Based on #5690.
## What is the purpose of the change
Ports the `JMXJobManagerMetricTest` to use `MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5719
[FLINK-8959][tests] Port AccumulatorLiveITCase to flip6
Based on #5701.
## What is the purpose of the change
This PR ports the `AccumulatorLiveITCase` to flip6. The existing test
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5715
[FLINK-8956][tests] Port RescalingITCase to flip6
Based on #5690.
## What is the purpose of the change
Ports the `RescalingITCase` to use `MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5714
[FLINK-8925][tests] Enable Flip6 on travis
## What is the purpose of the change
This PR enables Flip6 for half of our travis profiles.
## Brief change log
* add `Old
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5689
merging,
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5701
8703 c savepoint
Based on #5690 and #5699.
## What is the purpose of the change
With this PR accumulator updates are sent via heartbeats from the
TaskManager to JobManagers
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5699
[FLINK-8942][runtime] Pass heartbeat target ResourceID
## What is the purpose of the change
With this PR the heartbeat target `ResourceID` is passed to the
`HeartbeatListener` when
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5666
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5667
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5668
merging
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174450032
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java
---
@@ -140,19 +159,28 @@ public boolean contains(UK userKey
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r17107
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateEntry.java ---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r17245
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateEntry.java ---
@@ -39,29 +39,27 @@
private final InternalKvState<K, N
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r17070
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateEntry.java ---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5697
[FLINK-8704][tests] Port ScheduleOrUpdateConsumersTest
## What is the purpose of the change
This PR ports the `ScheduleOrUpdateConsumersTest` to flip6. The existing
test was renamed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174381716
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -686,7 +686,7
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174380197
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalMapState.java
---
@@ -20,13 +20,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174385360
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/query/KvStateRegistryTest.java
---
@@ -40,6 +54,81 @@
*/
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174380673
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapAggregatingState.java
---
@@ -30,18 +30,17 @@
import java.io.IOException
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174380400
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalAppendingState.java
---
@@ -24,9 +24,11 @@
* The peer
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174384860
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/query/KvStateRegistryTest.java
---
@@ -40,6 +54,81 @@
*/
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174381475
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateRegistry.java
---
@@ -136,13 +138,13 @@ public void unregisterKvState
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174380623
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapFoldingState.java
---
@@ -29,20 +29,19 @@
import java.io.IOException
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174383199
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateInfo.java ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174385834
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/query/KvStateRegistryTest.java
---
@@ -40,6 +54,81 @@
*/
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174379723
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalMergingState.java
---
@@ -26,12 +26,14 @@
* The peer
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174380744
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapMergingState.java
---
@@ -28,18 +28,19 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174385129
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/query/KvStateRegistryTest.java
---
@@ -40,6 +54,81 @@
*/
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174383043
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/KvStateEntry.java ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174385024
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/query/KvStateRegistryTest.java
---
@@ -40,6 +54,81 @@
*/
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174382685
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java
---
@@ -78,13
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174383696
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java
---
@@ -140,19 +159,28 @@ public boolean contains(UK userKey
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5677
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5692
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5679
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5670
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5695
[FLINK-8704][tests] Port PartialConsumerPipelinedResultTest
## What is the purpose of the change
This PR ports the `PartialConsumerPipelinedResultTest` to flip6. The
existing test
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5694
[FLINK-8704][tests] Port SlotCountExceedingParallelismTest
## What is the purpose of the change
This PR ports the `SlotCountExceedingParallelismTest` to flip6. The
existing test was renamed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174148331
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java
---
@@ -78,13
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174144247
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java
---
@@ -78,13
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5689#discussion_r174140412
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -119,6 +121,11 @@ public void run
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r174128377
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java
---
@@ -78,13
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5690
[FLINK-8935][tests] Extend MiniClusterClient
## What is the purpose of the change
With this PR the `MiniClusterClient` implements `listJobs()`,
`getAccumulators()`, `triggerSavepoint
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5689
[FLINK-4569][tests] Respect exceptions thrown in thread in
JobRetrievalITCase
## What is the purpose of the change
This PR ensures that exceptions that occur in the submitting thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5687#discussion_r174060373
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolTest.java
---
@@ -505,17 +513,21 @@ public void
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5681
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5681
[FLINK-4569][tests] Fix JobRetrievalITCase
## What is the purpose of the change
This PR contains 2 changes to the `JobRetrievalITCase`.
1) We now store exceptions that occur
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5665#discussion_r173743909
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
---
@@ -66,40 +73,44 @@
private static final
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5679#discussion_r173742203
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java
---
@@ -143,10 +152,66 @@ public int
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5679#discussion_r173742094
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java
---
@@ -143,10 +152,66 @@ public int
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5679#discussion_r173741952
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java
---
@@ -143,10 +152,66 @@ public int
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5673
How is this any different to a regular fat jar? I'm wondering what the
purpose of the `sql-jar` suffix is.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5670#discussion_r173627882
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendTestUtils.java
---
@@ -65,9 +67,14 @@ public static String getInvalidConfigDir
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5609
ehh...probably. The PR has a point as `sed --help` (v4.2.2) does not list
the `-E` option.
If we want to be super safe we could check that `sed -r` is supported and
use `-E` as a backup.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5669#discussion_r173455497
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka010ITCase.java
---
@@ -81,12 +81,6
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5669
[FLINK-8703][tests] Port KafkaTestBase to MiniClusterResource
## What is the purpose of the change
Ports the `KafkaTestBase` and extending classes to use
`MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5668
[FLINK-8703][tests] Port StreamingScalabilityAndLatency to MiniClusteâ¦
## What is the purpose of the change
Ports the `StreamingScalabilityAndLatency` to use `MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5667
[FLINK-8703][tests] Port NotSoMiniClusterIterations to MiniClusterResource
## What is the purpose of the change
Ports the `NotSoMiniClusterIterations` to use `MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5666
[FLINK-8703][tests] Port KafkaShortRetentionTestBase to MiniClusterReâ¦
## What is the purpose of the change
Ports the `KafkaShortRetentionTestBase` to use `MiniClusterResource
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5665
[FLINK-8703][tests] Port WebFrontendITCase to MiniClusterResource
## What is the purpose of the change
Ports the `WebFrontendITCase` to use `MiniClusterResource`.
## Brief change
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5664
[FLINK-8703][tests] Port CancelingTestBase to MiniClusterResource
## What is the purpose of the change
Ports the {{CancelingTestBase}} to use {{MiniClusterResource}}.
## Verifying
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5573
please do not trigger builds just to get that perfect green build. The test
failure here is quite common at the moment.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5657
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5573
@yanghua This test failure is unrelated, you can ignore it.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5554
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5637
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5594#discussion_r173266836
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java
---
@@ -84,8 +84,8 @@ protected AbstractHandler
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5651
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5645#discussion_r172922843
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java
---
@@ -163,8 +224,9 @@ public T copy(T from, T
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5656#discussion_r172893483
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
---
@@ -0,0 +1,333 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5656#discussion_r172893235
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
---
@@ -0,0 +1,333 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5645#discussion_r172893030
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java
---
@@ -163,8 +224,19 @@ public T copy(T from
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5656#discussion_r172857716
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
---
@@ -0,0 +1,333 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5656#discussion_r172856770
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
---
@@ -0,0 +1,333 @@
+/*
+ * Licensed
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5656
should probably clean this branch from the restore/QS tests, and rebase it
once.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5657
[FLINK-8887][tests] Add single retry in MiniClusterClient
## What is the purpose of the change
This PR presents a test workaround for race-conditions in FLIP-6 (most
notably FLINK-8887
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5648#discussion_r172835665
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -404,7 +406,29 @@ public void start() throws Exception
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5653#discussion_r172812790
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -290,16 +289,14 @@ public static boolean
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5653#discussion_r172808666
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -290,16 +289,14 @@ public static boolean
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5653#discussion_r172807476
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -290,16 +289,14 @@ public static boolean
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5653#discussion_r172809760
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -290,16 +289,14 @@ public static boolean
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5653#discussion_r172807512
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -290,16 +289,14 @@ public static boolean
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5652
yup. But one profile is already scratching the 50m limit as is :/
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5652
The alternative would be to make the `ClusterClient` functionality optional
and force tests to explicitly enable it.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5652
All legacy tests going through the `MiniClusterResource` will take longer.
I don't know by how much, but we now have to start multiple actor systems and
the JM<->TM communication is no longer local.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5652
[hotfix][tests] Do not use singleActorSystem in LocalFlinkMiniCluster
## What is the purpose of the change
The legacy cluster started in {{MiniClusterResource}} used a single actor
system
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5651
[FLINK-8889][tests] Do not override cluster config values
## What is the purpose of the change
This PR modifies the cluster configuration in {{MiniClusterResource}} or
{{TestBaseUtils
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5648#discussion_r172775779
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -404,16 +404,25 @@ public void start() throws Exception
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5573#discussion_r172756524
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -389,6 +393,27 @@ public String cancelWithSavepoint
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5573#discussion_r172755830
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -389,6 +393,27 @@ public String cancelWithSavepoint
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5573#discussion_r172756640
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsMessageParameters.java
---
@@ -0,0 +1,35
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5637
I would go for `TRACE` given how often we set the log level to `DEBUG`.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5573
We may want to delay merging this until
[FLINK-8881](https://issues.apache.org/jira/browse/FLINK-8881) has been
addressed, as it voids the primary use-case of this handler.
---
1001 - 1100 of 5225 matches
Mail list logo
