Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5463#discussion_r167612224
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -79,14 +87,18 @@
*/
public static
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5463#discussion_r167611073
--- Diff: docs/ops/config.md ---
@@ -408,38 +408,7 @@ of the JobManager, because the same ActorSystem is
used. Its not possible to use
### YARN
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5464
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5462#discussion_r167610029
--- Diff: docs/ops/config.md ---
@@ -502,27 +502,7 @@ Previously this key was named `recovery.mode` and the
default value was `standal
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5462#discussion_r167609071
--- Diff: docs/ops/config.md ---
@@ -502,27 +502,7 @@ Previously this key was named `recovery.mode` and the
default value was `standal
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5462#discussion_r167608682
--- Diff: docs/ops/config.md ---
@@ -502,27 +502,7 @@ Previously this key was named `recovery.mode` and the
default value was `standal
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5459#discussion_r167608020
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
@@ -127,7 +130,30 @@
*/
public static final
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5459#discussion_r167606303
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
@@ -127,7 +130,30 @@
*/
public static final
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5392
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5391
yes, this wasn't in there at all :) merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5390
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5389
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5387
Oh i just forgot the annotation, will add `@PublicEvolving` while merging...
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5461
yes, it will show up in the HA table. merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5460
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5392
plenty of missing options are being added by these PRs ð
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5392#discussion_r167596687
--- Diff: docs/ops/config.md ---
@@ -322,7 +321,6 @@ The following parameters configure Flink's JobManager
and TaskManagers.
- `taskmanager.exit
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5461
Currently we assign each `ConfigOption` to exactly one table, so there's
little we can do at the moment about this option.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5415
What would speak against creating a new FileInputFormat that supports
multiple paths instead? Common code could be moved into a shared super class (I
_think_ that would be allowed).
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5464
[FLINK-8475][config][docs] Integrate Checkpointing options
## What is the purpose of the change
This PR integrates the Checkpointing `ConfigOptions` into the
configuration docs generator
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5463
[FLINK-8475][config][docs] Integrate YARN options
## What is the purpose of the change
This PR integrates the YARN `ConfigOptions` into the configuration docs
generator.
## Brief
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5462
[FLINK-8475][config][docs] Integrate HA-ZK options
## What is the purpose of the change
This PR integrates the Zookeeper HA `ConfigOptions` into the configuration
docs generator
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5461
[FLINK-8475][config][docs] Integrate Mesos options
## What is the purpose of the change
This PR integrates the Mesos `ConfigOptions` into the configuration docs
generator.
## Brief
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167542881
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r167542075
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarListHandler.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r167541843
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r167540798
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarListHandler.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5460
[FLINK-8475][config][docs] Integrate Algorithm options
## What is the purpose of the change
This PR ports the runtime algorithm ConfigConstants to `ConfigOptions` and
integrates them
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5459
[FLINK-8475][config][docs] Integrate FS options
## What is the purpose of the change
This PR ports the fileystem ConfigConstants to `ConfigOptions` and
integrates them
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5443#discussion_r167413109
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -143,7 +143,7 @@
private final
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5443#discussion_r167412925
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/JobVertexBackPressureHandlerTest.java
---
@@ -57,7 +57,7 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5447#discussion_r167395295
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -591,16 +591,18 @@ public void collect
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5447#discussion_r167392891
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -591,16 +591,18 @@ public void collect
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5443#discussion_r167267838
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -143,7 +143,7 @@
private final
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5443#discussion_r167268048
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/VoidBackPressureStatsTracker.java
---
@@ -0,0 +1,36
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5426
notice files look good to me.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5426#discussion_r166906856
--- Diff:
flink-connectors/flink-connector-elasticsearch2/src/main/resources/META-INF/NOTICE
---
@@ -0,0 +1,86 @@
+This project includes software
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5426#discussion_r166904848
--- Diff:
flink-connectors/flink-connector-elasticsearch/src/main/resources/META-INF/NOTICE
---
@@ -0,0 +1,57 @@
+This project includes software
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5357
@maqingxiang You are correct that the parallelism check is redundant, but
that doesn't automatically mean that it should be removed.
This change imo hurts readability as the basic parallelism
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5418#discussion_r166564479
--- Diff:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
---
@@ -94,4 +96,22 @@ public void close
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5420
[FLINK-8576][QS] Reduce verbosity when classes can't be found
This PR reduces the verbosity of DEBUG logging messages when the
flink-queryable-state-runtime jar is not on the classpath. Instead
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5419
[FLINK-8574][travis] Add timestamp to logging messages
With this PR logging statements on travis also include a timestamp( e.g.
`09:00:27.972`). This allows us to better judge how long each part
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5417
[FLINK-8565][tests] Ensure locationBytes.length > 0 in CheckpointOptionsTest
This PR fixes a test instability in `CheckpointOptionsTest#testSavepoint`.
The tests generated a byte array of a ran
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4809
will merge this while addressing the comments
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5413
[hotfix][table][tests] Set @Ignore description for RowCsvInputFormatTâ¦
Trivial change that moves the reasoning for `@Ignore` from a comment into
the annotation itself.
You can merge this pull
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5161
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5412
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5072
@yew1eb Could you close the PR? The issue was addressed in
f1e4d25c11a678688064492d50ffad38c39ea877.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5412
[FLINK-8559][RocksDB] Release resources if snapshot operation fails
## What is the purpose of the change
This PR ensures that RocksDB resources are released
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5404
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5408
merging,
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5407
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165916481
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
---
@@ -108,7 +108,7 @@
* individually
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5394
How about calling `Thread.currentThread().interrupt();` only after having
left the loop?
```
public void run(SourceContext ctx) throws Exception {
boolean setInterruptFlag = false
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165807233
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
---
@@ -90,11 +90,11 @@
CompletableFuture
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165807228
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
---
@@ -109,7 +109,7 @@
* slot offers
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5406#discussion_r165807220
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
---
@@ -90,11 +90,11 @@
CompletableFuture
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5155
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5402#discussion_r165623427
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -206,6 +206,14 @@
key
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5399
Could you modify the title to `[FLINK-6206] [runtime] Use LOG.error() when
logging failure state changes`? THere's actually a JIRA ticket that covers this
change.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5364#discussion_r165459894
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/keyed/KeyedJob.java
---
@@ -100,9 +100,7 @@ public static void main(String
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5161
Correction: We still can't display them in the UI since we have no tab for
job metrics.
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5163
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5163
at this point we may just as well wait for the next flink-shaded release
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5394
[FLINK-6571][tests] Catch InterruptedException in StreamSourceOperatoâ¦
## What is the purpose of the change
This PR resolves a test instability in the StreamSourceOperatorTest, where
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5155
@aljoscha I've implemented your suggestion, in hindsight that's a rather
obvious solution isn't it. Also rebased the branch.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5269
looks good, +1
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5336#discussion_r165023129
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -92,21
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5335#discussion_r165022709
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -95,21
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5336#discussion_r165021513
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -92,21
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5336#discussion_r165021339
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5269#discussion_r165020094
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcherTest.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5269#discussion_r165019903
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5161
I've rebased the branch and did one more change:
```
this.latencyStats = new
LatencyStats(this.metrics.parent().parent().addGroup("latency"), historySize,
container.getIndexInSu
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5343
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5161
yes the display will now work.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5292
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5378
merging,
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5161
I'm wary about using the operator name (or _any_ variant that inexplicably
exists) as that significantly increases the size of watermarks.
I see the use-case, and ideally I would like to have
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5161#discussion_r165000781
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
---
@@ -194,14 +190,20 @@ public void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5392
[FLINK-8475][config][docs] Integrate JM options
## What is the purpose of the change
This PR integrates the JobManager `ConfigOptions` into the configuration
docs generator
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5391
[FLINK-8475][config][docs] Integrate BlobServer options
## What is the purpose of the change
This PR adds the BlobServer `ConfigOptions` to the full configuration
reference
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
Note that the existing docs were wrong regardless, see AkkaUtils:
```
val startupTimeout = configuration.getString(
AkkaOptions.STARTUP_TIMEOUT,
(akkaAskTimeout * 10
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
akka.startup-timeout has no default value because that's how the
ConfigOption is actually defined; in other words ATM we can't guarantee
anything about the default.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5384
@aljoscha Fixed.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5390
[FLINK-8475][config][docs] Integrate SlotManager options
## What is the purpose of the change
This PR integrates the SlotManager `ConfigOptions` into the configuration
docs generator
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5389
[FLINK-8475][config][docs] Integrate REST options
## What is the purpose of the change
This PR adds the REST `ConfigOptions` to the full configuration reference.
You can merge this pull
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5387
[FLINK-8475][config][docs] Integrate optimizer options
## What is the purpose of the change
This PR ports the batch compiler ConfigConstants to `ConfigOptions` and
integrates them
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5386
[FLINK-8475][config][docs] Integrate netty options
## What is the purpose of the change
This PR integrates the Netty `ConfigOptions` into the configuration docs
generator.
## Brief
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5385
[FLINK-8475][config][docs] Integrate SSL options
## What is the purpose of the change
This PR integrates the SSL `ConfigOptions` into the configuration docs
generator.
## Brief
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5384
[FLINK-8475][config][docs] Integrate akka options
## What is the purpose of the change
This PR integrates the Akka `ConfigOptions` into the configuration docs
generator.
## Brief
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5382
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5379
merging.
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/5340
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5340
Will split this PR into smaller chunks to make it easier to review.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5357
I would be in favor of closing this PR. This change doesn't _really_
improve anything, but removes a simple (and intuitive) sanity check.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5378
Added a test for the `ElasticSearchSinkBase` that passes an unmodifiable
map containing all properties that we currently try to remove.
I also modified the `ElasticSearchTestBase` to pass
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5377
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5379
[FLINK-8130][docs] Fix snapshot javadoc link
## What is the purpose of the change
This PR fixes the snapshot javadoc link that is currently broken. Currently
the website tries to access
1301 - 1400 of 5225 matches
Mail list logo
