GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5904
[FLINK-9249][build] Add convenience profile for skipping non-essential
plugins
## What is the purpose of the change
This PR adds a convenience profile for skipping non-essential plugins
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5903
[FLINK-9211][REST] JarRunHandler submits job to Dispatcher via RPC
## What is the purpose of the change
This PR reworks the `JarRunHandler` to submit the job to the dispatcher via
RPC
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5888
see #5902.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5902
[FLINK-9194][history] Add HistoryServer support to flip6
This PR subsumes #5888.
## What is the purpose of the change
This PR adds HistoryServer support to Flip6, i.e. allows
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183633001
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfo.java
---
@@ -18,41 +18,46 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183632835
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/SubtasksAllAccumulatorsHandler.java
---
@@ -97,15 +97,14 @@ public static
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5879
I think it is fine that exceptions are logged under debug, it's just that
we use exceptions in the normal life-cycle. I'm wondering if we could replace
these kind of exceptions with a special
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5893
see `JobVertexDetailsInfo` on how to use it.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5893
You have to use the `JobVertexIDSerializer` for that field.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5888
I'm currently preparing a PR for adding HistoryServer support to Flip6 and
will integrate this PR into that one.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5893
You have not changed the type of `SubtasksAllAccumulatorsInfo#jobVertexId`
to `JobVertexID`.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183357592
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtasksAllAccumulatorsHandler.java
---
@@ -0,0 +1,93
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183358123
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtasksAllAccumulatorsHandler.java
---
@@ -0,0 +1,93
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183359424
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfo.java
---
@@ -0,0 +1,139
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183360065
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtasksAllAccumulatorsHandler.java
---
@@ -0,0 +1,93
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183360560
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfoTest.java
---
@@ -0,0 +1,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183360526
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfoTest.java
---
@@ -0,0 +1,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183357875
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfo.java
---
@@ -0,0 +1,139
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r183355953
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -180,10 +180,22 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r183356809
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -231,18 +243,20 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r183357018
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
---
@@ -96,9 +108,26 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r183355330
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -180,10 +180,22 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r183356576
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -231,18 +243,20 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r18334
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -180,10 +180,22 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5888#discussion_r183356514
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
---
@@ -231,18 +243,20 @@ public void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5870
@NicoK I've addressed your comments.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5875
@Silven1117 My apologies, i went right at it since it was such an quick
fix. I recommend writing in the JIRA that you would like to work on the issue
yourself. I will give you contributor permissions
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5873
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5872
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5875
The issue has already been resolved.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5872#discussion_r182461066
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -857,7 +859,7 @@ public void run
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5872#discussion_r182459949
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -1214,7 +1216,7 @@ public void run
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5806
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5665
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5780
merging
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5865
merging, will fix the checkstyle violation on the way
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5864
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5852
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5872#discussion_r182441934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -1214,7 +1216,7 @@ public void run
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5872#discussion_r182442219
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -857,7 +859,7 @@ public void run
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5870
[FLINK-8967][tests] Port NetworkStackThroughputITCase to flip6
## What is the purpose of the change
This PR ports the `NetworkStackThroughputITCase` to flip6.
## Verifying
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5868#discussion_r182396425
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
---
@@ -1,53 +0,0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5868#discussion_r182385910
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
---
@@ -1,53 +0,0
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5780
checkstyle ð¡
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5665
@aljoscha I've addressed your comments and rebased the branch.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5780
I may have found the case, we have to set `MANAGED_MEMORY_SIZE` for this
test.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5780
travis is still failing with mysterious error messages..
```
15:58:07.061 [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (integration-tests
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5859
[FLINK-9186][build] Enable dependenvy convergence for flink-libraries
## What is the purpose of the change
This PR enables dependency-convergence for `flink-libraries`. There is only
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5665#discussion_r181776571
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
---
@@ -217,12 +231,12 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5665#discussion_r181775179
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
---
@@ -127,14 +137,18 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181759432
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -202,15 +204,27 @@ public void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5814
Correction: I had to modify the `LocalStreamEnvironment` instead.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5853#discussion_r181722455
--- Diff: flink-formats/flink-json/pom.xml ---
@@ -112,4 +112,25 @@ under the License
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5853#discussion_r181706338
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -102,9 +114,24 @@ under the License.
commons-dbcp
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5853
dependency convergence still fails:
```
Dependency convergence error for com.google.guava:guava:19.0 paths to
dependency are:
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5853
I suggest to actually enable the dependency convergence for flink-table as
we've already done the required work.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5814
I have removed a section from the `LocalExecutor` that sets the port to `0`.
This should cause the UI to run at `8081` without affecting test stability.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5805#discussion_r181691127
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractAggregatingMetricsHandler.java
---
@@ -0,0 +1,302
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5805
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181668393
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181681917
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/PeriodicStreamingJob.java
---
@@ -0,0 +1,111
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181669868
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181685888
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181669761
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181683094
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181685139
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181669905
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181668750
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181688557
--- Diff: flink-end-to-end-tests/test-scripts/test_rest_api.sh ---
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181687083
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181687398
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181685328
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181688583
--- Diff: flink-end-to-end-tests/test-scripts/test_rest_api.sh ---
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181687893
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181688947
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181686235
--- Diff:
flink-end-to-end-tests/flink-rest-api-test/src/main/java/org/apache/flink/runtime/rest/tests/RestApiTestSuite.java
---
@@ -0,0 +1,363
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5849#discussion_r181688711
--- Diff: flink-end-to-end-tests/test-scripts/test_rest_api.sh ---
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5838
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5730
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5805#discussion_r181583359
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/DoubleAccumulator.java
---
@@ -0,0 +1,257
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5780
I've cut down the PR to only not make any changes outside the tests, fixed
the checkstyle violations and the failing test.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181582943
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -196,21 +188,23 @@ public void
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5780
I would be fine with changing the PR to work against a `MiniCluster` (to
drop the JobExecutor changes) and a `TemporaryFolder` that we manage ourselves,
i,e. not as a `@Rule` (to drop the icky
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5805#discussion_r181534458
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AggregatingSubtasksMetricsHandler.java
---
@@ -0,0 +1,129
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5805#discussion_r181534395
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/DoubleAccumulator.java
---
@@ -0,0 +1,257
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181534220
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -49,15 +54,17 @@
* Starts
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181534097
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -196,21 +188,23 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181533944
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -117,6 +138,7 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181533175
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -196,21 +188,23 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181532978
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -49,15 +54,17 @@
* Starts
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/3899
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5844
Even then `invoke(Collection)` would never be called. `IN` is always
the type of the `DataStream` the sink is applied on, and it can't be
`Collection` as you would have an infinitely recursive type
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5843
[FLINK-8744][docs] Generate "Common Option" section
Base on #5822.
## What is the purpose of the change
With this PR the "Common Options" sect
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5820
I wouldn't bother cleaning up unused imports until we have a checkstyle
rule in place to enforce it.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5837
The PR has been merged, @mylog00 could you close it?
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5823#discussion_r180810121
--- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh ---
@@ -0,0 +1,117 @@
+#!/usr/bin/env bash
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5802
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5838
[FLINK-9156][REST][CLI] Update --jobmanager option logic for REST client
## What is the purpose of the change
With this PR the `--jobmanager` option is properly respected
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5819
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5827
merging.
---
701 - 800 of 5225 matches
Mail list logo
