[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1244366543 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1244366543 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1244364545 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -469,10 +469,10 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1243930582 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1242932736 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -469,10 +469,10 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1242916945 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -1132,22 +1132,14 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1242916945 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -1132,22 +1132,14 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239069716 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/subquery/SubqueryCorrelateVariablesValidationTest.scala: ## @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239069716 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/subquery/SubqueryCorrelateVariablesValidationTest.scala: ## @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239034289 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DagOptimizationTest.xml: ## @@ -379,30 +382,30 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239034473 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DagOptimizationTest.xml: ## @@ -379,30 +382,30 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239034473 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DagOptimizationTest.xml: ## @@ -379,30 +382,30 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239034289 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DagOptimizationTest.xml: ## @@ -379,30 +382,30 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239021813 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/subquery/SubqueryCorrelateVariablesValidationTest.xml: ## @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1239018426 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -526,7 +526,7 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1237090987 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/table/CalcTest.xml: ## @@ -107,14 +107,14 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1233372251 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190413352 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190413352 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190411735 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -469,10 +469,10 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190409133 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -526,7 +526,7 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190407800 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -469,10 +469,10 @@ private static List

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190406330 ## flink-table/flink-table-planner/pom.xml: ## @@ -99,16 +99,10 @@ under the License. -

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190405680 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1335,12 +1335,14 @@ SqlNode RichSqlInsert() : final SqlNodeList keywordList;