Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45722053
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725539
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725866
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726196
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -48,12 +49,10 @@
private static final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727062
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,6 +45,21 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727164
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727099
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728449
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728386
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728418
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728523
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728889
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path =
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45729000
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45724616
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725506
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726538
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726600
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727477
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728165
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728214
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -48,12 +49,10 @@
private static final Logger
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728168
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45729369
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726093
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726133
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728317
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728366
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,6 +45,21 @@
/** The schema (ie, ordered
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728576
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728678
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45730807
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45730899
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731544
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -48,12 +49,10 @@
private static final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731878
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731894
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733444
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733449
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733970
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734220
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path =
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734993
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path =
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731094
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path =
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731348
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731264
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731351
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732371
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733215
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733689
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734177
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734441
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45735762
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731988
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732254
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,6 +45,21 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732952
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733403
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733816
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733908
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734323
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
101 - 155 of 155 matches
Mail list logo
