Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5580
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r185517079
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r183700946
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -488,13 +494,36 @@ public void addJar(Path jar) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r183703858
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r183702885
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179123350
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -164,16 +165,13 @@ public void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179116502
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179116344
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179087145
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179079963
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179075409
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179071066
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179050736
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
---
@@ -37,18 +39,31 @@
*/
@Public
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179060408
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179056079
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179049139
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -231,6 +234,7 @@ public TaskExecutor(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179048742
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -26,6 +26,7 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179053003
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179053531
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179056758
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179054280
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179052173
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/pom.xml ---
@@ -0,0 +1,106 @@
+
+
+http://maven.apache.org/POM/4.0.0;
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179057582
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -631,14 +631,14 @@ else if (current == ExecutionState.CANCELING)
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179050544
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -331,7 +332,6 @@ public JobSubmissionResult
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179054489
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179053801
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179060824
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -33,16 +38,16 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179057166
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -262,106 +216,120 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r179052578
--- Diff:
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176767320
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1831,4 +1831,5 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176769129
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -143,30 +160,23 @@ public void shutdown() {
/**
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176767248
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
---
@@ -91,6 +93,7 @@ public void after() throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176767271
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/distributedcache/DistributedCacheTest.java
---
@@ -40,6 +42,7 @@
/**
* Test the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176768205
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176766216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176764920
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176747071
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176746645
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176745753
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -527,59 +403,83 @@ else if (response == RETURN_ERROR) {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176745183
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658024
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -306,18 +311,20 @@ public JobSubmissionResult
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662757
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662599
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176663553
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -57,89 +65,59 @@
+ "MICHAEL:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658632
--- Diff: flink-end-to-end-tests/pom.xml ---
@@ -78,6 +78,27 @@ under the License.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176660974
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -527,59 +403,83 @@ else if (response == RETURN_ERROR) {
*
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658516
--- Diff: flink-end-to-end-tests/pom.xml ---
@@ -78,6 +78,27 @@ under the License.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176659407
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -159,7 +162,7 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176659832
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -488,13 +493,36 @@ public void addJar(Path jar) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176658879
--- Diff:
flink-libraries/flink-streaming-python/src/main/java/org/apache/flink/streaming/python/api/environment/PythonStreamExecutionEnvironment.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176661729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662637
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -453,15 +460,51 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662188
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176662946
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -19,30 +19,38 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176661496
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
@@ -267,101 +208,60 @@ private static Thread
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r176657746
--- Diff:
flink-libraries/flink-python/src/test/java/org/apache/flink/python/api/PythonPlanBinderTest.java
---
@@ -30,6 +33,7 @@
/**
* Tests for
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171184258
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1829,6 +1830,28 @@ public
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171181348
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1829,6 +1830,28 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171175263
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171175037
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171174660
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171174187
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -1829,6 +1830,28 @@ public
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171172025
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java
---
@@ -106,9 +106,9 @@
* are created for
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r171171252
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java
---
@@ -106,9 +106,9 @@
* are created for the
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r170804963
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -314,6 +315,9 @@ public static TaskExecutor
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/5580
[FLINK-8620] Enable shipping custom files to BlobStore and accessing â¦
â¦them through DistributedCache
*Thank you very much for contributing to Apache Flink - we are happy that
66 matches
Mail list logo
