XComp merged PR #24315:
URL: https://github.com/apache/flink/pull/24315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
XComp commented on PR #24315:
URL: https://github.com/apache/flink/pull/24315#issuecomment-1952297264
I reorganized the commits (with no changes) and created the backport PRs for
1.19 and 1.18. I don't create the backport PR for 1.17 because the test
instability rarely happens in JDK17-
XComp opened a new pull request, #24336:
URL: https://github.com/apache/flink/pull/24336
1.18 backport for parent PR https://github.com/apache/flink/pull/24315
The hotfix improvement and the JUnit5 migration was not backported.
--
This is an automated message from the Apache Git
XComp opened a new pull request, #24335:
URL: https://github.com/apache/flink/pull/24335
1.19 backport for parent PR #24315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
XComp commented on PR #24315:
URL: https://github.com/apache/flink/pull/24315#issuecomment-1951990498
> I guess if we migrate from junit4 to junit5 then we don't need to depend
on TestLogger which contains JUnit4 rules
instead need to use @ExtendWith(TestLoggerExtension.class)
> Also
XComp commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1494214673
##
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##
@@ -158,7 +170,7 @@ public ClassLoaderBuilder withParentClassLoader(ClassLoader
XComp commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1494214115
##
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##
@@ -55,7 +58,7 @@ private static URLClassLoader createClassLoader(File root,
snuyanzin commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1493019218
##
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##
@@ -158,7 +170,7 @@ public ClassLoaderBuilder withParentClassLoader(ClassLoader
snuyanzin commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1493015749
##
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##
@@ -55,7 +58,7 @@ private static URLClassLoader createClassLoader(File root,
snuyanzin commented on PR #24315:
URL: https://github.com/apache/flink/pull/24315#issuecomment-1949378599
I guess if we migrate from junit4 to junit5 then we don't need to depend on
`TestLogger` which contains JUnit4 rules
instead need to use `@ExtendWith(TestLoggerExtension.class)`
snuyanzin commented on code in PR #24315:
URL: https://github.com/apache/flink/pull/24315#discussion_r1493005612
##
flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java:
##
@@ -55,7 +58,7 @@ private static URLClassLoader createClassLoader(File root,
flinkbot commented on PR #24315:
URL: https://github.com/apache/flink/pull/24315#issuecomment-1946420906
## CI report:
* 83368ca5bda5692ebc43f9024fa13d0f803369be UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
XComp opened a new pull request, #24315:
URL: https://github.com/apache/flink/pull/24315
## What is the purpose of the change
The test failed mostly with JDK21. It can happen that the OutOfMemoryError
appeared during the compilation phase. In that case, it would print a different
13 matches
Mail list logo
